提交 a7eee2c1 编写于 作者: dengyihao's avatar dengyihao

add/delete tag idx

上级 3e738363
...@@ -393,10 +393,12 @@ int metaAddIndexToSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) { ...@@ -393,10 +393,12 @@ int metaAddIndexToSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
SMetaEntry oStbEntry = {0}; SMetaEntry oStbEntry = {0};
SMetaEntry nStbEntry = {0}; SMetaEntry nStbEntry = {0};
STbDbKey tbDbKey = {0};
TBC *pUidIdxc = NULL; TBC *pUidIdxc = NULL;
TBC *pTbDbc = NULL; TBC *pTbDbc = NULL;
void *pData; void *pData = NULL;
int nData; int nData = 0;
int64_t oversion; int64_t oversion;
SDecoder dc = {0}; SDecoder dc = {0};
int32_t ret; int32_t ret;
...@@ -409,60 +411,44 @@ int metaAddIndexToSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) { ...@@ -409,60 +411,44 @@ int metaAddIndexToSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
goto _err; goto _err;
} }
// tdbTbcOpen(pMeta->pUidIdx, &pUidIdxc, NULL); tbDbKey.uid = suid;
// ret = tdbTbcMoveTo(pUidIdxc, &pReq->suid, sizeof(tb_uid_t), &c); tbDbKey.version = ((SUidIdxVal *)pData)[0].version;
// if (ret < 0 || c) { tdbTbGet(pMeta->pTbDb, &tbDbKey, sizeof(tbDbKey), &pData, &nData);
// tdbTbcClose(pUidIdxc);
// terrno = TSDB_CODE_TDB_STB_NOT_EXIST;
// return -1;
//}
// ret = tdbTbcGet(pUidIdxc, NULL, NULL, &pData, &nData);
// if (ret < 0) {
// tdbTbcClose(pUidIdxc);
// terrno = TSDB_CODE_TDB_STB_NOT_EXIST;
// return -1;
//}
// oversion = ((SUidIdxVal *)pData)[0].version;
// tdbTbcOpen(pMeta->pTbDb, &pTbDbc, NULL); tDecoderInit(&dc, pData, nData);
// ret = tdbTbcMoveTo(pTbDbc, &((STbDbKey){.uid = pReq->suid, .version = oversion}), sizeof(STbDbKey), &c); ret = metaDecodeEntry(&dc, &oStbEntry);
// if (!(ret == 0 && c == 0)) { if (ret < 0) {
// metaError("meta/table: invalide ret: %" PRId32 " or c: %" PRId32 "alter stb failed.", ret, c); goto _err;
// return -1; }
// }
// ret = tdbTbcGet(pTbDbc, NULL, NULL, &pData, &nData);
// if (ret < 0) {
// tdbTbcClose(pTbDbc);
// terrno = TSDB_CODE_TDB_STB_NOT_EXIST; if (oStbEntry.stbEntry.schemaTag.pSchema == NULL || oStbEntry.stbEntry.schemaTag.pSchema == NULL) {
// return -1; goto _err;
//} }
oStbEntry.pBuf = taosMemoryMalloc(nData); if (oStbEntry.stbEntry.schemaTag.version != pReq->schemaTag.version) {
memcpy(oStbEntry.pBuf, pData, nData); goto _err;
tDecoderInit(&dc, oStbEntry.pBuf, nData); }
metaDecodeEntry(&dc, &oStbEntry);
nStbEntry.version = version; if (oStbEntry.stbEntry.schemaTag.nCols != pReq->schemaTag.nCols) {
nStbEntry.type = TSDB_SUPER_TABLE; goto _err;
nStbEntry.uid = pReq->suid; }
nStbEntry.name = pReq->name;
nStbEntry.stbEntry.schemaRow = pReq->schemaRow;
nStbEntry.stbEntry.schemaTag = pReq->schemaTag;
metaWLock(pMeta); int diffIdx = -1;
// compare two entry for (int i = 0; i < pReq->schemaTag.nCols; i++) {
if (oStbEntry.stbEntry.schemaRow.version != pReq->schemaRow.version) { SSchema *pNew = pReq->schemaTag.pSchema + i;
metaSaveToSkmDb(pMeta, &nStbEntry); SSchema *pOld = oStbEntry.stbEntry.schemaTag.pSchema + i;
if (pNew->type != pOld->type || pNew->colId != pOld->colId || pNew->bytes != pOld->bytes ||
strncmp(pOld->name, pNew->name, sizeof(pNew->name))) {
goto _err;
}
if (IS_IDX_ON(pNew) && !IS_IDX_ON(pOld)) {
if (diffIdx != -1) goto _err;
diffIdx = i;
}
} }
// update table.db // update table.db
metaSaveToTbDb(pMeta, &nStbEntry); metaSaveToTbDb(pMeta, &nStbEntry);
// update uid index // update uid index
metaUpdateUidIdx(pMeta, &nStbEntry); metaUpdateUidIdx(pMeta, &nStbEntry);
...@@ -471,30 +457,12 @@ int metaAddIndexToSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) { ...@@ -471,30 +457,12 @@ int metaAddIndexToSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
metaULock(pMeta); metaULock(pMeta);
// Get target schema info // Get target schema info
SSchemaWrapper *pTagSchema = &nStbEntry.stbEntry.schemaTag; SSchemaWrapper *pTagSchema = &pReq->schemaTag;
if (pTagSchema->nCols == 1 && pTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) { if (pTagSchema->nCols == 1 && pTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) {
terrno = TSDB_CODE_VND_COL_ALREADY_EXISTS; terrno = TSDB_CODE_VND_COL_ALREADY_EXISTS;
goto _err; goto _err;
} }
SSchema *pCol = pTagSchema->pSchema + diffIdx;
char *tagName = "tag_col";
SSchema *pCol = NULL;
int32_t iCol = 0;
for (;;) {
pCol = NULL;
if (iCol >= pTagSchema->nCols) break;
pCol = &pTagSchema->pSchema[iCol];
if (strcmp(pCol->name, tagName) == 0) break;
iCol++;
}
if (iCol == 0) {
terrno = TSDB_CODE_VND_COL_ALREADY_EXISTS;
goto _err;
}
if (pCol == NULL) {
terrno = TSDB_CODE_VND_COL_NOT_EXISTS;
goto _err;
}
/* /*
* iterator all pTdDbc by uid and version * iterator all pTdDbc by uid and version
...@@ -541,12 +509,10 @@ int metaAddIndexToSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) { ...@@ -541,12 +509,10 @@ int metaAddIndexToSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
tdbTbUpsert(pMeta->pTagIdx, pTagIdxKey, nTagIdxKey, NULL, 0, pMeta->txn); tdbTbUpsert(pMeta->pTagIdx, pTagIdxKey, nTagIdxKey, NULL, 0, pMeta->txn);
metaDestroyTagIdxKey(pTagIdxKey); metaDestroyTagIdxKey(pTagIdxKey);
} }
metaWLock(pMeta);
if (oStbEntry.pBuf) taosMemoryFree(oStbEntry.pBuf); if (oStbEntry.pBuf) taosMemoryFree(oStbEntry.pBuf);
tDecoderClear(&dc); tDecoderClear(&dc);
tdbTbcClose(pTbDbc);
tdbTbcClose(pUidIdxc);
return TSDB_CODE_SUCCESS; return TSDB_CODE_SUCCESS;
_err: _err:
return TSDB_CODE_VND_COL_ALREADY_EXISTS; return TSDB_CODE_VND_COL_ALREADY_EXISTS;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册