Merge pull request #13985 from taosdata/feature/3.0_mhli

refactor(sync): append noop in become leader

source/libs/sync/src/syncMain.c

@@ -841,15 +841,6 @@ void syncNodeStart(SSyncNode* pSyncNode) {
     syncNodeBecomeLeader(pSyncNode, "one replica start");
 
     // Raft 3.6.2 Committing entries from previous terms
-
-    // use this now
-    syncNodeAppendNoop(pSyncNode);
-    syncMaybeAdvanceCommitIndex(pSyncNode);  // maybe only one replica
-
-    if (gRaftDetailLog) {
-      syncNodeLog2("==state change become leader immediately==", pSyncNode);
-    }
-
     return;
   }
 
@@ -1390,7 +1381,7 @@ void syncNodeUpdateConfig(SSyncNode* pSyncNode, SSyncCfg* pNewConfig, SyncIndex
         syncUtilU642Addr((pSyncNode->replicasId)[i].addr, host, sizeof(host), &port);
 
         do {
-          char eventLog[128];
+          char eventLog[256];
           snprintf(eventLog, sizeof(eventLog), "snapshot sender reset for %lu, newIndex:%d, %s:%d, %p",
                    (pSyncNode->replicasId)[i].addr, i, host, port, oldSenders[j]);
           syncNodeEventLog(pSyncNode, eventLog);
@@ -1405,7 +1396,7 @@ void syncNodeUpdateConfig(SSyncNode* pSyncNode, SSyncCfg* pNewConfig, SyncIndex
         (pSyncNode->senders)[i]->replicaIndex = i;
 
         do {
-          char eventLog[128];
+          char eventLog[256];
           snprintf(eventLog, sizeof(eventLog), "snapshot sender udpate replicaIndex from %d to %d, %s:%d, %p, reset:%d",
                    oldreplicaIndex, i, host, port, (pSyncNode->senders)[i], reset);
           syncNodeEventLog(pSyncNode, eventLog);
@@ -1583,6 +1574,10 @@ void syncNodeBecomeLeader(SSyncNode* pSyncNode, const char* debugStr) {
   // start heartbeat timer
   syncNodeStartHeartbeatTimer(pSyncNode);
 
+  // append noop
+  syncNodeAppendNoop(pSyncNode);
+  syncMaybeAdvanceCommitIndex(pSyncNode);  // maybe only one replica
+
   // trace log
   do {
     int32_t debugStrLen = strlen(debugStr);
@@ -1608,10 +1603,6 @@ void syncNodeCandidate2Leader(SSyncNode* pSyncNode) {
 
   // Raft 3.6.2 Committing entries from previous terms
 
-  // use this now
-  syncNodeAppendNoop(pSyncNode);
-  syncMaybeAdvanceCommitIndex(pSyncNode);  // maybe only one replica
-
   // do not use this
   // syncNodeEqNoop(pSyncNode);
 }