Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
taosdata
TDengine
提交
928473f0
TDengine
项目概览
taosdata
/
TDengine
接近 2 年 前同步成功
通知
1191
Star
22018
Fork
4786
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
1
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
TDengine
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
1
Issue
1
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
提交
928473f0
编写于
7月 27, 2021
作者:
M
markswang
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[TD-5534]<fix>:fix the coverity high risk of client
上级
ff9971ff
变更
7
隐藏空白更改
内联
并排
Showing
7 changed file
with
7 addition
and
12 deletion
+7
-12
src/client/src/tscParseLineProtocol.c
src/client/src/tscParseLineProtocol.c
+1
-1
src/client/src/tscPrepare.c
src/client/src/tscPrepare.c
+2
-2
src/client/src/tscSQLParser.c
src/client/src/tscSQLParser.c
+1
-1
src/client/src/tscServer.c
src/client/src/tscServer.c
+1
-1
src/client/src/tscUtil.c
src/client/src/tscUtil.c
+1
-5
src/query/inc/qExecutor.h
src/query/inc/qExecutor.h
+0
-1
src/query/src/qExecutor.c
src/query/src/qExecutor.c
+1
-1
未找到文件。
src/client/src/tscParseLineProtocol.c
浏览文件 @
928473f0
...
@@ -1653,7 +1653,7 @@ static int32_t parseSmlTimeStamp(TAOS_SML_KV **pTS, const char **index) {
...
@@ -1653,7 +1653,7 @@ static int32_t parseSmlTimeStamp(TAOS_SML_KV **pTS, const char **index) {
static
int32_t
parseSmlKey
(
TAOS_SML_KV
*
pKV
,
const
char
**
index
)
{
static
int32_t
parseSmlKey
(
TAOS_SML_KV
*
pKV
,
const
char
**
index
)
{
const
char
*
cur
=
*
index
;
const
char
*
cur
=
*
index
;
char
key
[
TSDB_COL_NAME_LEN
+
1
];
// +1 to avoid
1685 line
over write
char
key
[
TSDB_COL_NAME_LEN
+
1
];
// +1 to avoid
key[len]
over write
uint16_t
len
=
0
;
uint16_t
len
=
0
;
//key field cannot start with digit
//key field cannot start with digit
...
...
src/client/src/tscPrepare.c
浏览文件 @
928473f0
...
@@ -1628,8 +1628,8 @@ int taos_stmt_set_tbname_tags(TAOS_STMT* stmt, const char* name, TAOS_BIND* tags
...
@@ -1628,8 +1628,8 @@ int taos_stmt_set_tbname_tags(TAOS_STMT* stmt, const char* name, TAOS_BIND* tags
if
(
pStmt
->
mtb
.
subSet
&&
taosHashGetSize
(
pStmt
->
mtb
.
pTableHash
)
>
0
)
{
if
(
pStmt
->
mtb
.
subSet
&&
taosHashGetSize
(
pStmt
->
mtb
.
pTableHash
)
>
0
)
{
STableMetaInfo
*
pTableMetaInfo
=
tscGetTableMetaInfoFromCmd
(
pCmd
,
0
);
STableMetaInfo
*
pTableMetaInfo
=
tscGetTableMetaInfoFromCmd
(
pCmd
,
0
);
STableMeta
*
pTableMeta
=
pTableMetaInfo
->
pTableMeta
;
STableMeta
*
pTableMeta
=
pTableMetaInfo
->
pTableMeta
;
char
sTableName
[
TSDB_TABLE_FNAME_LEN
+
1
]
=
{
0
};
char
sTableName
[
TSDB_TABLE_FNAME_LEN
]
=
{
0
};
strncpy
(
sTableName
,
pTableMeta
->
sTableName
,
sizeof
(
sTableName
)
-
1
);
tstrncpy
(
sTableName
,
pTableMeta
->
sTableName
,
sizeof
(
sTableName
)
);
SStrToken
tname
=
{
0
};
SStrToken
tname
=
{
0
};
tname
.
type
=
TK_STRING
;
tname
.
type
=
TK_STRING
;
...
...
src/client/src/tscSQLParser.c
浏览文件 @
928473f0
...
@@ -8366,7 +8366,7 @@ static int32_t doValidateSubquery(SSqlNode* pSqlNode, int32_t index, SSqlObj* pS
...
@@ -8366,7 +8366,7 @@ static int32_t doValidateSubquery(SSqlNode* pSqlNode, int32_t index, SSqlObj* pS
return
invalidOperationMsg
(
msgBuf
,
"subquery alias name too long"
);
return
invalidOperationMsg
(
msgBuf
,
"subquery alias name too long"
);
}
}
strncpy
(
pTableMetaInfo1
->
aliasName
,
subInfo
->
aliasName
.
z
,
MIN
(
subInfo
->
aliasName
.
n
,
sizeof
(
pTableMetaInfo1
->
aliasName
)
-
1
));
tstrncpy
(
pTableMetaInfo1
->
aliasName
,
subInfo
->
aliasName
.
z
,
MIN
(
subInfo
->
aliasName
.
n
,
sizeof
(
pTableMetaInfo1
->
aliasName
)
));
}
}
taosArrayPush
(
pQueryInfo
->
pUpstream
,
&
pSub
);
taosArrayPush
(
pQueryInfo
->
pUpstream
,
&
pSub
);
...
...
src/client/src/tscServer.c
浏览文件 @
928473f0
...
@@ -164,7 +164,7 @@ static void tscUpdateVgroupInfo(SSqlObj *pSql, SRpcEpSet *pEpSet) {
...
@@ -164,7 +164,7 @@ static void tscUpdateVgroupInfo(SSqlObj *pSql, SRpcEpSet *pEpSet) {
vgroupInfo
.
inUse
=
pEpSet
->
inUse
;
vgroupInfo
.
inUse
=
pEpSet
->
inUse
;
vgroupInfo
.
numOfEps
=
pEpSet
->
numOfEps
;
vgroupInfo
.
numOfEps
=
pEpSet
->
numOfEps
;
for
(
int32_t
i
=
0
;
i
<
vgroupInfo
.
numOfEps
;
i
++
)
{
for
(
int32_t
i
=
0
;
i
<
vgroupInfo
.
numOfEps
;
i
++
)
{
strncpy
(
vgroupInfo
.
ep
[
i
].
fqdn
,
pEpSet
->
fqdn
[
i
],
TSDB_FQDN_LEN
);
// buffer not null terminated risk
t
strncpy
(
vgroupInfo
.
ep
[
i
].
fqdn
,
pEpSet
->
fqdn
[
i
],
TSDB_FQDN_LEN
);
// buffer not null terminated risk
vgroupInfo
.
ep
[
i
].
port
=
pEpSet
->
port
[
i
];
vgroupInfo
.
ep
[
i
].
port
=
pEpSet
->
port
[
i
];
}
}
...
...
src/client/src/tscUtil.c
浏览文件 @
928473f0
...
@@ -1236,10 +1236,6 @@ void handleDownstreamOperator(SSqlObj** pSqlObjList, int32_t numOfUpstream, SQue
...
@@ -1236,10 +1236,6 @@ void handleDownstreamOperator(SSqlObj** pSqlObjList, int32_t numOfUpstream, SQue
}
}
pSourceOperator
=
createJoinOperatorInfo
(
p
,
px
->
numOfTables
,
schema
,
num
);
pSourceOperator
=
createJoinOperatorInfo
(
p
,
px
->
numOfTables
,
schema
,
num
);
for
(
int32_t
i
=
0
;
i
<
px
->
numOfTables
;
++
i
)
{
destroyOperatorInfo
(
p
[
i
]);
}
tfree
(
p
);
tfree
(
p
);
}
else
{
}
else
{
size_t
num
=
taosArrayGetSize
(
px
->
colList
);
size_t
num
=
taosArrayGetSize
(
px
->
colList
);
...
@@ -4714,7 +4710,7 @@ static int32_t doAddTableName(char* nextStr, char** str, SArray* pNameArray, SSq
...
@@ -4714,7 +4710,7 @@ static int32_t doAddTableName(char* nextStr, char** str, SArray* pNameArray, SSq
int32_t
len
=
0
;
int32_t
len
=
0
;
if
(
nextStr
==
NULL
)
{
if
(
nextStr
==
NULL
)
{
strncpy
(
tablename
,
*
str
,
TSDB_TABLE_FNAME_LEN
-
1
);
tstrncpy
(
tablename
,
*
str
,
TSDB_TABLE_FNAME_LEN
);
len
=
(
int32_t
)
strlen
(
tablename
);
len
=
(
int32_t
)
strlen
(
tablename
);
}
else
{
}
else
{
len
=
(
int32_t
)(
nextStr
-
(
*
str
));
len
=
(
int32_t
)(
nextStr
-
(
*
str
));
...
...
src/query/inc/qExecutor.h
浏览文件 @
928473f0
...
@@ -578,7 +578,6 @@ void doCompactSDataBlock(SSDataBlock* pBlock, int32_t numOfRows, int8_t* p);
...
@@ -578,7 +578,6 @@ void doCompactSDataBlock(SSDataBlock* pBlock, int32_t numOfRows, int8_t* p);
SSDataBlock
*
createOutputBuf
(
SExprInfo
*
pExpr
,
int32_t
numOfOutput
,
int32_t
numOfRows
);
SSDataBlock
*
createOutputBuf
(
SExprInfo
*
pExpr
,
int32_t
numOfOutput
,
int32_t
numOfRows
);
void
*
destroyOutputBuf
(
SSDataBlock
*
pBlock
);
void
*
destroyOutputBuf
(
SSDataBlock
*
pBlock
);
void
*
doDestroyFilterInfo
(
SSingleColumnFilterInfo
*
pFilterInfo
,
int32_t
numOfFilterCols
);
void
*
doDestroyFilterInfo
(
SSingleColumnFilterInfo
*
pFilterInfo
,
int32_t
numOfFilterCols
);
void
destroyOperatorInfo
(
SOperatorInfo
*
pOperator
);
void
setInputDataBlock
(
SOperatorInfo
*
pOperator
,
SQLFunctionCtx
*
pCtx
,
SSDataBlock
*
pBlock
,
int32_t
order
);
void
setInputDataBlock
(
SOperatorInfo
*
pOperator
,
SQLFunctionCtx
*
pCtx
,
SSDataBlock
*
pBlock
,
int32_t
order
);
int32_t
getNumOfResult
(
SQueryRuntimeEnv
*
pRuntimeEnv
,
SQLFunctionCtx
*
pCtx
,
int32_t
numOfOutput
);
int32_t
getNumOfResult
(
SQueryRuntimeEnv
*
pRuntimeEnv
,
SQLFunctionCtx
*
pCtx
,
int32_t
numOfOutput
);
...
...
src/query/src/qExecutor.c
浏览文件 @
928473f0
...
@@ -5949,7 +5949,7 @@ static int32_t getNumOfScanTimes(SQueryAttr* pQueryAttr) {
...
@@ -5949,7 +5949,7 @@ static int32_t getNumOfScanTimes(SQueryAttr* pQueryAttr) {
return
1
;
return
1
;
}
}
void
destroyOperatorInfo
(
SOperatorInfo
*
pOperator
)
{
static
void
destroyOperatorInfo
(
SOperatorInfo
*
pOperator
)
{
if
(
pOperator
==
NULL
)
{
if
(
pOperator
==
NULL
)
{
return
;
return
;
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录