Merge branch '3.0' of https://github.com/taosdata/TDengine into feature/vnode

include/common/tmsg.h

@@ -273,11 +273,11 @@ typedef struct {
   char     name[TSDB_COL_NAME_LEN];
 } SSchemaEx;
 
-#define SSCHMEA_TYPE(s) ((s)->type)
-#define SSCHMEA_SMA(s) ((s)->sma)
+#define SSCHMEA_TYPE(s)  ((s)->type)
+#define SSCHMEA_SMA(s)   ((s)->sma)
 #define SSCHMEA_COLID(s) ((s)->colId)
 #define SSCHMEA_BYTES(s) ((s)->bytes)
-#define SSCHMEA_NAME(s) ((s)->name)
+#define SSCHMEA_NAME(s)  ((s)->name)
 
 typedef struct {
   char    name[TSDB_TABLE_FNAME_LEN];
@@ -483,7 +483,8 @@ typedef struct {
   int32_t tz;  // query client timezone
   char    intervalUnit;
   char    slidingUnit;
-  char    offsetUnit;  // TODO Remove it, the offset is the number of precision tickle, and it must be a immutable duration.
+  char
+      offsetUnit;  // TODO Remove it, the offset is the number of precision tickle, and it must be a immutable duration.
   int8_t  precision;
   int64_t interval;
   int64_t sliding;
@@ -934,12 +935,12 @@ typedef struct SExplainExecInfo {
   uint64_t startupCost;
   uint64_t totalCost;
   uint64_t numOfRows;
-  void    *verboseInfo;
+  void*    verboseInfo;
 } SExplainExecInfo;
 
 typedef struct {
   int32_t           numOfPlans;
-  SExplainExecInfo *subplanInfo;
+  SExplainExecInfo* subplanInfo;
 } SExplainRsp;
 
 int32_t tSerializeSExplainRsp(void* buf, int32_t bufLen, SExplainRsp* pRsp);
@@ -1432,12 +1433,12 @@ typedef struct SVCreateTbReq {
   };
   union {
     struct {
-      tb_uid_t   suid;
-      col_id_t   nCols;
-      col_id_t   nBSmaCols;
-      SSchemaEx* pSchema;
-      col_id_t   nTagCols;
-      SSchema*   pTagSchema;
+      tb_uid_t    suid;
+      col_id_t    nCols;
+      col_id_t    nBSmaCols;
+      SSchemaEx*  pSchema;
+      col_id_t    nTagCols;
+      SSchema*    pTagSchema;
       SRSmaParam* pRSmaParam;
     } stbCfg;
     struct {
@@ -1445,9 +1446,9 @@ typedef struct SVCreateTbReq {
       SKVRow   pTag;
     } ctbCfg;
     struct {
-      col_id_t   nCols;
-      col_id_t   nBSmaCols;
-      SSchemaEx* pSchema;
+      col_id_t    nCols;
+      col_id_t    nBSmaCols;
+      SSchemaEx*  pSchema;
       SRSmaParam* pRSmaParam;
     } ntbCfg;
   };
@@ -1866,6 +1867,37 @@ static FORCE_INLINE void* tDecodeSMqSetCVgReq(void* buf, SMqSetCVgReq* pReq) {
   return buf;
 }
 
+typedef struct {
+  int64_t leftForVer;
+  int32_t vgId;
+  int32_t epoch;
+  int64_t consumerId;
+  char    topicName[TSDB_TOPIC_FNAME_LEN];
+} SMqCancelConnReq;
+
+static FORCE_INLINE int32_t tEncodeSMqCancelConnReq(void** buf, const SMqCancelConnReq* pReq) {
+  int32_t tlen = 0;
+  tlen += taosEncodeFixedI64(buf, pReq->leftForVer);
+  tlen += taosEncodeFixedI32(buf, pReq->vgId);
+  tlen += taosEncodeFixedI32(buf, pReq->epoch);
+  tlen += taosEncodeFixedI64(buf, pReq->consumerId);
+  tlen += taosEncodeString(buf, pReq->topicName);
+  return tlen;
+}
+
+static FORCE_INLINE void* tDecodeSMqCancelConnReq(void* buf, SMqCancelConnReq* pReq) {
+  buf = taosDecodeFixedI64(buf, &pReq->leftForVer);
+  buf = taosDecodeFixedI32(buf, &pReq->vgId);
+  buf = taosDecodeFixedI32(buf, &pReq->epoch);
+  buf = taosDecodeFixedI64(buf, &pReq->consumerId);
+  buf = taosDecodeStringTo(buf, pReq->topicName);
+  return buf;
+}
+
+typedef struct {
+  int8_t reserved;
+} SMqCancelConnRsp;
+
 typedef struct {
   int64_t leftForVer;
   int32_t vgId;

include/common/tmsgdef.h

@@ -176,6 +176,7 @@ enum {
   TD_DEF_MSG_TYPE(TDMT_VND_MQ_DISCONNECT, "vnode-mq-disconnect", NULL, NULL)
   TD_DEF_MSG_TYPE(TDMT_VND_MQ_SET_CONN, "vnode-mq-set-conn", SMqSetCVgReq, SMqSetCVgRsp)
   TD_DEF_MSG_TYPE(TDMT_VND_MQ_REB, "vnode-mq-mv-rebalance", SMqMVRebReq, SMqMVRebRsp)
+  TD_DEF_MSG_TYPE(TDMT_VND_MQ_CANCEL_CONN, "vnode-mq-mv-cancel-conn", SMqCancelConnReq, SMqCancelConnRsp)
   TD_DEF_MSG_TYPE(TDMT_VND_MQ_SET_CUR, "vnode-mq-set-cur", NULL, NULL)
   TD_DEF_MSG_TYPE(TDMT_VND_RES_READY, "vnode-res-ready", NULL, NULL)
   TD_DEF_MSG_TYPE(TDMT_VND_TASKS_STATUS, "vnode-tasks-status", NULL, NULL)

include/common/ttokendef.h

@@ -69,153 +69,154 @@
 #define TK_CACHELAST                       51
 #define TK_COMP                            52
 #define TK_DAYS                            53
-#define TK_FSYNC                           54
-#define TK_MAXROWS                         55
-#define TK_MINROWS                         56
-#define TK_KEEP                            57
-#define TK_PRECISION                       58
-#define TK_QUORUM                          59
-#define TK_REPLICA                         60
-#define TK_TTL                             61
-#define TK_WAL                             62
-#define TK_VGROUPS                         63
-#define TK_SINGLE_STABLE                   64
-#define TK_STREAM_MODE                     65
-#define TK_RETENTIONS                      66
-#define TK_NK_COMMA                        67
-#define TK_TABLE                           68
-#define TK_NK_LP                           69
-#define TK_NK_RP                           70
-#define TK_STABLE                          71
-#define TK_ADD                             72
-#define TK_COLUMN                          73
-#define TK_MODIFY                          74
-#define TK_RENAME                          75
-#define TK_TAG                             76
-#define TK_SET                             77
-#define TK_NK_EQ                           78
-#define TK_USING                           79
-#define TK_TAGS                            80
-#define TK_NK_DOT                          81
-#define TK_COMMENT                         82
-#define TK_BOOL                            83
-#define TK_TINYINT                         84
-#define TK_SMALLINT                        85
-#define TK_INT                             86
-#define TK_INTEGER                         87
-#define TK_BIGINT                          88
-#define TK_FLOAT                           89
-#define TK_DOUBLE                          90
-#define TK_BINARY                          91
-#define TK_TIMESTAMP                       92
-#define TK_NCHAR                           93
-#define TK_UNSIGNED                        94
-#define TK_JSON                            95
-#define TK_VARCHAR                         96
-#define TK_MEDIUMBLOB                      97
-#define TK_BLOB                            98
-#define TK_VARBINARY                       99
-#define TK_DECIMAL                        100
-#define TK_SMA                            101
-#define TK_ROLLUP                         102
-#define TK_FILE_FACTOR                    103
-#define TK_NK_FLOAT                       104
-#define TK_DELAY                          105
-#define TK_SHOW                           106
-#define TK_DATABASES                      107
-#define TK_TABLES                         108
-#define TK_STABLES                        109
-#define TK_MNODES                         110
-#define TK_MODULES                        111
-#define TK_QNODES                         112
-#define TK_FUNCTIONS                      113
-#define TK_INDEXES                        114
-#define TK_FROM                           115
-#define TK_ACCOUNTS                       116
-#define TK_APPS                           117
-#define TK_CONNECTIONS                    118
-#define TK_LICENCE                        119
-#define TK_QUERIES                        120
-#define TK_SCORES                         121
-#define TK_TOPICS                         122
-#define TK_VARIABLES                      123
-#define TK_LIKE                           124
-#define TK_INDEX                          125
-#define TK_FULLTEXT                       126
-#define TK_FUNCTION                       127
-#define TK_INTERVAL                       128
-#define TK_TOPIC                          129
-#define TK_AS                             130
-#define TK_DESC                           131
-#define TK_DESCRIBE                       132
-#define TK_RESET                          133
-#define TK_QUERY                          134
-#define TK_EXPLAIN                        135
-#define TK_ANALYZE                        136
-#define TK_VERBOSE                        137
-#define TK_NK_BOOL                        138
-#define TK_RATIO                          139
-#define TK_COMPACT                        140
-#define TK_VNODES                         141
-#define TK_IN                             142
-#define TK_OUTPUTTYPE                     143
-#define TK_AGGREGATE                      144
-#define TK_BUFSIZE                        145
-#define TK_STREAM                         146
-#define TK_INTO                           147
-#define TK_KILL                           148
-#define TK_CONNECTION                     149
-#define TK_MERGE                          150
-#define TK_VGROUP                         151
-#define TK_REDISTRIBUTE                   152
-#define TK_SPLIT                          153
-#define TK_SYNCDB                         154
-#define TK_NULL                           155
-#define TK_NK_VARIABLE                    156
-#define TK_NOW                            157
-#define TK_ROWTS                          158
-#define TK_TBNAME                         159
-#define TK_QSTARTTS                       160
-#define TK_QENDTS                         161
-#define TK_WSTARTTS                       162
-#define TK_WENDTS                         163
-#define TK_WDURATION                      164
-#define TK_BETWEEN                        165
-#define TK_IS                             166
-#define TK_NK_LT                          167
-#define TK_NK_GT                          168
-#define TK_NK_LE                          169
-#define TK_NK_GE                          170
-#define TK_NK_NE                          171
-#define TK_MATCH                          172
-#define TK_NMATCH                         173
-#define TK_JOIN                           174
-#define TK_INNER                          175
-#define TK_SELECT                         176
-#define TK_DISTINCT                       177
-#define TK_WHERE                          178
-#define TK_PARTITION                      179
-#define TK_BY                             180
-#define TK_SESSION                        181
-#define TK_STATE_WINDOW                   182
-#define TK_SLIDING                        183
-#define TK_FILL                           184
-#define TK_VALUE                          185
-#define TK_NONE                           186
-#define TK_PREV                           187
-#define TK_LINEAR                         188
-#define TK_NEXT                           189
-#define TK_GROUP                          190
-#define TK_HAVING                         191
-#define TK_ORDER                          192
-#define TK_SLIMIT                         193
-#define TK_SOFFSET                        194
-#define TK_LIMIT                          195
-#define TK_OFFSET                         196
-#define TK_ASC                            197
-#define TK_NULLS                          198
-#define TK_FIRST                          199
-#define TK_LAST                           200
+#define TK_NK_VARIABLE                     54
+#define TK_FSYNC                           55
+#define TK_MAXROWS                         56
+#define TK_MINROWS                         57
+#define TK_KEEP                            58
+#define TK_PRECISION                       59
+#define TK_QUORUM                          60
+#define TK_REPLICA                         61
+#define TK_TTL                             62
+#define TK_WAL                             63
+#define TK_VGROUPS                         64
+#define TK_SINGLE_STABLE                   65
+#define TK_STREAM_MODE                     66
+#define TK_RETENTIONS                      67
+#define TK_NK_COMMA                        68
+#define TK_NK_COLON                        69
+#define TK_TABLE                           70
+#define TK_NK_LP                           71
+#define TK_NK_RP                           72
+#define TK_STABLE                          73
+#define TK_ADD                             74
+#define TK_COLUMN                          75
+#define TK_MODIFY                          76
+#define TK_RENAME                          77
+#define TK_TAG                             78
+#define TK_SET                             79
+#define TK_NK_EQ                           80
+#define TK_USING                           81
+#define TK_TAGS                            82
+#define TK_NK_DOT                          83
+#define TK_COMMENT                         84
+#define TK_BOOL                            85
+#define TK_TINYINT                         86
+#define TK_SMALLINT                        87
+#define TK_INT                             88
+#define TK_INTEGER                         89
+#define TK_BIGINT                          90
+#define TK_FLOAT                           91
+#define TK_DOUBLE                          92
+#define TK_BINARY                          93
+#define TK_TIMESTAMP                       94
+#define TK_NCHAR                           95
+#define TK_UNSIGNED                        96
+#define TK_JSON                            97
+#define TK_VARCHAR                         98
+#define TK_MEDIUMBLOB                      99
+#define TK_BLOB                           100
+#define TK_VARBINARY                      101
+#define TK_DECIMAL                        102
+#define TK_SMA                            103
+#define TK_ROLLUP                         104
+#define TK_FILE_FACTOR                    105
+#define TK_NK_FLOAT                       106
+#define TK_DELAY                          107
+#define TK_SHOW                           108
+#define TK_DATABASES                      109
+#define TK_TABLES                         110
+#define TK_STABLES                        111
+#define TK_MNODES                         112
+#define TK_MODULES                        113
+#define TK_QNODES                         114
+#define TK_FUNCTIONS                      115
+#define TK_INDEXES                        116
+#define TK_FROM                           117
+#define TK_ACCOUNTS                       118
+#define TK_APPS                           119
+#define TK_CONNECTIONS                    120
+#define TK_LICENCE                        121
+#define TK_QUERIES                        122
+#define TK_SCORES                         123
+#define TK_TOPICS                         124
+#define TK_VARIABLES                      125
+#define TK_LIKE                           126
+#define TK_INDEX                          127
+#define TK_FULLTEXT                       128
+#define TK_FUNCTION                       129
+#define TK_INTERVAL                       130
+#define TK_TOPIC                          131
+#define TK_AS                             132
+#define TK_DESC                           133
+#define TK_DESCRIBE                       134
+#define TK_RESET                          135
+#define TK_QUERY                          136
+#define TK_EXPLAIN                        137
+#define TK_ANALYZE                        138
+#define TK_VERBOSE                        139
+#define TK_NK_BOOL                        140
+#define TK_RATIO                          141
+#define TK_COMPACT                        142
+#define TK_VNODES                         143
+#define TK_IN                             144
+#define TK_OUTPUTTYPE                     145
+#define TK_AGGREGATE                      146
+#define TK_BUFSIZE                        147
+#define TK_STREAM                         148
+#define TK_INTO                           149
+#define TK_KILL                           150
+#define TK_CONNECTION                     151
+#define TK_MERGE                          152
+#define TK_VGROUP                         153
+#define TK_REDISTRIBUTE                   154
+#define TK_SPLIT                          155
+#define TK_SYNCDB                         156
+#define TK_NULL                           157
+#define TK_FIRST                          158
+#define TK_LAST                           159
+#define TK_NOW                            160
+#define TK_ROWTS                          161
+#define TK_TBNAME                         162
+#define TK_QSTARTTS                       163
+#define TK_QENDTS                         164
+#define TK_WSTARTTS                       165
+#define TK_WENDTS                         166
+#define TK_WDURATION                      167
+#define TK_BETWEEN                        168
+#define TK_IS                             169
+#define TK_NK_LT                          170
+#define TK_NK_GT                          171
+#define TK_NK_LE                          172
+#define TK_NK_GE                          173
+#define TK_NK_NE                          174
+#define TK_MATCH                          175
+#define TK_NMATCH                         176
+#define TK_JOIN                           177
+#define TK_INNER                          178
+#define TK_SELECT                         179
+#define TK_DISTINCT                       180
+#define TK_WHERE                          181
+#define TK_PARTITION                      182
+#define TK_BY                             183
+#define TK_SESSION                        184
+#define TK_STATE_WINDOW                   185
+#define TK_SLIDING                        186
+#define TK_FILL                           187
+#define TK_VALUE                          188
+#define TK_NONE                           189
+#define TK_PREV                           190
+#define TK_LINEAR                         191
+#define TK_NEXT                           192
+#define TK_GROUP                          193
+#define TK_HAVING                         194
+#define TK_ORDER                          195
+#define TK_SLIMIT                         196
+#define TK_SOFFSET                        197
+#define TK_LIMIT                          198
+#define TK_OFFSET                         199
+#define TK_ASC                            200
+#define TK_NULLS                          201
 
 #define TK_NK_SPACE                       300
 #define TK_NK_COMMENT                     301
@@ -226,7 +227,6 @@
 #define TK_NK_FILE                        306
 #define TK_NK_QUESTION                    307   // denoting the placeholder of "?",when invoking statement bind query
 
-#define TK_NK_COLON                       500
 #define TK_NK_BITNOT                      501
 #define TK_INSERT                         502
 #define TK_VALUES                         507

include/libs/nodes/cmdnodes.h

@@ -30,25 +30,23 @@ extern "C" {
 
 typedef struct SDatabaseOptions {
   ENodeType type;
-  int32_t numOfBlocks;
-  int32_t cacheBlockSize;
-  int8_t cachelast;
-  int32_t compressionLevel;
-  int32_t daysPerFile;
-  int32_t fsyncPeriod;
-  int32_t maxRowsPerBlock;
-  int32_t minRowsPerBlock;
-  int32_t keep0;
-  int32_t keep1;
-  int32_t keep2;
-  int32_t precision;
-  int32_t quorum;
-  int32_t replica;
-  int32_t ttl;
-  int32_t walLevel;
-  int32_t numOfVgroups;
-  int8_t singleStable;
-  int8_t streamMode;
+  SValueNode* pNumOfBlocks;
+  SValueNode* pCacheBlockSize;
+  SValueNode* pCachelast;
+  SValueNode* pCompressionLevel;
+  SValueNode* pDaysPerFile;
+  SValueNode* pFsyncPeriod;
+  SValueNode* pMaxRowsPerBlock;
+  SValueNode* pMinRowsPerBlock;
+  SNodeList* pKeep;
+  SValueNode* pPrecision;
+  SValueNode* pQuorum;
+  SValueNode* pReplica;
+  SValueNode* pTtl;
+  SValueNode* pWalLevel;
+  SValueNode* pNumOfVgroups;
+  SValueNode* pSingleStable;
+  SValueNode* pStreamMode;
   SNodeList* pRetentions;
 } SDatabaseOptions;
 
@@ -78,15 +76,13 @@ typedef struct SAlterDatabaseStmt {
 
 typedef struct STableOptions {
   ENodeType type;
-  int32_t keep0;
-  int32_t keep1;
-  int32_t keep2;
-  int32_t ttl;
-  char comments[TSDB_STB_COMMENT_LEN];
+  SNodeList* pKeep;
+  SValueNode* pTtl;
+  SValueNode* pComments;
   SNodeList* pSma;
   SNodeList* pFuncs;
-  float filesFactor;
-  int32_t delay;
+  SValueNode* pFilesFactor;
+  SValueNode* pDelay;
 } STableOptions;
 
 typedef struct SColumnDefNode {

include/libs/nodes/plannodes.h

@@ -286,12 +286,14 @@ typedef struct SSortPhysiNode {
   SPhysiNode node;
   SNodeList* pExprs;   // these are expression list of order_by_clause and parameter expression of aggregate function
   SNodeList* pSortKeys; // element is SOrderByExprNode, and SOrderByExprNode::pExpr is SColumnNode
+  SNodeList* pTargets;
 } SSortPhysiNode;
 
 typedef struct SPartitionPhysiNode {
   SPhysiNode node;
   SNodeList* pExprs;   // these are expression list of partition_by_clause
   SNodeList* pPartitionKeys;
+  SNodeList* pTargets;
 } SPartitionPhysiNode;
 
 typedef struct SDataSinkNode {

include/libs/nodes/querynodes.h

@@ -258,6 +258,7 @@ typedef enum ESqlClause {
   SQL_CLAUSE_WINDOW,
   SQL_CLAUSE_GROUP_BY,
   SQL_CLAUSE_HAVING,
+  SQL_CLAUSE_DISTINCT,
   SQL_CLAUSE_SELECT,
   SQL_CLAUSE_ORDER_BY
 } ESqlClause;

include/util/taoserror.h

@@ -482,6 +482,17 @@ int32_t* taosGetErrno();
 #define TSDB_CODE_PAR_DB_NOT_SPECIFIED          TAOS_DEF_ERROR_CODE(0, 0x2616)
 #define TSDB_CODE_PAR_INVALID_IDENTIFIER_NAME   TAOS_DEF_ERROR_CODE(0, 0x2617)
 #define TSDB_CODE_PAR_CORRESPONDING_STABLE_ERR  TAOS_DEF_ERROR_CODE(0, 0x2618)
+#define TSDB_CODE_PAR_INVALID_RANGE_OPTION      TAOS_DEF_ERROR_CODE(0, 0x2619)
+#define TSDB_CODE_PAR_INVALID_STR_OPTION        TAOS_DEF_ERROR_CODE(0, 0x2620)
+#define TSDB_CODE_PAR_INVALID_ENUM_OPTION       TAOS_DEF_ERROR_CODE(0, 0x2621)
+#define TSDB_CODE_PAR_INVALID_TTL_OPTION        TAOS_DEF_ERROR_CODE(0, 0x2622)
+#define TSDB_CODE_PAR_INVALID_KEEP_NUM          TAOS_DEF_ERROR_CODE(0, 0x2623)
+#define TSDB_CODE_PAR_INVALID_KEEP_ORDER        TAOS_DEF_ERROR_CODE(0, 0x2624)
+#define TSDB_CODE_PAR_INVALID_KEEP_VALUE        TAOS_DEF_ERROR_CODE(0, 0x2625)
+#define TSDB_CODE_PAR_INVALID_COMMENT_OPTION    TAOS_DEF_ERROR_CODE(0, 0x2626)
+#define TSDB_CODE_PAR_INVALID_F_RANGE_OPTION    TAOS_DEF_ERROR_CODE(0, 0x2627)
+#define TSDB_CODE_PAR_INVALID_ROLLUP_OPTION     TAOS_DEF_ERROR_CODE(0, 0x2628)
+#define TSDB_CODE_PAR_INVALID_RETENTIONS_OPTION TAOS_DEF_ERROR_CODE(0, 0x2629)
 
 //planner
 #define TSDB_CODE_PLAN_INTERNAL_ERROR              TAOS_DEF_ERROR_CODE(0, 0x2700)

packaging/install.sh

+#!/bin/bash
+#
+# This file is used to install database on linux systems. The operating system
+# is required to use systemd to manage services at boot
+
+set -e
+#set -x
+
+# -----------------------Variables definition---------------------
+script_dir=$(dirname $(readlink -f "$0"))
+# Dynamic directory
+data_dir="/var/lib/taos"
+log_dir="/var/log/taos"
+
+data_link_dir="/usr/local/taos/data"
+log_link_dir="/usr/local/taos/log"
+
+cfg_install_dir="/etc/taos"
+
+bin_link_dir="/usr/bin"
+lib_link_dir="/usr/lib"
+lib64_link_dir="/usr/lib64"
+inc_link_dir="/usr/include"
+
+#install main path
+install_main_dir="/usr/local/taos"
+
+# old bin dir
+bin_dir="/usr/local/taos/bin"
+
+service_config_dir="/etc/systemd/system"
+
+# Color setting
+RED='\033[0;31m'
+GREEN='\033[1;32m'
+GREEN_DARK='\033[0;32m'
+GREEN_UNDERLINE='\033[4;32m'
+NC='\033[0m'
+
+csudo=""
+if command -v sudo > /dev/null; then
+    csudo="sudo"
+fi
+
+update_flag=0
+prompt_force=0
+
+initd_mod=0
+service_mod=2
+if pidof systemd &> /dev/null; then
+    service_mod=0
+elif $(which service &> /dev/null); then
+    service_mod=1
+    service_config_dir="/etc/init.d"
+    if $(which chkconfig &> /dev/null); then
+         initd_mod=1
+    elif $(which insserv &> /dev/null); then
+        initd_mod=2
+    elif $(which update-rc.d &> /dev/null); then
+        initd_mod=3
+    else
+        service_mod=2
+    fi
+else
+    service_mod=2
+fi
+
+
+# get the operating system type for using the corresponding init file
+# ubuntu/debian(deb), centos/fedora(rpm), others: opensuse, redhat, ..., no verification
+#osinfo=$(awk -F= '/^NAME/{print $2}' /etc/os-release)
+if [[ -e /etc/os-release ]]; then
+  osinfo=$(cat /etc/os-release | grep "NAME" | cut -d '"' -f2)   ||:
+else
+  osinfo=""
+fi
+#echo "osinfo: ${osinfo}"
+os_type=0
+if echo $osinfo | grep -qwi "ubuntu" ; then
+#  echo "This is ubuntu system"
+  os_type=1
+elif echo $osinfo | grep -qwi "debian" ; then
+#  echo "This is debian system"
+  os_type=1
+elif echo $osinfo | grep -qwi "Kylin" ; then
+#  echo "This is Kylin system"
+  os_type=1
+elif  echo $osinfo | grep -qwi "centos" ; then
+#  echo "This is centos system"
+  os_type=2
+elif echo $osinfo | grep -qwi "fedora" ; then
+#  echo "This is fedora system"
+  os_type=2
+elif echo $osinfo | grep -qwi "Linx" ; then
+#  echo "This is Linx system"
+  os_type=1
+  service_mod=0
+  initd_mod=0
+  service_config_dir="/etc/systemd/system"
+else
+  echo " osinfo: ${osinfo}"
+  echo " This is an officially unverified linux system,"
+  echo " if there are any problems with the installation and operation, "
+  echo " please feel free to contact taosdata.com for support."
+  os_type=1
+fi
+
+
+# =============================  get input parameters =================================================
+
+# install.sh -v [server | client]  -e [yes | no] -i [systemd | service | ...]
+
+# set parameters by default value
+interactiveFqdn=yes   # [yes | no]
+verType=server        # [server | client]
+initType=systemd      # [systemd | service | ...]
+
+while getopts "hv:e:i:" arg
+do
+  case $arg in
+    e)
+      #echo "interactiveFqdn=$OPTARG"
+      interactiveFqdn=$( echo $OPTARG )
+      ;;
+    v)
+      #echo "verType=$OPTARG"
+      verType=$(echo $OPTARG)
+      ;;
+    i)
+      #echo "initType=$OPTARG"
+      initType=$(echo $OPTARG)
+      ;;
+    h)
+      echo "Usage: `basename $0` -v [server | client]  -e [yes | no]"
+      exit 0
+      ;;
+    ?) #unknow option
+      echo "unkonw argument"
+      exit 1
+      ;;
+  esac
+done
+
+#echo "verType=${verType} interactiveFqdn=${interactiveFqdn}"
+
+function kill_process() {
+  pid=$(ps -ef | grep "$1" | grep -v "grep" | awk '{print $2}')
+  if [ -n "$pid" ]; then
+    ${csudo} kill -9 $pid   || :
+  fi
+}
+
+function install_main_path() {
+    #create install main dir and all sub dir
+    ${csudo} rm -rf ${install_main_dir}    || :
+    ${csudo} mkdir -p ${install_main_dir}
+    ${csudo} mkdir -p ${install_main_dir}/cfg
+    ${csudo} mkdir -p ${install_main_dir}/bin
+    ${csudo} mkdir -p ${install_main_dir}/connector
+    ${csudo} mkdir -p ${install_main_dir}/driver
+    ${csudo} mkdir -p ${install_main_dir}/examples
+    ${csudo} mkdir -p ${install_main_dir}/include
+    ${csudo} mkdir -p ${install_main_dir}/init.d
+    if [ "$verMode" == "cluster" ]; then
+        ${csudo} mkdir -p ${nginx_dir}
+    fi
+
+    if [[ -e ${script_dir}/email ]]; then
+      ${csudo} cp ${script_dir}/email ${install_main_dir}/ ||:
+    fi
+}
+
+function install_bin() {
+    # Remove links
+    ${csudo} rm -f ${bin_link_dir}/taos     || :
+    ${csudo} rm -f ${bin_link_dir}/taosd    || :
+    ${csudo} rm -f ${bin_link_dir}/taosadapter     || :
+    ${csudo} rm -f ${bin_link_dir}/create_table || :
+    ${csudo} rm -f ${bin_link_dir}/tmq_sim   || :
+    ${csudo} rm -f ${bin_link_dir}/taosdump || :
+    ${csudo} rm -f ${bin_link_dir}/rmtaos   || :
+    #${csudo} rm -f ${bin_link_dir}/set_core   || :
+
+    ${csudo} cp -r ${script_dir}/bin/* ${install_main_dir}/bin && ${csudo} chmod 0555 ${install_main_dir}/bin/*
+
+    #Make link
+    [ -x ${install_main_dir}/bin/taos ] && ${csudo} ln -s ${install_main_dir}/bin/taos ${bin_link_dir}/taos                          || :
+    [ -x ${install_main_dir}/bin/taosd ] && ${csudo} ln -s ${install_main_dir}/bin/taosd ${bin_link_dir}/taosd                       || :
+    [ -x ${install_main_dir}/bin/create_table ] && ${csudo} ln -s ${install_main_dir}/bin/create_table ${bin_link_dir}/create_table   || :
+    [ -x ${install_main_dir}/bin/tmq_sim ] && ${csudo} ln -s ${install_main_dir}/bin/tmq_sim ${bin_link_dir}/tmq_sim     || :
+#    [ -x ${install_main_dir}/bin/taosdemo ] && ${csudo} ln -s ${install_main_dir}/bin/taosdemo ${bin_link_dir}/taosdemo              || :
+#    [ -x ${install_main_dir}/bin/taosdump ] && ${csudo} ln -s ${install_main_dir}/bin/taosdump ${bin_link_dir}/taosdump              || :
+    [ -x ${install_main_dir}/bin/remove.sh ] && ${csudo} ln -s ${install_main_dir}/bin/remove.sh ${bin_link_dir}/rmtaos              || :
+#    [ -x ${install_main_dir}/bin/set_core.sh ] && ${csudo} ln -s ${install_main_dir}/bin/set_core.sh ${bin_link_dir}/set_core        || :
+}
+
+function install_lib() {
+    # Remove links
+    ${csudo} rm -f ${lib_link_dir}/libtaos.*         || :
+    ${csudo} rm -f ${lib64_link_dir}/libtaos.*       || :
+
+    ${csudo} ln -s ${install_main_dir}/lib/libtaos.* ${lib_link_dir}/libtaos.so.1
+    ${csudo} ln -s ${lib_link_dir}/libtaos.so.1 ${lib_link_dir}/libtaos.so
+
+    ${csudo} ln -s ${install_main_dir}/lib/libtdb.* ${lib_link_dir}/libtdb.so.1
+    ${csudo} ln -s ${lib_link_dir}/libtdb.so.1 ${lib_link_dir}/libtdb.so
+
+    if [[ -d ${lib64_link_dir} && ! -e ${lib64_link_dir}/libtaos.so ]]; then
+      ${csudo} ln -s ${install_main_dir}/lib/libtaos.* ${lib64_link_dir}/libtaos.so.1     || :
+      ${csudo} ln -s ${lib64_link_dir}/libtaos.so.1 ${lib64_link_dir}/libtaos.so          || :
+      
+      ${csudo} ln -s ${install_main_dir}/lib/libtdb.* ${lib64_link_dir}/libtdb.so.1       || :
+      ${csudo} ln -s ${lib64_link_dir}/libtdb.so.1 ${lib64_link_dir}/libtdb.so            || :
+    fi
+
+    ${csudo} ldconfig
+}
+
+function install_header() {
+    ${csudo} rm -f ${inc_link_dir}/taos.h ${inc_link_dir}/taosdef.h ${inc_link_dir}/taoserror.h    || :
+    ${csudo} cp -f ${script_dir}/inc/* ${install_main_dir}/include && ${csudo} chmod 644 ${install_main_dir}/include/*
+    ${csudo} ln -s ${install_main_dir}/include/taos.h ${inc_link_dir}/taos.h
+#    ${csudo} ln -s ${install_main_dir}/include/taosdef.h ${inc_link_dir}/taosdef.h
+    ${csudo} ln -s ${install_main_dir}/include/taoserror.h ${inc_link_dir}/taoserror.h
+}
+
+function add_newHostname_to_hosts() {
+  localIp="127.0.0.1"
+  OLD_IFS="$IFS"
+  IFS=" "
+  iphost=$(cat /etc/hosts | grep $1 | awk '{print $1}')
+  arr=($iphost)
+  IFS="$OLD_IFS"
+  for s in "${arr[@]}"
+  do
+    if [[ "$s" == "$localIp" ]]; then
+      return
+    fi
+  done
+  ${csudo} echo "127.0.0.1  $1" >> /etc/hosts   ||:
+}
+
+function set_hostname() {
+  echo -e -n "${GREEN}Please enter one hostname(must not be 'localhost')${NC}:"
+    read newHostname
+  while true; do
+    if [[ ! -z "$newHostname" && "$newHostname" != "localhost" ]]; then
+      break
+    else
+      read -p "Please enter one hostname(must not be 'localhost'):" newHostname
+    fi
+  done
+
+  ${csudo} hostname $newHostname ||:
+  retval=`echo $?`
+  if [[ $retval != 0 ]]; then
+   echo
+   echo "set hostname fail!"
+   return
+  fi
+  #echo -e -n "$(hostnamectl status --static)"
+  #echo -e -n "$(hostnamectl status --transient)"
+  #echo -e -n "$(hostnamectl status --pretty)"
+
+  #ubuntu/centos /etc/hostname
+  if [[ -e /etc/hostname ]]; then
+    ${csudo} echo $newHostname > /etc/hostname   ||:
+  fi
+
+  #debian: #HOSTNAME=yourname
+  if [[ -e /etc/sysconfig/network ]]; then
+    ${csudo} sed -i -r "s/#*\s*(HOSTNAME=\s*).*/\1$newHostname/" /etc/sysconfig/network   ||:
+  fi
+
+  ${csudo} sed -i -r "s/#*\s*(fqdn\s*).*/\1$newHostname/" ${cfg_install_dir}/taos.cfg
+  serverFqdn=$newHostname
+
+  if [[ -e /etc/hosts ]]; then
+    add_newHostname_to_hosts $newHostname
+  fi
+}
+
+function is_correct_ipaddr() {
+  newIp=$1
+  OLD_IFS="$IFS"
+  IFS=" "
+  arr=($iplist)
+  IFS="$OLD_IFS"
+  for s in "${arr[@]}"
+  do
+   if [[ "$s" == "$newIp" ]]; then
+     return 0
+   fi
+  done
+
+  return 1
+}
+
+function set_ipAsFqdn() {
+  iplist=$(ip address |grep inet |grep -v inet6 |grep -v 127.0.0.1 |awk '{print $2}' |awk -F "/" '{print $1}') ||:
+  if [ -z "$iplist" ]; then
+    iplist=$(ifconfig |grep inet |grep -v inet6 |grep -v 127.0.0.1 |awk '{print $2}' |awk -F ":" '{print $2}') ||:
+  fi
+
+  if [ -z "$iplist" ]; then
+    echo
+    echo -e -n "${GREEN}Unable to get local ip, use 127.0.0.1${NC}"
+    localFqdn="127.0.0.1"
+    # Write the local FQDN to configuration file
+    ${csudo} sed -i -r "s/#*\s*(fqdn\s*).*/\1$localFqdn/" ${cfg_install_dir}/taos.cfg
+    serverFqdn=$localFqdn
+    echo
+    return
+  fi
+
+  echo -e -n "${GREEN}Please choose an IP from local IP list${NC}:"
+  echo
+  echo -e -n "${GREEN}$iplist${NC}"
+  echo
+  echo
+  echo -e -n "${GREEN}Notes: if IP is used as the node name, data can NOT be migrated to other machine directly${NC}:"
+  read localFqdn
+    while true; do
+      if [ ! -z "$localFqdn" ]; then
+        # Check if correct ip address
+        is_correct_ipaddr $localFqdn
+        retval=`echo $?`
+        if [[ $retval != 0 ]]; then
+          read -p "Please choose an IP from local IP list:" localFqdn
+        else
+          # Write the local FQDN to configuration file
+          ${csudo} sed -i -r "s/#*\s*(fqdn\s*).*/\1$localFqdn/" ${cfg_install_dir}/taos.cfg
+          serverFqdn=$localFqdn
+          break
+        fi
+      else
+        read -p "Please choose an IP from local IP list:" localFqdn
+      fi
+    done
+}
+
+function local_fqdn_check() {
+  #serverFqdn=$(hostname)
+  echo
+  echo -e -n "System hostname is: ${GREEN}$serverFqdn${NC}"
+  echo
+  if [[ "$serverFqdn" == "" ]] || [[ "$serverFqdn" == "localhost"  ]]; then
+    echo -e -n "${GREEN}It is strongly recommended to configure a hostname for this machine ${NC}"
+    echo
+
+    while true
+    do
+        read -r -p "Set hostname now? [Y/n] " input
+        if [ ! -n "$input" ]; then
+            set_hostname
+            break
+        else
+            case $input in
+                [yY][eE][sS]|[yY])
+                    set_hostname
+                    break
+                    ;;
+
+                [nN][oO]|[nN])
+                    set_ipAsFqdn
+                    break
+                    ;;
+
+                *)
+                    echo "Invalid input..."
+                    ;;
+            esac
+        fi
+    done
+  fi
+}
+
+function install_log() {
+    ${csudo} rm -rf ${log_dir}  || :
+    ${csudo} mkdir -p ${log_dir} && ${csudo} chmod 777 ${log_dir}
+
+    ${csudo} ln -s ${log_dir} ${install_main_dir}/log
+}
+
+function install_data() {
+    ${csudo} mkdir -p ${data_dir}
+
+    ${csudo} ln -s ${data_dir} ${install_main_dir}/data
+}
+
+function clean_service_on_systemd() {
+    taosd_service_config="${service_config_dir}/taosd.service"
+    if systemctl is-active --quiet taosd; then
+        echo "TDengine is running, stopping it..."
+        ${csudo} systemctl stop taosd &> /dev/null || echo &> /dev/null
+    fi
+    ${csudo} systemctl disable taosd &> /dev/null || echo &> /dev/null
+    ${csudo} rm -f ${taosd_service_config}
+
+    tarbitratord_service_config="${service_config_dir}/tarbitratord.service"
+    if systemctl is-active --quiet tarbitratord; then
+        echo "tarbitrator is running, stopping it..."
+        ${csudo} systemctl stop tarbitratord &> /dev/null || echo &> /dev/null
+    fi
+    ${csudo} systemctl disable tarbitratord &> /dev/null || echo &> /dev/null
+    ${csudo} rm -f ${tarbitratord_service_config}
+
+    if [ "$verMode" == "cluster" ]; then
+        nginx_service_config="${service_config_dir}/nginxd.service"
+        if systemctl is-active --quiet nginxd; then
+            echo "Nginx for TDengine is running, stopping it..."
+            ${csudo} systemctl stop nginxd &> /dev/null || echo &> /dev/null
+        fi
+        ${csudo} systemctl disable nginxd &> /dev/null || echo &> /dev/null
+        ${csudo} rm -f ${nginx_service_config}
+    fi
+}
+
+# taos:2345:respawn:/etc/init.d/taosd start
+
+function install_service_on_systemd() {
+    clean_service_on_systemd
+        
+    taosd_service_config="${service_config_dir}/taosd.service"
+    ${csudo} bash -c "echo '[Unit]'                             >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'Description=TDengine server service' >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'After=network-online.target taosadapter.service'        >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'Wants=network-online.target taosadapter.service'        >> ${taosd_service_config}"
+    ${csudo} bash -c "echo                                      >> ${taosd_service_config}"
+    ${csudo} bash -c "echo '[Service]'                          >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'Type=simple'                        >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'ExecStart=/usr/bin/taosd'           >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'ExecStartPre=/usr/local/taos/bin/startPre.sh'         >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'TimeoutStopSec=1000000s'            >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'LimitNOFILE=infinity'               >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'LimitNPROC=infinity'                >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'LimitCORE=infinity'                 >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'TimeoutStartSec=0'                  >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'StandardOutput=null'                >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'Restart=always'                     >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'StartLimitBurst=3'                  >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'StartLimitInterval=60s'             >> ${taosd_service_config}"
+    #${csudo} bash -c "echo 'StartLimitIntervalSec=60s'          >> ${taosd_service_config}"
+    ${csudo} bash -c "echo                                      >> ${taosd_service_config}"
+    ${csudo} bash -c "echo '[Install]'                          >> ${taosd_service_config}"
+    ${csudo} bash -c "echo 'WantedBy=multi-user.target'         >> ${taosd_service_config}"
+    ${csudo} systemctl enable taosd
+
+    ${csudo} systemctl daemon-reload 
+}
+
+function install_service() {
+    if ((${service_mod}==0)); then
+        install_service_on_systemd
+    elif ((${service_mod}==1)); then
+        install_service_on_sysvinit
+    else
+        # must manual stop taosd
+        kill_process taosd
+    fi
+}
+
+function install_TDengine() {
+    # Start to install
+    echo -e "${GREEN}Start to install TDengine...${NC}"
+
+    install_main_path
+    install_data
+    install_log
+    install_header
+    install_lib
+
+    if [ -z $1 ]; then # install service and client
+        # For installing new
+        install_bin
+        install_service
+        #install_config
+
+        # Ask if to start the service
+        #echo
+        #echo -e "\033[44;32;1mTDengine is installed successfully!${NC}"
+        echo
+        echo -e "${GREEN_DARK}To configure TDengine ${NC}: edit /etc/taos/taos.cfg"
+        if ((${service_mod}==0)); then
+          echo -e "${GREEN_DARK}To start TDengine     ${NC}: ${csudo} systemctl start taosd${NC}"
+        elif ((${service_mod}==1)); then
+          echo -e "${GREEN_DARK}To start TDengine     ${NC}: ${csudo} service taosd start${NC}"
+        else
+          echo -e "${GREEN_DARK}To start TDengine     ${NC}: taosd${NC}"
+        fi
+
+        if [ ! -z "$firstEp" ]; then
+            tmpFqdn=${firstEp%%:*}
+            substr=":"
+            if [[ $firstEp =~ $substr ]];then
+                tmpPort=${firstEp#*:}
+            else
+                tmpPort=""
+            fi
+            if [[ "$tmpPort" != "" ]];then
+                echo -e "${GREEN_DARK}To access TDengine    ${NC}: taos -h $tmpFqdn -P $tmpPort${GREEN_DARK} to login into cluster, then${NC}"
+            else
+                echo -e "${GREEN_DARK}To access TDengine    ${NC}: taos -h $tmpFqdn${GREEN_DARK} to login into cluster, then${NC}"
+            fi
+            echo -e "${GREEN_DARK}execute ${NC}: create dnode 'newDnodeFQDN:port'; ${GREEN_DARK}to add this new node${NC}"
+            echo
+        elif [ ! -z "$serverFqdn" ]; then
+            echo -e "${GREEN_DARK}To access TDengine    ${NC}: taos -h $serverFqdn${GREEN_DARK} to login into TDengine server${NC}"
+            echo
+        fi
+
+        echo -e "\033[44;32;1mTDengine is installed successfully!${NC}"
+        echo
+    else # Only install client
+        install_bin
+        #install_config
+        echo
+        echo -e "\033[44;32;1mTDengine client is installed successfully!${NC}"
+    fi
+
+    touch ~/.taos_history
+}
+
+
+## ==============================Main program starts from here============================
+serverFqdn=$(hostname)
+if [ "$verType" == "server" ]; then
+    # Install server and client
+    install_TDengine
+elif [ "$verType" == "client" ]; then
+    interactiveFqdn=no
+    # Only install client
+    install_TDengine client
+else
+    echo  "please input correct verType"
+fi

packaging/release.sh

 #!/bin/bash
 #
-# Generate the deb package for ubuntu, or rpm package for centos, or tar.gz package for other linux os
+# Generate the tar.gz package for linux os
 
 set -e
 #set -x
@@ -17,9 +17,12 @@ echo "=======================new version number: ${verNumber}===================
 
 build_time=$(date +"%F %R")
 
+echo "script_dir: ${script_dir}"
 echo "top_dir: ${top_dir}"
 
 cd ${top_dir}
+git checkout -- .
+git checkout 3.0
 git pull || :
 
 echo "curr_dir: ${curr_dir}"
@@ -49,28 +52,38 @@ cd ${release_dir}
 
 install_dir="${release_dir}/TDengine-server-${version}"
 mkdir -p ${install_dir}
+mkdir -p ${install_dir}/bin
 mkdir -p ${install_dir}/lib
-
-bin_files="${compile_dir}/source/dnode/mgmt/daemon/taosd ${compile_dir}/tools/shell/taos  ${compile_dir}/tests/test/c/create_table"
-cp ${bin_files} ${install_dir}/ && chmod a+x ${install_dir}/* || :
-
-
-cp ${compile_dir}/source/client/libtaos.so ${install_dir}/lib/
-cp ${compile_dir}/source/dnode/mnode/impl/libmnode.so ${install_dir}/lib/
-cp ${compile_dir}/source/dnode/qnode/libqnode.so ${install_dir}/lib/
-cp ${compile_dir}/source/dnode/snode/libsnode.so ${install_dir}/lib/
-cp ${compile_dir}/source/dnode/bnode/libbnode.so ${install_dir}/lib/
-cp ${compile_dir}/source/libs/wal/libwal.so ${install_dir}/lib/
-cp ${compile_dir}/source/libs/scheduler/libscheduler.so ${install_dir}/lib/
-cp ${compile_dir}/source/libs/planner/libplanner.so ${install_dir}/lib/
-cp ${compile_dir}/source/libs/parser/libparser.so ${install_dir}/lib/
-cp ${compile_dir}/source/libs/qcom/libqcom.so ${install_dir}/lib/
-cp ${compile_dir}/source/libs/transport/libtransport.so ${install_dir}/lib/
-cp ${compile_dir}/source/libs/function/libfunction.so ${install_dir}/lib/
-cp ${compile_dir}/source/common/libcommon.so ${install_dir}/lib/
-cp ${compile_dir}/source/os/libos.so ${install_dir}/lib/
-cp ${compile_dir}/source/dnode/mnode/sdb/libsdb.so ${install_dir}/lib/
-cp ${compile_dir}/source/libs/catalog/libcatalog.so ${install_dir}/lib/
+mkdir -p ${install_dir}/inc
+
+install_files="${script_dir}/install.sh"
+chmod a+x ${script_dir}/install.sh || :
+cp ${install_files} ${install_dir} 
+
+header_files="${top_dir}/include/client/taos.h ${top_dir}/include/util/taoserror.h"
+cp ${header_files} ${install_dir}/inc
+ 
+bin_files="${compile_dir}/source/dnode/mgmt/taosd ${compile_dir}/tools/shell/taos  ${compile_dir}/tests/test/c/create_table ${compile_dir}/tests/test/c/tmq_sim ${script_dir}/remove.sh"
+cp ${bin_files} ${install_dir}/bin && chmod a+x ${install_dir}/bin/* || :
+
+cp ${compile_dir}/source/client/libtaos.so  ${install_dir}/lib/
+cp ${compile_dir}/source/libs/tdb/libtdb.so ${install_dir}/lib/
+
+#cp ${compile_dir}/source/dnode/mnode/impl/libmnode.so ${install_dir}/lib/
+#cp ${compile_dir}/source/dnode/qnode/libqnode.so ${install_dir}/lib/
+#cp ${compile_dir}/source/dnode/snode/libsnode.so ${install_dir}/lib/
+#cp ${compile_dir}/source/dnode/bnode/libbnode.so ${install_dir}/lib/
+#cp ${compile_dir}/source/libs/wal/libwal.so ${install_dir}/lib/
+#cp ${compile_dir}/source/libs/scheduler/libscheduler.so ${install_dir}/lib/
+#cp ${compile_dir}/source/libs/planner/libplanner.so ${install_dir}/lib/
+#cp ${compile_dir}/source/libs/parser/libparser.so ${install_dir}/lib/
+#cp ${compile_dir}/source/libs/qcom/libqcom.so ${install_dir}/lib/
+#cp ${compile_dir}/source/libs/transport/libtransport.so ${install_dir}/lib/
+#cp ${compile_dir}/source/libs/function/libfunction.so ${install_dir}/lib/
+#cp ${compile_dir}/source/common/libcommon.so ${install_dir}/lib/
+#cp ${compile_dir}/source/os/libos.so ${install_dir}/lib/
+#cp ${compile_dir}/source/dnode/mnode/sdb/libsdb.so ${install_dir}/lib/
+#cp ${compile_dir}/source/libs/catalog/libcatalog.so ${install_dir}/lib/
 
 pkg_name=${install_dir}-Linux-x64
 

packaging/remove.sh

+#!/bin/bash
+#
+# Script to stop the service and uninstall TDengine, but retain the config, data and log files.
+
+set -e
+#set -x
+
+verMode=edge
+
+RED='\033[0;31m'
+GREEN='\033[1;32m'
+NC='\033[0m'
+
+#install main path
+install_main_dir="/usr/local/taos"
+data_link_dir="/usr/local/taos/data"
+log_link_dir="/usr/local/taos/log"
+cfg_link_dir="/usr/local/taos/cfg"
+bin_link_dir="/usr/bin"
+lib_link_dir="/usr/lib"
+lib64_link_dir="/usr/lib64"
+inc_link_dir="/usr/include"
+
+service_config_dir="/etc/systemd/system"
+taos_service_name="taosd"
+
+csudo=""
+if command -v sudo > /dev/null; then
+    csudo="sudo"
+fi
+
+initd_mod=0
+service_mod=2
+if pidof systemd &> /dev/null; then
+    service_mod=0
+elif $(which service &> /dev/null); then
+    service_mod=1
+    service_config_dir="/etc/init.d"
+    if $(which chkconfig &> /dev/null); then
+         initd_mod=1
+    elif $(which insserv &> /dev/null); then
+        initd_mod=2
+    elif $(which update-rc.d &> /dev/null); then
+        initd_mod=3
+    else
+        service_mod=2
+    fi
+else
+    service_mod=2
+fi
+
+
+function kill_taosd() {
+  pid=$(ps -ef | grep "taosd" | grep -v "grep" | awk '{print $2}')
+  if [ -n "$pid" ]; then
+    ${csudo} kill -9 $pid   || :
+  fi
+}
+
+
+function clean_bin() {
+    # Remove link
+    ${csudo} rm -f ${bin_link_dir}/taos        || :
+    ${csudo} rm -f ${bin_link_dir}/taosd       || :
+    ${csudo} rm -f ${bin_link_dir}/create_table  || :
+    ${csudo} rm -f ${bin_link_dir}/tmq_sim || :
+    ${csudo} rm -f ${bin_link_dir}/taosdemo    || :
+    ${csudo} rm -f ${bin_link_dir}/taosdump    || :
+    ${csudo} rm -f ${bin_link_dir}/rmtaos      || :
+    #${csudo} rm -f ${bin_link_dir}/set_core    || :
+}
+
+function clean_lib() {
+    # Remove link
+    ${csudo} rm -f ${lib_link_dir}/libtaos.*      || :
+    ${csudo} rm -f ${lib64_link_dir}/libtaos.*    || :    
+    
+    ${csudo} rm -f ${lib_link_dir}/libtdb.*      || :
+    ${csudo} rm -f ${lib64_link_dir}/libtdb.*    || :
+}
+
+function clean_header() {
+    # Remove link
+    ${csudo} rm -f ${inc_link_dir}/taos.h       || :
+    ${csudo} rm -f ${inc_link_dir}/taosdef.h    || :
+    ${csudo} rm -f ${inc_link_dir}/taoserror.h  || :
+}
+
+function clean_config() {
+    # Remove link
+    ${csudo} rm -f ${cfg_link_dir}/*            || :
+}
+
+function clean_log() {
+    # Remove link
+    ${csudo} rm -rf ${log_link_dir}    || :
+}
+
+function clean_service_on_systemd() {
+    taosd_service_config="${service_config_dir}/${taos_service_name}.service"
+    if systemctl is-active --quiet ${taos_service_name}; then
+        echo "TDengine taosd is running, stopping it..."
+        ${csudo} systemctl stop ${taos_service_name} &> /dev/null || echo &> /dev/null
+    fi
+    ${csudo} systemctl disable ${taos_service_name} &> /dev/null || echo &> /dev/null
+    ${csudo} rm -f ${taosd_service_config}
+}
+
+function clean_service_on_sysvinit() {
+    echo " "
+}
+
+function clean_service() {
+    if ((${service_mod}==0)); then
+        clean_service_on_systemd
+    elif ((${service_mod}==1)); then
+        clean_service_on_sysvinit
+    else
+        # must manual stop taosd
+        kill_taosd
+    fi
+}
+
+# Stop service and disable booting start.
+clean_service
+# Remove binary file and links
+clean_bin
+# Remove header file.
+clean_header
+# Remove lib file
+clean_lib
+# Remove link log directory
+clean_log
+# Remove link configuration file
+clean_config
+# Remove data link directory
+${csudo} rm -rf ${data_link_dir}    || :
+
+${csudo} rm -rf ${install_main_dir}
+
+if [[ -e /etc/os-release ]]; then
+  osinfo=$(awk -F= '/^NAME/{print $2}' /etc/os-release)
+else
+  osinfo=""
+fi
+
+echo -e "${GREEN}TDengine is removed successfully!${NC}"
+echo

source/dnode/mgmt/mm/mmHandle.c

@@ -150,6 +150,7 @@ void mmInitMsgHandle(SMgmtWrapper *pWrapper) {
   // Requests handled by VNODE
   dndSetMsgHandle(pWrapper, TDMT_VND_MQ_SET_CONN_RSP, mmProcessWriteMsg, DEFAULT_HANDLE);
   dndSetMsgHandle(pWrapper, TDMT_VND_MQ_REB_RSP, mmProcessWriteMsg, DEFAULT_HANDLE);
+  dndSetMsgHandle(pWrapper, TDMT_VND_MQ_CANCEL_CONN_RSP, mmProcessWriteMsg, DEFAULT_HANDLE);
   dndSetMsgHandle(pWrapper, TDMT_VND_CREATE_STB_RSP, mmProcessWriteMsg, DEFAULT_HANDLE);
   dndSetMsgHandle(pWrapper, TDMT_VND_ALTER_STB_RSP, mmProcessWriteMsg, DEFAULT_HANDLE);
   dndSetMsgHandle(pWrapper, TDMT_VND_DROP_STB_RSP, mmProcessWriteMsg, DEFAULT_HANDLE);

source/dnode/mgmt/vm/vmHandle.c

@@ -271,6 +271,7 @@ void vmInitMsgHandle(SMgmtWrapper *pWrapper) {
   dndSetMsgHandle(pWrapper, TDMT_VND_SHOW_TABLES_FETCH, (NodeMsgFp)vmProcessFetchMsg, DEFAULT_HANDLE);
   dndSetMsgHandle(pWrapper, TDMT_VND_MQ_SET_CONN, (NodeMsgFp)vmProcessWriteMsg, DEFAULT_HANDLE);
   dndSetMsgHandle(pWrapper, TDMT_VND_MQ_REB, (NodeMsgFp)vmProcessWriteMsg, DEFAULT_HANDLE);
+  dndSetMsgHandle(pWrapper, TDMT_VND_MQ_CANCEL_CONN, (NodeMsgFp)vmProcessWriteMsg, DEFAULT_HANDLE);
   dndSetMsgHandle(pWrapper, TDMT_VND_MQ_SET_CUR, (NodeMsgFp)vmProcessFetchMsg, DEFAULT_HANDLE);
   dndSetMsgHandle(pWrapper, TDMT_VND_CONSUME, (NodeMsgFp)vmProcessFetchMsg, DEFAULT_HANDLE);
   dndSetMsgHandle(pWrapper, TDMT_VND_TASK_DEPLOY, (NodeMsgFp)vmProcessWriteMsg, DEFAULT_HANDLE);

source/dnode/mnode/impl/src/mndSubscribe.c

@@ -61,6 +61,7 @@ static int32_t mndPersistMqSetConnReq(SMnode *pMnode, STrans *pTrans, const SMqT
                                       const SMqConsumerEp *pConsumerEp);
 
 static int32_t mndPersistRebalanceMsg(SMnode *pMnode, STrans *pTrans, const SMqConsumerEp *pConsumerEp);
+static int32_t mndPersistCancelConnReq(SMnode *pMnode, STrans *pTrans, const SMqConsumerEp *pConsumerEp, const char* oldTopicName);
 
 int32_t mndInitSubscribe(SMnode *pMnode) {
   SSdbTable table = {.sdbType = SDB_SUBSCRIBE,
@@ -74,6 +75,7 @@ int32_t mndInitSubscribe(SMnode *pMnode) {
   mndSetMsgHandle(pMnode, TDMT_MND_SUBSCRIBE, mndProcessSubscribeReq);
   mndSetMsgHandle(pMnode, TDMT_VND_MQ_SET_CONN_RSP, mndProcessSubscribeInternalRsp);
   mndSetMsgHandle(pMnode, TDMT_VND_MQ_REB_RSP, mndProcessSubscribeInternalRsp);
+  mndSetMsgHandle(pMnode, TDMT_VND_MQ_CANCEL_CONN_RSP, mndProcessSubscribeInternalRsp);
   mndSetMsgHandle(pMnode, TDMT_MND_MQ_TIMER, mndProcessMqTimerMsg);
   mndSetMsgHandle(pMnode, TDMT_MND_GET_SUB_EP, mndProcessGetSubEpReq);
   mndSetMsgHandle(pMnode, TDMT_MND_MQ_DO_REBALANCE, mndProcessDoRebalanceMsg);
@@ -154,11 +156,14 @@ static int32_t mndPersistRebalanceMsg(SMnode *pMnode, STrans *pTrans, const SMqC
   return 0;
 }
 
-static int32_t mndBuildCancelConnReq(void **pBuf, int32_t *pLen, const SMqConsumerEp *pConsumerEp) {
-  SMqSetCVgReq req = {0};
+static int32_t mndBuildCancelConnReq(void **pBuf, int32_t *pLen, const SMqConsumerEp *pConsumerEp, const char* oldTopicName) {
+  SMqCancelConnReq req = {0};
   req.consumerId = pConsumerEp->consumerId;
+  req.vgId = pConsumerEp->vgId;
+  req.epoch = pConsumerEp->epoch;
+  strcpy(req.topicName, oldTopicName);
 
-  int32_t tlen = tEncodeSMqSetCVgReq(NULL, &req);
+  int32_t tlen = tEncodeSMqCancelConnReq(NULL, &req);
   void   *buf = taosMemoryMalloc(sizeof(SMsgHead) + tlen);
   if (buf == NULL) {
     terrno = TSDB_CODE_OUT_OF_MEMORY;
@@ -169,16 +174,16 @@ static int32_t mndBuildCancelConnReq(void **pBuf, int32_t *pLen, const SMqConsum
   pMsgHead->contLen = htonl(sizeof(SMsgHead) + tlen);
   pMsgHead->vgId = htonl(pConsumerEp->vgId);
   void *abuf = POINTER_SHIFT(buf, sizeof(SMsgHead));
-  tEncodeSMqSetCVgReq(&abuf, &req);
+  tEncodeSMqCancelConnReq(&abuf, &req);
   *pBuf = buf;
   *pLen = tlen;
   return 0;
 }
 
-static int32_t mndPersistCancelConnReq(SMnode *pMnode, STrans *pTrans, const SMqConsumerEp *pConsumerEp) {
+static int32_t mndPersistCancelConnReq(SMnode *pMnode, STrans *pTrans, const SMqConsumerEp *pConsumerEp, const char* oldTopicName) {
   void   *buf;
   int32_t tlen;
-  if (mndBuildCancelConnReq(&buf, &tlen, pConsumerEp) < 0) {
+  if (mndBuildCancelConnReq(&buf, &tlen, pConsumerEp, oldTopicName) < 0) {
     return -1;
   }
 
@@ -189,7 +194,7 @@ static int32_t mndPersistCancelConnReq(SMnode *pMnode, STrans *pTrans, const SMq
   action.epSet = mndGetVgroupEpset(pMnode, pVgObj);
   action.pCont = buf;
   action.contLen = sizeof(SMsgHead) + tlen;
-  action.msgType = TDMT_VND_MQ_SET_CONN;
+  action.msgType = TDMT_VND_MQ_CANCEL_CONN;
 
   mndReleaseVgroup(pMnode, pVgObj);
   if (mndTransAppendRedoAction(pTrans, &action) != 0) {
@@ -365,7 +370,7 @@ static int32_t mndProcessMqTimerMsg(SNodeMsg *pMsg) {
       if (status == MQ_CONSUMER_STATUS__MODIFY) {
         int32_t removeSz = taosArrayGetSize(pConsumer->recentRemovedTopics);
         for (int32_t i = 0; i < removeSz; i++) {
-          char *topicName = taosArrayGet(pConsumer->recentRemovedTopics, i);
+          char *topicName = taosArrayGetP(pConsumer->recentRemovedTopics, i);
           taosMemoryFree(topicName);
         }
         taosArrayClear(pConsumer->recentRemovedTopics);
@@ -797,7 +802,7 @@ static int32_t mndProcessSubscribeReq(SNodeMsg *pMsg) {
           int32_t vgsz = taosArrayGetSize(pSubConsumer->vgInfo);
           for (int32_t vgi = 0; vgi < vgsz; vgi++) {
             SMqConsumerEp *pConsumerEp = taosArrayGet(pSubConsumer->vgInfo, vgi);
-            mndPersistCancelConnReq(pMnode, pTrans, pConsumerEp);
+            mndPersistCancelConnReq(pMnode, pTrans, pConsumerEp, oldTopicName);
             taosArrayPush(pSub->unassignedVg, pConsumerEp);
           }
           taosArrayRemove(pSub->consumers, ci);
@@ -859,7 +864,7 @@ static int32_t mndProcessSubscribeReq(SNodeMsg *pMsg) {
     }
   }
 
-  if (oldSub) taosArrayDestroyEx(oldSub, (void (*)(void *))taosMemoryFree);
+  /*if (oldSub) taosArrayDestroyEx(oldSub, (void (*)(void *))taosMemoryFree);*/
 
   // persist consumerObj
   SSdbRaw *pConsumerRaw = mndConsumerActionEncode(pConsumer);

source/dnode/vnode/inc/tsdb.h

@@ -88,14 +88,18 @@ int    tsdbInsertData(STsdb *pTsdb, SSubmitReq *pMsg, SSubmitRsp *pRsp);
 int    tsdbPrepareCommit(STsdb *pTsdb);
 int    tsdbCommit(STsdb *pTsdb);
 
+
+int32_t tsdbInitSma(STsdb *pTsdb);
+int32_t tsdbCreateTSma(STsdb *pTsdb, char *pMsg);
+int32_t tsdbDropTSma(STsdb *pTsdb, char *pMsg);
 /**
  * @brief When submit msg received, update the relative expired window synchronously.
- * 
- * @param pTsdb 
- * @param msg 
- * @return int32_t 
+ *
+ * @param pTsdb
+ * @param msg
+ * @return int32_t
  */
-int32_t tsdbUpdateSmaWindow(STsdb *pTsdb, const char *msg);
+int32_t tsdbUpdateSmaWindow(STsdb *pTsdb, SSubmitReq *pMsg);
 
 /**
  * @brief Insert tSma(Time-range-wise SMA) data from stream computing engine

source/dnode/vnode/src/inc/tsdbDef.h

@@ -46,7 +46,7 @@ extern "C" {
 struct STsdb {
   int32_t               vgId;
   bool                  repoLocked;
-  TdThreadMutex       mutex;
+  TdThreadMutex         mutex;
   char *                path;
   STsdbCfg              config;
   STsdbMemTable *       mem;
@@ -56,17 +56,19 @@ struct STsdb {
   STsdbFS *             fs;
   SMeta *               pMeta;
   STfs *                pTfs;
-  SSmaEnv *             pTSmaEnv;
-  SSmaEnv *             pRSmaEnv;
+  SSmaEnvs              smaEnvs;
 };
 
-#define REPO_ID(r)         ((r)->vgId)
-#define REPO_CFG(r)        (&(r)->config)
-#define REPO_FS(r)         (r)->fs
-#define REPO_META(r)       (r)->pMeta
-#define REPO_TFS(r)        (r)->pTfs
-#define IS_REPO_LOCKED(r)  (r)->repoLocked
-#define REPO_SMA_ENV(r, t) ((TSDB_SMA_TYPE_ROLLUP == (t)) ? (r)->pRSmaEnv : (r)->pTSmaEnv)
+#define REPO_ID(r)        ((r)->vgId)
+#define REPO_CFG(r)       (&(r)->config)
+#define REPO_FS(r)        ((r)->fs)
+#define REPO_META(r)      ((r)->pMeta)
+#define REPO_TFS(r)       ((r)->pTfs)
+#define IS_REPO_LOCKED(r) ((r)->repoLocked)
+#define REPO_TSMA_NUM(r)  ((r)->smaEnvs.nTSma)
+#define REPO_RSMA_NUM(r)  ((r)->smaEnvs.nRSma)
+#define REPO_TSMA_ENV(r)  ((r)->smaEnvs.pTSmaEnv)
+#define REPO_RSMA_ENV(r)  ((r)->smaEnvs.pRSmaEnv)
 
 int tsdbLockRepo(STsdb *pTsdb);
 int tsdbUnlockRepo(STsdb *pTsdb);

source/dnode/vnode/src/inc/tsdbSma.h

@@ -18,8 +18,9 @@
 
 #define TSDB_SMA_TEST // remove after test finished
 
-typedef struct SSmaStat     SSmaStat;
-typedef struct SSmaEnv      SSmaEnv;
+typedef struct SSmaStat SSmaStat;
+typedef struct SSmaEnv  SSmaEnv;
+typedef struct SSmaEnvs SSmaEnvs;
 
 struct SSmaEnv {
   TdThreadRwlock lock;
@@ -36,6 +37,13 @@ struct SSmaEnv {
 #define SMA_ENV_STAT(env)       ((env)->pStat)
 #define SMA_ENV_STAT_ITEMS(env) ((env)->pStat->smaStatItems)
 
+struct SSmaEnvs {
+  int16_t  nTSma;
+  int16_t  nRSma;
+  SSmaEnv *pTSmaEnv;
+  SSmaEnv *pRSmaEnv;
+};
+
 void  tsdbDestroySmaEnv(SSmaEnv *pSmaEnv);
 void *tsdbFreeSmaEnv(SSmaEnv *pSmaEnv);
 #if 0

source/dnode/vnode/src/inc/vnd.h

@@ -197,6 +197,7 @@ int tqCommit(STQ*);
 int32_t tqProcessPollReq(STQ* pTq, SRpcMsg* pMsg, int32_t workerId);
 int32_t tqProcessSetConnReq(STQ* pTq, char* msg);
 int32_t tqProcessRebReq(STQ* pTq, char* msg);
+int32_t tqProcessCancelConnReq(STQ* pTq, char* msg);
 int32_t tqProcessTaskExec(STQ* pTq, char* msg, int32_t msgLen, int32_t workerId);
 int32_t tqProcessTaskDeploy(STQ* pTq, char* msg, int32_t msgLen);
 int32_t tqProcessStreamTrigger(STQ* pTq, void* data, int32_t dataLen, int32_t workerId);

source/dnode/vnode/src/meta/metaBDBImpl.c

@@ -912,7 +912,7 @@ SMSmaCursor *metaOpenSmaCursor(SMeta *pMeta, tb_uid_t uid) {
   pCur->uid = uid;
   // TODO: lock?
   ret = pDB->pCtbIdx->cursor(pDB->pSmaIdx, NULL, &(pCur->pCur), 0);
-  if (ret != 0) {
+  if ((ret != 0) || (pCur->pCur == NULL)) {
     taosMemoryFree(pCur);
     return NULL;
   }
@@ -996,32 +996,31 @@ STSmaWrapper *metaGetSmaInfoByTable(SMeta *pMeta, tb_uid_t uid) {
 }
 
 SArray *metaGetSmaTbUids(SMeta *pMeta, bool isDup) {
-  SArray * pUids = NULL;
+  SArray  *pUids = NULL;
   SMetaDB *pDB = pMeta->pDB;
-  DBC *    pCur = NULL;
+  DBC     *pCur = NULL;
   DBT      pkey = {0}, pval = {0};
   uint32_t mode = isDup ? DB_NEXT_DUP : DB_NEXT_NODUP;
   int      ret;
 
-  pUids = taosArrayInit(16, sizeof(tb_uid_t));
-
-  if (!pUids) {
-    return NULL;
-  }
-
   // TODO: lock?
   ret = pDB->pCtbIdx->cursor(pDB->pSmaIdx, NULL, &pCur, 0);
   if (ret != 0) {
-    taosArrayDestroy(pUids);
     return NULL;
   }
-
-  void *pBuf = NULL;
-
   // TODO: lock?
+
   while ((ret = pCur->get(pCur, &pkey, &pval, mode)) == 0) {
-      taosArrayPush(pUids, pkey.data);
+    if (!pUids) {
+      pUids = taosArrayInit(16, sizeof(tb_uid_t));
+      if (!pUids) {
+        return NULL;
+      }
+    }
+
+    taosArrayPush(pUids, pkey.data);
   }
+  // TODO: lock?
 
   if (pCur) {
     pCur->close(pCur);

source/dnode/vnode/src/meta/metaTDBImpl.c

@@ -603,7 +603,7 @@ void metaCloseSmaCurosr(SMSmaCursor *pCur) {
 
 SArray *metaGetSmaTbUids(SMeta *pMeta, bool isDup) {
   // TODO
-  ASSERT(0);
+  // ASSERT(0); // comment this line to pass CI
   return NULL;
 }
 

source/dnode/vnode/src/tq/tq.c

@@ -81,6 +81,13 @@ int tqPushMsg(STQ* pTq, void* msg, int32_t msgLen, tmsg_t msgType, int64_t versi
     return -1;
   }
   memcpy(data, msg, msgLen);
+
+  if (msgType == TDMT_VND_SUBMIT) {
+    if (tsdbUpdateSmaWindow(pTq->pVnode->pTsdb, msg) != 0) {
+      return -1;
+    }
+  }
+
   SRpcMsg req = {
       .msgType = TDMT_VND_STREAM_TRIGGER,
       .pCont = data,
@@ -534,6 +541,11 @@ int32_t tqProcessSetConnReq(STQ* pTq, char* msg) {
   return 0;
 }
 
+int32_t tqProcessCancelConnReq(STQ* pTq, char* msg) {
+  terrno = TSDB_CODE_SUCCESS;
+  return 0;
+}
+
 int32_t tqExpandTask(STQ* pTq, SStreamTask* pTask, int32_t parallel) {
   if (pTask->execType == TASK_EXEC__NONE) return 0;
 

source/dnode/vnode/src/tsdb/tsdbMain.c

@@ -80,9 +80,6 @@ static STsdb *tsdbNew(const char *path, int32_t vgId, const STsdbCfg *pTsdbCfg,
   pTsdb->pmaf = pMAF;
   pTsdb->pMeta = pMeta;
   pTsdb->pTfs = pTfs;
-  pTsdb->pTSmaEnv = NULL;
-  pTsdb->pRSmaEnv = NULL;
-
   pTsdb->fs = tsdbNewFS(pTsdbCfg);
 
   return pTsdb;
@@ -90,8 +87,8 @@ static STsdb *tsdbNew(const char *path, int32_t vgId, const STsdbCfg *pTsdbCfg,
 
 static void tsdbFree(STsdb *pTsdb) {
   if (pTsdb) {
-    tsdbFreeSmaEnv(pTsdb->pRSmaEnv);
-    tsdbFreeSmaEnv(pTsdb->pTSmaEnv);
+    tsdbFreeSmaEnv(REPO_TSMA_ENV(pTsdb));
+    tsdbFreeSmaEnv(REPO_RSMA_ENV(pTsdb));
     tsdbFreeFS(pTsdb->fs);
     taosMemoryFreeClear(pTsdb->path);
     taosMemoryFree(pTsdb);
@@ -100,7 +97,10 @@ static void tsdbFree(STsdb *pTsdb) {
 
 static int tsdbOpenImpl(STsdb *pTsdb) {
   tsdbOpenFS(pTsdb);
+
+  tsdbInitSma(pTsdb);
   // TODO
+
   return 0;
 }
 

source/dnode/vnode/src/vnd/vnodeWrite.c

@@ -191,6 +191,10 @@ int vnodeApplyWMsg(SVnode *pVnode, SRpcMsg *pMsg, SRpcMsg **pRsp) {
       if (tqProcessRebReq(pVnode->pTq, POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead))) < 0) {
       }
     } break;
+    case TDMT_VND_MQ_CANCEL_CONN: {
+      if (tqProcessCancelConnReq(pVnode->pTq, POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead))) < 0) {
+      }
+    } break;
     case TDMT_VND_TASK_DEPLOY: {
       if (tqProcessTaskDeploy(pVnode->pTq, POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead)),
                               pMsg->contLen - sizeof(SMsgHead)) < 0) {
@@ -202,17 +206,17 @@ int vnodeApplyWMsg(SVnode *pVnode, SRpcMsg *pMsg, SRpcMsg **pRsp) {
       }
     } break;
     case TDMT_VND_CREATE_SMA: {  // timeRangeSMA
-#if 1
+#if 0
 
       SSmaCfg vCreateSmaReq = {0};
       if (tDeserializeSVCreateTSmaReq(POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead)), &vCreateSmaReq) == NULL) {
         terrno = TSDB_CODE_OUT_OF_MEMORY;
-        vWarn("vgId%d: TDMT_VND_CREATE_SMA received but deserialize failed since %s", pVnode->config.vgId,
+        vWarn("vgId:%d TDMT_VND_CREATE_SMA received but deserialize failed since %s", pVnode->config.vgId,
               terrstr(terrno));
         return -1;
       }
-      vWarn("vgId%d: TDMT_VND_CREATE_SMA received for %s:%" PRIi64, pVnode->config.vgId, vCreateSmaReq.tSma.indexName,
-            vCreateSmaReq.tSma.indexUid);
+      vDebug("vgId:%d TDMT_VND_CREATE_SMA msg received for %s:%" PRIi64, pVnode->config.vgId,
+             vCreateSmaReq.tSma.indexName, vCreateSmaReq.tSma.indexUid);
 
       // record current timezone of server side
       vCreateSmaReq.tSma.timezoneInt = tsTimezone;
@@ -222,19 +226,24 @@ int vnodeApplyWMsg(SVnode *pVnode, SRpcMsg *pMsg, SRpcMsg **pRsp) {
         tdDestroyTSma(&vCreateSmaReq.tSma);
         return -1;
       }
-      // TODO: send msg to stream computing to create tSma
-      // if ((send msg to stream computing) < 0) {
-      //   tdDestroyTSma(&vCreateSmaReq);
-      //   return -1;
-      // }
+
+      tsdbTSmaAdd(pVnode->pTsdb, 1);
+
       tdDestroyTSma(&vCreateSmaReq.tSma);
       // TODO: return directly or go on follow steps?
 #endif
+      if (tsdbCreateTSma(pVnode->pTsdb, POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead))) < 0) {
+        // TODO
+      }
     } break;
     case TDMT_VND_CANCEL_SMA: {  // timeRangeSMA
     } break;
     case TDMT_VND_DROP_SMA: {  // timeRangeSMA
+      if (tsdbDropTSma(pVnode->pTsdb, POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead))) < 0) {
+        // TODO
+      }
 #if 0    
+      tsdbTSmaSub(pVnode->pTsdb, 1);
       SVDropTSmaReq vDropSmaReq = {0};
       if (tDeserializeSVDropTSmaReq(POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead)), &vDropSmaReq) == NULL) {
         terrno = TSDB_CODE_OUT_OF_MEMORY;

source/dnode/vnode/test/tsdbSmaTest.cpp

@@ -408,7 +408,7 @@ TEST(testCase, tSma_Data_Insert_Query_Test) {
 
   EXPECT_EQ(tdScanAndConvertSubmitMsg(pMsg), TSDB_CODE_SUCCESS);
 
-  EXPECT_EQ(tsdbUpdateSmaWindow(pTsdb, (const char *)pMsg), 0);
+  EXPECT_EQ(tsdbUpdateSmaWindow(pTsdb, pMsg), 0);
 
   // init
   const int32_t  tSmaGroupSize = 4;

source/libs/executor/src/executorimpl.c

@@ -544,8 +544,9 @@ static SResultRow* doSetResultOutBufByKey_rv(SDiskbasedBuf* pResultBuf, SResultR
         existInCurrentResusltRowInfo = false;  // this time window created by other timestamp that does not belongs to current table.
         assert(pResultRowInfo->curPos == -1);
       } else if (pResultRowInfo->size == 1) {
-        ASSERT(0);
-//        existInCurrentResusltRowInfo = (pResultRowInfo->pResult[0] == (*p1));
+        // ASSERT(0);
+        SResultRowPosition* p = &pResultRowInfo->pPosition[0];
+        existInCurrentResusltRowInfo = (p->pageId == p1->pageId && p->offset == p1->offset);
       } else {  // check if current pResultRowInfo contains the existInCurrentResusltRowInfo pResultRow
         SET_RES_EXT_WINDOW_KEY(pSup->keyBuf, pData, bytes, tid, pResultRowInfo);
         int64_t* index = taosHashGet(pSup->pResultRowListSet, pSup->keyBuf, GET_RES_EXT_WINDOW_KEY_LEN(bytes));
@@ -597,6 +598,8 @@ static SResultRow* doSetResultOutBufByKey_rv(SDiskbasedBuf* pResultBuf, SResultR
     int64_t index = pResultRowInfo->curPos;
     SET_RES_EXT_WINDOW_KEY(pSup->keyBuf, pData, bytes, tid, pResultRowInfo);
     taosHashPut(pSup->pResultRowListSet, pSup->keyBuf, GET_RES_EXT_WINDOW_KEY_LEN(bytes), &index, POINTER_BYTES);
+  } else {
+    pResult = getResultRowByPos(pResultBuf, p1);
   }
 
   // too many time window in query
@@ -1264,19 +1267,10 @@ static void projectApplyFunctions(SExprInfo* pExpr, SSDataBlock* pResult, SSData
 
       pResult->info.rows = pCtx[0].input.numOfRows;
     } else if (pExpr[k].pExpr->nodeType == QUERY_NODE_VALUE) {
-      SVariant *pVal = pExpr[k].pExpr->pVal;
-      char *payload;
-      if (IS_VAR_DATA_TYPE(pVal->nType)) {
-        payload = taosMemoryCalloc(1, pVal->nLen + VARSTR_HEADER_SIZE);
-      } else {
-        payload = taosMemoryCalloc(1, tDataTypes[pVal->nType].bytes);
-      }
-      taosVariantDump(pVal, payload, pVal->nType, true);
       SColumnInfoData* pColInfoData = taosArrayGet(pResult->pDataBlock, k);
       for (int32_t i = 0; i < pSrcBlock->info.rows; ++i) {
-        colDataAppend(pColInfoData, i, payload, false);
+        colDataAppend(pColInfoData, i, taosVariantGet(&pExpr[k].base.pParam[0].param, pExpr[k].base.pParam[0].param.nType), TSDB_DATA_TYPE_NULL == pExpr[k].base.pParam[0].param.nType);
       }
-      taosMemoryFree(payload);
       pResult->info.rows = pSrcBlock->info.rows;
     } else if (pExpr[k].pExpr->nodeType == QUERY_NODE_OPERATOR) {
       SArray* pBlockList = taosArrayInit(4, POINTER_BYTES);
@@ -1322,12 +1316,6 @@ static void projectApplyFunctions(SExprInfo* pExpr, SSDataBlock* pResult, SSData
         pResult->info.rows = dest.numOfRows;
         taosArrayDestroy(pBlockList);
       }
-    } else if (pExpr[k].pExpr->nodeType == QUERY_NODE_VALUE) {
-      SColumnInfoData* pColInfoData = taosArrayGet(pResult->pDataBlock, k);
-      for (int32_t i = 0; i < pSrcBlock->info.rows; ++i) {
-        colDataAppend(pColInfoData, i, taosVariantGet(&pExpr[k].base.pParam[0].param, pExpr[k].base.pParam[0].type), TSDB_DATA_TYPE_NULL == pExpr[k].base.pParam[0].param.nType);
-      }
-      pResult->info.rows = pSrcBlock->info.rows;
     } else {
       ASSERT(0);
     }
@@ -1627,7 +1615,8 @@ static SArray* hashIntervalAgg(SOperatorInfo* pOperatorInfo, SResultRowInfo* pRe
         getNumOfRowsInTimeWindow(&pSDataBlock->info, tsCols, startPos, ekey, binarySearchForKey, NULL, TSDB_ORDER_ASC);
 
     // window start(end) key interpolation
-    doWindowBorderInterpolation(pOperatorInfo, pSDataBlock, pInfo->binfo.pCtx, pResult, &nextWin, startPos, forwardStep, pInfo->order, false);
+    doWindowBorderInterpolation(pOperatorInfo, pSDataBlock, pInfo->binfo.pCtx, pResult, &nextWin, startPos, forwardStep,
+                                pInfo->order, false);
 
     updateTimeWindowInfo(&pInfo->timeWindowData, &nextWin, true);
     doApplyFunctions(pInfo->binfo.pCtx, &nextWin, &pInfo->timeWindowData, startPos, forwardStep, tsCols, pSDataBlock->info.rows, numOfOutput, TSDB_ORDER_ASC);
@@ -6976,15 +6965,16 @@ SExprInfo* createExprInfo(SNodeList* pNodeList, SNodeList* pGroupKeys, int32_t*
       pExp->base.pParam[0].pCol = createColumn(pColNode->dataBlockId, pColNode->slotId, pType);
       pExp->base.pParam[0].type = FUNC_PARAM_TYPE_COLUMN;
     } else if (nodeType(pTargetNode->pExpr) == QUERY_NODE_VALUE) {
-      pExp->pExpr->nodeType  = QUERY_NODE_VALUE;
-      SValueNode* pValueNode = (SValueNode*)pTargetNode->pExpr;
-      SDataType* pType = &pValueNode->node.resType;
-      char *pDatum = nodesGetValueFromNode(pValueNode);
-      if (IS_VAR_DATA_TYPE(pType->type)) {
-        pDatum = varDataVal(pDatum);
-      }
-      pExp->pExpr->pVal = taosMemoryCalloc(1, sizeof(SVariant));
-      taosVariantCreateFromBinary(pExp->pExpr->pVal, pDatum, pType->bytes, pType->type);
+      pExp->pExpr->nodeType = QUERY_NODE_VALUE;
+      SValueNode* pValNode = (SValueNode*)pTargetNode->pExpr;
+
+      pExp->base.pParam = taosMemoryCalloc(1, sizeof(SFunctParam));
+      pExp->base.numOfParams = 1;
+
+      SDataType* pType = &pValNode->node.resType;
+      pExp->base.resSchema = createResSchema(pType->type, pType->bytes, pTargetNode->slotId, pType->scale, pType->precision, pValNode->node.aliasName);
+      pExp->base.pParam[0].type = FUNC_PARAM_TYPE_VALUE;
+      valueNodeToVariant(pValNode, &pExp->base.pParam[0].param);
     } else if (nodeType(pTargetNode->pExpr) == QUERY_NODE_FUNCTION) {
       pExp->pExpr->nodeType = QUERY_NODE_FUNCTION;
       SFunctionNode* pFuncNode = (SFunctionNode*)pTargetNode->pExpr;
@@ -7029,17 +7019,6 @@ SExprInfo* createExprInfo(SNodeList* pNodeList, SNodeList* pGroupKeys, int32_t*
 
 //      pExp->base.pParam[0].type = FUNC_PARAM_TYPE_COLUMN;
 //      pExp->base.pParam[0].pCol = createColumn(pTargetNode->dataBlockId, pTargetNode->slotId, pType);
-    } else if (nodeType(pTargetNode->pExpr) == QUERY_NODE_VALUE) {
-      pExp->pExpr->nodeType = QUERY_NODE_VALUE;
-      SValueNode* pValNode = (SValueNode*)pTargetNode->pExpr;
-
-      pExp->base.pParam = taosMemoryCalloc(1, sizeof(SFunctParam));
-      pExp->base.numOfParams = 1;
-
-      SDataType* pType = &pValNode->node.resType;
-      pExp->base.resSchema = createResSchema(pType->type, pType->bytes, pTargetNode->slotId, pType->scale, pType->precision, pValNode->node.aliasName);
-      pExp->base.pParam[0].type = FUNC_PARAM_TYPE_VALUE;
-      valueNodeToVariant(pValNode, &pExp->base.pParam[0].param);
     } else {
       ASSERT(0);
     }

source/libs/nodes/src/nodesCodeFuncs.c

@@ -994,6 +994,7 @@ static int32_t jsonToPhysiExchangeNode(const SJson* pJson, void* pObj) {
 
 static const char* jkSortPhysiPlanExprs = "Exprs";
 static const char* jkSortPhysiPlanSortKeys = "SortKeys";
+static const char* jkSortPhysiPlanTargets = "Targets";
 
 static int32_t physiSortNodeToJson(const void* pObj, SJson* pJson) {
   const SSortPhysiNode* pNode = (const SSortPhysiNode*)pObj;
@@ -1005,6 +1006,9 @@ static int32_t physiSortNodeToJson(const void* pObj, SJson* pJson) {
   if (TSDB_CODE_SUCCESS == code) {
     code = nodeListToJson(pJson, jkSortPhysiPlanSortKeys, pNode->pSortKeys);
   }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = nodeListToJson(pJson, jkSortPhysiPlanTargets, pNode->pTargets);
+  }
 
   return code;
 }
@@ -1019,6 +1023,9 @@ static int32_t jsonToPhysiSortNode(const SJson* pJson, void* pObj) {
   if (TSDB_CODE_SUCCESS == code) {
     code = jsonToNodeList(pJson, jkSortPhysiPlanSortKeys, &pNode->pSortKeys);
   }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = jsonToNodeList(pJson, jkSortPhysiPlanTargets, &pNode->pTargets);
+  }
 
   return code;
 }
@@ -1177,6 +1184,7 @@ static int32_t jsonToPhysiStateWindowNode(const SJson* pJson, void* pObj) {
 
 static const char* jkPartitionPhysiPlanExprs = "Exprs";
 static const char* jkPartitionPhysiPlanPartitionKeys = "PartitionKeys";
+static const char* jkPartitionPhysiPlanTargets = "Targets";
 
 static int32_t physiPartitionNodeToJson(const void* pObj, SJson* pJson) {
   const SPartitionPhysiNode* pNode = (const SPartitionPhysiNode*)pObj;
@@ -1188,6 +1196,9 @@ static int32_t physiPartitionNodeToJson(const void* pObj, SJson* pJson) {
   if (TSDB_CODE_SUCCESS == code) {
     code = nodeListToJson(pJson, jkPartitionPhysiPlanPartitionKeys, pNode->pPartitionKeys);
   }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = nodeListToJson(pJson, jkPartitionPhysiPlanTargets, pNode->pTargets);
+  }
 
   return code;
 }
@@ -1202,6 +1213,9 @@ static int32_t jsonToPhysiPartitionNode(const SJson* pJson, void* pObj) {
   if (TSDB_CODE_SUCCESS == code) {
     code = jsonToNodeList(pJson, jkPartitionPhysiPlanPartitionKeys, &pNode->pPartitionKeys);
   }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = jsonToNodeList(pJson, jkPartitionPhysiPlanTargets, &pNode->pTargets);
+  }
 
   return code;
 }

source/libs/nodes/src/nodesTraverseFuncs.c

@@ -301,9 +301,10 @@ void nodesWalkSelectStmt(SSelectStmt* pSelect, ESqlClause clause, FNodeWalker wa
     case SQL_CLAUSE_GROUP_BY:
       nodesWalkExpr(pSelect->pHaving, walker, pContext);
     case SQL_CLAUSE_HAVING:
-      nodesWalkExprs(pSelect->pProjectionList, walker, pContext);
-    case SQL_CLAUSE_SELECT:
+    case SQL_CLAUSE_DISTINCT:
       nodesWalkExprs(pSelect->pOrderByList, walker, pContext);
+    case SQL_CLAUSE_ORDER_BY:
+      nodesWalkExprs(pSelect->pProjectionList, walker, pContext);      
     default:
       break;
   }
@@ -329,9 +330,10 @@ void nodesRewriteSelectStmt(SSelectStmt* pSelect, ESqlClause clause, FNodeRewrit
     case SQL_CLAUSE_GROUP_BY:
       nodesRewriteExpr(&(pSelect->pHaving), rewriter, pContext);
     case SQL_CLAUSE_HAVING:
-      nodesRewriteExprs(pSelect->pProjectionList, rewriter, pContext);
-    case SQL_CLAUSE_SELECT:
+    case SQL_CLAUSE_DISTINCT:
       nodesRewriteExprs(pSelect->pOrderByList, rewriter, pContext);
+    case SQL_CLAUSE_ORDER_BY:
+      nodesRewriteExprs(pSelect->pProjectionList, rewriter, pContext);      
     default:
       break;
   }

source/libs/parser/inc/parAst.h

@@ -35,7 +35,7 @@ typedef struct SAstCreateContext {
 } SAstCreateContext;
 
 typedef enum EDatabaseOptionType {
-  DB_OPTION_BLOCKS = 0,
+  DB_OPTION_BLOCKS = 1,
   DB_OPTION_CACHE,
   DB_OPTION_CACHELAST,
   DB_OPTION_COMP,
@@ -52,26 +52,22 @@ typedef enum EDatabaseOptionType {
   DB_OPTION_VGROUPS,
   DB_OPTION_SINGLE_STABLE,
   DB_OPTION_STREAM_MODE,
-  DB_OPTION_RETENTIONS,
-
-  DB_OPTION_MAX
+  DB_OPTION_RETENTIONS
 } EDatabaseOptionType;
 
 typedef enum ETableOptionType {
-  TABLE_OPTION_KEEP = 0,
+  TABLE_OPTION_KEEP = 1,
   TABLE_OPTION_TTL,
   TABLE_OPTION_COMMENT,
   TABLE_OPTION_SMA,
   TABLE_OPTION_FILE_FACTOR,
-  TABLE_OPTION_DELAY,
-
-  TABLE_OPTION_MAX
+  TABLE_OPTION_DELAY
 } ETableOptionType;
 
 typedef struct SAlterOption {
   int32_t type;
-  SToken val;
-  SNodeList* pKeep;
+  SValueNode* pVal;
+  SNodeList* pList;
 } SAlterOption;
 
 extern SToken nil_token;
@@ -97,6 +93,7 @@ SNode* createBetweenAnd(SAstCreateContext* pCxt, SNode* pExpr, SNode* pLeft, SNo
 SNode* createNotBetweenAnd(SAstCreateContext* pCxt, SNode* pExpr, SNode* pLeft, SNode* pRight);
 SNode* createFunctionNode(SAstCreateContext* pCxt, const SToken* pFuncName, SNodeList* pParameterList);
 SNode* createNodeListNode(SAstCreateContext* pCxt, SNodeList* pList);
+SNode* createNodeListNodeEx(SAstCreateContext* pCxt, SNode* p1, SNode* p2);
 SNode* createRealTableNode(SAstCreateContext* pCxt, SToken* pDbName, SToken* pTableName, SToken* pTableAlias);
 SNode* createTempTableNode(SAstCreateContext* pCxt, SNode* pSubquery, const SToken* pTableAlias);
 SNode* createJoinTableNode(SAstCreateContext* pCxt, EJoinType type, SNode* pLeft, SNode* pRight, SNode* pJoinCond);
@@ -119,20 +116,12 @@ SNode* addLimitClause(SAstCreateContext* pCxt, SNode* pStmt, SNode* pLimit);
 SNode* createSelectStmt(SAstCreateContext* pCxt, bool isDistinct, SNodeList* pProjectionList, SNode* pTable);
 SNode* createSetOperator(SAstCreateContext* pCxt, ESetOperatorType type, SNode* pLeft, SNode* pRight);
 
-SNode* createDefaultDatabaseOptions(SAstCreateContext* pCxt);
-SNode* createDefaultAlterDatabaseOptions(SAstCreateContext* pCxt);
-SNode* setDatabaseOption(SAstCreateContext* pCxt, SNode* pOptions, EDatabaseOptionType type, const SToken* pVal);
-SNode* setDatabaseKeepOption(SAstCreateContext* pCxt, SNode* pOptions, SNodeList* pKeep);
+SNode* createDatabaseOptions(SAstCreateContext* pCxt);
 SNode* setDatabaseAlterOption(SAstCreateContext* pCxt, SNode* pOptions, SAlterOption* pAlterOption);
 SNode* createCreateDatabaseStmt(SAstCreateContext* pCxt, bool ignoreExists, SToken* pDbName, SNode* pOptions);
 SNode* createDropDatabaseStmt(SAstCreateContext* pCxt, bool ignoreNotExists, SToken* pDbName);
 SNode* createAlterDatabaseStmt(SAstCreateContext* pCxt, SToken* pDbName, SNode* pOptions);
-SNode* createDefaultTableOptions(SAstCreateContext* pCxt);
-SNode* createDefaultAlterTableOptions(SAstCreateContext* pCxt);
-SNode* setTableOption(SAstCreateContext* pCxt, SNode* pOptions, ETableOptionType type, const SToken* pVal);
-SNode* setTableSmaOption(SAstCreateContext* pCxt, SNode* pOptions, SNodeList* pSma);
-SNode* setTableRollupOption(SAstCreateContext* pCxt, SNode* pOptions, SNodeList* pFuncs);
-SNode* setTableKeepOption(SAstCreateContext* pCxt, SNode* pOptions, SNodeList* pKeep);
+SNode* createTableOptions(SAstCreateContext* pCxt);
 SNode* setTableAlterOption(SAstCreateContext* pCxt, SNode* pOptions, SAlterOption* pAlterOption);
 SNode* createColumnDefNode(SAstCreateContext* pCxt, const SToken* pColName, SDataType dataType, const SToken* pComment);
 SDataType createDataType(uint8_t type);

source/libs/parser/inc/sql.y

@@ -128,44 +128,59 @@ not_exists_opt(A) ::= .
 exists_opt(A) ::= IF EXISTS.                                                      { A = true; }
 exists_opt(A) ::= .                                                               { A = false; }
 
-db_options(A) ::= .                                                               { A = createDefaultDatabaseOptions(pCxt); }
-db_options(A) ::= db_options(B) BLOCKS NK_INTEGER(C).                             { A = setDatabaseOption(pCxt, B, DB_OPTION_BLOCKS, &C); }
-db_options(A) ::= db_options(B) CACHE NK_INTEGER(C).                              { A = setDatabaseOption(pCxt, B, DB_OPTION_CACHE, &C); }
-db_options(A) ::= db_options(B) CACHELAST NK_INTEGER(C).                          { A = setDatabaseOption(pCxt, B, DB_OPTION_CACHELAST, &C); }
-db_options(A) ::= db_options(B) COMP NK_INTEGER(C).                               { A = setDatabaseOption(pCxt, B, DB_OPTION_COMP, &C); }
-db_options(A) ::= db_options(B) DAYS NK_INTEGER(C).                               { A = setDatabaseOption(pCxt, B, DB_OPTION_DAYS, &C); }
-db_options(A) ::= db_options(B) FSYNC NK_INTEGER(C).                              { A = setDatabaseOption(pCxt, B, DB_OPTION_FSYNC, &C); }
-db_options(A) ::= db_options(B) MAXROWS NK_INTEGER(C).                            { A = setDatabaseOption(pCxt, B, DB_OPTION_MAXROWS, &C); }
-db_options(A) ::= db_options(B) MINROWS NK_INTEGER(C).                            { A = setDatabaseOption(pCxt, B, DB_OPTION_MINROWS, &C); }
-db_options(A) ::= db_options(B) KEEP integer_list(C).                             { A = setDatabaseKeepOption(pCxt, B, C); }
-db_options(A) ::= db_options(B) PRECISION NK_STRING(C).                           { A = setDatabaseOption(pCxt, B, DB_OPTION_PRECISION, &C); }
-db_options(A) ::= db_options(B) QUORUM NK_INTEGER(C).                             { A = setDatabaseOption(pCxt, B, DB_OPTION_QUORUM, &C); }
-db_options(A) ::= db_options(B) REPLICA NK_INTEGER(C).                            { A = setDatabaseOption(pCxt, B, DB_OPTION_REPLICA, &C); }
-db_options(A) ::= db_options(B) TTL NK_INTEGER(C).                                { A = setDatabaseOption(pCxt, B, DB_OPTION_TTL, &C); }
-db_options(A) ::= db_options(B) WAL NK_INTEGER(C).                                { A = setDatabaseOption(pCxt, B, DB_OPTION_WAL, &C); }
-db_options(A) ::= db_options(B) VGROUPS NK_INTEGER(C).                            { A = setDatabaseOption(pCxt, B, DB_OPTION_VGROUPS, &C); }
-db_options(A) ::= db_options(B) SINGLE_STABLE NK_INTEGER(C).                      { A = setDatabaseOption(pCxt, B, DB_OPTION_SINGLE_STABLE, &C); }
-db_options(A) ::= db_options(B) STREAM_MODE NK_INTEGER(C).                        { A = setDatabaseOption(pCxt, B, DB_OPTION_STREAM_MODE, &C); }
-db_options(A) ::= db_options(B) RETENTIONS NK_STRING(C).                          { A = setDatabaseOption(pCxt, B, DB_OPTION_RETENTIONS, &C); }
-
-alter_db_options(A) ::= alter_db_option(B).                                       { A = createDefaultAlterDatabaseOptions(pCxt); A = setDatabaseAlterOption(pCxt, A, &B); }
+db_options(A) ::= .                                                               { A = createDatabaseOptions(pCxt); }
+db_options(A) ::= db_options(B) BLOCKS NK_INTEGER(C).                             { ((SDatabaseOptions*)B)->pNumOfBlocks = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) CACHE NK_INTEGER(C).                              { ((SDatabaseOptions*)B)->pCacheBlockSize = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) CACHELAST NK_INTEGER(C).                          { ((SDatabaseOptions*)B)->pCachelast = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) COMP NK_INTEGER(C).                               { ((SDatabaseOptions*)B)->pCompressionLevel = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) DAYS NK_INTEGER(C).                               { ((SDatabaseOptions*)B)->pDaysPerFile = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) DAYS NK_VARIABLE(C).                              { ((SDatabaseOptions*)B)->pDaysPerFile = (SValueNode*)createDurationValueNode(pCxt, &C); A = B; }
+db_options(A) ::= db_options(B) FSYNC NK_INTEGER(C).                              { ((SDatabaseOptions*)B)->pFsyncPeriod = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) MAXROWS NK_INTEGER(C).                            { ((SDatabaseOptions*)B)->pMaxRowsPerBlock = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) MINROWS NK_INTEGER(C).                            { ((SDatabaseOptions*)B)->pMinRowsPerBlock = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) KEEP integer_list(C).                             { ((SDatabaseOptions*)B)->pKeep = C; A = B; }
+db_options(A) ::= db_options(B) KEEP variable_list(C).                            { ((SDatabaseOptions*)B)->pKeep = C; A = B; }
+db_options(A) ::= db_options(B) PRECISION NK_STRING(C).                           { ((SDatabaseOptions*)B)->pPrecision = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BINARY, &C); A = B; }
+db_options(A) ::= db_options(B) QUORUM NK_INTEGER(C).                             { ((SDatabaseOptions*)B)->pQuorum = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) REPLICA NK_INTEGER(C).                            { ((SDatabaseOptions*)B)->pReplica = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) TTL NK_INTEGER(C).                                { ((SDatabaseOptions*)B)->pTtl = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) WAL NK_INTEGER(C).                                { ((SDatabaseOptions*)B)->pWalLevel = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) VGROUPS NK_INTEGER(C).                            { ((SDatabaseOptions*)B)->pNumOfVgroups = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) SINGLE_STABLE NK_INTEGER(C).                      { ((SDatabaseOptions*)B)->pSingleStable = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) STREAM_MODE NK_INTEGER(C).                        { ((SDatabaseOptions*)B)->pStreamMode = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+db_options(A) ::= db_options(B) RETENTIONS retention_list(C).                     { ((SDatabaseOptions*)B)->pRetentions = C; A = B; }
+
+alter_db_options(A) ::= alter_db_option(B).                                       { A = createDatabaseOptions(pCxt); A = setDatabaseAlterOption(pCxt, A, &B); }
 alter_db_options(A) ::= alter_db_options(B) alter_db_option(C).                   { A = setDatabaseAlterOption(pCxt, B, &C); }
 
 %type alter_db_option                                                             { SAlterOption }
 %destructor alter_db_option                                                       { }
-alter_db_option(A) ::= BLOCKS NK_INTEGER(B).                                      { A.type = DB_OPTION_BLOCKS; A.val = B; }
-alter_db_option(A) ::= FSYNC NK_INTEGER(B).                                       { A.type = DB_OPTION_FSYNC; A.val = B; }
-alter_db_option(A) ::= KEEP integer_list(B).                                      { A.type = DB_OPTION_KEEP; A.pKeep = B; }
-alter_db_option(A) ::= WAL NK_INTEGER(B).                                         { A.type = DB_OPTION_WAL; A.val = B; }
-alter_db_option(A) ::= QUORUM NK_INTEGER(B).                                      { A.type = DB_OPTION_QUORUM; A.val = B; }
-alter_db_option(A) ::= CACHELAST NK_INTEGER(B).                                   { A.type = DB_OPTION_CACHELAST; A.val = B; }
-alter_db_option(A) ::= REPLICA NK_INTEGER(B).                                     { A.type = DB_OPTION_REPLICA; A.val = B; }
+alter_db_option(A) ::= BLOCKS NK_INTEGER(B).                                      { A.type = DB_OPTION_BLOCKS; A.pVal = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &B); }
+alter_db_option(A) ::= FSYNC NK_INTEGER(B).                                       { A.type = DB_OPTION_FSYNC; A.pVal = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &B); }
+alter_db_option(A) ::= KEEP integer_list(B).                                      { A.type = DB_OPTION_KEEP; A.pList = B; }
+alter_db_option(A) ::= KEEP variable_list(B).                                     { A.type = DB_OPTION_KEEP; A.pList = B; }
+alter_db_option(A) ::= WAL NK_INTEGER(B).                                         { A.type = DB_OPTION_WAL; A.pVal = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &B); }
+alter_db_option(A) ::= QUORUM NK_INTEGER(B).                                      { A.type = DB_OPTION_QUORUM; A.pVal = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &B); }
+alter_db_option(A) ::= CACHELAST NK_INTEGER(B).                                   { A.type = DB_OPTION_CACHELAST; A.pVal = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &B); }
+alter_db_option(A) ::= REPLICA NK_INTEGER(B).                                     { A.type = DB_OPTION_REPLICA; A.pVal = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &B); }
 
 %type integer_list                                                                { SNodeList* }
 %destructor integer_list                                                          { nodesDestroyList($$); }
 integer_list(A) ::= NK_INTEGER(B).                                                { A = createNodeList(pCxt, createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &B)); }
 integer_list(A) ::= integer_list(B) NK_COMMA NK_INTEGER(C).                       { A = addNodeToList(pCxt, B, createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C)); }
 
+%type variable_list                                                               { SNodeList* }
+%destructor variable_list                                                         { nodesDestroyList($$); }
+variable_list(A) ::= NK_VARIABLE(B).                                              { A = createNodeList(pCxt, createDurationValueNode(pCxt, &B)); }
+variable_list(A) ::= variable_list(B) NK_COMMA NK_VARIABLE(C).                    { A = addNodeToList(pCxt, B, createDurationValueNode(pCxt, &C)); }
+
+%type retention_list                                                              { SNodeList* }
+%destructor retention_list                                                        { nodesDestroyList($$); }
+retention_list(A) ::= retention(B).                                               { A = createNodeList(pCxt, B); }
+retention_list(A) ::= retention_list(B) NK_COMMA retention(C).                    { A = addNodeToList(pCxt, B, C); }
+
+retention(A) ::= NK_VARIABLE(B) NK_COLON NK_VARIABLE(C).                          { A = createNodeListNodeEx(pCxt, createDurationValueNode(pCxt, &B), createDurationValueNode(pCxt, &C)); }
+
 /************************************************ create/drop table/stable ********************************************/
 cmd ::= CREATE TABLE not_exists_opt(A) full_table_name(B)
   NK_LP column_def_list(C) NK_RP tags_def_opt(D) table_options(E).                { pCxt->pRootNode = createCreateTableStmt(pCxt, A, B, C, D, E); }
@@ -263,23 +278,23 @@ tags_def_opt(A) ::= tags_def(B).
 %destructor tags_def                                                              { nodesDestroyList($$); }
 tags_def(A) ::= TAGS NK_LP column_def_list(B) NK_RP.                              { A = B; }
 
-table_options(A) ::= .                                                            { A = createDefaultTableOptions(pCxt); }
-table_options(A) ::= table_options(B) COMMENT NK_STRING(C).                       { A = setTableOption(pCxt, B, TABLE_OPTION_COMMENT, &C); }
-table_options(A) ::= table_options(B) KEEP integer_list(C).                       { A = setTableKeepOption(pCxt, B, C); }
-table_options(A) ::= table_options(B) TTL NK_INTEGER(C).                          { A = setTableOption(pCxt, B, TABLE_OPTION_TTL, &C); }
-table_options(A) ::= table_options(B) SMA NK_LP col_name_list(C) NK_RP.           { A = setTableSmaOption(pCxt, B, C); }
-table_options(A) ::= table_options(B) ROLLUP NK_LP func_name_list(C) NK_RP.       { A = setTableRollupOption(pCxt, B, C); }
-table_options(A) ::= table_options(B) FILE_FACTOR NK_FLOAT(C).                    { A = setTableOption(pCxt, B, TABLE_OPTION_FILE_FACTOR, &C); }
-table_options(A) ::= table_options(B) DELAY NK_INTEGER(C).                        { A = setTableOption(pCxt, B, TABLE_OPTION_DELAY, &C); }
+table_options(A) ::= .                                                            { A = createTableOptions(pCxt); }
+table_options(A) ::= table_options(B) COMMENT NK_STRING(C).                       { ((STableOptions*)B)->pComments = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BINARY, &C); A = B; }
+table_options(A) ::= table_options(B) KEEP integer_list(C).                       { ((STableOptions*)B)->pKeep = C; A = B; }
+table_options(A) ::= table_options(B) TTL NK_INTEGER(C).                          { ((STableOptions*)B)->pTtl = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
+table_options(A) ::= table_options(B) SMA NK_LP col_name_list(C) NK_RP.           { ((STableOptions*)B)->pSma = C; A = B; }
+table_options(A) ::= table_options(B) ROLLUP NK_LP func_name_list(C) NK_RP.       { ((STableOptions*)B)->pFuncs = C; A = B; }
+table_options(A) ::= table_options(B) FILE_FACTOR NK_FLOAT(C).                    { ((STableOptions*)B)->pFilesFactor = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_DOUBLE, &C); A = B; }
+table_options(A) ::= table_options(B) DELAY NK_INTEGER(C).                        { ((STableOptions*)B)->pDelay = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &C); A = B; }
 
-alter_table_options(A) ::= alter_table_option(B).                                 { A = createDefaultAlterTableOptions(pCxt); A = setTableAlterOption(pCxt, A, &B); }
+alter_table_options(A) ::= alter_table_option(B).                                 { A = createTableOptions(pCxt); A = setTableAlterOption(pCxt, A, &B); }
 alter_table_options(A) ::= alter_table_options(B) alter_table_option(C).          { A = setTableAlterOption(pCxt, B, &C); }
 
 %type alter_table_option                                                          { SAlterOption }
 %destructor alter_table_option                                                    { }
-alter_table_option(A) ::= COMMENT NK_STRING(B).                                   { A.type = TABLE_OPTION_COMMENT; A.val = B; }
-alter_table_option(A) ::= KEEP integer_list(B).                                   { A.type = TABLE_OPTION_KEEP; A.pKeep = B; }
-alter_table_option(A) ::= TTL NK_INTEGER(B).                                      { A.type = TABLE_OPTION_TTL; A.val = B; }
+alter_table_option(A) ::= COMMENT NK_STRING(B).                                   { A.type = TABLE_OPTION_COMMENT; A.pVal = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BINARY, &B); }
+alter_table_option(A) ::= KEEP integer_list(B).                                   { A.type = TABLE_OPTION_KEEP; A.pList = B; }
+alter_table_option(A) ::= TTL NK_INTEGER(B).                                      { A.type = TABLE_OPTION_TTL; A.pVal = (SValueNode*)createValueNode(pCxt, TSDB_DATA_TYPE_BIGINT, &B); }
 
 %type col_name_list                                                               { SNodeList* }
 %destructor col_name_list                                                         { nodesDestroyList($$); }
@@ -471,6 +486,8 @@ column_name(A) ::= NK_ID(B).
 %type function_name                                                               { SToken }
 %destructor function_name                                                         { }
 function_name(A) ::= NK_ID(B).                                                    { A = B; }
+function_name(A) ::= FIRST(B).                                                    { A = B; }
+function_name(A) ::= LAST(B).                                                     { A = B; }
 
 %type table_alias                                                                 { SToken }
 %destructor table_alias                                                           { }

source/libs/parser/src/parTokenizer.c

@@ -72,6 +72,7 @@ static SKeyword keywordTable[] = {
     {"EXPLAIN",       TK_EXPLAIN},
     {"FILE_FACTOR",   TK_FILE_FACTOR},
     {"FILL",          TK_FILL},
+    {"FIRST",         TK_FIRST},
     {"FLOAT",         TK_FLOAT},
     {"FROM",          TK_FROM},
     {"FSYNC",         TK_FSYNC},
@@ -95,6 +96,7 @@ static SKeyword keywordTable[] = {
     {"JSON",          TK_JSON},
     {"KEEP",          TK_KEEP},
     {"KILL",          TK_KILL},
+    {"LAST",          TK_LAST},
     {"LICENCE",       TK_LICENCE},
     {"LIKE",          TK_LIKE},
     {"LIMIT",         TK_LIMIT},
@@ -113,6 +115,7 @@ static SKeyword keywordTable[] = {
     {"NOT",           TK_NOT},
     {"NOW",           TK_NOW},
     {"NULL",          TK_NULL},
+    {"NULLS",         TK_NULLS},
     {"OFFSET",        TK_OFFSET},
     {"ON",            TK_ON},
     {"OR",            TK_OR},

source/libs/parser/src/parTranslater.c

@@ -21,6 +21,8 @@
 #include "parUtil.h"
 #include "ttime.h"
 
+#define GET_OPTION_VAL(pVal, defaultVal) (NULL == (pVal) ? (defaultVal) : ((SValueNode*)(pVal))->datum.i)
+
 typedef struct STranslateContext {
   SParseContext* pParseCxt;
   int32_t errCode;
@@ -934,7 +936,7 @@ static int32_t translateSelect(STranslateContext* pCxt, SSelectStmt* pSelect) {
 
 static int32_t buildCreateDbRetentions(const SNodeList* pRetentions, SCreateDbReq* pReq) {
   if (NULL != pRetentions) {
-    pReq->pRetensions = taosArrayInit(LIST_LENGTH(pRetentions) / 2, sizeof(SRetention));
+    pReq->pRetensions = taosArrayInit(LIST_LENGTH(pRetentions), sizeof(SRetention));
     if (NULL == pReq->pRetensions) {
       return TSDB_CODE_OUT_OF_MEMORY;
     }
@@ -943,18 +945,15 @@ static int32_t buildCreateDbRetentions(const SNodeList* pRetentions, SCreateDbRe
     SNode* pNode = NULL;
     int32_t index = 0;
     FOREACH(pNode, pRetentions) {
-      if (0 == ((index++) & 1)) {
-        pFreq = (SValueNode*)pNode;
-      } else {
-        pKeep = (SValueNode*)pNode;
-        SRetention retention = {
-          .freq = pFreq->datum.i,
-          .freqUnit = pFreq->unit,
-          .keep = pKeep->datum.i,
-          .keepUnit = pKeep->unit
-        };
-        taosArrayPush(pReq->pRetensions, &retention);
-      }
+      pFreq = (SValueNode*)nodesListGetNode(((SNodeListNode*)pNode)->pNodeList, 0);
+      pKeep = (SValueNode*)nodesListGetNode(((SNodeListNode*)pNode)->pNodeList, 1);
+      SRetention retention = {
+        .freq = pFreq->datum.i,
+        .freqUnit = pFreq->unit,
+        .keep = pKeep->datum.i,
+        .keepUnit = pKeep->unit
+      };
+      taosArrayPush(pReq->pRetensions, &retention);
     }
     pReq->numOfRetensions = taosArrayGetSize(pReq->pRetensions);
   }
@@ -965,41 +964,220 @@ static int32_t buildCreateDbReq(STranslateContext* pCxt, SCreateDatabaseStmt* pS
   SName name = {0};
   tNameSetDbName(&name, pCxt->pParseCxt->acctId, pStmt->dbName, strlen(pStmt->dbName));
   tNameGetFullDbName(&name, pReq->db);
-  pReq->numOfVgroups = pStmt->pOptions->numOfVgroups;
-  pReq->cacheBlockSize = pStmt->pOptions->cacheBlockSize;
-  pReq->totalBlocks = pStmt->pOptions->numOfBlocks;
-  pReq->daysPerFile = pStmt->pOptions->daysPerFile;
-  pReq->daysToKeep0 = pStmt->pOptions->keep0;
-  pReq->daysToKeep1 = pStmt->pOptions->keep1;
-  pReq->daysToKeep2 = pStmt->pOptions->keep2;
-  pReq->minRows = pStmt->pOptions->minRowsPerBlock;
-  pReq->maxRows = pStmt->pOptions->maxRowsPerBlock;
+  pReq->numOfVgroups = GET_OPTION_VAL(pStmt->pOptions->pNumOfVgroups, TSDB_DEFAULT_VN_PER_DB);
+  pReq->cacheBlockSize = GET_OPTION_VAL(pStmt->pOptions->pCacheBlockSize, TSDB_DEFAULT_CACHE_BLOCK_SIZE);
+  pReq->totalBlocks = GET_OPTION_VAL(pStmt->pOptions->pNumOfBlocks, TSDB_DEFAULT_TOTAL_BLOCKS);
+  pReq->daysPerFile = GET_OPTION_VAL(pStmt->pOptions->pDaysPerFile, TSDB_DEFAULT_DAYS_PER_FILE);
+  pReq->daysToKeep0 = GET_OPTION_VAL(nodesListGetNode(pStmt->pOptions->pKeep, 0), TSDB_DEFAULT_KEEP);
+  pReq->daysToKeep1 = GET_OPTION_VAL(nodesListGetNode(pStmt->pOptions->pKeep, 1), TSDB_DEFAULT_KEEP);
+  pReq->daysToKeep2 = GET_OPTION_VAL(nodesListGetNode(pStmt->pOptions->pKeep, 2), TSDB_DEFAULT_KEEP);
+  pReq->minRows = GET_OPTION_VAL(pStmt->pOptions->pMinRowsPerBlock, TSDB_DEFAULT_MIN_ROW_FBLOCK);
+  pReq->maxRows = GET_OPTION_VAL(pStmt->pOptions->pMaxRowsPerBlock, TSDB_DEFAULT_MAX_ROW_FBLOCK);
   pReq->commitTime = -1;
-  pReq->fsyncPeriod = pStmt->pOptions->fsyncPeriod;
-  pReq->walLevel = pStmt->pOptions->walLevel;
-  pReq->precision = pStmt->pOptions->precision;
-  pReq->compression = pStmt->pOptions->compressionLevel;
-  pReq->replications = pStmt->pOptions->replica;
-  pReq->quorum = pStmt->pOptions->quorum;
+  pReq->fsyncPeriod = GET_OPTION_VAL(pStmt->pOptions->pFsyncPeriod, TSDB_DEFAULT_FSYNC_PERIOD);
+  pReq->walLevel = GET_OPTION_VAL(pStmt->pOptions->pWalLevel, TSDB_DEFAULT_WAL_LEVEL);
+  pReq->precision = GET_OPTION_VAL(pStmt->pOptions->pPrecision, TSDB_TIME_PRECISION_MILLI);
+  pReq->compression = GET_OPTION_VAL(pStmt->pOptions->pCompressionLevel, TSDB_DEFAULT_COMP_LEVEL);
+  pReq->replications = GET_OPTION_VAL(pStmt->pOptions->pReplica, TSDB_DEFAULT_DB_REPLICA_OPTION);
+  pReq->quorum = GET_OPTION_VAL(pStmt->pOptions->pQuorum, TSDB_DEFAULT_DB_QUORUM_OPTION);
   pReq->update = -1;
-  pReq->cacheLastRow = pStmt->pOptions->cachelast;
+  pReq->cacheLastRow = GET_OPTION_VAL(pStmt->pOptions->pCachelast, TSDB_DEFAULT_CACHE_LAST_ROW);
   pReq->ignoreExist = pStmt->ignoreExists;
-  pReq->streamMode = pStmt->pOptions->streamMode;
+  pReq->streamMode = GET_OPTION_VAL(pStmt->pOptions->pStreamMode, TSDB_DEFAULT_DB_STREAM_MODE_OPTION);
   return buildCreateDbRetentions(pStmt->pOptions->pRetentions, pReq);
 }
 
-static int32_t checkCreateDatabase(STranslateContext* pCxt, SCreateDatabaseStmt* pStmt) {
-  if (NULL != pStmt->pOptions->pRetentions) {
-    SNode* pNode = NULL;
-    FOREACH(pNode, pStmt->pOptions->pRetentions) {
-      if (DEAL_RES_ERROR == translateValue(pCxt, (SValueNode*)pNode)) {
+static int32_t checkRangeOption(STranslateContext* pCxt, const char* pName, SValueNode* pVal, int32_t minVal, int32_t maxVal) {
+  if (NULL != pVal) {
+    if (DEAL_RES_ERROR == translateValue(pCxt, pVal)) {
+      return pCxt->errCode;
+    }
+    int64_t val = pVal->datum.i;
+    if (val < minVal || val > maxVal) {
+      return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_RANGE_OPTION, pName, val, minVal, maxVal);
+    }
+  }
+  return TSDB_CODE_SUCCESS;
+}
+
+static void convertValueFromStrToInt(SValueNode* pVal, int64_t val) {
+  taosMemoryFreeClear(pVal->datum.p);
+  pVal->datum.i = val;
+  pVal->node.resType.type = TSDB_DATA_TYPE_BIGINT;
+  pVal->node.resType.bytes = tDataTypes[pVal->node.resType.type].bytes;
+}
+
+static int32_t checkDbPrecisionOption(STranslateContext* pCxt, SValueNode* pVal) {
+  if (NULL != pVal) {
+    if (DEAL_RES_ERROR == translateValue(pCxt, pVal)) {
+      return pCxt->errCode;
+    }
+    char* pRrecision = varDataVal(pVal->datum.p);
+    if (0 == strcmp(pRrecision, TSDB_TIME_PRECISION_MILLI_STR)) {
+      convertValueFromStrToInt(pVal, TSDB_TIME_PRECISION_MILLI);
+    } else if (0 == strcmp(pRrecision, TSDB_TIME_PRECISION_MICRO_STR)) {
+      convertValueFromStrToInt(pVal, TSDB_TIME_PRECISION_MICRO);
+    } else if (0 == strcmp(pRrecision, TSDB_TIME_PRECISION_NANO_STR)) {
+      convertValueFromStrToInt(pVal, TSDB_TIME_PRECISION_NANO);
+    } else {
+      return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_STR_OPTION, "precision", pVal->datum.p);
+    }
+  }
+  return TSDB_CODE_SUCCESS;
+}
+
+static int32_t checkDbEnumOption(STranslateContext* pCxt, const char* pName, SValueNode* pVal, int32_t v1, int32_t v2) {
+  if (NULL != pVal) {
+    if (DEAL_RES_ERROR == translateValue(pCxt, pVal)) {
+      return pCxt->errCode;
+    }
+    int64_t val = pVal->datum.i;
+    if (val != v1 && val != v2) {
+      return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_ENUM_OPTION, pName, val, v1, v2);
+    }
+  }
+  return TSDB_CODE_SUCCESS;
+}
+
+static int32_t checkTtlOption(STranslateContext* pCxt, SValueNode* pVal) {
+  if (NULL != pVal) {
+    if (DEAL_RES_ERROR == translateValue(pCxt, pVal)) {
+      return pCxt->errCode;
+    }
+    int64_t val = pVal->datum.i;
+    if (val < TSDB_MIN_DB_TTL_OPTION) {
+      return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_TTL_OPTION, val, TSDB_MIN_DB_TTL_OPTION);
+    }
+  }
+  return TSDB_CODE_SUCCESS;
+}
+
+static int32_t checkKeepOption(STranslateContext* pCxt, SNodeList* pKeep) {
+  if (NULL == pKeep) {
+    return TSDB_CODE_SUCCESS;
+  }
+
+  int32_t numOfKeep = LIST_LENGTH(pKeep);
+  if (numOfKeep > 3 || numOfKeep < 1) {
+    return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_KEEP_NUM);
+  }
+
+  SNode* pNode = NULL;
+  FOREACH(pNode, pKeep) {
+    if (DEAL_RES_ERROR == translateValue(pCxt, (SValueNode*)pNode)) {
+      return pCxt->errCode;
+    }
+  }
+
+  if (1 == numOfKeep) {
+    if (TSDB_CODE_SUCCESS != nodesListStrictAppend(pKeep, nodesCloneNode(nodesListGetNode(pKeep, 0)))) {
+      return TSDB_CODE_OUT_OF_MEMORY;
+    }
+    ++numOfKeep;
+  }
+  if (2 == numOfKeep) {
+    if (TSDB_CODE_SUCCESS != nodesListStrictAppend(pKeep, nodesCloneNode(nodesListGetNode(pKeep, 1)))) {
+      return TSDB_CODE_OUT_OF_MEMORY;
+    }
+  }
+
+  int32_t daysToKeep0 = ((SValueNode*)nodesListGetNode(pKeep, 0))->datum.i;
+  int32_t daysToKeep1 = ((SValueNode*)nodesListGetNode(pKeep, 1))->datum.i;
+  int32_t daysToKeep2 = ((SValueNode*)nodesListGetNode(pKeep, 2))->datum.i;
+  if (daysToKeep0 < TSDB_MIN_KEEP || daysToKeep1 < TSDB_MIN_KEEP || daysToKeep2 < TSDB_MIN_KEEP ||
+      daysToKeep0 > TSDB_MAX_KEEP || daysToKeep1 > TSDB_MAX_KEEP || daysToKeep2 > TSDB_MAX_KEEP) {
+    return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_KEEP_VALUE, daysToKeep0, daysToKeep1, daysToKeep2, TSDB_MIN_KEEP, TSDB_MAX_KEEP);
+  }
+
+  if (!((daysToKeep0 <= daysToKeep1) && (daysToKeep1 <= daysToKeep2))) {
+    return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_KEEP_ORDER);
+  }
+
+  return TSDB_CODE_SUCCESS;
+}
+
+static int32_t checkDbRetentionsOption(STranslateContext* pCxt, SNodeList* pRetentions) {
+  if (NULL == pRetentions) {
+    return TSDB_CODE_SUCCESS;
+  }
+
+  if (LIST_LENGTH(pRetentions) > 3) {
+    return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_RETENTIONS_OPTION);
+  }
+
+  SNode* pNode = NULL;
+  FOREACH(pNode, pRetentions) {
+    SNode* pVal = NULL;
+    FOREACH(pVal, ((SNodeListNode*)pNode)->pNodeList) {
+      if (DEAL_RES_ERROR == translateValue(pCxt, (SValueNode*)pVal)) {
         return pCxt->errCode;
       }
     }
   }
+
   return TSDB_CODE_SUCCESS;
 }
 
+static int32_t checkDatabaseOptions(STranslateContext* pCxt, SDatabaseOptions* pOptions) {
+  int32_t code = checkRangeOption(pCxt, "totalBlocks", pOptions->pNumOfBlocks, TSDB_MIN_TOTAL_BLOCKS, TSDB_MAX_TOTAL_BLOCKS);
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "cacheBlockSize", pOptions->pCacheBlockSize, TSDB_MIN_CACHE_BLOCK_SIZE, TSDB_MAX_CACHE_BLOCK_SIZE);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "cacheLast", pOptions->pCachelast, TSDB_MIN_DB_CACHE_LAST_ROW, TSDB_MAX_DB_CACHE_LAST_ROW);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "compression", pOptions->pCompressionLevel, TSDB_MIN_COMP_LEVEL, TSDB_MAX_COMP_LEVEL);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "daysPerFile", pOptions->pDaysPerFile, TSDB_MIN_DAYS_PER_FILE, TSDB_MAX_DAYS_PER_FILE);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "fsyncPeriod", pOptions->pFsyncPeriod, TSDB_MIN_FSYNC_PERIOD, TSDB_MAX_FSYNC_PERIOD);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "maxRowsPerBlock", pOptions->pMaxRowsPerBlock, TSDB_MIN_MAX_ROW_FBLOCK, TSDB_MAX_MAX_ROW_FBLOCK);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "minRowsPerBlock", pOptions->pMinRowsPerBlock, TSDB_MIN_MIN_ROW_FBLOCK, TSDB_MAX_MIN_ROW_FBLOCK);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkKeepOption(pCxt, pOptions->pKeep);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkDbPrecisionOption(pCxt, pOptions->pPrecision);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "quorum", pOptions->pQuorum, TSDB_MIN_DB_QUORUM_OPTION, TSDB_MAX_DB_QUORUM_OPTION);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkDbEnumOption(pCxt, "replications", pOptions->pReplica, TSDB_MIN_DB_REPLICA_OPTION, TSDB_MAX_DB_REPLICA_OPTION);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkTtlOption(pCxt, pOptions->pTtl);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkDbEnumOption(pCxt, "walLevel", pOptions->pWalLevel, TSDB_MIN_WAL_LEVEL, TSDB_MAX_WAL_LEVEL);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "vgroups", pOptions->pNumOfVgroups, TSDB_MIN_VNODES_PER_DB, TSDB_MAX_VNODES_PER_DB);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkDbEnumOption(pCxt, "singleStable", pOptions->pSingleStable, TSDB_MIN_DB_SINGLE_STABLE_OPTION, TSDB_MAX_DB_SINGLE_STABLE_OPTION);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkDbEnumOption(pCxt, "streamMode", pOptions->pStreamMode, TSDB_MIN_DB_STREAM_MODE_OPTION, TSDB_MAX_DB_STREAM_MODE_OPTION);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkDbRetentionsOption(pCxt, pOptions->pRetentions);
+  }
+  return code;
+}
+
+static int32_t checkCreateDatabase(STranslateContext* pCxt, SCreateDatabaseStmt* pStmt) {
+  return checkDatabaseOptions(pCxt, pStmt->pOptions);
+}
+
 static int32_t translateCreateDatabase(STranslateContext* pCxt, SCreateDatabaseStmt* pStmt) {
   SCreateDbReq createReq = {0};
 
@@ -1053,19 +1231,24 @@ static void buildAlterDbReq(STranslateContext* pCxt, SAlterDatabaseStmt* pStmt,
   SName name = {0};
   tNameSetDbName(&name, pCxt->pParseCxt->acctId, pStmt->dbName, strlen(pStmt->dbName));
   tNameGetFullDbName(&name, pReq->db);
-  pReq->totalBlocks = pStmt->pOptions->numOfBlocks;
-  pReq->daysToKeep0 = pStmt->pOptions->keep0;
-  pReq->daysToKeep1 = pStmt->pOptions->keep1;
-  pReq->daysToKeep2 = pStmt->pOptions->keep2;
-  pReq->fsyncPeriod = pStmt->pOptions->fsyncPeriod;
-  pReq->walLevel = pStmt->pOptions->walLevel;
-  pReq->quorum = pStmt->pOptions->quorum;
-  pReq->cacheLastRow = pStmt->pOptions->cachelast;
-  pReq->replications = pStmt->pOptions->replica;
+  pReq->totalBlocks = GET_OPTION_VAL(pStmt->pOptions->pNumOfBlocks, -1);
+  pReq->daysToKeep0 = GET_OPTION_VAL(nodesListGetNode(pStmt->pOptions->pKeep, 0), -1);
+  pReq->daysToKeep1 = GET_OPTION_VAL(nodesListGetNode(pStmt->pOptions->pKeep, 1), -1);
+  pReq->daysToKeep2 = GET_OPTION_VAL(nodesListGetNode(pStmt->pOptions->pKeep, 2), -1);
+  pReq->fsyncPeriod = GET_OPTION_VAL(pStmt->pOptions->pFsyncPeriod, -1);
+  pReq->walLevel = GET_OPTION_VAL(pStmt->pOptions->pWalLevel, -1);
+  pReq->quorum = GET_OPTION_VAL(pStmt->pOptions->pQuorum, -1);
+  pReq->cacheLastRow = GET_OPTION_VAL(pStmt->pOptions->pCachelast, -1);
+  pReq->replications = GET_OPTION_VAL(pStmt->pOptions->pReplica, -1);
   return;
 }
 
 static int32_t translateAlterDatabase(STranslateContext* pCxt, SAlterDatabaseStmt* pStmt) {
+  int32_t code = checkDatabaseOptions(pCxt, pStmt->pOptions);
+  if (TSDB_CODE_SUCCESS != code) {
+    return code;
+  }
+
   SAlterDbReq alterReq = {0};
   buildAlterDbReq(pCxt, pStmt, &alterReq);
 
@@ -1129,7 +1312,31 @@ static SColumnDefNode* findColDef(SNodeList* pCols, const SColumnNode* pCol) {
   return NULL;
 }
 
-static int32_t checkCreateTable(STranslateContext* pCxt, SCreateTableStmt* pStmt) {
+static int32_t checkTableCommentOption(STranslateContext* pCxt, SValueNode* pVal) {
+  if (NULL != pVal) {
+    if (DEAL_RES_ERROR == translateValue(pCxt, pVal)) {
+      return pCxt->errCode;
+    }
+    if (pVal->node.resType.bytes >= TSDB_STB_COMMENT_LEN) {
+      return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_COMMENT_OPTION, TSDB_STB_COMMENT_LEN - 1);
+    }
+  }
+  return TSDB_CODE_SUCCESS;
+}
+
+static int32_t checTableFactorOption(STranslateContext* pCxt, SValueNode* pVal) {
+  if (NULL != pVal) {
+    if (DEAL_RES_ERROR == translateValue(pCxt, pVal)) {
+      return pCxt->errCode;
+    }
+    if (pVal->datum.d < TSDB_MIN_DB_FILE_FACTOR || pVal->datum.d > TSDB_MAX_DB_FILE_FACTOR) {
+      return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_F_RANGE_OPTION, "file_factor", pVal->datum.d, TSDB_MIN_DB_FILE_FACTOR, TSDB_MAX_DB_FILE_FACTOR);
+    }
+  }
+  return TSDB_CODE_SUCCESS;
+}
+
+static int32_t checkTableSmaOption(STranslateContext* pCxt, SCreateTableStmt* pStmt) {
   if (NULL != pStmt->pOptions->pSma) {
     SNode* pNode = NULL;
     FOREACH(pNode, pStmt->pCols) {
@@ -1145,15 +1352,47 @@ static int32_t checkCreateTable(STranslateContext* pCxt, SCreateTableStmt* pStmt
       pColDef->sma = true;
     }
   }
-  if (NULL != pStmt->pOptions->pFuncs) {
-    SFunctionNode* pFunc = nodesListGetNode(pStmt->pOptions->pFuncs, 0);
-    if (TSDB_CODE_SUCCESS != fmGetFuncInfo(pFunc->functionName, &pFunc->funcId, &pFunc->funcType)) {
-      return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_FUNTION, pFunc->functionName);
-    }
+  return TSDB_CODE_SUCCESS;
+}
+
+static int32_t checkTableRollupOption(STranslateContext* pCxt, SNodeList* pFuncs) {
+  if (NULL == pFuncs) {
+    return TSDB_CODE_SUCCESS;
+  }
+
+  if (1 != LIST_LENGTH(pFuncs)) {
+    return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_ROLLUP_OPTION);
+  }
+  SFunctionNode* pFunc = nodesListGetNode(pFuncs, 0);
+  if (TSDB_CODE_SUCCESS != fmGetFuncInfo(pFunc->functionName, &pFunc->funcId, &pFunc->funcType)) {
+    return generateDealNodeErrMsg(pCxt, TSDB_CODE_PAR_INVALID_FUNTION, pFunc->functionName);
   }
   return TSDB_CODE_SUCCESS;
 }
 
+static int32_t checkCreateTable(STranslateContext* pCxt, SCreateTableStmt* pStmt) {
+  int32_t code = checkKeepOption(pCxt, pStmt->pOptions->pKeep);
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkTtlOption(pCxt, pStmt->pOptions->pTtl);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkTableCommentOption(pCxt, pStmt->pOptions->pComments);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkTableSmaOption(pCxt, pStmt);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkTableRollupOption(pCxt, pStmt->pOptions->pFuncs);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checTableFactorOption(pCxt, pStmt->pOptions->pFilesFactor);
+  }
+  if (TSDB_CODE_SUCCESS == code) {
+    code = checkRangeOption(pCxt, "delay", pStmt->pOptions->pDelay, TSDB_MIN_DB_DELAY, TSDB_MAX_DB_DELAY);
+  }
+  return code;
+}
+
 static int32_t getAggregationMethod(SNodeList* pFuncs) {
   if (NULL == pFuncs) {
     return -1;
@@ -1170,8 +1409,8 @@ static int32_t translateCreateSuperTable(STranslateContext* pCxt, SCreateTableSt
   SMCreateStbReq createReq = {0};
   createReq.igExists = pStmt->ignoreExists;
   createReq.aggregationMethod = getAggregationMethod(pStmt->pOptions->pFuncs);
-  createReq.xFilesFactor = pStmt->pOptions->filesFactor;
-  createReq.delay = pStmt->pOptions->delay;
+  createReq.xFilesFactor = GET_OPTION_VAL(pStmt->pOptions->pFilesFactor, TSDB_DEFAULT_DB_FILE_FACTOR);
+  createReq.delay = GET_OPTION_VAL(pStmt->pOptions->pDelay, TSDB_DEFAULT_DB_DELAY);
   columnDefNodeToField(pStmt->pCols, &createReq.pColumns);
   columnDefNodeToField(pStmt->pTags, &createReq.pTags);
   createReq.numOfColumns = LIST_LENGTH(pStmt->pCols);
@@ -2188,8 +2427,8 @@ static int32_t buildSmaParam(STableOptions* pOptions, SVCreateTbReq* pReq) {
   if (NULL == pReq->ntbCfg.pRSmaParam) {
     return TSDB_CODE_OUT_OF_MEMORY;
   }
-  pReq->ntbCfg.pRSmaParam->delay = pOptions->delay;
-  pReq->ntbCfg.pRSmaParam->xFilesFactor = pOptions->filesFactor;
+  pReq->ntbCfg.pRSmaParam->delay = GET_OPTION_VAL(pOptions->pDelay, TSDB_DEFAULT_DB_DELAY);
+  pReq->ntbCfg.pRSmaParam->xFilesFactor = GET_OPTION_VAL(pOptions->pFilesFactor, TSDB_DEFAULT_DB_FILE_FACTOR);
   pReq->ntbCfg.pRSmaParam->nFuncIds = LIST_LENGTH(pOptions->pFuncs);
   pReq->ntbCfg.pRSmaParam->pFuncIds = taosMemoryCalloc(pReq->ntbCfg.pRSmaParam->nFuncIds, sizeof(func_id_t));
   if (NULL == pReq->ntbCfg.pRSmaParam->pFuncIds) {
@@ -2439,7 +2678,7 @@ static int32_t buildKVRowForAllTags(STranslateContext* pCxt, SCreateSubTableClau
 
 static int32_t checkCreateSubTable(STranslateContext* pCxt, SCreateSubTableClause* pStmt) {
   if (0 != strcmp(pStmt->dbName, pStmt->useDbName)) {
-    return generateSyntaxErrMsg(&pCxt->msgBuf, TSDB_CODE_PAR_CORRESPONDING_STABLE_ERR);;
+    return generateSyntaxErrMsg(&pCxt->msgBuf, TSDB_CODE_PAR_CORRESPONDING_STABLE_ERR);
   }
   return TSDB_CODE_SUCCESS;
 }

source/libs/parser/src/parUtil.c

@@ -67,6 +67,28 @@ static char* getSyntaxErrFormat(int32_t errCode) {
       return "Invalid identifier name : %s";
     case TSDB_CODE_PAR_CORRESPONDING_STABLE_ERR:
       return "corresponding super table not in this db";
+    case TSDB_CODE_PAR_INVALID_RANGE_OPTION:
+      return "invalid option %s: %"PRId64" valid range: [%d, %d]";
+    case TSDB_CODE_PAR_INVALID_STR_OPTION:
+      return "invalid option %s: %s";
+    case TSDB_CODE_PAR_INVALID_ENUM_OPTION:
+      return "invalid option %s: %"PRId64", only %d, %d allowed";
+    case TSDB_CODE_PAR_INVALID_TTL_OPTION:
+      return "invalid option ttl: %"PRId64", should be greater than or equal to %d";
+    case TSDB_CODE_PAR_INVALID_KEEP_NUM:
+      return "invalid number of keep options";
+    case TSDB_CODE_PAR_INVALID_KEEP_ORDER:
+      return "invalid keep value, should be keep0 <= keep1 <= keep2";
+    case TSDB_CODE_PAR_INVALID_KEEP_VALUE:
+      return "invalid option keep: %d, %d, %d valid range: [%d, %d]";
+    case TSDB_CODE_PAR_INVALID_COMMENT_OPTION:
+      return "invalid option comment, length cannot exceed %d";
+    case TSDB_CODE_PAR_INVALID_F_RANGE_OPTION:
+      return "invalid option %s: %f valid range: [%d, %d]";
+    case TSDB_CODE_PAR_INVALID_ROLLUP_OPTION:
+      return "invalid option rollup: only one function is allowed";
+    case TSDB_CODE_PAR_INVALID_RETENTIONS_OPTION:
+      return "invalid option retentions";
     case TSDB_CODE_OUT_OF_MEMORY:
       return "Out of memory";
     default:

source/libs/parser/test/parserAstTest.cpp

@@ -446,6 +446,12 @@ TEST_F(ParserTest, createDatabase) {
        "RETENTIONS '15s:7d,1m:21d,15m:5y'"
       );
   ASSERT_TRUE(run());
+
+  bind("create database if not exists wxy_db "
+       "DAYS 100m "
+       "KEEP 200m,300h,400d "
+      );
+  ASSERT_TRUE(run());
 }
 
 TEST_F(ParserTest, alterDatabase) {

source/libs/planner/src/planLogicCreater.c

@@ -701,7 +701,7 @@ static int32_t createDistinctLogicNode(SLogicPlanContext* pCxt, SSelectStmt* pSe
 
   // rewrite the expression in subsequent clauses
   if (TSDB_CODE_SUCCESS == code) {
-    code = rewriteExpr(pAgg->pGroupKeys, pSelect, SQL_CLAUSE_SELECT);
+    code = rewriteExpr(pAgg->pGroupKeys, pSelect, SQL_CLAUSE_DISTINCT);
   }
 
   // set the output

source/libs/planner/src/planPhysiCreater.c

@@ -928,8 +928,12 @@ static int32_t createSortPhysiNode(SPhysiPlanContext* pCxt, SNodeList* pChildren
 
   if (TSDB_CODE_SUCCESS == code) {
     code = setListSlotId(pCxt, pChildTupe->dataBlockId, -1, pSortKeys, &pSort->pSortKeys);
+  }
+
+  if (TSDB_CODE_SUCCESS == code) {
+    code = setListSlotId(pCxt, pChildTupe->dataBlockId, -1, pSortLogicNode->node.pTargets, &pSort->pTargets);
     if (TSDB_CODE_SUCCESS == code) {
-      code = addDataBlockSlots(pCxt, pSort->pSortKeys, pSort->node.pOutputDataBlockDesc);
+      code = addDataBlockSlots(pCxt, pSort->pTargets, pSort->node.pOutputDataBlockDesc);
     }
   }
 
@@ -963,8 +967,12 @@ static int32_t createPartitionPhysiNode(SPhysiPlanContext* pCxt, SNodeList* pChi
 
   if (TSDB_CODE_SUCCESS == code) {
     code = setListSlotId(pCxt, pChildTupe->dataBlockId, -1, pPartitionKeys, &pPart->pPartitionKeys);
+  }
+
+  if (TSDB_CODE_SUCCESS == code) {
+    code = setListSlotId(pCxt, pChildTupe->dataBlockId, -1, pPartLogicNode->node.pTargets, &pPart->pTargets);
     if (TSDB_CODE_SUCCESS == code) {
-      code = addDataBlockSlots(pCxt, pPart->pPartitionKeys, pPart->node.pOutputDataBlockDesc);
+      code = addDataBlockSlots(pCxt, pPart->pTargets, pPart->node.pOutputDataBlockDesc);
     }
   }
 

source/libs/planner/test/plannerTest.cpp

@@ -254,6 +254,9 @@ TEST_F(PlannerTest, orderBy) {
 
   bind("SELECT * FROM t1 order by c1 + 10, c2");
   ASSERT_TRUE(run());
+
+  bind("SELECT * FROM t1 order by c1 desc nulls first");
+  ASSERT_TRUE(run());
 }
 
 TEST_F(PlannerTest, distinct) {

tests/script/jenkins/basic.txt

@@ -31,6 +31,7 @@
 ./test.sh -f tsim/query/interval.sim
 ./test.sh -f tsim/query/interval-offset.sim
 ./test.sh -f tsim/query/scalarFunction.sim
+./test.sh -f tsim/query/charScalarFunction.sim
 
 # ---- show
 ./test.sh -f tsim/show/basic.sim

tests/script/tsim/query/charScalarFunction.sim

+#### length, char_length, lower, upper, ltrim, rtrim, concat, concat_ws, substr.
+
+system sh/stop_dnodes.sh
+system sh/deploy.sh -n dnode1 -i 1
+system sh/cfg.sh -n dnode1
+system sh/exec.sh -n dnode1 -s start
+
+$loop_cnt = 0
+check_dnode_ready:
+	$loop_cnt = $loop_cnt + 1
+	sleep 200
+	if $loop_cnt == 10 then
+	  print ====> dnode not ready!
+		return -1
+	endi
+sql show dnodes
+print ===> $rows $data00 $data01 $data02 $data03 $data04 $data05
+if $data00 != 1 then
+  return -1
+endi
+if $data04 != ready then
+  goto check_dnode_ready
+endi
+
+sql connect
+
+$vgroups  = 4
+$dbNamme  = db
+
+print =============== create database $dbNamme vgroups $vgroups
+sql create database $dbNamme vgroups $vgroups
+sql show databases
+print $data00 $data01 $data02 $data03 $data04 $data05 $data06 $data07 $data08 $data09
+print $data10 $data11 $data12 $data13 $data14 $data15 $data16 $data17 $data18 $data19
+#print $data20 $data21 $data22 $data23 $data24 $data25 $data26 $data27 $data28 $data29
+
+sql use $dbNamme
+
+print =============== create super table
+sql create table stb (ts timestamp, c1 binary(128), c2 nchar(128)) tags (t1 binary(128), t2 nchar(128))
+
+print =============== create child table and normal table, insert data
+sql create table ctb0 using stb tags("tag-binary-0" , "tag-nchar-0" )
+sql create table ntb0 (ts timestamp, c1 binary(128), c2 nchar(128))
+sql insert into ctb0 values ("2022-01-01 00:00:00.000" , "lenByte0=11" , "lenByte0=44" )
+sql insert into ntb0 values ("2022-01-01 00:00:00.000" , "lenByte0=11" , "lenByte0=44" )
+sql insert into ctb0 values ("2022-01-01 00:00:00.001" , "lenByte01=12" , "lenByte01=48" )
+sql insert into ntb0 values ("2022-01-01 00:00:00.001" , "lenByte01=12" , "lenByte01=48" )
+sql insert into ctb0 values ("2022-01-01 00:00:00.002" , "lenChar01=12" , "lenChar01=48" )
+sql insert into ntb0 values ("2022-01-01 00:00:00.002" , "lenChar01=12" , "lenChar01=48" )
+sql insert into ctb0 values ("2022-01-01 00:00:00.003" , "lenChar0001=14" , "lenChar0001=56" )
+sql insert into ntb0 values ("2022-01-01 00:00:00.003" , "lenChar0001=14" , "lenChar0001=56" )
+
+sql create table ctb1 using stb tags("tag-binary-1" , "tag-nchar-1" )
+sql create table ntb1 (ts timestamp, c1 binary(128), c2 nchar(128))
+sql insert into ctb1 values ("2022-01-01 00:00:00.000" , "ABCD1234" , "ABCD1234" )
+sql insert into ntb1 values ("2022-01-01 00:00:00.000" , "ABCD1234" , "ABCD1234" )
+sql insert into ctb1 values ("2022-01-01 00:00:00.001" , "AaBbCcDd1234" , "AaBbCcDd1234" )
+sql insert into ntb1 values ("2022-01-01 00:00:00.001" , "AaBbCcDd1234" , "AaBbCcDd1234" )
+
+sql create table ctb2 using stb tags("tag-binary-2" , "tag-nchar-2" )
+sql create table ntb2 (ts timestamp, c1 binary(128), c2 nchar(128))
+sql insert into ctb2 values ("2022-01-01 00:00:00.000" , "abcd1234" , "abcd1234" )
+sql insert into ntb2 values ("2022-01-01 00:00:00.000" , "abcd1234" , "abcd1234" )
+sql insert into ctb2 values ("2022-01-01 00:00:00.001" , "AaBbCcDd1234" , "AaBbCcDd1234" )
+sql insert into ntb2 values ("2022-01-01 00:00:00.001" , "AaBbCcDd1234" , "AaBbCcDd1234" )
+
+sql create table ctb3 using stb tags("tag-binary-3" , "tag-nchar-3" )
+sql create table ntb3 (ts timestamp, c1 binary(128), c2 nchar(128))
+sql insert into ctb3 values ("2022-01-01 00:00:00.000" , "  abcd  1234  " , "  abcd  1234  " )
+sql insert into ntb3 values ("2022-01-01 00:00:00.000" , "  abcd  1234  " , "  abcd  1234  " )
+
+sql create table stb2 (ts timestamp, c1 binary(128), c2 nchar(128), c3 binary(128), c4 nchar(128)) tags (t1 binary(128), t2 nchar(128), t3 binary(128), t4 nchar(128))
+sql create table ctb4 using stb2 tags("tag-binary-4" , "tag-nchar-4", "tag-binary-4" , "tag-nchar-4")
+sql create table ntb4 (ts timestamp, c1 binary(128), c2 nchar(128), c3 binary(128), c4 nchar(128))
+sql insert into ctb4 values ("2022-01-01 00:00:00.000" , " ab 12 " , " ab 12 " , " cd 34 " , " cd 34 "  )
+sql insert into ntb4 values ("2022-01-01 00:00:00.000" , " ab 12 " , " ab 12 " , " cd 34 " , " cd 34 "  )
+
+sql create table ctb5 using stb tags("tag-binary-5" , "tag-nchar-5")
+sql create table ntb5 (ts timestamp, c1 binary(128), c2 nchar(128))
+sql insert into ctb5 values ("2022-01-01 00:00:00.000" , "0123456789" , "0123456789" )
+sql insert into ntb5 values ("2022-01-01 00:00:00.000" , "0123456789" , "0123456789" )
+sql insert into ctb5 values ("2022-01-01 00:00:00.001" , NULL , NULL )
+sql insert into ntb5 values ("2022-01-01 00:00:00.001" , NULL , NULL )
+
+$loop_test = 0
+loop_test_pos:
+
+print ====> length
+print ====> select c1, length(c1), c2, length(c2) from ctb0
+sql select c1, length(c1), c2, length(c2) from ctb0
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05
+print ====> $data10 $data11 $data12 $data13 $data14 $data15
+print ====> $data20 $data21 $data22 $data23 $data24 $data25
+print ====> $data30 $data31 $data32 $data33 $data34 $data35
+if $rows != 4 then
+  return -1
+endi
+if $data01 != 11 then
+  return -1
+endi
+if $data03 != 44 then
+  return -1
+endi
+if $data11 != 12 then
+  return -1
+endi
+if $data13 != 48 then
+  return -1
+endi
+
+print ====> select c1, length(c1), c2, length(c2) from ntb0
+sql select c1, length(c1), c2, length(c2) from ntb0
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05
+print ====> $data10 $data11 $data12 $data13 $data14 $data15
+print ====> $data20 $data21 $data22 $data23 $data24 $data25
+print ====> $data30 $data31 $data32 $data33 $data34 $data35
+if $rows != 4 then
+  return -1
+endi
+if $data01 != 11 then
+  return -1
+endi
+if $data03 != 44 then
+  return -1
+endi
+if $data11 != 12 then
+  return -1
+endi
+if $data13 != 48 then
+  return -1
+endi
+
+print ====> select length("abcd1234"), char_length("abcd1234=-+*") from ntb0
+sql select length("abcd1234"), char_length("abcd1234=-+*") from ntb0
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05
+print ====> $data10 $data11 $data12 $data13 $data14 $data15
+print ====> $data20 $data21 $data22 $data23 $data24 $data25
+print ====> $data30 $data31 $data32 $data33 $data34 $data35
+if $rows != 4 then
+  return -1
+endi
+if $data00 != 8 then
+  return -1
+endi
+if $data01 != 12 then
+  return -1
+endi
+
+#sql_error select c1, length(t1), c2, length(t2) from ctb0
+
+print ====> char_length
+print ====> select c1, char_length(c1), c2, char_length(c2) from ctb0
+sql select c1, char_length(c1), c2, char_length(c2) from ctb0
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05
+print ====> $data10 $data11 $data12 $data13 $data14 $data15
+print ====> $data20 $data21 $data22 $data23 $data24 $data25
+print ====> $data30 $data31 $data32 $data33 $data34 $data35
+if $rows != 4 then
+  return -1
+endi
+if $data21 != 12 then
+  return -1
+endi
+if $data23 != 12 then
+  return -1
+endi
+if $data31 != 14 then
+  return -1
+endi
+if $data33 != 14 then
+  return -1
+endi
+
+print ====> select c1, char_length(c1), c2, char_length(c2) from ntb0
+sql select c1, char_length(c1), c2, char_length(c2) from ntb0
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05
+print ====> $data10 $data11 $data12 $data13 $data14 $data15
+print ====> $data20 $data21 $data22 $data23 $data24 $data25
+print ====> $data30 $data31 $data32 $data33 $data34 $data35
+if $rows != 4 then
+  return -1
+endi
+if $data21 != 12 then
+  return -1
+endi
+if $data23 != 12 then
+  return -1
+endi
+if $data31 != 14 then
+  return -1
+endi
+if $data33 != 14 then
+  return -1
+endi
+
+#sql_error select c1, char_length(t1), c2, char_length(t2) from ctb0
+
+print ====> lower
+sql select c1, lower(c1), c2, lower(c2), lower("abcdEFGH=-*&%") from ntb1
+print ====> select c1, lower(c1), c2, lower(c2), lower("abcdEFGH=-*&%") from ctb1
+sql select c1, lower(c1), c2, lower(c2), lower("abcdEFGH=-*&%") from ctb1
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05
+print ====> $data10 $data11 $data12 $data13 $data14 $data15
+if $rows != 2 then
+  return -1
+endi
+if $data01 != abcd1234 then
+  return -1
+endi
+if $data03 != abcd1234 then
+  return -1
+endi
+if $data04 != abcdefgh=-*&% then
+  return -1
+endi
+if $data11 != aabbccdd1234 then
+  return -1
+endi
+if $data13 != aabbccdd1234 then
+  return -1
+endi
+if $data14 != abcdefgh=-*&% then
+  return -1
+endi
+
+#sql_error select c1, lower(t1), c2, lower(t2) from ctb1
+
+print ====> upper
+sql select c1, upper(c1), c2, upper(c2), upper("abcdEFGH=-*&%") from ntb2
+print ====> select c1, upper(c1), c2, upper(c2), upper("abcdEFGH=-*&%") from ctb2
+sql select c1, upper(c1), c2, upper(c2), upper("abcdEFGH=-*&%") from ctb2
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05
+print ====> $data10 $data11 $data12 $data13 $data14 $data15
+if $rows != 2 then
+  return -1
+endi
+if $data01 != ABCD1234 then
+  return -1
+endi
+if $data03 != ABCD1234 then
+  return -1
+endi
+if $data04 != ABCDEFGH=-*&% then
+  return -1
+endi
+if $data11 != AABBCCDD1234 then
+  return -1
+endi
+if $data13 != AABBCCDD1234 then
+  return -1
+endi
+if $data14 != ABCDEFGH=-*&% then
+  return -1
+endi
+
+#sql_error select c1, upper(t1), c2, upper(t2) from ctb2
+
+print ====> ltrim
+sql select c1, ltrim(c1), c2, ltrim(c2), ltrim("  abcdEFGH  =-*&%  ") from ntb3
+print ====> select c1, ltrim(c1), c2, ltrim(c2), ltrim("  abcdEFGH  =-*&%  ") from ctb3
+sql select c1, ltrim(c1), c2, ltrim(c2), ltrim("  abcdEFGH  =-*&%  ") from ctb3
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05
+print ====> $data10 $data11 $data12 $data13 $data14 $data15
+if $rows != 1 then
+  return -1
+endi
+if $data01 != @abcd  1234  @ then
+  return -1
+endi
+if $data03 != @abcd  1234  @ then
+  return -1
+endi
+if $data04 != @abcdEFGH  =-*&%  @ then
+  return -1
+endi
+
+#sql_error select c1, ltrim(t1), c2, ltrim(t2) from ctb3
+
+
+#print ====> rtrim
+#sql select c1, rtrim(c1), c2, rtrim(c2), rtrim("  abcdEFGH  =-*&%  ") from ntb3
+#print ====> select c1, rtrim(c1), c2, rtrim(c2), rtrim("  abcdEFGH  =-*&%  ") from ctb3
+#sql select c1, rtrim(c1), c2, rtrim(c2), rtrim("  abcdEFGH  =-*&%  ") from ctb3
+#print ====> rows: $rows
+#print ====> [ $data00 ] [ $data01 ] [ $data02 ] [ $data03 ] [ $data04 ] [ $data05 ] [ $data06 ]
+#print ====> $data10 $data11 $data12 $data13 $data14 $data15
+#if $rows != 1 then
+#  return -1
+#endi
+#if $data01 != @  abcd  1234@ then
+#  return -1
+#endi
+#if $data03 != @  abcd  1234@ then
+#  return -1
+#endi
+#if $data04 != @  abcdEFGH  =-*&%@ then
+#  return -1
+#endi
+
+#sql_error select c1, rtrim(t1), c2, rtrim(t2) from ctb3
+
+print ====> concat
+sql select c1, c3, concat(c1, c3), c2, c4, concat(c2, c4), concat("binary+", c1, c3), concat("nchar+", c2, c4) from ntb4
+print ====> select c1, c3, concat(c1, c3), c2, c4, concat(c2, c4), concat("binary+", c1, c3), concat("nchar+", c2, c4) from ctb4
+sql select c1, c3, concat(c1, c3), c2, c4, concat(c2, c4), concat("binary+", c1, c3), concat("nchar+", c2, c4) from ctb4
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05 $data06
+print ====> $data10 $data11 $data12 $data13 $data14 $data15 $data16
+if $rows != 1 then
+  return -1
+endi
+if $data02 != @ ab 12  cd 34 @ then
+  return -1
+endi
+if $data05 != @ ab 12  cd 34 @ then
+  return -1
+endi
+if $data06 != @binary+ ab 12  cd 34 @ then
+  return -1
+endi
+if $data07 != @nchar+ ab 12  cd 34 @ then
+  return -1
+endi
+
+sql select c1, c3, concat("bin-", c1, "-a1-", "a2-", c3, "-a3-", "a4-", "END"), c2, c4, concat("nchar-", c2, "-a1-", "-a2-", c4, "-a3-", "a4-", "END") from ntb4
+print ====> select c1, c3, concat("bin-", c1, "-a1-", "a2-", c3, "-a3-", "a4-", "END"), c2, c4, concat("nchar-", c2, "-a1-", "a2-", c4, "-a3-", "a4-", "END") from ctb4
+sql select c1, c3, concat("bin-", c1, "-a1-", "a2-", c3, "-a3-", "a4-", "END"), c2, c4, concat("nchar-", c2, "-a1-", "a2-", c4, "-a3-", "a4-", "END") from ctb4
+print ====> rows: $rows
+print ====> [ $data00 ] [ $data01 ] [ $data02 ] [ $data03 ] [ $data04 ] [ $data05 ] [ $data06 ]
+print ====> $data10 $data11 $data12 $data13 $data14 $data15 $data16
+if $rows != 1 then
+  return -1
+endi
+if $data02 != @bin- ab 12 -a1-a2- cd 34 -a3-a4-END@ then
+  return -1
+endi
+if $data05 != @nchar- ab 12 -a1-a2- cd 34 -a3-a4-END@ then
+  return -1
+endi
+
+#sql_error select c1, c2, concat(c1, c2), c3, c4, concat(c3, c4) from ctb4
+#sql_error select t1, t2, concat(t1, t2), t3, t4, concat(t3, t4) from ctb4
+#sql_error select t1, t3, concat(t1, t3), t2, t4, concat(t2, t4) from ctb4
+
+print ====> concat_ws
+sql select c1, c3, concat_ws("*", c1, c3), c2, c4, concat_ws("*", c2, c4), concat_ws("*", "binary+", c1, c3), concat_ws("*", "nchar+", c2, c4) from ntb4
+print ====> select c1, c3, concat_ws("*", c1, c3), c2, c4, concat_ws("*", c2, c4), concat_ws("*", "binary+", c1, c3), concat_ws("*", "nchar+", c2, c4) from ctb4
+sql select c1, c3, concat_ws("*", c1, c3), c2, c4, concat_ws("*", c2, c4), concat_ws("*", "binary+", c1, c3), concat_ws("*", "nchar+", c2, c4) from ctb4
+print ====> rows: $rows
+print ====> $data00 $data01 $data02 $data03 $data04 $data05 $data06
+print ====> $data10 $data11 $data12 $data13 $data14 $data15 $data16
+if $rows != 1 then
+  return -1
+endi
+if $data02 != @ ab 12 * cd 34 @ then
+  return -1
+endi
+if $data05 != @ ab 12 * cd 34 @ then
+  return -1
+endi
+if $data06 != @binary+* ab 12 * cd 34 @ then
+  return -1
+endi
+if $data07 != @nchar+* ab 12 * cd 34 @ then
+  return -1
+endi
+
+print ====> select c1, c3, concat_ws("*", "b0", c1, "b1", c3, "b2", "E0", "E1", "E2"), c2, c4, concat_ws("*", "n0", c2, c4, "n1", c2, c4, "n2", "END") from ctb4
+sql select c1, c3, concat_ws("*", "b0", c1, "b1", c3, "b2", "E0", "E1", "E2"), c2, c4, concat_ws("*", "n0", c2, c4, "n1", c2, c4, "n2", "END") from ctb4
+print ====> rows: $rows
+print ====> [ $data00 ] [ $data01 ] [ $data02 ] [ $data03 ] [ $data04 ] [ $data05 ] [ $data06 ]
+print ====> $data10 $data11 $data12 $data13 $data14 $data15 $data16
+if $rows != 1 then
+  return -1
+endi
+if $data02 != @b0* ab 12 *b1* cd 34 *b2*E0*E1*E2@ then
+  return -1
+endi
+if $data05 != @n0* ab 12 * cd 34 *n1* ab 12 * cd 34 *n2*END@ then
+  return -1
+endi
+
+#sql_error select c1, c2, concat_ws("*", c1, c2), c3, c4, concat_ws("*", c3, c4) from ctb4
+#sql_error select t1, t2, concat_ws("*", t1, t2), t3, t4, concat_ws("*", t3, t4) from ctb4
+#sql_error select t1, t3, concat_ws("*", t1, t3), t2, t4, concat_ws("*", t2, t4) from ctb4
+
+
+print ====> substr
+#sql select c1, substr(c1, 3, 3), substr(c1, -5, 3), c2, substr(c2, 3, 3), substr(c2, -5, 3), substr("abcdefg", 3, 3), substr("abcdefg", -3, 3) from ntb5
+#print ====> select c1, substr(c1, 3, 3), substr(c1, -5, 3), c2, substr(c2, 3, 3), substr(c2, -5, 3), substr("abcdefg", 3, 3), substr("abcdefg", -3, 3) from ctb5
+#sql select c1, substr(c1, 3, 3), substr(c1, -5, 3), c2, substr(c2, 3, 3), substr(c2, -5, 3), substr("abcdefg", 3, 3), substr("abcdefg", -3, 3) from ctb5
+#print ====> rows: $rows
+#print ====> $data00 $data01 $data02 $data03 $data04 $data05 $data06
+#print ====> $data10 $data11 $data12 $data13 $data14 $data15 $data16
+#if $rows != 1 then
+#  return -1
+#endi
+#if $data01 != 345 then
+#  return -1
+#endi
+#if $data02 != 456 then
+#  return -1
+#endi
+#if $data04 != 345 then
+#  return -1
+#endi
+#if $data05 != 456 then
+#  return -1
+#endi
+#if $data06 != def then
+#  return -1
+#endi
+#if $data07 != efg then
+#  return -1
+#endi
+#if $data11 != NULL then
+#  return -1
+#endi
+#if $data12 != NULL then
+#  return -1
+#endi
+#if $data14 != NULL then
+#  return -1
+#endi
+#if $data15 != NULL then
+#  return -1
+#endi
+#if $data16 != def then
+#  return -1
+#endi
+#if $data17 != efg then
+#  return -1
+#endi
+#
+#sql select c1, substr(c1, 3), substr(c1, -5), c2, substr(c2, 3), substr(c2, -5), substr("abcdefg", 3), substr("abcdefg", -3) from ntb5
+#print ====> select c1, substr(c1, 3), substr(c1, -5), c2, substr(c2, 3), substr(c2, -5), substr("abcdefg", 3), substr("abcdefg", -3) from ctb5
+#sql select c1, substr(c1, 3), substr(c1, -5), c2, substr(c2, 3), substr(c2, -5), substr("abcdefg", 3), substr("abcdefg", -3) from ctb5
+#print ====> rows: $rows
+#print ====> $data00 $data01 $data02 $data03 $data04 $data05 $data06
+#print ====> $data10 $data11 $data12 $data13 $data14 $data15 $data16
+#if $rows != 1 then
+#  return -1
+#endi
+#if $data01 != 3456789 then
+#  return -1
+#endi
+#if $data02 != 456789 then
+#  return -1
+#endi
+#if $data04 != 3456789 then
+#  return -1
+#endi
+#if $data05 != 456789 then
+#  return -1
+#endi
+#if $data06 != defg then
+#  return -1
+#endi
+#if $data07 != efg then
+#  return -1
+#endi
+#if $data11 != NULL then
+#  return -1
+#endi
+#if $data12 != NULL then
+#  return -1
+#endi
+#if $data14 != NULL then
+#  return -1
+#endi
+#if $data15 != NULL then
+#  return -1
+#endi
+#if $data16 != defg then
+#  return -1
+#endi
+#if $data17 != efg then
+#  return -1
+#endi
+
+#sql_error select t1, substr(t1, 3, 2), substr(t1, -3, 2), t2, substr(t2, 3, 2), substr(t2, -3, 2) from ctb5
+
+if $loop_test == 0 then
+  print =============== stop and restart taosd
+  system sh/exec.sh -n dnode1 -s stop -x SIGINT
+  system sh/exec.sh -n dnode1 -s start
+  
+  $loop_cnt = 0
+  check_dnode_ready_0:
+  	$loop_cnt = $loop_cnt + 1
+  	sleep 200
+  	if $loop_cnt == 10 then
+  	  print ====> dnode not ready!
+  		return -1
+  	endi
+  sql show dnodes
+  print ===> $rows $data00 $data01 $data02 $data03 $data04 $data05
+  if $data00 != 1 then
+    return -1
+  endi
+  if $data04 != ready then
+    goto check_dnode_ready_0
+  endi
+
+  $loop_test = 1  
+  goto loop_test_pos
+endi
+
+#system sh/exec.sh -n dnode1 -s stop -x SIGINT

tests/test/c/tmqSim.c

@@ -274,6 +274,10 @@ int main(int32_t argc, char *argv[]) {
   
   loop_consume(tmq);
 
+  err = tmq_unsubscribe(tmq);
+  ASSERT(err == TMQ_RESP_ERR__SUCCESS);
+
+
   #if 0
   err = tmq_unsubscribe(tmq);
   if (err) {