[TD-93] sort out error codes

src/client/src/tscServer.c

@@ -233,7 +233,7 @@ void tscProcessMsgFromServer(SRpcMsg *rpcMsg) {
     STableMetaInfo *pTableMetaInfo = tscGetTableMetaInfoFromCmd(pCmd, pCmd->clauseIndex, 0);
     if (rpcMsg->code == TSDB_CODE_NOT_ACTIVE_TABLE || rpcMsg->code == TSDB_CODE_INVALID_TABLE_ID ||
         rpcMsg->code == TSDB_CODE_INVALID_VNODE_ID || rpcMsg->code == TSDB_CODE_NOT_ACTIVE_VNODE ||
-        rpcMsg->code == TSDB_CODE_NETWORK_UNAVAIL || rpcMsg->code == TSDB_CODE_NOT_ACTIVE_SESSION ||
+        rpcMsg->code == TSDB_CODE_NETWORK_UNAVAIL || rpcMsg->code == TSDB_CODE_NOT_ACTIVE_TABLE ||
         rpcMsg->code == TSDB_CODE_TABLE_ID_MISMATCH) {
       /*
        * not_active_table: 1. the virtual node may fail to create table, since the procedure of create table is asynchronized,

src/mnode/src/mgmtDnode.c

@@ -147,8 +147,7 @@ void *  mgmtGetNextDnode(void *pNode, SDnodeObj **pDnode) {
 
 void mgmtProcessCfgDnodeMsg(SQueuedMsg *pMsg) {
   SRpcMsg rpcRsp = {.handle = pMsg->thandle, .pCont = NULL, .contLen = 0, .code = 0, .msgType = 0};
-  if (mgmtCheckRedirect(pMsg->thandle)) return;
-
+  
   SCMCfgDnodeMsg *pCmCfgDnode = pMsg->pCont;
   if (pCmCfgDnode->ip[0] == 0) {
     strcpy(pCmCfgDnode->ip, tsPrivateIp);
@@ -176,14 +175,14 @@ void mgmtProcessCfgDnodeMsg(SQueuedMsg *pMsg) {
   }
 
   if (rpcRsp.code == TSDB_CODE_SUCCESS) {
-    mTrace("dnode:%s is configured by %s", pCmCfgDnode->ip, pMsg->pUser->user);
+    mPrint("dnode:%s, is configured by %s", pCmCfgDnode->ip, pMsg->pUser->user);
   }
 
   rpcSendResponse(&rpcRsp);
 }
 
 static void mgmtProcessCfgDnodeMsgRsp(SRpcMsg *rpcMsg) {
-  mTrace("cfg vnode rsp is received");
+  mPrint("cfg vnode rsp is received");
 }
 
 void mgmtProcessDnodeStatusMsg(SRpcMsg *rpcMsg) {

src/mnode/src/mgmtUser.c

@@ -168,7 +168,7 @@ int32_t mgmtCreateUser(SAcctObj *pAcct, char *name, char *pass) {
   }
 
   if (name[0] == 0 || pass[0] == 0) {
-    return TSDB_CODE_INVALID_MSG;
+    return TSDB_CODE_INVALID_MSG_CONTENT;
   }
 
   SUserObj *pUser = mgmtGetUser(name);

src/util/src/tglobalcfg.c

@@ -20,6 +20,7 @@
 #include "tkey.h"
 #include "tlog.h"
 #include "taosdef.h"
+#include "taoserror.h"
 #include "tsocket.h"
 #include "tsystem.h"
 #include "tutil.h"
@@ -994,7 +995,7 @@ int tsCfgDynamicOptions(char *msg) {
   int   vint = 0;
 
   paGetToken(msg, &option, &olen);
-  if (olen == 0) return 0;
+  if (olen == 0) return code;
 
   paGetToken(option + olen + 1, &value, &vlen);
   if (vlen == 0)

tests/script/sh/deploy.sh

@@ -90,7 +90,7 @@ echo "logDir              $LOG_DIR"       >> $TAOS_CFG
 echo "publicIp            $NODE_IP"       >> $TAOS_CFG
 echo "internalIp          $NODE_IP"       >> $TAOS_CFG
 echo "privateIp           $NODE_IP"       >> $TAOS_CFG
-echo "dDebugFlag          135"            >> $TAOS_CFG
+echo "dDebugFlag          199"            >> $TAOS_CFG
 echo "mDebugFlag          199"            >> $TAOS_CFG
 echo "sdbDebugFlag        199"            >> $TAOS_CFG
 echo "rpcDebugFlag        135"            >> $TAOS_CFG

tests/script/unique/dnodes/basic1.sim

@@ -31,3 +31,60 @@ endi
 if $data01 != 192.168.0.1 then 
   return -1
 endi
+
+print =============== create dnodes
+sql create dnode 192.168.0.2
+sql show dnodes;
+if $rows != 2 then 
+  return -1
+endi
+
+if $data00 != 1 then 
+  return -1
+endi
+
+if $data01 != 192.168.0.1 then 
+  return -1
+endi
+
+if $data10 != 2 then 
+  return -1
+endi
+
+if $data11 != 192.168.0.2 then 
+  return -1
+endi
+
+sql show mnodes;
+if $rows != 1 then 
+  return -1
+endi
+
+if $data00 != 1 then 
+  return -1
+endi
+
+if $data01 != 192.168.0.1 then 
+  return -1
+endi
+
+print =============== create table
+sql create database d1;
+sql create database d2;
+sql create database d3;
+sql create database d4;
+sql create database d5;
+
+sql create table d1.t1 (ts timestamp, i int);
+sql create table d2.t1 (ts timestamp, i int);
+sql create table d3.t1 (ts timestamp, i int);
+sql create table d4.t1 (ts timestamp, i int);
+
+sql show dnodes;
+if $data05 != 2 then 
+  return -1
+endi
+
+if $data15 != 2 then 
+  return -1
+endi