metaTable.c 24.3 KB
Newer Older
H
more  
Hongze Cheng 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13
/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
H
refact  
Hongze Cheng 已提交
14 15
 */

H
Hongze Cheng 已提交
16
#include "meta.h"
H
refact  
Hongze Cheng 已提交
17

H
Hongze Cheng 已提交
18 19 20 21 22 23 24
static int metaHandleEntry(SMeta *pMeta, const SMetaEntry *pME);
static int metaSaveToTbDb(SMeta *pMeta, const SMetaEntry *pME);
static int metaUpdateUidIdx(SMeta *pMeta, const SMetaEntry *pME);
static int metaUpdateNameIdx(SMeta *pMeta, const SMetaEntry *pME);
static int metaUpdateTtlIdx(SMeta *pMeta, const SMetaEntry *pME);
static int metaSaveToSkmDb(SMeta *pMeta, const SMetaEntry *pME);
static int metaUpdateCtbIdx(SMeta *pMeta, const SMetaEntry *pME);
H
Hongze Cheng 已提交
25
static int metaUpdateTagIdx(SMeta *pMeta, const SMetaEntry *pCtbEntry);
H
Hongze Cheng 已提交
26 27

int metaCreateSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
H
Hongze Cheng 已提交
28
  SMetaEntry  me = {0};
H
Hongze Cheng 已提交
29 30 31 32 33 34 35
  int         kLen = 0;
  int         vLen = 0;
  const void *pKey = NULL;
  const void *pVal = NULL;
  void       *pBuf = NULL;
  int32_t     szBuf = 0;
  void       *p = NULL;
H
Hongze Cheng 已提交
36 37 38
  SMetaReader mr = {0};

  // validate req
H
Hongze Cheng 已提交
39
  metaReaderInit(&mr, pMeta, 0);
H
Hongze Cheng 已提交
40
  if (metaGetTableEntryByName(&mr, pReq->name) == 0) {
H
Hongze Cheng 已提交
41 42
// TODO: just for pass case
#if 0
H
Hongze Cheng 已提交
43 44 45
    terrno = TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
    metaReaderClear(&mr);
    return -1;
H
Hongze Cheng 已提交
46 47 48 49
#else
    metaReaderClear(&mr);
    return 0;
#endif
H
Hongze Cheng 已提交
50
  }
H
Hongze Cheng 已提交
51
  metaReaderClear(&mr);
H
Hongze Cheng 已提交
52 53

  // set structs
H
Hongze Cheng 已提交
54
  me.version = version;
H
Hongze Cheng 已提交
55 56 57
  me.type = TSDB_SUPER_TABLE;
  me.uid = pReq->suid;
  me.name = pReq->name;
H
Hongze Cheng 已提交
58 59
  me.stbEntry.schema = pReq->schema;
  me.stbEntry.schemaTag = pReq->schemaTag;
H
Hongze Cheng 已提交
60

H
Hongze Cheng 已提交
61
  if (metaHandleEntry(pMeta, &me) < 0) goto _err;
H
Hongze Cheng 已提交
62

H
Hongze Cheng 已提交
63
  metaDebug("vgId:%d super table is created, name:%s uid: %" PRId64, TD_VID(pMeta->pVnode), pReq->name, pReq->suid);
H
Hongze Cheng 已提交
64 65 66 67

  return 0;

_err:
H
Hongze Cheng 已提交
68
  metaError("vgId:%d failed to create super table: %s uid: %" PRId64 " since %s", TD_VID(pMeta->pVnode), pReq->name,
H
Hongze Cheng 已提交
69 70 71 72 73
            pReq->suid, tstrerror(terrno));
  return -1;
}

int metaDropSTable(SMeta *pMeta, int64_t verison, SVDropStbReq *pReq) {
H
Hongze Cheng 已提交
74 75 76
  TBC        *pNameIdxc = NULL;
  TBC        *pUidIdxc = NULL;
  TBC        *pCtbIdxc = NULL;
H
Hongze Cheng 已提交
77 78 79 80 81 82
  SCtbIdxKey *pCtbIdxKey;
  const void *pKey = NULL;
  int         nKey;
  const void *pData = NULL;
  int         nData;
  int         c, ret;
H
Hongze Cheng 已提交
83

H
Hongze Cheng 已提交
84
  // prepare uid idx cursor
H
Hongze Cheng 已提交
85 86
  tdbTbcOpen(pMeta->pUidIdx, &pUidIdxc, &pMeta->txn);
  ret = tdbTbcMoveTo(pUidIdxc, &pReq->suid, sizeof(tb_uid_t), &c);
H
Hongze Cheng 已提交
87 88
  if (ret < 0 || c != 0) {
    terrno = TSDB_CODE_VND_TB_NOT_EXIST;
H
Hongze Cheng 已提交
89
    tdbTbcClose(pUidIdxc);
H
Hongze Cheng 已提交
90 91 92
    goto _err;
  }

H
Hongze Cheng 已提交
93
  // prepare name idx cursor
H
Hongze Cheng 已提交
94 95
  tdbTbcOpen(pMeta->pNameIdx, &pNameIdxc, &pMeta->txn);
  ret = tdbTbcMoveTo(pNameIdxc, pReq->name, strlen(pReq->name) + 1, &c);
H
Hongze Cheng 已提交
96 97 98 99
  if (ret < 0 || c != 0) {
    ASSERT(0);
  }

H
Hongze Cheng 已提交
100 101 102 103
  tdbTbcDelete(pUidIdxc);
  tdbTbcDelete(pNameIdxc);
  tdbTbcClose(pUidIdxc);
  tdbTbcClose(pNameIdxc);
H
Hongze Cheng 已提交
104 105

  // loop to drop each child table
H
Hongze Cheng 已提交
106 107 108 109
  tdbTbcOpen(pMeta->pCtbIdx, &pCtbIdxc, &pMeta->txn);
  ret = tdbTbcMoveTo(pCtbIdxc, &(SCtbIdxKey){.suid = pReq->suid, .uid = INT64_MIN}, sizeof(SCtbIdxKey), &c);
  if (ret < 0 || (c < 0 && tdbTbcMoveToNext(pCtbIdxc) < 0)) {
    tdbTbcClose(pCtbIdxc);
H
Hongze Cheng 已提交
110 111 112 113
    goto _exit;
  }

  for (;;) {
H
Hongze Cheng 已提交
114
    tdbTbcGet(pCtbIdxc, &pKey, &nKey, NULL, NULL);
H
Hongze Cheng 已提交
115 116 117 118 119 120
    pCtbIdxKey = (SCtbIdxKey *)pKey;

    if (pCtbIdxKey->suid > pReq->suid) break;

    // drop the child table (TODO)

H
Hongze Cheng 已提交
121
    if (tdbTbcMoveToNext(pCtbIdxc) < 0) break;
H
Hongze Cheng 已提交
122 123 124 125
  }

_exit:
  metaDebug("vgId:%d  super table %s uid:%" PRId64 " is dropped", TD_VID(pMeta->pVnode), pReq->name, pReq->suid);
H
Hongze Cheng 已提交
126
  return 0;
H
Hongze Cheng 已提交
127 128 129 130 131

_err:
  metaError("vgId:%d failed to drop super table %s uid:%" PRId64 " since %s", TD_VID(pMeta->pVnode), pReq->name,
            pReq->suid, tstrerror(terrno));
  return -1;
H
Hongze Cheng 已提交
132 133
}

H
Hongze Cheng 已提交
134 135 136
int metaAlterSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
  SMetaEntry  oStbEntry = {0};
  SMetaEntry  nStbEntry = {0};
H
Hongze Cheng 已提交
137 138
  TBC        *pUidIdxc = NULL;
  TBC        *pTbDbc = NULL;
H
Hongze Cheng 已提交
139 140 141 142 143 144 145
  const void *pData;
  int         nData;
  int64_t     oversion;
  SDecoder    dc = {0};
  int32_t     ret;
  int32_t     c;

H
Hongze Cheng 已提交
146 147
  tdbTbcOpen(pMeta->pUidIdx, &pUidIdxc, &pMeta->txn);
  ret = tdbTbcMoveTo(pUidIdxc, &pReq->suid, sizeof(tb_uid_t), &c);
H
Hongze Cheng 已提交
148 149 150 151 152
  if (ret < 0 || c) {
    ASSERT(0);
    return -1;
  }

H
Hongze Cheng 已提交
153
  ret = tdbTbcGet(pUidIdxc, NULL, NULL, &pData, &nData);
H
Hongze Cheng 已提交
154 155 156 157 158 159 160
  if (ret < 0) {
    ASSERT(0);
    return -1;
  }

  oversion = *(int64_t *)pData;

H
Hongze Cheng 已提交
161 162
  tdbTbcOpen(pMeta->pTbDb, &pTbDbc, &pMeta->txn);
  ret = tdbTbcMoveTo(pTbDbc, &((STbDbKey){.uid = pReq->suid, .version = oversion}), sizeof(STbDbKey), &c);
H
Hongze Cheng 已提交
163 164
  ASSERT(ret == 0 && c == 0);

H
Hongze Cheng 已提交
165
  ret = tdbTbcGet(pTbDbc, NULL, NULL, &pData, &nData);
H
Hongze Cheng 已提交
166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193
  ASSERT(ret == 0);

  tDecoderInit(&dc, pData, nData);
  metaDecodeEntry(&dc, &oStbEntry);

  nStbEntry.version = version;
  nStbEntry.type = TSDB_SUPER_TABLE;
  nStbEntry.uid = pReq->suid;
  nStbEntry.name = pReq->name;
  nStbEntry.stbEntry.schema = pReq->schema;
  nStbEntry.stbEntry.schemaTag = pReq->schemaTag;

  metaWLock(pMeta);
  // compare two entry
  if (oStbEntry.stbEntry.schema.sver != pReq->schema.sver) {
    if (oStbEntry.stbEntry.schema.nCols != pReq->schema.nCols) {
      metaSaveToSkmDb(pMeta, &nStbEntry);
    }
  }

  // if (oStbEntry.stbEntry.schemaTag.sver != pReq->schemaTag.sver) {
  //   // change tag schema
  // }

  // update table.db
  metaSaveToTbDb(pMeta, &nStbEntry);

  // update uid index
H
Hongze Cheng 已提交
194
  tdbTbcUpsert(pUidIdxc, &pReq->suid, sizeof(tb_uid_t), &version, sizeof(version), 0);
H
Hongze Cheng 已提交
195 196 197

  metaULock(pMeta);
  tDecoderClear(&dc);
H
Hongze Cheng 已提交
198 199
  tdbTbcClose(pTbDbc);
  tdbTbcClose(pUidIdxc);
H
Hongze Cheng 已提交
200 201 202
  return 0;
}

H
Hongze Cheng 已提交
203
int metaCreateTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq) {
H
Hongze Cheng 已提交
204 205
  SMetaEntry  me = {0};
  SMetaReader mr = {0};
H
Hongze Cheng 已提交
206 207 208 209 210

  // validate message
  if (pReq->type != TSDB_CHILD_TABLE && pReq->type != TSDB_NORMAL_TABLE) {
    terrno = TSDB_CODE_INVALID_MSG;
    goto _err;
H
more  
Hongze Cheng 已提交
211 212
  }

H
Hongze Cheng 已提交
213
  // validate req
H
Hongze Cheng 已提交
214
  metaReaderInit(&mr, pMeta, 0);
H
Hongze Cheng 已提交
215
  if (metaGetTableEntryByName(&mr, pReq->name) == 0) {
H
Hongze Cheng 已提交
216 217 218 219
    pReq->uid = mr.me.uid;
    if (pReq->type == TSDB_CHILD_TABLE) {
      pReq->ctb.suid = mr.me.ctbEntry.suid;
    }
H
Hongze Cheng 已提交
220 221 222
    terrno = TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
    metaReaderClear(&mr);
    return -1;
H
Hongze Cheng 已提交
223 224 225
  } else {
    pReq->uid = tGenIdPI64();
    pReq->ctime = taosGetTimestampMs();
H
Hongze Cheng 已提交
226
  }
H
Hongze Cheng 已提交
227
  metaReaderClear(&mr);
H
Hongze Cheng 已提交
228 229

  // build SMetaEntry
H
Hongze Cheng 已提交
230
  me.version = version;
H
Hongze Cheng 已提交
231 232 233 234 235 236 237 238 239 240 241
  me.type = pReq->type;
  me.uid = pReq->uid;
  me.name = pReq->name;
  if (me.type == TSDB_CHILD_TABLE) {
    me.ctbEntry.ctime = pReq->ctime;
    me.ctbEntry.ttlDays = pReq->ttl;
    me.ctbEntry.suid = pReq->ctb.suid;
    me.ctbEntry.pTags = pReq->ctb.pTag;
  } else {
    me.ntbEntry.ctime = pReq->ctime;
    me.ntbEntry.ttlDays = pReq->ttl;
H
Hongze Cheng 已提交
242
    me.ntbEntry.schema = pReq->ntb.schema;
H
Hongze Cheng 已提交
243
    me.ntbEntry.ncid = me.ntbEntry.schema.pSchema[me.ntbEntry.schema.nCols - 1].colId + 1;
H
more  
Hongze Cheng 已提交
244 245
  }

H
Hongze Cheng 已提交
246
  if (metaHandleEntry(pMeta, &me) < 0) goto _err;
H
Hongze Cheng 已提交
247

H
Hongze Cheng 已提交
248 249
  metaDebug("vgId:%d table %s uid %" PRId64 " is created, type:%" PRId8, TD_VID(pMeta->pVnode), pReq->name, pReq->uid,
            pReq->type);
H
refact  
Hongze Cheng 已提交
250
  return 0;
H
Hongze Cheng 已提交
251 252 253 254 255

_err:
  metaError("vgId:%d failed to create table:%s type:%s since %s", TD_VID(pMeta->pVnode), pReq->name,
            pReq->type == TSDB_CHILD_TABLE ? "child table" : "normal table", tstrerror(terrno));
  return -1;
H
refact  
Hongze Cheng 已提交
256 257
}

H
Hongze Cheng 已提交
258
int metaDropTable(SMeta *pMeta, int64_t version, SVDropTbReq *pReq) {
H
Hongze Cheng 已提交
259 260 261
  TBC        *pTbDbc = NULL;
  TBC        *pUidIdxc = NULL;
  TBC        *pNameIdxc = NULL;
H
Hongze Cheng 已提交
262 263 264 265 266
  const void *pData;
  int         nData;
  tb_uid_t    uid;
  int64_t     tver;
  SMetaEntry  me = {0};
H
Hongze Cheng 已提交
267
  SDecoder    coder = {0};
H
Hongze Cheng 已提交
268 269 270
  int8_t      type;
  int64_t     ctime;
  tb_uid_t    suid;
H
Hongze Cheng 已提交
271
  int         c = 0, ret;
H
Hongze Cheng 已提交
272 273

  // search & delete the name idx
H
Hongze Cheng 已提交
274 275 276 277
  tdbTbcOpen(pMeta->pNameIdx, &pNameIdxc, &pMeta->txn);
  ret = tdbTbcMoveTo(pNameIdxc, pReq->name, strlen(pReq->name) + 1, &c);
  if (ret < 0 || !tdbTbcIsValid(pNameIdxc) || c) {
    tdbTbcClose(pNameIdxc);
H
Hongze Cheng 已提交
278
    terrno = TSDB_CODE_VND_TABLE_NOT_EXIST;
H
more  
Hongze Cheng 已提交
279 280 281
    return -1;
  }

H
Hongze Cheng 已提交
282
  ret = tdbTbcGet(pNameIdxc, NULL, NULL, &pData, &nData);
H
Hongze Cheng 已提交
283 284
  if (ret < 0) {
    ASSERT(0);
H
more  
Hongze Cheng 已提交
285 286
    return -1;
  }
H
Hongze Cheng 已提交
287 288 289

  uid = *(tb_uid_t *)pData;

H
Hongze Cheng 已提交
290 291
  tdbTbcDelete(pNameIdxc);
  tdbTbcClose(pNameIdxc);
H
Hongze Cheng 已提交
292 293

  // search & delete uid idx
H
Hongze Cheng 已提交
294 295
  tdbTbcOpen(pMeta->pUidIdx, &pUidIdxc, &pMeta->txn);
  ret = tdbTbcMoveTo(pUidIdxc, &uid, sizeof(uid), &c);
H
Hongze Cheng 已提交
296 297 298 299 300
  if (ret < 0 || c != 0) {
    ASSERT(0);
    return -1;
  }

H
Hongze Cheng 已提交
301
  ret = tdbTbcGet(pUidIdxc, NULL, NULL, &pData, &nData);
H
Hongze Cheng 已提交
302 303 304 305 306 307
  if (ret < 0) {
    ASSERT(0);
    return -1;
  }

  tver = *(int64_t *)pData;
H
Hongze Cheng 已提交
308 309
  tdbTbcDelete(pUidIdxc);
  tdbTbcClose(pUidIdxc);
H
Hongze Cheng 已提交
310 311

  // search and get meta entry
H
Hongze Cheng 已提交
312 313
  tdbTbcOpen(pMeta->pTbDb, &pTbDbc, &pMeta->txn);
  ret = tdbTbcMoveTo(pTbDbc, &(STbDbKey){.uid = uid, .version = tver}, sizeof(STbDbKey), &c);
H
Hongze Cheng 已提交
314 315 316 317 318
  if (ret < 0 || c != 0) {
    ASSERT(0);
    return -1;
  }

H
Hongze Cheng 已提交
319
  ret = tdbTbcGet(pTbDbc, NULL, NULL, &pData, &nData);
H
Hongze Cheng 已提交
320 321 322 323 324
  if (ret < 0) {
    ASSERT(0);
    return -1;
  }

H
Hongze Cheng 已提交
325 326 327
  // decode entry
  void *pDataCopy = taosMemoryMalloc(nData);  // remove the copy (todo)
  memcpy(pDataCopy, pData, nData);
H
Hongze Cheng 已提交
328
  tDecoderInit(&coder, pDataCopy, nData);
H
Hongze Cheng 已提交
329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344
  ret = metaDecodeEntry(&coder, &me);
  if (ret < 0) {
    ASSERT(0);
    return -1;
  }

  type = me.type;
  if (type == TSDB_CHILD_TABLE) {
    ctime = me.ctbEntry.ctime;
    suid = me.ctbEntry.suid;
  } else if (type == TSDB_NORMAL_TABLE) {
    ctime = me.ntbEntry.ctime;
    suid = 0;
  } else {
    ASSERT(0);
  }
H
Hongze Cheng 已提交
345

H
Hongze Cheng 已提交
346
  taosMemoryFree(pDataCopy);
H
Hongze Cheng 已提交
347
  tDecoderClear(&coder);
H
Hongze Cheng 已提交
348
  tdbTbcClose(pTbDbc);
H
more  
Hongze Cheng 已提交
349

H
Hongze Cheng 已提交
350 351
  if (type == TSDB_CHILD_TABLE) {
    // remove the pCtbIdx
H
Hongze Cheng 已提交
352 353
    TBC *pCtbIdxc = NULL;
    tdbTbcOpen(pMeta->pCtbIdx, &pCtbIdxc, &pMeta->txn);
H
Hongze Cheng 已提交
354

H
Hongze Cheng 已提交
355
    ret = tdbTbcMoveTo(pCtbIdxc, &(SCtbIdxKey){.suid = suid, .uid = uid}, sizeof(SCtbIdxKey), &c);
H
Hongze Cheng 已提交
356 357 358 359 360
    if (ret < 0 || c != 0) {
      ASSERT(0);
      return -1;
    }

H
Hongze Cheng 已提交
361 362
    tdbTbcDelete(pCtbIdxc);
    tdbTbcClose(pCtbIdxc);
H
Hongze Cheng 已提交
363 364 365 366 367 368 369 370 371 372 373 374

    // remove tags from pTagIdx (todo)
  } else if (type == TSDB_NORMAL_TABLE) {
    // remove from pSkmDb
  } else {
    ASSERT(0);
  }

  // remove from ttl (todo)
  if (ctime > 0) {
  }

H
refact  
Hongze Cheng 已提交
375 376
  return 0;
}
H
Hongze Cheng 已提交
377

H
Hongze Cheng 已提交
378
static int metaAlterTableColumn(SMeta *pMeta, int64_t version, SVAlterTbReq *pAlterTbReq) {
H
Hongze Cheng 已提交
379 380 381 382 383 384 385 386 387 388 389 390 391
  void           *pVal = NULL;
  int             nVal = 0;
  const void     *pData = NULL;
  int             nData = 0;
  int             ret = 0;
  tb_uid_t        uid;
  int64_t         oversion;
  SSchema        *pColumn = NULL;
  SMetaEntry      entry = {0};
  SSchemaWrapper *pSchema;
  int             c;

  // search name index
H
Hongze Cheng 已提交
392
  ret = tdbTbGet(pMeta->pNameIdx, pAlterTbReq->tbName, strlen(pAlterTbReq->tbName) + 1, &pVal, &nVal);
H
Hongze Cheng 已提交
393 394 395 396 397 398 399 400 401 402
  if (ret < 0) {
    terrno = TSDB_CODE_VND_TABLE_NOT_EXIST;
    return -1;
  }

  uid = *(tb_uid_t *)pVal;
  tdbFree(pVal);
  pVal = NULL;

  // search uid index
H
Hongze Cheng 已提交
403
  TBC *pUidIdxc = NULL;
H
Hongze Cheng 已提交
404

H
Hongze Cheng 已提交
405 406
  tdbTbcOpen(pMeta->pUidIdx, &pUidIdxc, &pMeta->txn);
  tdbTbcMoveTo(pUidIdxc, &uid, sizeof(uid), &c);
H
Hongze Cheng 已提交
407 408
  ASSERT(c == 0);

H
Hongze Cheng 已提交
409
  tdbTbcGet(pUidIdxc, NULL, NULL, &pData, &nData);
H
Hongze Cheng 已提交
410 411 412
  oversion = *(int64_t *)pData;

  // search table.db
H
Hongze Cheng 已提交
413
  TBC *pTbDbc = NULL;
H
Hongze Cheng 已提交
414

H
Hongze Cheng 已提交
415 416
  tdbTbcOpen(pMeta->pTbDb, &pTbDbc, &pMeta->txn);
  tdbTbcMoveTo(pTbDbc, &((STbDbKey){.uid = uid, .version = oversion}), sizeof(STbDbKey), &c);
H
Hongze Cheng 已提交
417
  ASSERT(c == 0);
H
Hongze Cheng 已提交
418
  tdbTbcGet(pTbDbc, NULL, NULL, &pData, &nData);
H
Hongze Cheng 已提交
419 420 421 422

  // get table entry
  SDecoder dc = {0};
  tDecoderInit(&dc, pData, nData);
H
Hongze Cheng 已提交
423 424
  ret = metaDecodeEntry(&dc, &entry);
  ASSERT(ret == 0);
H
Hongze Cheng 已提交
425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444

  if (entry.type != TSDB_NORMAL_TABLE) {
    terrno = TSDB_CODE_VND_INVALID_TABLE_ACTION;
    goto _err;
  }

  // search the column to add/drop/update
  pSchema = &entry.ntbEntry.schema;
  int32_t iCol = 0;
  for (;;) {
    pColumn = NULL;

    if (iCol >= pSchema->nCols) break;
    pColumn = &pSchema->pSchema[iCol];

    if (strcmp(pColumn->name, pAlterTbReq->colName) == 0) break;
    iCol++;
  }

  entry.version = version;
H
Hongze Cheng 已提交
445 446
  int      tlen;
  SSchema *pNewSchema = NULL;
H
Hongze Cheng 已提交
447 448 449 450 451 452 453 454
  switch (pAlterTbReq->action) {
    case TSDB_ALTER_TABLE_ADD_COLUMN:
      if (pColumn) {
        terrno = TSDB_CODE_VND_COL_ALREADY_EXISTS;
        goto _err;
      }
      pSchema->sver++;
      pSchema->nCols++;
H
Hongze Cheng 已提交
455 456 457
      pNewSchema = taosMemoryMalloc(sizeof(SSchema) * pSchema->nCols);
      memcpy(pNewSchema, pSchema->pSchema, sizeof(SSchema) * (pSchema->nCols - 1));
      pSchema->pSchema = pNewSchema;
H
Hongze Cheng 已提交
458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477
      pSchema->pSchema[entry.ntbEntry.schema.nCols - 1].bytes = pAlterTbReq->bytes;
      pSchema->pSchema[entry.ntbEntry.schema.nCols - 1].type = pAlterTbReq->type;
      pSchema->pSchema[entry.ntbEntry.schema.nCols - 1].flags = pAlterTbReq->flags;
      pSchema->pSchema[entry.ntbEntry.schema.nCols - 1].colId = entry.ntbEntry.ncid++;
      strcpy(pSchema->pSchema[entry.ntbEntry.schema.nCols - 1].name, pAlterTbReq->colName);
      break;
    case TSDB_ALTER_TABLE_DROP_COLUMN:
      if (pColumn == NULL) {
        terrno = TSDB_CODE_VND_TABLE_COL_NOT_EXISTS;
        goto _err;
      }
      if (pColumn->colId == 0) {
        terrno = TSDB_CODE_VND_INVALID_TABLE_ACTION;
        goto _err;
      }
      pSchema->sver++;
      tlen = (pSchema->nCols - iCol - 1) * sizeof(SSchema);
      if (tlen) {
        memmove(pColumn, pColumn + 1, tlen);
      }
H
Hongze Cheng 已提交
478
      pSchema->nCols--;
H
Hongze Cheng 已提交
479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503
      break;
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES:
      if (pColumn == NULL) {
        terrno = TSDB_CODE_VND_TABLE_COL_NOT_EXISTS;
        goto _err;
      }
      if (!IS_VAR_DATA_TYPE(pColumn->type) || pColumn->bytes <= pAlterTbReq->bytes) {
        terrno = TSDB_CODE_VND_INVALID_TABLE_ACTION;
        goto _err;
      }
      pSchema->sver++;
      pColumn->bytes = pAlterTbReq->bytes;
      break;
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_NAME:
      if (pColumn == NULL) {
        terrno = TSDB_CODE_VND_TABLE_COL_NOT_EXISTS;
        goto _err;
      }
      pSchema->sver++;
      strcpy(pColumn->name, pAlterTbReq->colNewName);
      break;
  }

  entry.version = version;

H
Hongze Cheng 已提交
504 505 506 507 508 509
  // do actual write
  metaWLock(pMeta);

  // save to table db
  metaSaveToTbDb(pMeta, &entry);

H
Hongze Cheng 已提交
510
  tdbTbcUpsert(pUidIdxc, &entry.uid, sizeof(tb_uid_t), &version, sizeof(version), 0);
H
Hongze Cheng 已提交
511 512 513 514 515

  metaSaveToSkmDb(pMeta, &entry);

  metaULock(pMeta);

H
Hongze Cheng 已提交
516
  if (pNewSchema) taosMemoryFree(pNewSchema);
H
Hongze Cheng 已提交
517
  tDecoderClear(&dc);
H
Hongze Cheng 已提交
518 519
  tdbTbcClose(pTbDbc);
  tdbTbcClose(pUidIdxc);
H
Hongze Cheng 已提交
520
  return 0;
H
Hongze Cheng 已提交
521 522 523

_err:
  tDecoderClear(&dc);
H
Hongze Cheng 已提交
524 525
  tdbTbcClose(pTbDbc);
  tdbTbcClose(pUidIdxc);
H
Hongze Cheng 已提交
526
  return -1;
H
Hongze Cheng 已提交
527 528 529
}

static int metaUpdateTableTagVal(SMeta *pMeta, int64_t version, SVAlterTbReq *pAlterTbReq) {
H
Hongze Cheng 已提交
530 531
  SMetaEntry  ctbEntry = {0};
  SMetaEntry  stbEntry = {0};
H
Hongze Cheng 已提交
532 533 534 535 536 537 538 539 540 541
  void       *pVal = NULL;
  int         nVal = 0;
  int         ret;
  int         c;
  tb_uid_t    uid;
  int64_t     oversion;
  const void *pData = NULL;
  int         nData = 0;

  // search name index
H
Hongze Cheng 已提交
542
  ret = tdbTbGet(pMeta->pNameIdx, pAlterTbReq->tbName, strlen(pAlterTbReq->tbName) + 1, &pVal, &nVal);
H
Hongze Cheng 已提交
543 544 545 546 547 548 549 550 551 552
  if (ret < 0) {
    terrno = TSDB_CODE_VND_TABLE_NOT_EXIST;
    return -1;
  }

  uid = *(tb_uid_t *)pVal;
  tdbFree(pVal);
  pVal = NULL;

  // search uid index
H
Hongze Cheng 已提交
553
  TBC *pUidIdxc = NULL;
H
Hongze Cheng 已提交
554

H
Hongze Cheng 已提交
555 556
  tdbTbcOpen(pMeta->pUidIdx, &pUidIdxc, &pMeta->txn);
  tdbTbcMoveTo(pUidIdxc, &uid, sizeof(uid), &c);
H
Hongze Cheng 已提交
557 558
  ASSERT(c == 0);

H
Hongze Cheng 已提交
559
  tdbTbcGet(pUidIdxc, NULL, NULL, &pData, &nData);
H
Hongze Cheng 已提交
560 561 562
  oversion = *(int64_t *)pData;

  // search table.db
H
Hongze Cheng 已提交
563
  TBC     *pTbDbc = NULL;
H
Hongze Cheng 已提交
564
  SDecoder dc = {0};
H
Hongze Cheng 已提交
565

H
Hongze Cheng 已提交
566
  /* get ctbEntry */
H
Hongze Cheng 已提交
567 568
  tdbTbcOpen(pMeta->pTbDb, &pTbDbc, &pMeta->txn);
  tdbTbcMoveTo(pTbDbc, &((STbDbKey){.uid = uid, .version = oversion}), sizeof(STbDbKey), &c);
H
Hongze Cheng 已提交
569
  ASSERT(c == 0);
H
Hongze Cheng 已提交
570
  tdbTbcGet(pTbDbc, NULL, NULL, &pData, &nData);
H
Hongze Cheng 已提交
571

H
Hongze Cheng 已提交
572 573 574 575 576
  ctbEntry.pBuf = taosMemoryMalloc(nData);
  memcpy(ctbEntry.pBuf, pData, nData);
  tDecoderInit(&dc, ctbEntry.pBuf, nData);
  metaDecodeEntry(&dc, &ctbEntry);
  tDecoderClear(&dc);
H
Hongze Cheng 已提交
577

H
Hongze Cheng 已提交
578
  /* get stbEntry*/
H
Hongze Cheng 已提交
579 580 581
  tdbTbGet(pMeta->pUidIdx, &ctbEntry.ctbEntry.suid, sizeof(tb_uid_t), &pVal, &nVal);
  tdbTbGet(pMeta->pTbDb, &((STbDbKey){.uid = ctbEntry.ctbEntry.suid, .version = *(int64_t *)pVal}), sizeof(STbDbKey),
           (void **)&stbEntry.pBuf, &nVal);
H
Hongze Cheng 已提交
582 583 584 585 586 587
  tdbFree(pVal);
  tDecoderInit(&dc, stbEntry.pBuf, nVal);
  metaDecodeEntry(&dc, &stbEntry);
  tDecoderClear(&dc);

  SSchemaWrapper *pTagSchema = &stbEntry.stbEntry.schemaTag;
H
Hongze Cheng 已提交
588
  SSchema        *pColumn = NULL;
H
Hongze Cheng 已提交
589 590 591 592 593 594 595 596 597 598 599 600 601 602 603
  int32_t         iCol = 0;
  for (;;) {
    pColumn = NULL;

    if (iCol >= pTagSchema->nCols) break;
    pColumn = &pTagSchema->pSchema[iCol];

    if (strcmp(pColumn->name, pAlterTbReq->tagName) == 0) break;
    iCol++;
  }

  if (pColumn == NULL) {
    terrno = TSDB_CODE_VND_TABLE_COL_NOT_EXISTS;
    goto _err;
  }
H
Hongze Cheng 已提交
604

H
Hongze Cheng 已提交
605 606
  if (iCol == 0) {
    // TODO : need to update tag index
H
Hongze Cheng 已提交
607 608
  }

H
Hongze Cheng 已提交
609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637
  ctbEntry.version = version;
  SKVRowBuilder kvrb = {0};
  const SKVRow  pOldTag = (const SKVRow)ctbEntry.ctbEntry.pTags;
  SKVRow        pNewTag = NULL;

  tdInitKVRowBuilder(&kvrb);
  for (int32_t i = 0; i < pTagSchema->nCols; i++) {
    SSchema *pCol = &pTagSchema->pSchema[i];
    if (iCol == i) {
      tdAddColToKVRow(&kvrb, pCol->colId, pAlterTbReq->pTagVal, pAlterTbReq->nTagVal);
    } else {
      void *p = tdGetKVRowValOfCol(pOldTag, pCol->colId);
      if (p) {
        if (IS_VAR_DATA_TYPE(pCol->type)) {
          tdAddColToKVRow(&kvrb, pCol->colId, p, varDataTLen(p));
        } else {
          tdAddColToKVRow(&kvrb, pCol->colId, p, pCol->bytes);
        }
      }
    }
  }

  ctbEntry.ctbEntry.pTags = tdGetKVRowFromBuilder(&kvrb);
  tdDestroyKVRowBuilder(&kvrb);

  // save to table.db
  metaSaveToTbDb(pMeta, &ctbEntry);

  // save to uid.idx
H
Hongze Cheng 已提交
638
  tdbTbUpsert(pMeta->pUidIdx, &ctbEntry.uid, sizeof(tb_uid_t), &version, sizeof(version), &pMeta->txn);
H
Hongze Cheng 已提交
639

H
Hongze Cheng 已提交
640 641
  if (ctbEntry.pBuf) taosMemoryFree(ctbEntry.pBuf);
  if (stbEntry.pBuf) tdbFree(stbEntry.pBuf);
H
Hongze Cheng 已提交
642 643
  tdbTbcClose(pTbDbc);
  tdbTbcClose(pUidIdxc);
H
Hongze Cheng 已提交
644
  return 0;
H
Hongze Cheng 已提交
645 646

_err:
H
Hongze Cheng 已提交
647 648
  if (ctbEntry.pBuf) taosMemoryFree(ctbEntry.pBuf);
  if (stbEntry.pBuf) tdbFree(stbEntry.pBuf);
H
Hongze Cheng 已提交
649 650
  tdbTbcClose(pTbDbc);
  tdbTbcClose(pUidIdxc);
H
Hongze Cheng 已提交
651
  return -1;
H
Hongze Cheng 已提交
652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677
}

static int metaUpdateTableOptions(SMeta *pMeta, int64_t version, SVAlterTbReq *pAlterTbReq) {
  // TODO
  ASSERT(0);
  return 0;
}

int metaAlterTable(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
  switch (pReq->action) {
    case TSDB_ALTER_TABLE_ADD_COLUMN:
    case TSDB_ALTER_TABLE_DROP_COLUMN:
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES:
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_NAME:
      return metaAlterTableColumn(pMeta, version, pReq);
    case TSDB_ALTER_TABLE_UPDATE_TAG_VAL:
      return metaUpdateTableTagVal(pMeta, version, pReq);
    case TSDB_ALTER_TABLE_UPDATE_OPTIONS:
      return metaUpdateTableOptions(pMeta, version, pReq);
    default:
      terrno = TSDB_CODE_VND_INVALID_TABLE_ACTION;
      return -1;
      break;
  }
}

H
Hongze Cheng 已提交
678
static int metaSaveToTbDb(SMeta *pMeta, const SMetaEntry *pME) {
H
Hongze Cheng 已提交
679 680 681 682 683
  STbDbKey tbDbKey;
  void    *pKey = NULL;
  void    *pVal = NULL;
  int      kLen = 0;
  int      vLen = 0;
H
Hongze Cheng 已提交
684
  SEncoder coder = {0};
H
Hongze Cheng 已提交
685 686

  // set key and value
H
Hongze Cheng 已提交
687
  tbDbKey.version = pME->version;
H
Hongze Cheng 已提交
688 689 690 691
  tbDbKey.uid = pME->uid;

  pKey = &tbDbKey;
  kLen = sizeof(tbDbKey);
H
Hongze Cheng 已提交
692

wafwerar's avatar
wafwerar 已提交
693 694 695
  int32_t ret = 0;
  tEncodeSize(metaEncodeEntry, pME, vLen, ret);
  if (ret < 0) {
H
Hongze Cheng 已提交
696 697 698 699 700 701 702 703 704
    goto _err;
  }

  pVal = taosMemoryMalloc(vLen);
  if (pVal == NULL) {
    terrno = TSDB_CODE_OUT_OF_MEMORY;
    goto _err;
  }

H
Hongze Cheng 已提交
705
  tEncoderInit(&coder, pVal, vLen);
H
Hongze Cheng 已提交
706 707 708 709 710

  if (metaEncodeEntry(&coder, pME) < 0) {
    goto _err;
  }

H
Hongze Cheng 已提交
711
  tEncoderClear(&coder);
H
Hongze Cheng 已提交
712 713

  // write to table.db
H
Hongze Cheng 已提交
714
  if (tdbTbInsert(pMeta->pTbDb, pKey, kLen, pVal, vLen, &pMeta->txn) < 0) {
H
Hongze Cheng 已提交
715 716 717 718 719 720 721 722 723 724 725
    goto _err;
  }

  taosMemoryFree(pVal);
  return 0;

_err:
  taosMemoryFree(pVal);
  return -1;
}

H
Hongze Cheng 已提交
726
static int metaUpdateUidIdx(SMeta *pMeta, const SMetaEntry *pME) {
H
Hongze Cheng 已提交
727
  return tdbTbInsert(pMeta->pUidIdx, &pME->uid, sizeof(tb_uid_t), &pME->version, sizeof(int64_t), &pMeta->txn);
H
Hongze Cheng 已提交
728 729
}

H
Hongze Cheng 已提交
730
static int metaUpdateNameIdx(SMeta *pMeta, const SMetaEntry *pME) {
H
Hongze Cheng 已提交
731
  return tdbTbInsert(pMeta->pNameIdx, pME->name, strlen(pME->name) + 1, &pME->uid, sizeof(tb_uid_t), &pMeta->txn);
H
Hongze Cheng 已提交
732 733
}

H
Hongze Cheng 已提交
734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753
static int metaUpdateTtlIdx(SMeta *pMeta, const SMetaEntry *pME) {
  int32_t    ttlDays;
  int64_t    ctime;
  STtlIdxKey ttlKey;

  if (pME->type == TSDB_CHILD_TABLE) {
    ctime = pME->ctbEntry.ctime;
    ttlDays = pME->ctbEntry.ttlDays;
  } else if (pME->type == TSDB_NORMAL_TABLE) {
    ctime = pME->ntbEntry.ctime;
    ttlDays = pME->ntbEntry.ttlDays;
  } else {
    ASSERT(0);
  }

  if (ttlDays <= 0) return 0;

  ttlKey.dtime = ctime + ttlDays * 24 * 60 * 60;
  ttlKey.uid = pME->uid;

H
Hongze Cheng 已提交
754
  return tdbTbInsert(pMeta->pTtlIdx, &ttlKey, sizeof(ttlKey), NULL, 0, &pMeta->txn);
H
Hongze Cheng 已提交
755 756
}

H
Hongze Cheng 已提交
757 758
static int metaUpdateCtbIdx(SMeta *pMeta, const SMetaEntry *pME) {
  SCtbIdxKey ctbIdxKey = {.suid = pME->ctbEntry.suid, .uid = pME->uid};
H
Hongze Cheng 已提交
759
  return tdbTbInsert(pMeta->pCtbIdx, &ctbIdxKey, sizeof(ctbIdxKey), NULL, 0, &pMeta->txn);
H
Hongze Cheng 已提交
760 761
}

H
Hongze Cheng 已提交
762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806
static int metaCreateTagIdxKey(tb_uid_t suid, int32_t cid, const void *pTagData, int8_t type, tb_uid_t uid,
                               STagIdxKey **ppTagIdxKey, int32_t *nTagIdxKey) {
  int32_t nTagData = 0;

  if (pTagData) {
    if (IS_VAR_DATA_TYPE(type)) {
      nTagData = varDataTLen(pTagData);
    } else {
      nTagData = tDataTypes[type].bytes;
    }
  }
  *nTagIdxKey = sizeof(STagIdxKey) + nTagData + sizeof(tb_uid_t);

  *ppTagIdxKey = (STagIdxKey *)taosMemoryMalloc(*nTagIdxKey);
  if (*ppTagIdxKey == NULL) {
    terrno = TSDB_CODE_OUT_OF_MEMORY;
    return -1;
  }

  (*ppTagIdxKey)->suid = suid;
  (*ppTagIdxKey)->cid = cid;
  (*ppTagIdxKey)->isNull = (pTagData == NULL) ? 1 : 0;
  (*ppTagIdxKey)->type = type;
  if (nTagData) memcpy((*ppTagIdxKey)->data, pTagData, nTagData);
  *(tb_uid_t *)((*ppTagIdxKey)->data + nTagData) = uid;

  return 0;
}

static void metaDestroyTagIdxKey(STagIdxKey *pTagIdxKey) {
  if (pTagIdxKey) taosMemoryFree(pTagIdxKey);
}

static int metaUpdateTagIdx(SMeta *pMeta, const SMetaEntry *pCtbEntry) {
  void          *pData = NULL;
  int            nData = 0;
  STbDbKey       tbDbKey = {0};
  SMetaEntry     stbEntry = {0};
  STagIdxKey    *pTagIdxKey = NULL;
  int32_t        nTagIdxKey;
  const SSchema *pTagColumn;       // = &stbEntry.stbEntry.schema.pSchema[0];
  const void    *pTagData = NULL;  //
  SDecoder       dc = {0};

  // get super table
H
Hongze Cheng 已提交
807
  tdbTbGet(pMeta->pUidIdx, &pCtbEntry->ctbEntry.suid, sizeof(tb_uid_t), &pData, &nData);
H
Hongze Cheng 已提交
808 809
  tbDbKey.uid = pCtbEntry->ctbEntry.suid;
  tbDbKey.version = *(int64_t *)pData;
H
Hongze Cheng 已提交
810
  tdbTbGet(pMeta->pTbDb, &tbDbKey, sizeof(tbDbKey), &pData, &nData);
H
Hongze Cheng 已提交
811 812 813 814 815 816 817 818 819 820 821 822

  tDecoderInit(&dc, pData, nData);
  metaDecodeEntry(&dc, &stbEntry);

  pTagColumn = &stbEntry.stbEntry.schemaTag.pSchema[0];
  pTagData = tdGetKVRowValOfCol((const SKVRow)pCtbEntry->ctbEntry.pTags, pTagColumn->colId);

  // update tag index
  if (metaCreateTagIdxKey(pCtbEntry->ctbEntry.suid, pTagColumn->colId, pTagData, pTagColumn->type, pCtbEntry->uid,
                          &pTagIdxKey, &nTagIdxKey) < 0) {
    return -1;
  }
H
Hongze Cheng 已提交
823
  tdbTbInsert(pMeta->pTagIdx, pTagIdxKey, nTagIdxKey, NULL, 0, &pMeta->txn);
H
Hongze Cheng 已提交
824 825 826 827 828
  metaDestroyTagIdxKey(pTagIdxKey);

  tDecoderClear(&dc);
  tdbFree(pData);

H
Hongze Cheng 已提交
829 830 831
  return 0;
}

H
Hongze Cheng 已提交
832
static int metaSaveToSkmDb(SMeta *pMeta, const SMetaEntry *pME) {
H
Hongze Cheng 已提交
833
  SEncoder              coder = {0};
H
Hongze Cheng 已提交
834 835 836 837 838 839 840 841 842 843 844 845
  void                 *pVal = NULL;
  int                   vLen = 0;
  int                   rcode = 0;
  SSkmDbKey             skmDbKey = {0};
  const SSchemaWrapper *pSW;

  if (pME->type == TSDB_SUPER_TABLE) {
    pSW = &pME->stbEntry.schema;
  } else if (pME->type == TSDB_NORMAL_TABLE) {
    pSW = &pME->ntbEntry.schema;
  } else {
    ASSERT(0);
H
Hongze Cheng 已提交
846 847
  }

H
Hongze Cheng 已提交
848 849
  skmDbKey.uid = pME->uid;
  skmDbKey.sver = pSW->sver;
H
Hongze Cheng 已提交
850 851

  // encode schema
wafwerar's avatar
wafwerar 已提交
852 853 854
  int32_t ret = 0;
  tEncodeSize(tEncodeSSchemaWrapper, pSW, vLen, ret);
  if (ret < 0) return -1;
H
Hongze Cheng 已提交
855
  pVal = taosMemoryMalloc(vLen);
H
Hongze Cheng 已提交
856 857 858 859 860 861
  if (pVal == NULL) {
    rcode = -1;
    terrno = TSDB_CODE_OUT_OF_MEMORY;
    goto _exit;
  }

H
Hongze Cheng 已提交
862
  tEncoderInit(&coder, pVal, vLen);
H
Hongze Cheng 已提交
863 864
  tEncodeSSchemaWrapper(&coder, pSW);

H
Hongze Cheng 已提交
865
  if (tdbTbInsert(pMeta->pSkmDb, &skmDbKey, sizeof(skmDbKey), pVal, vLen, &pMeta->txn) < 0) {
H
Hongze Cheng 已提交
866 867 868 869 870
    rcode = -1;
    goto _exit;
  }

_exit:
H
Hongze Cheng 已提交
871
  taosMemoryFree(pVal);
H
Hongze Cheng 已提交
872
  tEncoderClear(&coder);
H
Hongze Cheng 已提交
873 874 875 876
  return rcode;
}

static int metaHandleEntry(SMeta *pMeta, const SMetaEntry *pME) {
H
Hongze Cheng 已提交
877 878
  metaWLock(pMeta);

H
Hongze Cheng 已提交
879
  // save to table.db
H
Hongze Cheng 已提交
880
  if (metaSaveToTbDb(pMeta, pME) < 0) goto _err;
H
Hongze Cheng 已提交
881 882

  // update uid.idx
H
Hongze Cheng 已提交
883
  if (metaUpdateUidIdx(pMeta, pME) < 0) goto _err;
H
Hongze Cheng 已提交
884 885

  // update name.idx
H
Hongze Cheng 已提交
886
  if (metaUpdateNameIdx(pMeta, pME) < 0) goto _err;
H
Hongze Cheng 已提交
887 888 889

  if (pME->type == TSDB_CHILD_TABLE) {
    // update ctb.idx
H
Hongze Cheng 已提交
890
    if (metaUpdateCtbIdx(pMeta, pME) < 0) goto _err;
H
Hongze Cheng 已提交
891 892

    // update tag.idx
H
Hongze Cheng 已提交
893
    if (metaUpdateTagIdx(pMeta, pME) < 0) goto _err;
H
Hongze Cheng 已提交
894 895
  } else {
    // update schema.db
H
Hongze Cheng 已提交
896
    if (metaSaveToSkmDb(pMeta, pME) < 0) goto _err;
H
Hongze Cheng 已提交
897 898 899
  }

  if (pME->type != TSDB_SUPER_TABLE) {
H
Hongze Cheng 已提交
900
    if (metaUpdateTtlIdx(pMeta, pME) < 0) goto _err;
H
Hongze Cheng 已提交
901 902
  }

H
Hongze Cheng 已提交
903
  metaULock(pMeta);
H
Hongze Cheng 已提交
904
  return 0;
H
Hongze Cheng 已提交
905 906 907 908

_err:
  metaULock(pMeta);
  return -1;
H
Hongze Cheng 已提交
909
}