1. 01 11月, 2014 2 次提交
    • L
      fix · c76dcb44
      Lei Jin 提交于
      Summary:
      
      Test Plan:
      
      Reviewers:
      
      CC:
      
      Task ID: #
      
      Blame Rev:
      c76dcb44
    • L
      fix · b452dede
      Lei Jin 提交于
      Summary:
      
      Test Plan:
      
      Reviewers:
      
      CC:
      
      Task ID: #
      
      Blame Rev:
      b452dede
  2. 11 10月, 2014 2 次提交
    • Y
      Fixed Mac compile error in util/options_test.cc · 3ead857a
      Yueh-Hsuan Chiang 提交于
      Summary:
      Fixed the following error in Mac:
      
      ./util/testharness.h:93:19: error: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Werror,-Wsign-compare]
        BINARY_OP(IsEq, ==)
        ~~~~~~~~~~~~~~~~^~~
      ./util/testharness.h:86:14: note: expanded from macro 'BINARY_OP'
          if (! (x op y)) {                                   \
                   ^
      util/options_test.cc:269:3: note: in instantiation of function template specialization 'rocksdb::test::Tester::IsEq<unsigned long, int>' requested here
        ASSERT_EQ(new_cf_opt.write_buffer_size, 5);
        ^
      
      Test Plan:
      options_test
      3ead857a
    • L
      convert Options from string · cd0d581f
      Lei Jin 提交于
      Summary: Allow accepting Options as a string of key/value pairs
      
      Test Plan: unit test
      
      Reviewers: yhchiang, sdong, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D24597
      cd0d581f
  3. 25 9月, 2014 1 次提交
  4. 23 9月, 2014 1 次提交
  5. 18 9月, 2014 2 次提交
  6. 05 9月, 2014 1 次提交
  7. 23 7月, 2014 1 次提交
    • S
      Add a utility function to guess optimized options based on constraints · e6de0210
      sdong 提交于
      Summary:
      Add a function GetOptions(), where based on four parameters users give: read/write amplification threshold, memory budget for mem tables and target DB size, it picks up a compaction style and parameters for them. Background threads are not touched yet.
      
      One limit of this algorithm: since compression rate and key/value size are hard to predict, it's hard to predict level 0 file size from write buffer size. Simply make 1:1 ratio here.
      
      Sample results: https://reviews.facebook.net/P477
      
      Test Plan: Will add some a unit test where some sample scenarios are given and see they pick the results that make sense
      
      Reviewers: yhchiang, dhruba, haobo, igor, ljin
      
      Reviewed By: ljin
      
      Subscribers: leveldb
      
      Differential Revision: https://reviews.facebook.net/D18741
      e6de0210