1. 14 1月, 2014 2 次提交
  2. 12 1月, 2014 1 次提交
  3. 11 1月, 2014 4 次提交
  4. 10 1月, 2014 2 次提交
    • Y
      fix compile warning · afdd2d1a
      Yancey 提交于
      afdd2d1a
    • I
      Feature requests for BackupableDB · cb37ddf2
      Igor Canadi 提交于
      Summary:
      This diff introduces some features that were requested by two internal customers:
      * Ability for backups not to share table files, because we can't guarantee that equal filename means equal content accross replicas
      * Ability for two threads to call EnableFileDeletions() and DisableFileDeletions()
      * Ability to stop backup from another thread and not slow down the DB close
      * Copy the files to the temporary folder first and then atomically rename
      
      Test Plan: Added some tests to backupable_db_test
      
      Reviewers: dhruba, sanketh, muthu, sdong, haobo
      
      Reviewed By: haobo
      
      CC: leveldb, sanketh, muthu
      
      Differential Revision: https://reviews.facebook.net/D14769
      cb37ddf2
  5. 09 1月, 2014 4 次提交
  6. 08 1月, 2014 5 次提交
    • M
      Don't always compress L0 files written by memtable flush · 50994bf6
      Mark Callaghan 提交于
      Summary:
      Code was always compressing L0 files written by a memtable flush
      when compression was enabled. Now this is done when
      min_level_to_compress=0 for leveled compaction and when
      universal_compaction_size_percent=-1 for universal compaction.
      
      Task ID: #3416472
      
      Blame Rev:
      
      Test Plan:
      ran db_bench with compression options
      
      Revert Plan:
      
      Database Impact:
      
      Memcache Impact:
      
      Other Notes:
      
      EImportant:
      
      - begin *PUBLIC* platform impact section -
      Bugzilla: #
      - end platform impact -
      
      Reviewers: dhruba, igor, sdong
      
      Reviewed By: dhruba
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D14757
      50994bf6
    • I
      Merge pull request #59 from mlin/more-c-bindings · a45b7d83
      Igor Canadi 提交于
      C API: add rocksdb_env_set_high_priority_background_threads
      a45b7d83
    • I
      [column families] Implement DB::OpenWithColumnFamilies() · 72918eff
      Igor Canadi 提交于
      Summary:
      In addition to implementing OpenWithColumnFamilies, this diff also includes some minor changes:
      * Changed all column family names from Slice() to std::string. The performance of column family name handling is not critical, and it's more convenient and cleaner to have names as std::strings
      * Implemented ColumnFamilyOptions(const Options&) and DBOptions(const Options&)
      * Added ColumnFamilyOptions to VersionSet::ColumnFamilyData. ColumnFamilyOptions are specified on OpenWithColumnFamilies() and CreateColumnFamily()
      
      I will keep the diff in the Phabricator for a day or two and will push to the branch then. Feel free to comment even after the diff has been pushed.
      
      Test Plan: Added a simple unit test
      
      Reviewers: dhruba, haobo
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D15033
      72918eff
    • I
      Merge branch 'master' into columnfamilies · d3a2ba9c
      Igor Canadi 提交于
      d3a2ba9c
    • T
      Fix a deadlock in CompactRange() · 9f690ec6
      Tomislav Novak 提交于
      Summary:
      The way DBImpl::TEST_CompactRange() throttles down the number of bg compactions
      can cause it to deadlock when CompactRange() is called concurrently from
      multiple threads. Imagine a following scenario with only two threads
      (max_background_compactions is 10 and bg_compaction_scheduled_ is initially 0):
      
         1. Thread #1 increments bg_compaction_scheduled_ (to LargeNumber), sets
            bg_compaction_scheduled_ to 9 (newvalue), schedules the compaction
            (bg_compaction_scheduled_ is now 10) and waits for it to complete.
         2. Thread #2 calls TEST_CompactRange(), increments bg_compaction_scheduled_
            (now LargeNumber + 10) and waits on a cv for bg_compaction_scheduled_ to
            drop to LargeNumber.
         3. BG thread completes the first manual compaction, decrements
            bg_compaction_scheduled_ and wakes up all threads waiting on bg_cv_.
            Thread #1 runs, increments bg_compaction_scheduled_ by LargeNumber again
            (now 2*LargeNumber + 9). Since that's more than LargeNumber + newvalue,
            thread #2 also goes to sleep (waiting on bg_cv_), without resetting
            bg_compaction_scheduled_.
      
      This diff attempts to address the problem by introducing a new counter
      bg_manual_only_ (when positive, MaybeScheduleFlushOrCompaction() will only
      schedule manual compactions).
      
      Test Plan:
      I could pretty much consistently reproduce the deadlock with a program that
      calls CompactRange(nullptr, nullptr) immediately after Write() from multiple
      threads. This no longer happens with this patch.
      
      Tests (make check) pass.
      
      Reviewers: dhruba, igor, sdong, haobo
      
      Reviewed By: igor
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D14799
      9f690ec6
  7. 07 1月, 2014 4 次提交
  8. 06 1月, 2014 1 次提交
  9. 05 1月, 2014 1 次提交
  10. 03 1月, 2014 4 次提交
    • I
      [column families] Support to create and drop column families · ef6ad170
      Igor Canadi 提交于
      Summary:
      This diff provides basic implementations of CreateColumnFamily(), DropColumnFamily() and ListColumnFamilies(). It builds on top of https://reviews.facebook.net/D14733
      
      It also includes a bug fix for DBImplReadOnly, where Get implementation would be redirected to DBImpl instead of DBImplReadOnly.
      
      Test Plan: Added unit test
      
      Reviewers: dhruba, haobo, kailiu
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D15021
      ef6ad170
    • K
      Add clang-format rules · 463086bc
      Kai Liu 提交于
      Summary:
      The rule file is forked from that in Facebook's repo.
      
      I'll add format file for now and team members can tune the rules later.
      
      In this patch, I made only two changes in order to be consistent with existing coding style
      
      `SpacesBeforeTrailingComments: 2`
      
      `ColumnLimit:     80`
      
      Test Plan: N/A
      
      Reviewers: igor
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D15015
      463086bc
    • K
      Automate the preparation step for a new release · 46950597
      Kai Liu 提交于
      Summary: Added a script that prepares the repo for facebook's new rocksdb release, which will automatically do some necessary work to make sure this repo is ready for 3rdparty release.
      
      Test Plan:
      Run this script and observed:
      
      * new version was created (both in local and remote repo) as a git tag.
      * build_version.cc was updated
      * build_detect_platform was changed so that it won't create any new change.
      
      Reviewers: haobo, dhruba, sdong, igor
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D15003
      46950597
    • K
      Hotfix the bug in table cache's GetSliceForFileNumber · 9281a826
      kailiu 提交于
      Forgot to fix this problem in master branch. Already fixed it in performance branch.
      9281a826
  11. 02 1月, 2014 6 次提交
  12. 01 1月, 2014 1 次提交
  13. 31 12月, 2013 3 次提交
  14. 30 12月, 2013 2 次提交