- 30 6月, 2015 2 次提交
-
-
由 Hans Muller 提交于
A simple container for a TabBar. It is defined by a list of TabNavigatorViews, each of which is just a TabLabel and the tab's content. The content of each tab is represented by a function that produces a Widget called "content". I couldn't bring myself to call it buildTabContentCallback or something else more specific. R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1212993003.
-
由 Hixie 提交于
This should be a perf win, but I haven't tested it. Also adds an operator overloading such that Offset + Size -> Rect. Also adds Rect.fromLTWH(). R=abarth@chromium.org Review URL: https://codereview.chromium.org/1209413004.
-
- 27 6月, 2015 13 次提交
-
-
由 Adam Barth 提交于
Instead of having a one-off //sky/apk/stocks, we now use the |sky_app| GN template to create Stocks.apk directly from //sky/sdk/example/stocks. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1211883004.
-
由 Adam Barth 提交于
This library is logically part of //sky/viewer and shouldn't clutter up the top-level //sky directory. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1213683004.
-
由 Adam Barth 提交于
These benchmarks are very out-dated. In fact, they're still written in JavaScript and mostly test the performance of the DOM. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1216823002.
-
由 Adam Barth 提交于
* Remove all the DOM-based examples except for the old stocks app * Rename stocks2 to stocks * Promote hello_widgets.dart to a top-level hello_world example TBR=ianh@google.com Review URL: https://codereview.chromium.org/1219493003.
-
由 Adam Barth 提交于
This CL builds an APK for MineDigger that works offline. We use |sky_packager| to snapshot the Dart code, which we then extract from the APK during startup. If we succeed in extracting a snapshot, we load it by default. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1211253004.
-
由 Adam Barth 提交于
We're trying to follow the pattern described in https://www.dartlang.org/tools/pub/package-layout.html TBR=iansf@google.com Review URL: https://codereview.chromium.org/1210173004.
-
由 Hans Muller 提交于
When both icons and text are specified, the icon goes on top, 10 pixels of margin goes in between, and the TabBar's height grows to 72. R=ianh@google.com Review URL: https://codereview.chromium.org/1213043002.
-
由 Hixie 提交于
Added a OffsetBase class that Size now inherits from, and added a new Offset class that also inherits from OffsetBase. Offset has: - dx and dy members - zero and infinite static constants - a method that returns a new Offset that's the existing one scaled by a scalar - a unary minus operator - operators overloads such that subtracting or adding two Offsets gives another Offset - a toPoint() method Added Offset and Size to the dart bindings, so they can be used from C++. Changed the Canvas API to use Point, Size, and Offset where appropriate: - drawLine uses Points now - drawCircle uses a Point now - drawImage uses a Paint now - the constructor uses a Size Changed Point as follows: - added a unary minus - Point difference now gives an Offset rather than a Size - You can add an Offset to a Point to get a new Point - toSize() has been replaced by toOffset() Changed Rect as follows: - renamed upperLeft and lowerRight to topLeft and bottomRight for consistency with our other APIs - added bottomLeft and topRight for completeness Changed Size as follows: - now inherits from OffsetBase - added *, /, ~/, and % operators for scaling sizes - subtracting a Size from a Size gives an Offset - subtracting an Offset from a Size gives a Size - changed the + operator to take an Offset instead of a Size - added topLeft, bottomLeft, topRight, bottomRight to match Rect - added center for the same reason - added shortestSide getter since that was a common pattern - removed toPoint() Changed DrawLooperLayerInfo as follows: - setOffset member takes an Offset instead of a Point Changed BoxConstraints as follows: - added biggest getter since it was a common pattern - added smallest getter for symmetry Changed BoxShadow as follows: - offset member is an Offset rather than a Size Changed ViewConstraints as follows: - replaced height and width members by a single size member I did some minor code cleanup in nearby files while I was there, including sorting sky/engine/core/core.gni alphabetically, and fixing some warnings in the examples. BUG= R=abarth@chromium.org, chinmaygarde@google.com Review URL: https://codereview.chromium.org/1214833004.
-
由 Ian Fischer 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1218593002.
-
由 Hans Muller 提交于
It's a typo I introduced in https://codereview.chromium.org/1217533002 TBR=ianh Review URL: https://codereview.chromium.org/1221473002.
-
由 Hans Muller 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1217533002.
-
由 Hans Muller 提交于
Also added a smoke test for examples/widgets/tabs.dart. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1213873002.
-
由 Hixie 提交于
- Rename animate() to watch(). - Fix Toggleable to actually be animated (previously, it was essentially luck that let it be animated -- it was piggy-backing on the splash, I think). R=abarth@chromium.org Review URL: https://codereview.chromium.org/1216533003.
-
- 26 6月, 2015 12 次提交
-
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1208293002.
-
由 Hixie 提交于
Let's hide double.INFINITY a bit more, by providing cleaner APIs for the cases where we're currently trying to use it. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1209233002.
-
由 Hixie 提交于
Add a note about sizedByParent's use. One day we should audit our RenderBoxes and see if any of them can have it set; currently only Scaffold uses it. TBR=abarth Review URL: https://codereview.chromium.org/1216533002.
-
由 Adam Barth 提交于
Unbreak support for snapshots now that we have our offline Dart loader. Also, wire up support for snapshots in sky_shell on Linux. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1212623002.
-
由 Hixie 提交于
New asserts: - verify that after layout, the size fits the constraints - verify that after layout, the size isn't infinite - verify that you don't set the size in performLayout() if you have sizedByParent set - verify that nobody reads your size during layout except you, or your parent if they said parentUsesSize:true Fixes some bugs found by those asserts: - RenderBlock, RenderStack, and RenderScaffold were not always setting parentUsesSize correctly - RenderScaffold was setting its slot entries to null rather than removing them when the slot went away, which led to null derefs in certain circumstances Also, rename a local variable in RenderStack.performLayout() because it was shadowing a variable on the object itself, which was really confusing when I first tried to debug this function... R=abarth@chromium.org Review URL: https://codereview.chromium.org/1213473003.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1204373003.
-
由 Hans Muller 提交于
There's is no support for animating the selected tab indicator, there isn't a TabNavigator container yet, overflow layout (tabs don't fit) isn't supported yet, etc. R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1205953002.
-
由 Adam Barth 提交于
This CL makes it possible to run Sky apps offline by introducing new DartLibraryProvider subclasses, specifically one that can load directly from the file system. A future CL will expand this functionality to work with asset bundles as well. Currently, the only platform that uses this functionality is Linux, which can now load a simple Sky app without even loading a network stack. Making this work on other platforms is work for future CLs. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1203143004.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1206373002.
-
由 Viktor Lidholt 提交于
Adds documentation to Texture and SpriteSheet R=abarth@chromium.org Review URL: https://codereview.chromium.org/1212073002.
-
由 Hixie 提交于
TBR=collin,hansmuller Review URL: https://codereview.chromium.org/1211573003.
-
由 Hixie 提交于
Give rationale for style guide, suggest using more concise code when doing so doesn't harm readability. TBR=abarth Review URL: https://codereview.chromium.org/1209003002.
-
- 25 6月, 2015 11 次提交
-
-
由 Carlos Pizano 提交于
Win was not being detected. BUG=none R=abarth@chromium.org Review URL: https://codereview.chromium.org/1209823002.
-
由 Hixie 提交于
This also fixes the C++ side to give the right baseline information. Previously it was giving the baseline distance for the font, but not for the actual laid-out text. I considered also providing a "defaultBaseline" accessor that returns the distance for the actual dominant baseline, but it turns out right now we never decide the baseline is ideographic. We always use the alphabetic baseline. We should probably fix that... R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1200233002.
-
由 Viet-Trung Luu 提交于
WorkerPools can't be shut down, which means that the app's .so can't be unloaded (which is bad for single process mode, and which is probably why the asset bundle tests are flakily crashing on the try bots). So use a SequencedWorkerPool instead (even though we don't care about sequencing). R=eseidel@chromium.org, kulakowski@chromium.org, abarth@chromium.org BUG=Fixes #268 Review URL: https://codereview.chromium.org/1206673006.
-
由 Carlos Pizano 提交于
-replace UINode for Widget -add the minedigger demo -fix spelling of astroids BUG=none R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1203923006.
-
由 Hixie 提交于
Also, some minor cleanup in TextStyle to make it more readable. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1203253002.
-
由 Hixie 提交于
R=eseidel@chromium.org, eseidel Review URL: https://codereview.chromium.org/1210653002.
-
由 Hixie 提交于
TBR=iansf Review URL: https://codereview.chromium.org/1201383005.
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1208483002.
-
由 Ian Fischer 提交于
-
由 Ian Fischer 提交于
Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia counterparts. Also changes the framework dart code to use the refactored APIs and fixes the various examples and tests. R=abarth@chromium.org, ianh@chromium.org Review URL: https://codereview.chromium.org/1190123003.
-
由 Adam Barth 提交于
This CL factors the network interactions out of DartLoader into a DartLibraryProvider interface, paving the way for other library providers (e.g., offline). As part of this CL, I've renamed DartLoader to DartLibraryLoader and moved the class into tonic, where it can't have any direct network dependencies. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1202283004.
-
- 24 6月, 2015 2 次提交
-
-
由 Adam Barth 提交于
This CL generated by |sed -i '/sky\/engine\/config.h/d'| and a manual sweep to catch some oddballs. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1206763002.
-
由 Adam Barth 提交于
This CL removes all the content from config.h. It doesn't actually delete the file. I'll make that change in a separate CL. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1205793002.
-