- 17 4月, 2015 1 次提交
-
-
由 Ryan Macnak 提交于
https://github.com/domokit/mojo/issues/98 R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1088263004
-
- 16 4月, 2015 6 次提交
-
-
由 Zachary Anderson 提交于
At present there is a special case in Dart bindings generation which makes the Mojo SDK and things under mojo/services portable. However, we must not require things under mojo/services to be next to the Mojo SDK under mojo/public/... in client repos. Further, other collections of mojoms should also be portable. To fix this, instead of using the path in the host repo as the canonical package: import URI for the generated Dart code, this CL uses the mojom module name. BUG=https://github.com/domokit/mojo/issues/73 R=blundell@chromium.org, johnmccutchan@google.com, tonyg@chromium.org Review URL: https://codereview.chromium.org/1071693003
-
由 Eric Seidel 提交于
This reverts commit 9b03c575a4e12f80739d1de7d2c6d66a7cdb214a. https://codereview.chromium.org/999253005 I've not seen the stale caching behavior. I think we need to debug that and fix it. Living with out the cache causes very long load times in SkyShell. R=ianh@google.com Review URL: https://codereview.chromium.org/1086233002
-
由 Eric Seidel 提交于
Hopefully this will make it slightly more clear that the sky_sdk repository is not actually a stand-alone repository, but rather generated by a script. R=ianh@google.com Review URL: https://codereview.chromium.org/1088223003
-
由 Eric Seidel 提交于
This will require me to roll the sky pub package, sigh. R=ianh@google.com Review URL: https://codereview.chromium.org/1090713002
-
由 Eric Seidel 提交于
https://github.com/domokit/sky_sdk/pull/2 https://github.com/domokit/sky_sdk/pull/3 R=sethladd@google.com, ianh@google.com Review URL: https://codereview.chromium.org/1091613002
-
由 Ojan Vafai 提交于
If your layout manager changes, then you need to setNeedsLayout, otherwise the next frame doesn't even get scheduled. We already correctly handle going from not having layout to having one or vice versa by doing the more drastic reattaching since that requires changing your actual render class. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1060013005
-
- 15 4月, 2015 9 次提交
-
-
由 Ojan Vafai 提交于
It was returing all element descendants instead of all element immediate children. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1048333006
-
由 Eric Seidel 提交于
TBR=hansmuller@chromium.org Review URL: https://codereview.chromium.org/1082413002
-
由 Eric Seidel 提交于
R=ianh@google.com, ojan@chromium.org Review URL: https://codereview.chromium.org/1085933002
-
由 Ojan Vafai 提交于
We weren't correctly marking an element as needing style recalc if it was *losing* it's layout manager. We were only doing so when it was gaining a layout manager for the first time. Review URL: https://codereview.chromium.org/1082273004
-
由 Hixie 提交于
otherwise when you switch from one Container instance to another, you end up with the the layout being done by the wrong instance. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1086983004
-
由 Eric Seidel 提交于
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1083963003
-
由 Eric Seidel 提交于
Also fixed display of text in touch-demo.sky R=ianh@google.com Review URL: https://codereview.chromium.org/1059743004
-
由 Hixie 提交于
[Effen] Custom layout. For now, FixedHeightScrollable uses a custom BlockLayout algorithm, mostly as a proof of concept. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1064983002
-
由 Hans Muller 提交于
Scrollable should use scrollTo() instead of setting _scrollOffset directly, when starting an animation. I'd missed this case when adding Scrollable.scrollTo() https://codereview.chromium.org/1074033002 R=ianh@google.com Review URL: https://codereview.chromium.org/1082163002
-
- 14 4月, 2015 1 次提交
-
-
由 Eric Seidel 提交于
TBR=ojan@chromium.org Review URL: https://codereview.chromium.org/1056433004
-
- 11 4月, 2015 6 次提交
-
-
https://codereview.chromium.org/1078973002由 Hixie 提交于
making sure the basic.sky test exposes the right (new) DOM now that text is always wrapped in a display:paragraph div. BUG=85 R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1083443002
-
由 Eric Seidel 提交于
TBR=ojan@chromium.org Review URL: https://codereview.chromium.org/1063633006
-
由 Eric Seidel 提交于
Also cleaned up some uneeded comments in CSSValueKeywords.in TBR=ojan@chromium.org Review URL: https://codereview.chromium.org/1076353003
-
由 Eric Seidel 提交于
I wrote a little script to try removing each non-comment line of this file and re-compiling. This was the result of said script. R=ianh@google.com Review URL: https://codereview.chromium.org/1076313003
-
由 Ojan Vafai 提交于
There's no way to create anonymous renderers anymore. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1070233002
-
由 Eric Seidel 提交于
TBR=hansmuller@chromium.org Review URL: https://codereview.chromium.org/1073243002
-
- 10 4月, 2015 17 次提交
-
-
由 Tony Gentilcore 提交于
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1073173002
-
由 Hans Muller 提交于
A subclass could override this method to limit scrolling or to initialize the scroll offset. R=ianh@google.com Review URL: https://codereview.chromium.org/1074033002
-
由 James Robinson 提交于
Having the output of the tracing service be a list of json objects instead of one json object makes it much easier to combine multiple sources. This teaches skydb (which wants to format the output into a json file loadable by trace-viewer) to emit the tracing header/footer itself. This will make it possible to combine data from the tracing service with data collected by the shell itself. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1065093003
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1076963002
-
由 Hixie 提交于
element with display:paragraph, so that the C++ side shares RenderStyles. (based on review comments on https://codereview.chromium.org/1078973002 ) R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1070243003
-
由 Hixie 提交于
R=eseidel@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/1078973002
-
由 Hixie 提交于
Also it seems we're not parsing @page rules anyway, so this was presumably dead code. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1078883003
-
由 Eric Seidel 提交于
The world may never know what to do with empty cells? Besides. This was mislabled as layout, it was clearly a paint property. :p R=ianh@google.com Review URL: https://codereview.chromium.org/1074953004
-
由 Eric Seidel 提交于
It's dead Jim. R=ianh@google.com Review URL: https://codereview.chromium.org/1075023002
-
由 Eric Seidel 提交于
We want some sort of per-screen breaking, but this CSS is not the way to do it. All of this was already dead code. R=ianh@google.com Review URL: https://codereview.chromium.org/1070313003
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1078943002
-
由 Eric Seidel 提交于
The support was gone, this is just dead code. R=ianh@google.com, ojan@chromium.org Review URL: https://codereview.chromium.org/1070263002
-
由 Eric Seidel 提交于
TBR=hansmuller@chromium.org Review URL: https://codereview.chromium.org/1074933003
-
由 Eric Seidel 提交于
This does not belong in CSS in Sky. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1068383005
-
由 Ojan Vafai 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1077453002
-
由 Ojan Vafai 提交于
Text can only only inside paragraphs and inlines. This patch makes it so we stop putting such text nodes in the render tree at all if their parent is not a paragraph or an inline. This is the final step in making it so that we don't create anonymous renderers, which fixes a crash in the new custom layout code. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1077473002
-
由 Hixie 提交于
R=ojan@chromium.org Review URL: https://codereview.chromium.org/1068073002
-