- 16 8月, 2019 4 次提交
-
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/e30a485a68c9..e5dc1ebc864a git log e30a485a68c9..e5dc1ebc864a --date=short --no-merges --format='%ad %ae %s' 2019-08-15 ethannicholas@google.com unified Metal uniform buffers 2019-08-15 brianosman@google.com Fix crash in reinterpretcolorspace GM with abandoned context 2019-08-15 dtapuska@chromium.org Fix duplicate definition of kRect_ClipType. 2019-08-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-15 bsalomon@google.com Make GrBlend.h private 2019-08-15 brianosman@google.com Add SkImage::reinterpretColorSpace 2019-08-15 egdaniel@google.com Remove remaining functions in GrGLCaps that use GrPixelConfig. Created with: gclient setdep -r src/third_party/skia@e5dc1ebc864a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-
由 Ben Konyi 提交于
dart-lang/sdk@9552646dc4 [CFE] First batch of fixes for requiring explicit types dart-lang/sdk@9d4e778cde [cfe] Support getters, setters, fields and operators in extensions dart-lang/sdk@93d4d28f6c [CFE] Add lint test: Require explicit types
-
由 Jason Simmons 提交于
-
由 inthroxify 提交于
This is a fix for [flutter/flutter issue #34791](https://github.com/flutter/flutter/issues/34791). PR #8048 in flutter/engine produced a bug/regression (flutter/flutter #34791) in flutter for Android that doesn't permit the Recents app bar color to be changed. This restores the original arguments to the function found in the previous version (https://github.com/flutter/engine/blob/2f4a38dbd33061e950cf83ddc31785803d58c126/shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java) of PlatformPlugin.java while preserving the enhancements for the linter. I've compiled and tested this fix locally. The bar changes color again.
-
- 15 8月, 2019 26 次提交
-
-
由 Ben Konyi 提交于
dart-lang/sdk@cae08c6813 [CFE] Apply lines_longer_than_80_chars lint dart-lang/sdk@2c49015cd5 [vm] Add (Zone*) overload for Object::ZoneHandle() dart-lang/sdk@54f26e3554 [cfe+ddc] Support --target=dartdevc in _fasta/compile.dart dart-lang/sdk@3921ae1ee1 [CFE] Enable a number of linters dart-lang/sdk@c30a2be812 [vm/compiler] Check current_ssa_temp_index in FlowGraphChecker. dart-lang/sdk@e14300e7d9 [vm] Adding zone-passing constructor to IntMap. dart-lang/sdk@024052f367 [cfe+dart2js+analyzer] Remove support for libs in id testing dart-lang/sdk@7551b9cee3 [dart2js] (New RTI) Support constructing all unary RTIs. dart-lang/sdk@29b9aa84e3 Build summary1 or summary2 for SDK depending on the useSummary2 flag. dart-lang/sdk@617dd903e2 Update static error expectations for static_extension_bounds_error_test.dart . dart-lang/sdk@326139b729 [dart2js] Add new RTI instantiation entry point. dart-lang/sdk@d0c24059c6 [dart2js] new-rti: Specialize some cases of instanceType dart-lang/sdk@8d1dc8c99b Add a cli flag to enable ML code completion using the default SDK path dart-lang/sdk@a981bfe47b [dartdevc] fix virtual method computation due to nsm dart-lang/sdk@81e98dd47b Update comment on assignability dart-lang/sdk@12b66ceb9d Migration: begin hooking up flow analysis. dart-lang/sdk@b64cf7a146 Cherry-pick CHANGELOG from analyzer 0.37.1+1. dart-lang/sdk@14825ebaf7 Remove defensive coding around type arguments of Future/FutureOr. dart-lang/sdk@6a73fc8442 Fix for detecting constant class fields with summary2. dart-lang/sdk@edb7d0e1d4 Fix the documentation of TypeSystem.isAssignableTo dart-lang/sdk@02dc398b6e Cover the invocation of a function-valued getter defined by an extension of a function type dart-lang/sdk@3e6e0bb368 Enhance the documentation to call out that some members of a class can now be members of an extension dart-lang/sdk@1eaa7d2902 [html] cleanup JS types dart-lang/sdk@2ea18498e9 [vm/compiler] Improve range analysis over MOD dart-lang/sdk@85f7f4c453 [dartdevc] Workaround for constants with overridden fields dart-lang/sdk@ec2d06d4b9 Use MAP_JIT when doing an mmap for executable pages (needed for macOS Catalina). dart-lang/sdk@f87237c4e4 [vm/bytecode] Check context level when accessing await jump variable in debugger dart-lang/sdk@a2de29095e [vm] Implement fingerprints for bytecode functions.
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/f3f50099533d..e30a485a68c9 git log f3f50099533d..e30a485a68c9 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 michaelludwig@google.com Move the source image into Context 2019-08-15 bsalomon@google.com Make GrSamplerState.h and GrRenderTarget.h private Created with: gclient setdep -r src/third_party/skia@e30a485a68c9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/319fd3d7bcb4..f3f50099533d git log 319fd3d7bcb4..f3f50099533d --date=short --no-merges --format='%ad %ae %s' 2019-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 99cffe5db419..3ea90d609720 (11 commits) 2019-08-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3f00da8c515f..efe495cfe7ef (457 commits) 2019-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5e4e8b0af5fa..aa3f31f98a5c (26 commits) Created with: gclient setdep -r src/third_party/skia@f3f50099533d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-
由 skia-flutter-autoroll 提交于
Roll fuchsia/sdk/core/linux-amd64 from pCY3J... to _fvZN... The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/c061d31c2415..319fd3d7bcb4 git log c061d31c2415..319fd3d7bcb4 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-14 bungeman@google.com Add portable allocator to raster allocator test. 2019-08-14 liyuqian@google.com Test serializing pictures with cull rects 2019-08-14 bungeman@google.com Make fontscalerdistortable more flexible. 2019-08-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-14 senorblanco@chromium.org Implement GrDawnGpuTextureCommandBuffer. 2019-08-14 bungeman@google.com Move bigconic gm to be a test. Created with: gclient setdep -r src/third_party/skia@319fd3d7bcb4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-
由 Ben Konyi 提交于
-
由 Chris Bracken 提交于
Ensure that we always pull in the ensure_fuchsia_sdk gn variable. Fixes breakage introduced in flutter/engine#11016 when building outside of a Fuchsia tree (e.g. in a stock Flutter engine tree0 on macOS hosts.
-
由 Chris Bracken 提交于
When building Fuchsia on macOS hosts, ensure that we reference the correct clang toolchain path. This patch also prevents bitcode compilation on Fuchsia tree builds on macOS.
-
由 Chinmay Garde 提交于
-
由 xster 提交于
-
由 Jason Simmons 提交于
The engine's activity_running flag tracks whether the app is in the paused or running lifecycle state. The engine had been defaulting activity_running to false (meaning paused). But the animator had been defaulting its paused flag to false, which allowed frames to render at startup. If the engine loses and regains its surface, then frames would stop rendering because activity_running is false (even though frames had been rendering when the engine initially acquired its surface). This change puts the engine and the animator into a consistent state at startup. Frames will continue to render until the embedder sends a lifecycle message that will pause both the engine and the animator. See https://github.com/flutter/flutter/issues/32624
-
-
由 stuartmorgan 提交于
Renames all FLE* classes in the macOS embedding to Flutter*. With the exception of -[FlutterDartProject engineSwitches], which is very clearly called out in the comment, the APIs should be stable at this point, so the marker prefix is no longer needed. This is a breaking change for macOS embedders, but going forward breaking changes at the source level for the macOS API should now be rare. Some of these classes will likely merge with the iOS versions in the future (e.g., FlutterDartProject), but that will be an implementation detail that will not affect clients. Fixes flutter/flutter#31735
-
由 James Clarke 提交于
Start work on flutter/flutter#30726 by adding an alternative win32 shell platform implementation for Windows that is not based on GLFW and that uses LIBANGLE for rendering and native win32 windowing and input. This change does not replace the GLFW implementation but rather runs side by side with it producing a secondary flutter_windows_win32.dll artifact. The following items must be added to attain parity with the GLFW implementation: - Custom task scheduling - Support for keyboard modifier keys - Async texture uploads - Correct high DPI handling on Windows versions < 1703 and will be added in subsequent changes.
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/735f1d2f0208..c061d31c2415 git log 735f1d2f0208..c061d31c2415 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 bungeman@google.com Make the flippity not crash in Viewer. 2019-08-14 bsalomon@google.com Turn calls to glTexImage2D with non-null ptr into glTexImage2D followed by glTexSubImage2D. 2019-08-14 senorblanco@chromium.org First implementation of GrTextureRenderTarget. 2019-08-14 egdaniel@google.com Remove GrCaps isConfigTexturable. 2019-08-14 bsalomon@google.com Handle size_t addition overflow in GrCpuBuffer::Make 2019-08-14 michaelludwig@google.com Remove SkImageFilter_Base::OutputProperties 2019-08-14 brianosman@google.com Remove unused dstColorSpace parameter from makeTextureImage 2019-08-14 senorblanco@chromium.org First implementation of GrDawnTexture. 2019-08-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-14 jlavrova@google.com Existing unit tests are working with some minor differences 2019-08-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-14 brianosman@google.com Add coord transform to GrSKSLFP, support CTM/local matrix in runtime shaders 2019-08-14 robertphillips@google.com Swap async readback gms over to using GrContext's createBackendTexture 2019-08-14 mtklein@google.com new ideas for bilerp/bicubic? 2019-08-14 fmalita@chromium.org [skottie] Add support for multiple range selectors 2019-08-14 robertphillips@google.com Update Metal backend's createBackendTexture to initialize to a given color 2019-08-14 bungeman@google.com Use COM_DECLSPEC_NOTHROW STDMETHODIMP Created with: gclient setdep -r src/third_party/skia@c061d31c2415 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-
由 Dan Field 提交于
-
由 Ben Konyi 提交于
dart-lang/sdk@e35e8833ee [vm/bytecode] Take context level into account when accessing async context vars
-
由 Dan Field 提交于
This has landed in LUCI as of https://chromium-review.googlesource.com/c/chromium/tools/build/+/1745539
-
由 Dan Field 提交于
-
由 Jason Simmons 提交于
The dynamic linker on some older versions of Android on x86 fails when doing dlsym(RTLD_DEFAULT) lookups of symbols exported by the engine library itself. The engine needs to do this for some data files that are linked into the engine library (ICU data and Dart snapshot blobs). To work around this, the engine will declare static symbols for these data objects on the affected platforms. Fixes https://github.com/flutter/flutter/issues/20091
-
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/5f5a481ae1a9..735f1d2f0208 git log 5f5a481ae1a9..735f1d2f0208 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 halcanary@google.com SkMallocPixelRef: hide implementation 2019-08-14 scroggo@google.com Hook up SkHeifCodec for ImageDecoder animation 2019-08-14 csmartdalton@google.com Reland "Initiate regeneration of mipmaps from proxy DAG land" 2019-08-14 reed@google.com expose direct methods for decoding to an image 2019-08-14 egdaniel@google.com Revert "unified Vulkan uniform buffers" 2019-08-14 bsalomon@google.com Make GrRectBlurEffect be analytical rather than use a texture LUT. 2019-08-14 bsalomon@google.com SkSL GLSL generator writes default precision for sampler2D/samplerExternalOS/sampler2DRect Created with: gclient setdep -r src/third_party/skia@735f1d2f0208 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-
由 skia-flutter-autoroll 提交于
Roll fuchsia/sdk/core/linux-amd64 from TIpmi... to pCY3J... The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
-
由 Ben Konyi 提交于
dart-lang/sdk@c4727fddf4 [CFE] Apply unawaited_futures lint dart-lang/sdk@70e31c18a8 Migration: add tests for AlreadyMigratedCodeDecorator. dart-lang/sdk@c121c8b021 Change InterfaceTypeImpl optional arguments to named. dart-lang/sdk@28e857bbf5 Use a small pool of code completion model isolates dart-lang/sdk@32123b7d13 Add support for extensions on function types dart-lang/sdk@56c3cfe34c [CFE] Apply prefer_adjacent_string_concatenation lint dart-lang/sdk@48af666c9f [CFE] apply curly_braces_in_flow_control_structures lint dart-lang/sdk@812796ff3d [vm/compiler] Make BlockScheduler AllStatic. dart-lang/sdk@85e26c2ce9 [cfe] Update greatest lower bound ruels for FutureOr dart-lang/sdk@a58052974e Adjusted Dart.g to contain the grammar updates of language repo PR 293
-
由 Dan Field 提交于
-
- 14 8月, 2019 10 次提交
-
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/d5d8a64cd54b..5f5a481ae1a9 git log d5d8a64cd54b..5f5a481ae1a9 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 ethannicholas@google.com unified Vulkan uniform buffers 2019-08-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/skia@5f5a481ae1a9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/f4a7190d2a5b..d5d8a64cd54b git log f4a7190d2a5b..d5d8a64cd54b --date=short --no-merges --format='%ad %ae %s' 2019-08-14 csmartdalton@google.com Add GrCaps::msaaResolvesAutomatically 2019-08-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9e4b116ccc40..99cffe5db419 (6 commits) Created with: gclient setdep -r src/third_party/skia@d5d8a64cd54b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-
由 Ben Konyi 提交于
dart-lang/sdk@76c99bcd01 Add tests for internal name conflicts in extension methods dart-lang/sdk@6c46a93361 Check whether completion has been aborted before making model request or blocking on response dart-lang/sdk@9776e3699f Tests and fixes for searching extensions and extension members. dart-lang/sdk@b6455ab53a Expand the version range for dart_internal to allow 2.5.x versions. dart-lang/sdk@37a483ef78 Set incorrectly referenced static element, and test CHANGE_TO_STATIC_ACCESS.
-
由 skia-flutter-autoroll 提交于
Roll fuchsia/clang/mac-amd64 from 2aCB4... to VdFWD... The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-mac-toolchain-flutter-engine Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/96b383a78c84..f4a7190d2a5b git log 96b383a78c84..f4a7190d2a5b --date=short --no-merges --format='%ad %ae %s' 2019-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3ae2445b3416..3f00da8c515f (378 commits) 2019-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 34c59c9b88b7..5e4e8b0af5fa (2 commits) Created with: gclient setdep -r src/third_party/skia@f4a7190d2a5b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-
由 Ben Konyi 提交于
dart-lang/sdk@b173229baa [dart2js] new-rti: Accelerate specialized checks dart-lang/sdk@647f2ec309 [vm] fix file_system_watcher_test.dart on Mac dart-lang/sdk@7d18272498 [vm/bytecode] Deduplicate script objects in bytecode dart-lang/sdk@13005eec86 [vm] Limit heap size to 15GB on 64-bit systems to avoid fatal errors on page table exhaustion. dart-lang/sdk@fd10fa1b1d Defend against null includedSuggestionRelevanceTags dart-lang/sdk@1f5b6bca12 Search for extensions and their members. dart-lang/sdk@449446571f [vm/bytecode] Collect context levels for compiled code generated from bytecode dart-lang/sdk@5852f5ae92 [gardening] Mark a few co19 tests as slow on bytecode interpreter. dart-lang/sdk@5a292f82cc Remove unused DDC config dart-lang/sdk@748d927c60 Fix example statusText dart-lang/sdk@d83425be57 [vm] DirectoryWatch on windows stop immeidate issueRead after initialization dart-lang/sdk@3707f39530 [vm/fuzzer] Track variables to avoid inf. loops dart-lang/sdk@3cc20cd185 Remove quotes from suggestions coming out of model when completion is requested inside of quotes dart-lang/sdk@e556e23bfc Add getOverrideMember() to return the member with replaced type parmeters.
-
由 skia-flutter-autoroll 提交于
Roll fuchsia/sdk/core/linux-amd64 from j8BvV... to TIpmi... The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
-
由 stuartmorgan 提交于
- Allow for BSD formatting where the conditions are not bulleted or indented in any way. - Add support for Bison, which uses a modifed GPL license with an exception that allows distributing under "terms of your choice" when the larger work is not itself a parser-generator based on it.
-
由 Ben Konyi 提交于
dart-lang/sdk@88c43bbcc4 [dartdevc] Properly handling external constant tearoffs dart-lang/sdk@bb12829571 Prepare to publish analyzer version 0.37.1. dart-lang/sdk@39c74d30a1 [nnbd_migration] more postdominator feedback: postdominating locals lists dart-lang/sdk@b92176c080 Migration: Add tracking of generic function type bounds to DecoratedType. dart-lang/sdk@f0049e3d7d Add getter DartType.isDartCoreObject dart-lang/sdk@59b640ede4 Migration: introduce operator== for decorated types. dart-lang/sdk@a5772382dc Migration: refactor infrastructure for testing decorated types.
-
由 skia-flutter-autoroll 提交于
https://skia.googlesource.com/skia.git/+log/f75996469d02..96b383a78c84 git log f75996469d02..96b383a78c84 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 bsalomon@google.com Remove GrRenderable param from GrProxyProvider::createTextureProxy() Created with: gclient setdep -r src/third_party/skia@96b383a78c84 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. Bug: None TBR=scroggo@google.com
-