- 08 7月, 2015 13 次提交
-
-
由 Ian Fischer 提交于
R=abarth@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1222913006 .
-
由 Adam Barth 提交于
We don't need these anymore. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1226773009 .
-
由 Collin Jackson 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1215313004 .
-
由 Eric Seidel 提交于
R=abarth@chromium.org, abarth@google.com Review URL: https://codereview.chromium.org/1218293017 .
-
由 Adam Barth 提交于
When run with a root bundle, the Stocks app now fetches its data from the Internet. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1208053008 .
-
由 Viet-Trung Luu 提交于
Currently, these places are picking it up via some include chain involving interface_impl.h, which is bad since I'm going to delete that file (since InterfaceImpl<> is deprecated and no longer used) -- I'll do this separately. R=rudominer@chromium.org Review URL: https://codereview.chromium.org/1214633009 .
-
由 Eric Seidel 提交于
This isn't quite perfect since we seem to do a second layout as the activity switcher is brought up which is shifting down our toolbar and making it bleed slightly below the Activity Switcher's Task description bar. But at least we're the right color now. R=abarth@chromium.org, abarth@google.com Review URL: https://codereview.chromium.org/1209423008 .
-
由 Adam Barth 提交于
This file will be used by a future version of the Dart analyzer to understand Dart code that uses the dart:sky package. R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/1214433006 .
-
由 Adam Barth 提交于
R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1214633008 .
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth@google.com Review URL: https://codereview.chromium.org/1214073014.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, hixie Review URL: https://codereview.chromium.org/1209423006.
-
由 Adam Barth 提交于
From SkyDemo.apk. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1221143003 .
-
由 Adam Barth 提交于
A ScrollableList seems like a generically useful widget. R=ianh@google.com Review URL: https://codereview.chromium.org/1223863003 .
-
- 07 7月, 2015 26 次提交
-
-
由 Adam Barth 提交于
Previously, if a subclass of FixedHeightScrollable didn't set itemCount, everything would silently work except that you wouldn't actully be able to scroll. This CL makes it harder to forget to provide the itemCount by making it an abstract getter. Now the analyzer will flag it as missing in subclasses and we'll throw an exception at runtime if you forget it. R=ianh@google.com, tonyg@google.com Review URL: https://codereview.chromium.org/1219933004 .
-
由 Viktor Lidholt 提交于
Renames actions Fixes smaller bug in particle systems R=abarth@chromium.org Review URL: https://codereview.chromium.org/1223543004.
-
由 Viktor Lidholt 提交于
Adds ActionRemoveFromParent Adds ActionCallFunction R=abarth@chromium.org Review URL: https://codereview.chromium.org/1224773003.
-
由 Adam Barth 提交于
TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1218283003.
-
由 Collin Jackson 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1212343011.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth@google.com Review URL: https://codereview.chromium.org/1213623008.
-
由 Adam Barth 提交于
We now put stocks.skyx into the APK so that we can run it offline. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1216673011.
-
由 Eric Seidel 提交于
This does way more than a single CL should do, sorry. - Fixed a bunch of logging/error reporting during loads. - Made it possible for --package-root to be absolute. - Fixed (hypothetically) parts of iOS build to be clang-plugin-compliant. - Made all tests pass in sky_shell - Removed a bunch of layout_tests including windows support. I'll remove all the mojo test harness stuff in a follow-up patch. R=abarth@chromium.org, abarth@google.com Review URL: https://codereview.chromium.org/1215953006.
-
由 Hixie 提交于
The initial fix was updating Image to NetworkImage, which is the new name for the Widget that takes a URL to an image. However, this exposed an underlying bug: slots given to MultiChildRenderObjectWrapper children were not getting updated in the initial build. Initially, we don't have a next sibling for any of the children's roots, since we haven't yet synced anyone after the one we're syncing. So we pass null. However, as soon as we build the next one, the previous one now has an out of date slot: null means "append", but it needs to be "insert before the newly inserted root of the next child". So now we update the slot after each insertion. This returned the spinning_mixed demo to its original state, but that state was buggy: the image would expand to fit the button and push the text out of the button. To resolve that, this patch changes how RenderImage sizes an image that has no desired dimensions but has some constraints that make it impossible to show the image at full size: now, we try to maintain the aspect ratio and honour the constraints all at the same time. Also, if the constraints are tight we skip all that logic, because it'd be a waste of time. To help with the slot issue above, I needed to see the widget tree and the render tree and compare them (to see where the nodes were getting out of order), so I also extended Widget.toString() to dump a deep tree of the widget hierarchy. Also, while debugging all this I noticed we sometimes walk the tree into nodes that are null, which causes crashes. So to avoid that I added null-checks to certain walkChildren() functions. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1212943007.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth@google.com Review URL: https://codereview.chromium.org/1217093005.
-
由 Adam Barth 提交于
We now get the thumbnails from the root bundle when offline and otherwise fall back to the network. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1212343009.
-
由 Adam Barth 提交于
Offline support isn't complete, but after this CL, SkyDemo.apk is able to start and show some UI offline. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1225883002.
-
由 Collin Jackson 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1222243007.
-
由 Adam Barth 提交于
This CL makes it easier to insert line breaks into text runs. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1221913003.
-
由 Adam Barth 提交于
This CL makes home.dart less of a special snowflake and instead makes it a peer to the other Sky examples. As a result, we can add a sky.yaml file and embed the thumbnail assets it needs into demo_launcher.skyx. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1215703010.
-
由 Hixie 提交于
This: - Adds asserts all over the place to make sure things are working right with respect to the parent pointer. - Fixes the bugs those asserts uncovered. It turns out we were failing to update the parent pointer in a couple of cases: when the child hadn't changed (but the parent had), and when the node was replaced. - Remove the operator[] nonsense in scaffold. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1218183009.
-
由 Hans Muller 提交于
As far as I can tell, Material TabBars are not supposed to overscroll/bounce. The new TabBarScrollBehavior class supports fling, but it doesn't overscroll/bounce. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1215713009.
-
由 Matt Perry 提交于
- The drawer mask was too dark. - The drawer didn't track the user's finger when dragging. R=ianh@google.com Review URL: https://codereview.chromium.org/1220973005.
-
由 John McCutchan 提交于
BUG= R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1224623007.
-
https://codereview.chromium.org/1218183009/由 Hixie 提交于
Trivial parts of https://codereview.chromium.org/1218183009/ so that that patch isn't confused by variable renames. TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/1222393002.
-
由 Hixie 提交于
This is done by the following steps: - Make Inherited classes notify their descendants when their state changes. - Make Components track which Inherited classes they looked at. - Make Components handle being notified of state changes by rebuilding if the changed ancestor is of a type we've looked at. - Refactor setState() and scheduleBuild(). - Make the "buildDirtyComponents" phase support incrementally building more components as each one finds it needs to update itself. The way this works is that when the menu item updates its color, it does so by changing a DefaultTextStyle (Inherited) node in its tree. That node then notifies its ancestors, which include in particular the Text component, which uses DefaultTextStyle. The notification is received, and, even though we're already in the rebuild phase, the Text queues itself up to be rebuilt as well. Since we now support adding people to the rebuild phase while it's active, it gets rebuilt as well, and all is well. This CL depends on the fix in https://codereview.chromium.org/1218183009 R=abarth@chromium.org Review URL: https://codereview.chromium.org/1222823004.
-
由 Adam Barth 提交于
We no longer have view padding during testing so these values change a bit. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1225703003.
-
由 Adam Barth 提交于
Rather than hardcoding the size and presence of the notification area in Dart, we now expose padding values on the view. These values are set to non-zero values when there are UI elements that overlap the view. We currently respect only the top padding, but this CL paves the way to respect padding in other directions. We still hardcode the size of the notification area in Java. A future CL will retrieve this value from the Android framework. Fixes #257 R=ianh@google.com Review URL: https://codereview.chromium.org/1220353002.
-
由 Adam Barth 提交于
We should remove the state from our map only if the last button is going up. Fixes #260 R=chinmaygarde@google.com Review URL: https://codereview.chromium.org/1215743003.
-
由 Hans Muller 提交于
TODO: - Make fling-scrolling work - Tune scrolling performance - When a tab is selected, snap it to the center if possible R=abarth@chromium.org Review URL: https://codereview.chromium.org/1221673006.
-
由 Adam Barth 提交于
These are now scheduleFrame/setFrameCallback. Also, update schduler.dart to not poke at sky.window, which is now always null. Fixes #178 R=ianh@google.com Review URL: https://codereview.chromium.org/1214943005.
-
- 06 7月, 2015 1 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth@google.com Review URL: https://codereview.chromium.org/1216613004.
-