- 24 2月, 2015 18 次提交
-
-
由 Ojan Vafai 提交于
Merge most of it into RenderBox. Only RenderBoxes can have layers now. This also meant a bit of code could be cleaned up since some virtuals (e.g. updateFromStyle) are no longer needed since they're only called on RenderBoxes. collectSelfPaintingLayers is the only bit that's moved into RenderBoxModelObject instead of RenderBox. That's because we need to be able to recurse down into RenderInlines since they may contain RenderBoxes that have selfPaintingLayers. R=abarth@chromium.org Review URL: https://codereview.chromium.org/953673002
-
由 Eric Seidel 提交于
Also made the background a MD color. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/951653004
-
由 Ojan Vafai 提交于
This removes support for opacity, filters and clip-path on RenderInlines. If you want inline content that uses these properties you need to use an inline-block. We may want to add back support for opacity or filters on inlines eventually, but we'd implement it differently and right now they're getting in the way. R=abarth@chromium.org Review URL: https://codereview.chromium.org/950963003
-
由 Eric Seidel 提交于
http://www.google.com/design/spec/components/lists.html#lists-specs http://www.google.com/design/spec/style/color.html# R=abarth@chromium.org Review URL: https://codereview.chromium.org/930193004
-
由 Scott Violet 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/948943002
-
由 Rafael Weinstein 提交于
R=abarth@chromium.org, abarth BUG= Review URL: https://codereview.chromium.org/951063003
-
由 Adam Barth 提交于
None of this code runs in the current Sky. Some of it never ran. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/951673003
-
由 Eric Seidel 提交于
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/953593002
-
由 Eric Seidel 提交于
This reverts commit 75d3e86468813c450c36d2320bbd7a8b2e2ba9c4. Android mojo_shell fails to run. It can'd find the AndroidHandler class. Unclear what part of this change is causing this. jamesr and I spent a while trying to figure out, but we're reverting this for now to unblock the rest of the team working on android development. Hopefully the paris team will be able to bail us out here when they wake. :) R=jamesr@chromium.org,qsr@chromium.org,davemoore@chromium.org Review URL: https://codereview.chromium.org/951673002
-
由 Adam Barth 提交于
Previously the scrollbar wasn't constrained to the scrollable element and we had messed up the math on the fling curve. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/947303003
-
由 Eric Seidel 提交于
I removed the green background and added display of percent change (which is random for now). I also display a random assortment of stocks every time instead of always the top 100. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/950073002
-
由 Dave Moore 提交于
BUG= R=jamesr@chromium.org Review URL: https://codereview.chromium.org/946243002
-
由 Eric Seidel 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/954513003
-
由 Adam Barth 提交于
Now that I can test these with a touch device, I found a few runtime errors that are fixed in this CL. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/948073002
-
由 Adam Barth 提交于
-
由 Adam Barth 提交于
We'll flesh this example out over time to demo a bunch of our widgets. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/954503002
-
由 Adam Barth 提交于
Also, port the "appish" example to exercise the drawer. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/942413002
-
由 Adam Barth 提交于
This CL updates sky-box, sky-button, sky-checkbox, sky-input, and sky-radio to work in Dart. We don't have a data binding system yet, so there's a bit more plumbing in the code. This CL adds support for sky-element@attributes, which lets you specify which attributes your element supports. We use this information to synthesize getters and setters for those attributes and to dispatch to mumbleChanged methods when the attributes change. I've also wrapped the widgets demo itself in a sky-scrollable so the whole thing scrolls. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/946813005
-
- 23 2月, 2015 1 次提交
-
-
由 Hans Muller 提交于
I also made the singleton embedder's fields static, so that they're lazily computed. R=abarth@chromium.org Review URL: https://codereview.chromium.org/945143003
-
- 22 2月, 2015 2 次提交
-
-
由 Adam Barth 提交于
This CL ports sky-scrollable to the new sky-element. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/950603002
-
由 Adam Barth 提交于
... instead of hard-coding "example". We do this by adding a custom constructor for Element that gets the |tagName| property off the instance. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/943153002
-
- 21 2月, 2015 19 次提交
-
-
由 Adam Barth 提交于
After this CL, you can use <sky-element> to describe custom elements. The current iteration is very basic and is hardcoded to "example", but its a start. This CL renames the |init| function to |_init| to prevent importers from calling it directly. Also, we now pass the <script> element to |_init| to give some context. R=ojan@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/950493003
-
由 Ojan Vafai 提交于
Just deleted the obvious bits and verified that test_sky, skydb and pretty-diff still work. R=abarth@chromium.org Review URL: https://codereview.chromium.org/946753002
-
由 Ojan Vafai 提交于
This will let us delete webkit-patch and a bunch of python code and it will save me some annoyance at needing to type "webkit-patch pretty-diff" all the time. R=abarth@chromium.org Review URL: https://codereview.chromium.org/944193003
-
由 Ojan Vafai 提交于
If your current branch has an upstream branch, then diff to that branch. That way you get the same diff that git cl upload gives instead of the diff to origin/master. TBR=esprehn@chromium.org Review URL: https://codereview.chromium.org/948663002
-
由 Ojan Vafai 提交于
On the web, if you set position:absolute, but not top/right/bottom/left, then the absolute goes where it would have gone if it wasn't positioned. The use-cases for this are slim and it introduces a lot of complexity to the engine. Also changes behavior in the presence of direction:rtl. On the web, direction:rtl and top/left:auto would sometimes set right:0. Instead we always position at 0,0 if the opposing values are auto. This removes the code for this positioning and allows simplifying a bunch of dirty bit handling code since we don't need to setNeedsLayout if lines move around or wrap differently. The test cases did change their output, but the new positioning all looks correct to me. Review URL: https://codereview.chromium.org/944073006
-
由 Ojan Vafai 提交于
We only need to walk the immediate children of the paragraph. The other inline children of the paragraph will get paint called on them and they will then appropriately add the self painting layers to the array inside their paint calls. R=abarth@chromium.org Review URL: https://codereview.chromium.org/945223002
-
由 Ojan Vafai 提交于
This exposes a bug that we position and size position:absolute correctly inside paragraphs, but we fail to paint them. R=abarth@chromium.org Review URL: https://codereview.chromium.org/943113003
-
由 Ojan Vafai 提交于
-ASSERT(layer()->parent()) in all the transform codepaths since the RenderView cannot have a transform. -Early return if the content rect does not intersect the damage rect in the painting code. We don't need to do any of the filter and/or transparency dance if we're not going to paint anything. This also allowed for removing the shouldPaintContent bool. -Remove a random style() null check that can't be hit. R=abarth@chromium.org Review URL: https://codereview.chromium.org/950553002
-
由 Adam Barth 提交于
We've removed the old implementation of custom elements. We can move the new implementation into the proper place and give the classes their proper name. R=ojan@chromium.org Review URL: https://codereview.chromium.org/946083003
-
由 Adam Barth 提交于
This code is unused now that we have sky/engine/core/dom/custom2 working. R=ojan@chromium.org Review URL: https://codereview.chromium.org/950523002
-
由 Hixie 提交于
Specs: define how importing element registrations works, move built-in elements to a separate module so dart:sky can be a simple library Review URL: https://codereview.chromium.org/944873007
-
由 Adam Barth 提交于
This CL implements custom elements. The design is as follows: 1) Authors subclass Element and call registerElement. 2) When we create C++ elements for custom elements, we call the author's constructor synchronously. 3) The attach/detach/attributeChanged callbacks are called either: a) when exiting the current custom element callback scoped (e.g., before returning from appendChild), or b) when draining the microtask queue. The implementation in this CL is a bit fragile because we don't detect name registration conflicts and we let you create custom elements with the same name as built-in elements. Also, not every part of the engine is prepared to execute script synchronously below createElement. We'll need to iron out these issues over time, but this CL is a start. R=ojan@chromium.org Review URL: https://codereview.chromium.org/943013002
-
由 Eric Seidel 提交于
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/950503002
-
由 Hans Muller 提交于
Currently the embedder is just an encapsulation of the Mojo shell. Exposing an ApplicationConnection that encapsulates the ViewManager Embed SPs is next. R=abarth@chromium.org, zra@google.com Review URL: https://codereview.chromium.org/948463003
-
由 Ojan Vafai 提交于
The only bit that was still used was the containingBlockLogicalWidthChanged check in RenderBlock::widthAvailableToChildrenHasChanged. https://chromium.googlesource.com/chromium/blink/+/a4f1e657ff786f80bbc32f0a2af787bc33327e56 is the patch that added that code. I added a test to confirm we still pass the test case that code was added for. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/945003002
-
由 Hixie 提交于
function, rename it _init(), plumb that through AutomaticMetadata, and move @tagname and Element.tagname to a new frameworks.md file that has stuff that wouldn't actually be part of core Sky Review URL: https://codereview.chromium.org/946513006
-
由 Adam Barth 提交于
-
由 Adam Barth 提交于
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/932783004
-