- 24 2月, 2015 3 次提交
-
-
由 Adam Barth 提交于
We'll flesh this example out over time to demo a bunch of our widgets. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/954503002
-
由 Adam Barth 提交于
Also, port the "appish" example to exercise the drawer. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/942413002
-
由 Adam Barth 提交于
This CL updates sky-box, sky-button, sky-checkbox, sky-input, and sky-radio to work in Dart. We don't have a data binding system yet, so there's a bit more plumbing in the code. This CL adds support for sky-element@attributes, which lets you specify which attributes your element supports. We use this information to synthesize getters and setters for those attributes and to dispatch to mumbleChanged methods when the attributes change. I've also wrapped the widgets demo itself in a sky-scrollable so the whole thing scrolls. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/946813005
-
- 23 2月, 2015 1 次提交
-
-
由 Hans Muller 提交于
I also made the singleton embedder's fields static, so that they're lazily computed. R=abarth@chromium.org Review URL: https://codereview.chromium.org/945143003
-
- 22 2月, 2015 2 次提交
-
-
由 Adam Barth 提交于
This CL ports sky-scrollable to the new sky-element. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/950603002
-
由 Adam Barth 提交于
... instead of hard-coding "example". We do this by adding a custom constructor for Element that gets the |tagName| property off the instance. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/943153002
-
- 21 2月, 2015 24 次提交
-
-
由 Adam Barth 提交于
After this CL, you can use <sky-element> to describe custom elements. The current iteration is very basic and is hardcoded to "example", but its a start. This CL renames the |init| function to |_init| to prevent importers from calling it directly. Also, we now pass the <script> element to |_init| to give some context. R=ojan@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/950493003
-
由 Ojan Vafai 提交于
Just deleted the obvious bits and verified that test_sky, skydb and pretty-diff still work. R=abarth@chromium.org Review URL: https://codereview.chromium.org/946753002
-
由 Ojan Vafai 提交于
This will let us delete webkit-patch and a bunch of python code and it will save me some annoyance at needing to type "webkit-patch pretty-diff" all the time. R=abarth@chromium.org Review URL: https://codereview.chromium.org/944193003
-
由 Ojan Vafai 提交于
If your current branch has an upstream branch, then diff to that branch. That way you get the same diff that git cl upload gives instead of the diff to origin/master. TBR=esprehn@chromium.org Review URL: https://codereview.chromium.org/948663002
-
由 Ojan Vafai 提交于
On the web, if you set position:absolute, but not top/right/bottom/left, then the absolute goes where it would have gone if it wasn't positioned. The use-cases for this are slim and it introduces a lot of complexity to the engine. Also changes behavior in the presence of direction:rtl. On the web, direction:rtl and top/left:auto would sometimes set right:0. Instead we always position at 0,0 if the opposing values are auto. This removes the code for this positioning and allows simplifying a bunch of dirty bit handling code since we don't need to setNeedsLayout if lines move around or wrap differently. The test cases did change their output, but the new positioning all looks correct to me. Review URL: https://codereview.chromium.org/944073006
-
由 Ojan Vafai 提交于
We only need to walk the immediate children of the paragraph. The other inline children of the paragraph will get paint called on them and they will then appropriately add the self painting layers to the array inside their paint calls. R=abarth@chromium.org Review URL: https://codereview.chromium.org/945223002
-
由 Ojan Vafai 提交于
This exposes a bug that we position and size position:absolute correctly inside paragraphs, but we fail to paint them. R=abarth@chromium.org Review URL: https://codereview.chromium.org/943113003
-
由 Ojan Vafai 提交于
-ASSERT(layer()->parent()) in all the transform codepaths since the RenderView cannot have a transform. -Early return if the content rect does not intersect the damage rect in the painting code. We don't need to do any of the filter and/or transparency dance if we're not going to paint anything. This also allowed for removing the shouldPaintContent bool. -Remove a random style() null check that can't be hit. R=abarth@chromium.org Review URL: https://codereview.chromium.org/950553002
-
由 Adam Barth 提交于
We've removed the old implementation of custom elements. We can move the new implementation into the proper place and give the classes their proper name. R=ojan@chromium.org Review URL: https://codereview.chromium.org/946083003
-
由 Adam Barth 提交于
This code is unused now that we have sky/engine/core/dom/custom2 working. R=ojan@chromium.org Review URL: https://codereview.chromium.org/950523002
-
由 Hixie 提交于
Specs: define how importing element registrations works, move built-in elements to a separate module so dart:sky can be a simple library Review URL: https://codereview.chromium.org/944873007
-
由 Adam Barth 提交于
This CL implements custom elements. The design is as follows: 1) Authors subclass Element and call registerElement. 2) When we create C++ elements for custom elements, we call the author's constructor synchronously. 3) The attach/detach/attributeChanged callbacks are called either: a) when exiting the current custom element callback scoped (e.g., before returning from appendChild), or b) when draining the microtask queue. The implementation in this CL is a bit fragile because we don't detect name registration conflicts and we let you create custom elements with the same name as built-in elements. Also, not every part of the engine is prepared to execute script synchronously below createElement. We'll need to iron out these issues over time, but this CL is a start. R=ojan@chromium.org Review URL: https://codereview.chromium.org/943013002
-
由 Eric Seidel 提交于
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/950503002
-
由 Hans Muller 提交于
Currently the embedder is just an encapsulation of the Mojo shell. Exposing an ApplicationConnection that encapsulates the ViewManager Embed SPs is next. R=abarth@chromium.org, zra@google.com Review URL: https://codereview.chromium.org/948463003
-
由 Ojan Vafai 提交于
The only bit that was still used was the containingBlockLogicalWidthChanged check in RenderBlock::widthAvailableToChildrenHasChanged. https://chromium.googlesource.com/chromium/blink/+/a4f1e657ff786f80bbc32f0a2af787bc33327e56 is the patch that added that code. I added a test to confirm we still pass the test case that code was added for. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/945003002
-
由 Hixie 提交于
function, rename it _init(), plumb that through AutomaticMetadata, and move @tagname and Element.tagname to a new frameworks.md file that has stuff that wouldn't actually be part of core Sky Review URL: https://codereview.chromium.org/946513006
-
由 Adam Barth 提交于
-
由 Adam Barth 提交于
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/932783004
-
由 Adam Barth 提交于
We now expand |any| to DartValue (which exists) as opposed to ScriptValue (which does not). Also, fill in a few missing pieces in tonic that will be used by custom elements. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/942993002
-
由 Adam Barth 提交于
This CL is progress towards deleting the concept of an HTMLElement entirely. We won't actually get all the way there in this CL series, but we're getting closer. This CL also will let us make custom elements just be Elements instead of HTMLElements. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/942933003
-
由 Ojan Vafai 提交于
There are some cases in this patch where it's not obvious that the code only applies to position:relative, but the code asserts that it does. In those cases, I trusted the asserts and deleted the code. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/938193004
-
由 Eric Seidel 提交于
This does several things: 1. Teaches sky about asynchronous script execution. Previously once all imports were loaded and the script text was available, we executed a script and assumed it completed synchronously. We left the parser loop to do so, but that was fine as the next chunk from the background thread would resume the parser. In this change scripts now load and execute separately. The "load" step may trigger further dart import loads which may cause the execution to happen asynchronously which required teaching both the DartController and the HTMLScriptRunner to take callbacks to allow HTMLDocumentParser to know to continue parsing after the Dart script has resolved its imports and executed. This required re-working some of how the parser executes scripts and I re-purposed isWaitingForScripts to include "is the parser blocked" where as before it was limited only to "does the treebuilder have a script", even though the imports system may have had pending scripts as well. I made HTMLScriptRunner live only as long as the script it was executing since it only contained per-script state at this point. 2. Fixed an error reporting bug whereby we would not show errors when "init" failed to execute, only "main". This required using the dart_mirrors_api.h which required adding an include path to the core build. :( 3. Made it possible for a single sky file to contain multiple dart <script> tags. Each <script> is a separate library and executes as soon as </script> is seen. main or init is called for each. This required mangling "urls" for these script blocks since Dart unique's libraries by urls. Before this change it may have been possible to do <import 'foo.sky'> and then <script>import 'foo.sky'</script> and have it work!? R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/938623005
-
由 Eric Seidel 提交于
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/942923002
-
- 20 2月, 2015 10 次提交
-
-
由 Adam Barth 提交于
There's no point in CustomEvent anymore because authors can just subclass Event themselves. R=esprehn@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/941243002
-
由 Adam Barth 提交于
After this CL, authors can create custom subclasses of Event that actually work in a reasonable way, including being able to dispatch. R=hansmuller@google.com, hansmuller@chromium.org Review URL: https://codereview.chromium.org/938003004
-
由 Adam Barth 提交于
This CL makes it possible for authors to extend any host object (e.g., DOM objects) and to use those objects in all the usual places they can be used in the API. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/936193005
-
由 Ojan Vafai 提交于
Change hit testing to walk over the render tree instead of the RenderLayer tree. This is a step in the direction of removing the RenderLayer tree entirely. For now, there's a few calls back into RenderLayer that will be removed in a followup patch. This patch also breaks hit testing on transformed inlines. I'll be removing the ability to transform inlines in a followup patch anyways, so it's ok for hit testing to give the wrong result temporarily here. Almost all of this patch is just moving code from RenderLayer to RenderBox. The primary substantive change is in RenderBox::hitTestLayer. Instead of having hitTestChildren calls, we call collectSelfPaintingLayers, reverse sort by z-index (so we start at the top), and then iterate over the result. The test-case also exposes that we don't correctly hit transformed elements inside inline-blocks. I went back as far as 4153b8a515d54275934d4244aaf2d5a7a8fe3333 and the bug still happened. R=abarth@chromium.org Review URL: https://codereview.chromium.org/945693002
-
由 Adam Barth 提交于
These now appear on internals as takeServicesProvidedToEmbedder and takeServicesProvidedByEmbedder. When you call these functions, you get back the raw int that represents the handle. We'll need to wrap them up inside the Dart VM with the appropriate types. We can create a nice wrapper for that in a future CL. R=hansmuller@google.com, hansmuller@chromium.org Review URL: https://codereview.chromium.org/944733002
-
由 Adam Barth 提交于
We now use List<Node> instead, which is more idiomatic. R=ojan@chromium.org Review URL: https://codereview.chromium.org/941913002
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/943843002
-
由 Hans Muller 提交于
I haven't removed the JS color picker code yet. R=abarth@chromium.org Review URL: https://codereview.chromium.org/940233002
-
由 Hixie 提交于
Specs: remove previousSibling/nextSibling arguments to parentChangeCallback() since their purpose is not documented Review URL: https://codereview.chromium.org/943453004
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/944613002
-