- 25 7月, 2015 2 次提交
-
-
由 Hixie 提交于
-
由 Hixie 提交于
This removes the need to manually include the dialog builder in the main window's build() function. It also removes the need to track if a dialog is visible. Other changes: - I made dialog.dart a bit more readable. - I renamed transitionFinished to fullyOpaque since that's what actually matters. - I made Routes track if they're opaque. Eventually this should probably be more configurable when creating the route. Directions for Future Research: - Use this for focus management somehow. - The popup menu should use something like this. - We should factor the following out into a showDialog() function that returns a future for the dialog's exit result: navigator.push(new DialogRoute(builder: (navigator, route) { ... })); - Maybe navigator.pop() should take a value to return to that Future.
-
- 23 7月, 2015 1 次提交
-
-
由 Hixie 提交于
This fixes some theoretical bugs whereby we were using hashCode to try to get unique keys for objects, but really we wanted object identity. It also lays the groundwork for a new GlobalKey concept. I tried to keep the impact on the code minimal, which is why the "Key" constructor is actually a factory that returns a StringKey. The code has this class hierarchy: ``` KeyBase | Key--------------+---------------+ | | | StringKey ObjectKey UniqueKey ``` ...where the constructors are Key and Key.stringify (StringKey), Key.fromObjectIdentity (ObjectKey), and Key.unique (UniqueKey). We could instead of factory methods use regular constructors with the following hierarchy: ``` KeyBase | LocalKey---------+---------------+ | | | Key ObjectIdentityKey UniqueKey ``` ...with constructors Key, Key.stringify, ObjectIdentityKey, and UniqueKey, but I felt that that was maybe a more confusing hierarchy. I don't have a strong opinion on this.
-
- 22 7月, 2015 2 次提交
-
-
由 Hixie 提交于
Route (named routes) no longer have a key, and have their own storage for their names. RouseState no longer has a key, and uses an owner field pointing to a StatefulComponent instead. As such, RouteBase no longer has a key. HistoryEntry no longer uses a global int to ensure uniqueness. Propagated this to stocks app.
-
由 Matt Perry 提交于
-
- 18 7月, 2015 3 次提交
-
-
由 Collin Jackson 提交于
-
由 Collin Jackson 提交于
-
由 Collin Jackson 提交于
-
- 17 7月, 2015 4 次提交
-
-
由 Collin Jackson 提交于
-
由 Collin Jackson 提交于
-
由 Collin Jackson 提交于
-
由 Collin Jackson 提交于
-
- 15 7月, 2015 1 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1231753008 .
-
- 12 7月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Apparently this style is recommended by Dart developers. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1232313002 .
-
- 07 7月, 2015 1 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth@google.com Review URL: https://codereview.chromium.org/1217093005.
-
- 19 6月, 2015 2 次提交
-
-
由 Collin Jackson 提交于
Currently you lose your scroll and drawer state when coming back from the settings pane. I think we should solve this by having the Navigator maintain a Stack and keeping the StockHome alive underneath it. But this is good enough for a first iteration. R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1191153002.
-
由 Adam Barth 提交于
I broke this when I merged my AppContainer patch with Collin's back button patch. This change restores the functionality I broke. TBR=jackson@chromium.org Review URL: https://codereview.chromium.org/1182463007.
-
- 18 6月, 2015 1 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1195493002.
-
- 17 6月, 2015 3 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth, hixie Review URL: https://codereview.chromium.org/1181773006.
-
由 Hixie 提交于
Also, move a widget example from examples/raw/ to examples/widgets/ R=abarth@chromium.org Review URL: https://codereview.chromium.org/1190793002.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth, hixie Review URL: https://codereview.chromium.org/1186273002.
-