https://skia.googlesource.com/skia.git/+log/45239cb84d1d..a85f3a138cbc


Created with:
  gclient setdep -r src/third_party/skia@a85f3a138cbc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

Format code from previous patch

* If isolate is already running, return true

* Use shell::Engine::RunStatus as result of Engine::Run

https://skia.googlesource.com/skia.git/+log/a9adb6f03525..45239cb84d1d


Created with:
  gclient setdep -r src/third_party/skia@45239cb84d1d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

Use a screen height ratio to determine if the keyboard is onscreen or not. This is used because Android does not provide a deterministic API to detect this.

We remove the padding when the keyboard is closed and the inset is due to the hidden navigation bar, otherwise, we apply the full keyboard inset.

* Change FlutterDartProject to keep precedence when looking for the assets bundle

* Change assetsPath to fallback to mainBundle when the defined bundle does not contain assets

https://skia.googlesource.com/skia.git/+log/0a3864651457..a9adb6f03525


Created with:
  gclient setdep -r src/third_party/skia@a9adb6f03525

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

https://skia.googlesource.com/skia.git/+log/c955a1645148..0a3864651457


Created with:
  gclient setdep -r src/third_party/skia@0a3864651457

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

https://skia.googlesource.com/skia.git/+log/bdb32d17999e..c955a1645148


Created with:
  gclient setdep -r src/third_party/skia@c955a1645148

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

https://skia.googlesource.com/skia.git/+log/937348d4d442..bdb32d17999e


Created with:
  gclient setdep -r src/third_party/skia@bdb32d17999e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

https://skia.googlesource.com/skia.git/+log/175b587a634d..937348d4d442


Created with:
  gclient setdep -r src/third_party/skia@937348d4d442

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

This shell used to serve the dual purpose of running Flutter tests as
well as optionally being able to run Flutter applications on a Mac
desktop. After all the test runner targets were consolidated
(flutter_tester), this target was no longer used to run the tests. This
target is currently only used by engine developers to test changes
quickly on the host. Even for this purpose, the Desktop embedders are
more full featured and use the stable embedder API. The presence of a
cross-platform tester target, alternatives for Desktop targets that use
the stable embedder API and the fact that this target is no longer
tested, makes having this code in the source entirely redundant.

https://skia.googlesource.com/skia.git/+log/11f4994b84e1..175b587a634d


Created with:
  gclient setdep -r src/third_party/skia@175b587a634d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

https://skia.googlesource.com/skia.git/+log/358558a4cecc..11f4994b84e1


Created with:
  gclient setdep -r src/third_party/skia@11f4994b84e1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

654c4babc8 [vm/bytecode] Fix a couple of assertions when running with bytecode
b540626589 Change DeclarationResolver to extend RecursiveAstVisitor<void>.
52bec5e34b Update parser to find token on which to report the error
93dcfaa289 [vm, gc] Concurrent marking.
e06ef81efa [vm] Unconditionally generate interpreter stubs
6a04b3079f Fix test_mixinInference_noMatchingClass_namedMixinApplication_new_syntax
484405b1c8 Fix missing_return hint in _getInferredMixinType
1357778286 Issue 34546. Get ClassElementImpl a way that support element handles.
012b7050e5 [VM interpreter] Use a helper to test entry frame pc marker.
e22dd19b13 Create a base class for compile-time error code test cases.
491db89917 Upgrade dartdoc to v0.21.1
7cd25705ab Fix parsing label between 2 switch cases
33f6c8ef35 More super mixin tests.
e9ff597673 Optimize gatherMixinSupertypeConstraints for new mixin syntax.
5cf0d9e844 Replicate existing analyzer supermixin tests using new "mixin" syntax.
20342cea27 [vm/compiler] added compilation trace tracer
c92406f57c bump to linter 0.1.63
19e2040f35 [vm] Cleanup the ability to specify entry points via JSON and text files
ead158ab5d Fix gatherMixinSupertypeConstraints to handle named mixin applications.
51f2dac483 Reland: [vm] Adds a benchmark for Dart_LoadLibraryFromKernel
82c784a60f Revert "[vm] Adds a benchmark for Dart_LoadLibraryFromKernel"
762a14e139 Update dart2js_dynamic_test to exclude CFE code.
0c60a52bb2 [VM bytecode] Triage failures in interpreted mode.
e75a48b7fe Add status entries for dartdevk on new super invocation tests
46e5954b0a Turn on and fix mixin type inference checks when not in "supermixin" mode.
b7f762923e Add tests for more super invocation edge cases
64b6d713e3 [dartdevc] enable super mixin support in Kernel backend
0ec9945885 Fix #33629 boolean negation of void
0b5a7c847d Add support for intermittent filesystems to the analysis server, this PR is a synced version of Devons PR https://dart-review.googlesource.com/c/sdk/+/72980, without the DAS protocol change.
fee8efa3d6 [vm] Adds a benchmark for Dart_LoadLibraryFromKernel
46ec629096 [vm/bytecode] Trigger JIT-compilation from interpreter
9f5aecb22b Introduce a new flag to the Dart Analysis Server: --ux-experiment-1 which changes analysis roots to the be the current set of priority files.
9f72b09f0f Convert resolver.dart to triple-slash comment style.
ee0a6033bf Fix checks for absence of concrete implementations of super-invoked members.
3a5b748521 Optimize index data structure for search by supertype id.
af2fd419fb Update more analyzer error codes to be generated from messages.yaml
0bbdd8f7d9 [build] Correctly rebase kernel-service output for depfile
cbf60679eb [vm/fuzzer] Migrated driver from Python to Dart.
e95d944f5f [VM interpreter] Propagate error from invoked compiled function to interpreter caller.
05ba85399f Cleanup fasta parser rewriter insert token methods
07a1f233f8 Improve parser recover to fix more code completion tests
ffa99b9cde Update analyzer error code generation
fa0b38b45d Fix some constructor initializer code completion situations
2455141018 Remove ClassElement.isSuperConstructorAccessible().
3263550e86 [vm] Decouple bytecode reading from compilation
e3dbea9523 Convert declaration_resolver.dart to triple-slash comment style.
d32e93db46 Remove unused import.
4baa3ec951 Create a base class for non-error resolver test cases.
2e43557274 Mark Kernel classes that were Dart mixin declarations

* Make FlutterStandardCodec handle writing NSData

iOS developers can accidentally pass an `NSData` object directly to
`FlutterStandardCodec` and forget to wrap it in
`FlutterStandardTypedData`.  This failure won't be caught until
runtime.

Let's make `FlutterStandardCodec` more tolerant by making it assume
that `NSData` should be treated as a binary blob and by wrapping it
automatically.

Fixes https://github.com/flutter/flutter/issues/17449

Testing Done:
* Made a sample Flutter iOS application that created a
  `FlutterMethodChannel` and invoked a method using an `NSData*`
  argument.  Verified that the Flutter method handler received the
  message and that the `MethodCall.arguments` was a `UInt8Array` that
  preserved the original byte order.
* Verified that without this change, the same sample application
  crashed when run in debug mode.

* Add a unit test for encoding raw NSData

* Formatting adjustments

Decouple PlatformViewsController from FlutterView.

Instead of getting a FlutterView instance, depend on the specific interfaces required by
PlatformViewsController (BinaryMessenger, TextureRegistry, and Context).

This allows using PlatformViewsControlling in the flutter/embedding
code.

Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (#6307)

* Revert "Add logging if FlutterDartProject fails to load the application kernel snapshot (#6257)"

This reverts commit d29c7db7.

* Revert "Update deprecated subtags from language subtag registry. (#6280)"

This reverts commit 2a1debfc.

* Revert "Add Xib splashscreen support (#6289)"

This reverts commit 540cd962.

* Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (#6279)"

This reverts commit 05f21e63.

https://skia.googlesource.com/skia.git/+log/c25f440d537e..358558a4cecc


Created with:
  gclient setdep -r src/third_party/skia@358558a4cecc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

To make "Engine run configuration was invalid." failures (e.g.
https://github.com/flutter/flutter/issues/20777) a bit easier to
diagnose, add some more logging to `FlutterDartProject` to verify
that snapshot assets were properly bundled.

https://skia.googlesource.com/skia.git/+log/d842557c0724..c25f440d537e


Created with:
  gclient setdep -r src/third_party/skia@c25f440d537e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

https://skia.googlesource.com/skia.git/+log/38ca6d509d9f..d842557c0724


Created with:
  gclient setdep -r src/third_party/skia@d842557c0724

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

https://skia.googlesource.com/skia.git/+log/05cf051f0252..38ca6d509d9f


Created with:
  gclient setdep -r src/third_party/skia@38ca6d509d9f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

https://skia.googlesource.com/skia.git/+log/44c6167c4125..05cf051f0252


Created with:
  gclient setdep -r src/third_party/skia@05cf051f0252

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

On the iPhone X, raising the keyboard sets a bottom physical inset equal
to the keyboard height, however we previously did not zero out the bottom
physical padding. This was incorrect; when a soft keyboard is present,
it 'consumes' the safe area inset for the home indicator widget,
eliminating the need for the app to handle this at all.

https://skia.googlesource.com/skia.git/+log/c9873a5f8b8e..44c6167c4125


Created with:
  gclient setdep -r src/third_party/skia@44c6167c4125

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

46ec629096 [vm/bytecode] Trigger JIT-compilation from interpreter
9f5aecb22b Introduce a new flag to the Dart Analysis Server: --ux-experiment-1 which changes analysis roots to the be the current set of priority files.
9f72b09f0f Convert resolver.dart to triple-slash comment style.
ee0a6033bf Fix checks for absence of concrete implementations of super-invoked members.
3a5b748521 Optimize index data structure for search by supertype id.
af2fd419fb Update more analyzer error codes to be generated from messages.yaml
0bbdd8f7d9 [build] Correctly rebase kernel-service output for depfile
cbf60679eb [vm/fuzzer] Migrated driver from Python to Dart.
e95d944f5f [VM interpreter] Propagate error from invoked compiled function to interpreter caller.
05ba85399f Cleanup fasta parser rewriter insert token methods
07a1f233f8 Improve parser recover to fix more code completion tests
ffa99b9cde Update analyzer error code generation
fa0b38b45d Fix some constructor initializer code completion situations
2455141018 Remove ClassElement.isSuperConstructorAccessible().
3263550e86 [vm] Decouple bytecode reading from compilation
e3dbea9523 Convert declaration_resolver.dart to triple-slash comment style.
d32e93db46 Remove unused import.
4baa3ec951 Create a base class for non-error resolver test cases.
2e43557274 Mark Kernel classes that were Dart mixin declarations

Revert "Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (#6290)" as it broke Windows buildbot. (#6292)

This reverts commit 09afb2b8.

https://skia.googlesource.com/skia.git/+log/c9873a5f8b8e..f3ebd312f213


Created with:
  gclient setdep -r src/third_party/skia@f3ebd312f213

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

https://skia.googlesource.com/skia.git/+log/9369031fde2d..c9873a5f8b8e


Created with:
  gclient setdep -r src/third_party/skia@c9873a5f8b8e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll dart to c688d0c0c3ad3dece3a79ce0e115d787a94707ea.

Changes since last roll:
```
c688d0c0c3 [frontend] When serializing compiled expression proc, clone type params first.
346895eb35 Choose the right platform in the command-line fasta tool in strong mode
51d530475a [frontend] Honor embedSourceText option in incremental compiler.
06792cb91f Remove StackListener.popList
69cd7cb43f [infra] Add compare_results.dart and update_flakiness.dart.
c3c4e63ce4 Adjusted spec to use package syntax, thus eliminating bnf.sty
0315707dec Add 'set' case to type_variable_conflict_test
00f2054242 Add --repeat flag to test.py, so tests can be run multiple times
cf5cdea808 Add J/K versions CommonElements and ElementEnvironment
1681241062 Remove _ClassEnsurer
a5b71813ab Use json expectation files in dynamic tests
d560887ae5 Fix TypeError in Observatory
867c5271be Debugging dart in methods with dynamic type arguments
2e3f17fa2b Add support for the new mixin syntax to supertype constraint checking and resynthesis.
929b2fbc55 Adjust status file to account for CustomIsolates test passing now.
f0974aee20 Remove entry_points option from the test harness (should fix the precompiler bot failure).
296e4aa7e6 Split mixin_declaration_inference_valid_classes_test.dart into multiple tests.
2c427d33fc Train the dartanalyzer on less source.
41273507b2 Detect references to instance variables without declared type.
a0776096b9 Cleanup some of the build rules to not use Dart 1 mode.
3463f94ed9 Delete any existing version of a DevFS file before overwriting the file
7763ec3cd1 Surface analyzer toplevel inference limitations as DDC errors.
a386c07281 [vm/aot] Add extra call specialization pass
878017481f Roll dart_style to 1.2.0.
a890d95a26 [vm/compiler] Avoid !(x>y) -> x<=y on fp operands.
bc79674bc1 [vm/aot] Fix inferred type of implicitly initialized final fields
7df4900a94 Train the dartanalyzer tool on generating summaries.
80c1b88626 Add copyright comments in resolution tests.
bbe49524be Cache mapping from subtypes names to files where they are subtyped.
cf67e402bd Add test case reproducing issues #34498 and #34500.
81ce969060 Enable implicit constructors with optional parameters in mixin applications.
cb331064e0 Compare AnalysisOptions signatures in analyzer_cli.
eb059a76f3 Keep analyzer-specific status entries together in language_2_analyzer.status
62ce86e20c Add --test-list and --repeat options to test.py, for deflaking
9e86c1a395 Normalize strong.status
3831da8743 Include all problems in expectations
a1bd50168e Make input validation optional
6fe272314d Tweak parameters of ProcessedOptions
0a5d7b866d Update status files after de984e58.
de984e58cb Type checking for redirecting factories.
4134b95a3d [vm/tfa] Streamline handling of tear-offs in TFA
d44ffba254 [vm/tfa] Stop accepting non-empty entry points json files
30f0026022 [VM runtime] Fix type test: C is a subtype of C<FutureOr> (fixes #34482).
bbe83465ea Test that type of the ListLiteral with two different enums is inferred.
37b41bd317 Update status files after d4148159cc39d3f38d8295cf79ed736c6337d7ac
d9fcaa33b1 Implement StreamTransformer.fromBind
abb392fc0d add Pubspec.dependencyOverrides
c733ed7fd7 firefix status for LayoutTests/fast/dom/Range/getClientRects-character_t01
d4148159cc Initial valid inference checks
dcabf2cb0e Test for mixin declaration isObject and tweaks for error verifier.
```

* Update license

https://skia.googlesource.com/skia.git/+log/1d6281d4bb47..9369031fde2d

Created with:
  gclient setdep -r src/third_party/skia@9369031fde2d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.