- 18 6月, 2015 27 次提交
-
-
由 Hixie 提交于
Some files are moved by this: Copy framework/node.dart into types/ - preparing for framework/'s decomissioning. Move app/scheduler.dart into sky/scheduler.dart - "app" doesn't really make sense. As part of the SkyBinding cleanup, I made the hit-testing less RenderBox-specific, by having the HitTestEntry.target member be a HitTestTarget, which is an interface with the handleEvent() function, which is then implemented by RenderBox. In theory, someone could now extend hit testing from the RenderBox world into their own tree of nodes, and take part in all the same dispatch logic automatically. This involved moving all the hit testing type definitions into a new sky/hittest.dart file. Renamed SkyBinding._app to SkyBinding._instance for clarity. Moved code around in SkyBinding so that related things are together. Made WidgetSkyBinding use the existing SkyBinding.instance singleton logic rather than having its own copy. I also added some stub README.md files that describe dependencies. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1187393002.
-
由 Carlos Pizano 提交于
So we can tell l-click from r-click. BUG=none R=abarth@chromium.org Review URL: https://codereview.chromium.org/1192023002.
-
由 Hixie 提交于
Summary: framework/animation/* -> animation/* framework/debug/utils.dart -> debug/utils.dart framework/shell.dart -> mojo/shell.dart framework/embedder.dart -> mojo/embedder.dart framework/net/* -> mojo/net/* This should have no code changes except fixing and reordering imports. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1189943004.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1191793004.
-
由 Hixie 提交于
Introduce a LeafRenderObjectWrapper abstract class so that RenderObjectWrappers that are leaves don't have to all redundantly assert that they're not misused. Also, make images use their URL as their src. Other misc code cleanup. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1191443009.
-
由 Hixie 提交于
Move app/view.dart to rendering/sky_binding.dart since it's part of the RenderObject API, really (it knows about RenderView intimately). The tests pass. I didn't check every last example. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1183913006.
-
由 Adam Barth 提交于
Also, trim the redundant |Mode| suffix from the TransferMode names. R=ianh@google.com Review URL: https://codereview.chromium.org/1188003006.
-
由 Adam Barth 提交于
Buttons and menu items use onPressed. Also, don't pass along the sky.Event because that's a lower-level concept. I've also reordered parameter lists to put the |child| argument last in a number of places. Also, fixed a bug where FloatingActionButton was missing syncFields. R=ianh@google.com Review URL: https://codereview.chromium.org/1188993003.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1187023005.
-
由 Hixie 提交于
Doesn't affect any APIs. TBR=abarth Review URL: https://codereview.chromium.org/1184823007.
-
由 Hans Muller 提交于
Defined constants for all 9 CSS font-weight values with conventional names from the "Common weight name mapping" section of https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight. The FontWeight enum now just enumerates the actual CSS weight values. I've moved the TextStyle class into its own file. R=ianh@google.com Review URL: https://codereview.chromium.org/1173323004.
-
由 Hixie 提交于
This also moves the test for stocks into a new tests/examples/ directory, where we can put tests that test the examples. TBR=abarth Review URL: https://codereview.chromium.org/1182223004.
-
由 Hixie 提交于
Turns out it's ok to not detach all the RenderObjects from the widget tree from each other, since they're not reused... but the WidgetToRenderBoxAdapter's renderBox _is_ reused, so we better detach that one. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1191053002.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1194473004.
-
由 Hixie 提交于
This removes the requirement that things with the same type things have unique keys. Now, anything without a key is assumed to be interchangeable. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1178723010.
-
由 Hixie 提交于
- removes the unit testing framework from tests that don't use it - use 'async' where that makes the code less convoluted R=abarth@chromium.org Review URL: https://codereview.chromium.org/1192003003.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1191973003.
-
由 Collin Jackson 提交于
R=ianh@google.com TBR=hixie Review URL: https://codereview.chromium.org/1185283004.
-
由 Hixie 提交于
Clean up how we remove nodes from the render tree, and make sure we reinsert them in the right place. Fixes weird behaviours when the old and new children of TagNodes can't be synced. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1182463006.
-
由 Collin Jackson 提交于
R=ianh@google.com, hixie Review URL: https://codereview.chromium.org/1192543004.
-
由 Adam Barth 提交于
The underlying problem is that we lacked a RenderObjectWrapper for the RenderView, which meant we couldn't handle changing the RenderObject that was the root of the RenderView. This CL introduces a RenderViewWrapper and uses it in a new AppContainer widget root. This change allows us to make App a non-magical Component that is inserted into the AppContainer in the newly introduced runApp function. R=ianh@google.com Review URL: https://codereview.chromium.org/1184823006.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1195493002.
-
由 Adam Barth 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1188163004.
-
由 Hans Muller 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1194583002.
-
由 Adam Barth 提交于
They no longer exist but I forgot to remove them in my previous CL. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1192603003.
-
由 Hans Muller 提交于
If action: was specified, content: was added twice. R=jackson@google.com Review URL: https://codereview.chromium.org/1188303002.
-
由 Adam Barth 提交于
This framework is two generations old and has no clients. R=ianh@google.com Review URL: https://codereview.chromium.org/1177843010.
-
- 17 6月, 2015 13 次提交
-
-
由 Adam Barth 提交于
R=hansmuller@chromium.org Review URL: https://codereview.chromium.org/1183603003.
-
由 Adam Barth 提交于
I missed one rename in my Listener CL. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1180243003.
-
由 Adam Barth 提交于
Fixed ` vs ' typo.
-
由 Adam Barth 提交于
There's lots more ground to cover, but this CL is a start. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1187173003.
-
由 Adam Barth 提交于
The basic widgets are going to be used many, many times, so we want them to have short, snappy names. Also, give the Widget argument to Listener the name |child| for consistency. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1193513007.
-
由 Collin Jackson 提交于
This fixes the test TBR=abarth Review URL: https://codereview.chromium.org/1192533002.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1191863002.
-
由 Chinmay Garde 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1185813005.
-
由 Adam Barth 提交于
The dialog will need many more features to be complete, but this class is a basic skeleton of what we'll need. R=jackson@google.com, jackson@chromium.org Review URL: https://codereview.chromium.org/1189893002.
-
由 Hixie 提交于
TBR=abarth,jackson Review URL: https://codereview.chromium.org/1178323004.
-
由 Adam Barth 提交于
Specifically, RaisedButton, FlatButton, and FloatingActionButton. These just test that these classes work in their default configurations. R=ianh@google.com, jackson@chromium.org Review URL: https://codereview.chromium.org/1193453005.
-
由 Ryan Macnak 提交于
Standalone changes were in https://codereview.chromium.org/1166433008/ R=abarth@chromium.org Review URL: https://codereview.chromium.org/1183453004.
-
由 Hans Muller 提交于
This is a completion of Eric's WIP patch: https://codereview.chromium.org/1179663005/ Low level support for creating a paragraph that contains runs of styled text. The styles may be nested. The Paragraph and RenderParagraph classes have been replaced by Inline and RenderInline. Styled text is defined with a tree of InlineText and InlineStyle objects. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177833012.
-