The response APIs for method channels and event channels used pointers
for optional parameters; this kept the API surface simple, but meant
that they couldn't take rvalues. As a result, returning success values
or error details often took an extra line, declaring a variable for the
result just to have something to pass the address of.

This converts them to using references, with function overloading to
allow for optional parameters, so that values can be inlined.

For now the pointer versions are still present, so that conversion can
be done before it becomes a breaking change; they will be removed soon.

Part of https://github.com/flutter/flutter/issues/63975

This reverts commit 9893a293.

Landing on red to fix the build.

Manual land of roll - two bots on luci-engine are red due to flakes.

https://skia.googlesource.com/skia.git/+log/17c5b7024297..e1e240804211

2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ff3c275665f9 to e45f0c4dce5a (503 revisions)
2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from b54c82ed3948 to eff9ef0f2212 (2 revisions)
2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 699bcde0b729 to 5dff6075d29f (19 revisions)
2020-08-20 mtklein@google.com Revert "Add utilities to SkGeometry for quad and cubic rotation angles"
2020-08-20 mtklein@google.com Revert "remove sksl interpreter guards"
2020-08-20 ethannicholas@google.com Revert "Added support for the 'inline' hint on SkSL functions"
2020-08-20 ethannicholas@google.com Revert "SkSL CPP and H backends no longer emitted in non-dev builds"
2020-08-20 ethannicholas@google.com Revert "SkSL now supports uniform array types"
2020-08-19 csmartdalton@google.com Move GrWangsFormula::nextlog2 to sk_float_nextlog2
2020-08-19 johnstiles@google.com Remove final vestiges of sk_InColor.
2020-08-19 ethannicholas@google.com SkSL now supports uniform array types
2020-08-19 csmartdalton@google.com Add utilities to SkGeometry for quad and cubic rotation angles
2020-08-19 mtklein@google.com update placeholder approx op count
2020-08-19 johnstiles@google.com Remove sk_InColor from unit tests.
2020-08-19 adlai@google.com Remove GrContext variant of SkImageGenerator::isValid
2020-08-19 johnstiles@google.com Fix simplification of switch statements with casts.
2020-08-19 reed@google.com pass 'nested' bool to approximateOpCount
2020-08-19 mtklein@google.com clean up SK_LATE_DITHER
2020-08-19 ethannicholas@google.com Added support for the 'inline' hint on SkSL functions
2020-08-19 mtklein@google.com remove sksl interpreter guards

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

I just made a pass on the scenario scripts so that they can be more easily run from the scenario directory, set the ANDROID_HOME correctly, and generally fixed lint errors.

Also compile_android_aot.sh didn't appear to work, and I think I fixed it (it builds now).

Builders are read from a json file to get their last builds using
buildbucket and calculate the tree status. Some builders were not being
used for the tree status validation allowing rollers to land changes
even though some builders were failing.

Bug:
  https://github.com/flutter/flutter/issues/64061

Fix flutter#40068 Redraw issues on resize/minimize/maximize on Windows and startup in release (#20357)

* Fix redraw issues

* Address CR feedback.

* Fix build

* CR feedback

Missing default focus when navigating to a page with no SemanticsNode that sets namesRoute:true (#20516)

* Hint the VM when a layer or picture goes out of scope

* update chrome version, should be merged after recipe changes

* changing directory to use chrome driver in LUCI

* changing directory path's order

* add cipd packages's chrome version for mac

* addressing reviewer comments

* more documentation. update readme

* remove late since it didn't build. remove distinction in paths for local and LUCI.

* addressing reviewer comments. (non-null fields needs rechanging)

* addressing reviewer comments. adding 2.6 on files missing the notation

Skia is removing the ctors on these structs so removing them.

Adds APIs for runners to delegate WindowProc handlers into the Flutter
engine, and for plugins to register as possible delegates.

This allows for plugins to alter top-level window behavior in ways that
can only be done from the WindowProc, such as resize control. This
functionality remains entirely on the native side, so is synchronous.

Part of https://github.com/flutter/flutter/issues/53168

* Remove doc comments in copied web interfaces

* Whitespace changes to improve readability

* rename "compositor"/"surface" to "canvaskit"/"html"; document conventions

This converts the ci/format.sh script to a Dart script that uses process_runner and isolates to multi-process the clang-format, diffs, and grepping needed to do the formatting changes.

It also will (by default) only check the formatting of changed files.

The user can optionally check all files (--all-files) or do only some types of checks with --check. --verbose prints the versions of the tools used for Clang format and Java format.

Specifying --fix will cause any formatting errors that would have been detected to be fixed.