Image
Codec
FrameInfo
Scene/Picture toImage

Revert "Try rasterizing images and layers only once , even when their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (#16545)" (#16889)

This caused regression in several benchmarks, including:
animated_placeholder_perf. Regression tracked in
https://github.com/flutter/flutter/issues/51776.

This reverts commit 01a52b99.

dart-lang/sdk@ 09bbd3cca5 [VM/concurrency] - Temporary workaround for issue https://github.com/dart-lang/sdk/issues/40836
dart-lang/sdk@ 5af2cc768a [dart2js] Add a raw type predicate to LegacyType and NullableType which forwards to the wrapped type.
dart-lang/sdk@ 5b23373f7e Modify fields in some abstract and native classes
dart-lang/sdk@ 9f79dfc37d Address analyzer errors in golden files in dart:html
dart-lang/sdk@ 80f84e1942 Change all fields to native getters/setters
dart-lang/sdk@ 3ec6ec2a2d Change getters/setters to native for nnbd
dart-lang/sdk@ e797a066dc Separate canvasrenderingcontext2d into multiple tests
dart-lang/sdk@ d2bd9691aa [vm] Remove unused Resolver::ResolveStaticAllowPrivate
dart-lang/sdk@ 7f483c067c Set TypeName type of unresolved class with prefixed identifier in instance creation.
dart-lang/sdk@ dc366a5ad5 [nnbd_migration] Assert an edge origin exists in _checkAssignment
dart-lang/sdk@ 3ae91fc8c5 [nnbd_migration] Add an edge origin for `return;`
dart-lang/sdk@ 1d1f3a5049 [nnbd_migration] Origin for inferred instance creation bounds
dart-lang/sdk@ e9df1ee07a [nnbd_migration] Add an edge origin for inferred parameter substitution
dart-lang/sdk@ 42d0c8245d [nnbd_migration] Add edge origin for explicit instantiation params
dart-lang/sdk@ 18814410a4 [nnbd_migration] Record edge origin for explicit call parameters
dart-lang/sdk@ c0bcfb7d0c [nnbd_migration] Add a description for type parameter instantiation
dart-lang/sdk@ 734ad9c00c [nnbd_migration] Add an edge origin for type name parameters.
dart-lang/sdk@ 8e3850395a [dartdev] refactor the dartdev pub command - delegate to the pub snapshot
dart-lang/sdk@ 34fcc56458 Fix for renaming named formal parameters from invocations, when synthetic.

* script for fetching correct flutter version

* change cirrus yml for the script location

* change location of the script. Add it to tools

* cirrus still does not see the script. repeat path change from the previous step

* Looks like script worked correctly. do not change directory.

* change directory back to build root after scriot is run

* script runs ok. Still not able to find the bin directory. go all the way back

* still can't see the bin directory. carry the script content to cirrus.yml to debug better

* get the last commit id of the right repository

* content of the script worked in cirrus. call the script from tools

* cannot find the script under tools

* print the current path in the script to see why cirrus cannot see bin directory

* move to flutter path before running update packages

* tests run now. remove print outs

* error if the ENGINE_PATH is not set. exit the script

* addressing reviewer comments

* engine branch name on cirrus logs doesn't make sense

* fix typo

* change the directory of branch calculation

* remove extra logs

* addressing PR comments. Testing CIRRUS_CI env variable

* adding CIRRUS_CI check

Try rasterizing images and layers only once, even when their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (#16545)

If Rasterization fails, i.e. image.is_valid() is false, the cache might try rasterizing the image again on the next frame. Not only is this wasteful put might also prevent other pictures to be cached within the current frame budget.