Manual Dart roll fa4379946109467c8a48f20f19d83d7c72968a3e...d45c3d15cb3cea0104a87697c085259666eec528 (#13761)

dart-lang/sdk@d45c3d15cb [VM/nnbd] Make Nullability and NNBDMode class enums to avoid name conflicts.
dart-lang/sdk@cfec969eff Update dartdoc version to 0.29.1.
dart-lang/sdk@e3e0ef8548 Make explanations for unchanged types optional and disabled by default
dart-lang/sdk@e39b0f8d99 Disallow a deferred import of a library with extensions if any extensions are visible
dart-lang/sdk@9c983d2ee3 [cfe] Support extensions via prefix
dart-lang/sdk@5f5ce5d119 Include type parameter bounds into string expections for subtyping.
dart-lang/sdk@dc69edcdb3 NullabilityEliminator for removing nullabilities in legacy libraries.
dart-lang/sdk@7ad7e6202d Allow extensions imported with a prefix to be accessible
dart-lang/sdk@ea57b1e62c [VM/nnbd] Pass nullability when creating Class::DeclarationType.

* Implement Path.computeMetrics in the CanvasKit backend

* Add license for path_metrics.dart

Fixes https://github.com/flutter/flutter/issues/41086

Manual roll of Dart e68ca9b652acdb642668a6acb5f630d5be6c03da...fa4379946109467c8a48f20f19d83d7c72968a3e (#13756)

dart-lang/sdk@fa43799461 [vm/bytecode] Check number of type arguments in non-generic closures
dart-lang/sdk@a01c3b464e Use TypeParameterElement(s) as free variables in FunctionType.toString().
dart-lang/sdk@9c4c49d9ee [vm/benchmarks] Reduce number of isolate spawn runs from 5 to 3.
dart-lang/sdk@e3aac9e25d Check more in LegacyTypeAsserter.
dart-lang/sdk@0957c13054 Check for null before dereferencing constraint text.
dart-lang/sdk@fd9f79c25d [cfe] Handle deferred explicit extension access
dart-lang/sdk@7c78ab75a5 Migration: allow already-migrated libraries to be opted in.
dart-lang/sdk@6317779f9b Simplify TestTypeProvider constructor.
dart-lang/sdk@7e8e66016a Migration: do not use `always` or `never` in already-migrated types.
dart-lang/sdk@e4a60912a7 [cfe] Use library's NNBD opt-in status while serializing supertypes
dart-lang/sdk@ee2efe8e58 [CFE] Add more incremental compiler tests, prepare for better invalidation strategy
dart-lang/sdk@5eaccc20ba [CFE] Incremental test suite now has expect files
dart-lang/sdk@ec0d042955 [infra] Support multiple named configurations in test infrastructure
dart-lang/sdk@b334ea8320 [dart2js] new-rti: experiment - fault in '$is' test
dart-lang/sdk@7a45228584 Use ElementsTypesMixin in TypeSystem tests.
dart-lang/sdk@ec519c3d16 [vm/aot] Disable bytecode in AOT compilation pipeline
dart-lang/sdk@f4780a6450 [vm] Late modifier for non-static final fields.
dart-lang/sdk@23770fcc6c [vm, gc] Increase HeapPage size to 512k; increase max heap size to 32GB.

This reverts commit 618e6666.

* Add draw image test
* Optimize drawImageScaled
* optimize cloning in HtmlImage, implement drawImageRect using image tag

This removes TextRange from the framework and moves it to the engine, in preparation for using it to return text ranges from the text extent APIs, like Paragraph.getWordBoundary instead of a List<int>.

Also added new tests for TextRange.

https://skia.googlesource.com/skia.git/+log/8c1e265f6f81..c88d1774ed50

git log 8c1e265f6f81..c88d1774ed50 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 mtklein@google.com add SkColorTypeIsNormalized()
2019-11-08 jlavrova@google.com Font resolution: all unit tests working
2019-11-08 kjlubick@google.com [canvaskit] Expand SkAnimatedImage
2019-11-08 kjlubick@google.com [canvaskit] Fix null dereference when GrContext cannot be made
2019-11-08 egdaniel@google.com Handle failure to create VkRenderPasses in vulkan backend.
2019-11-08 mtklein@google.com Pre-flight SkTLS_pthread changes for C++17

Created with:
  gclient setdep -r src/third_party/skia@c88d1774ed50

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com

Revert "Always use `IOSGLContextSwitch` to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)" (#13753)

Always use `IOSGLContextSwitch` to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)

https://skia.googlesource.com/skia.git/+log/99b558b594a1..8c1e265f6f81

git log 99b558b594a1..8c1e265f6f81 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 mtklein@google.com remove redundant comparison ops

Created with:
  gclient setdep -r src/third_party/skia@8c1e265f6f81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com

Roll fuchsia/sdk/core/mac-amd64 from H_5HL... to KRali...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/3fd426d19df3..99b558b594a1

git log 3fd426d19df3..99b558b594a1 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cc0919dcb64b..652dbfc63e70 (7 commits)

Created with:
  gclient setdep -r src/third_party/skia@99b558b594a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com

https://skia.googlesource.com/skia.git/+log/76eaab6b8cef..3fd426d19df3

git log 76eaab6b8cef..3fd426d19df3 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 27a3d31d7a9d..d9ed1c2732ba (1 commits)

Created with:
  gclient setdep -r src/third_party/skia@3fd426d19df3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com

The earlier assumption was that the render target would be re-materialized per frame. The render target needs its own picture recorder to be create per frame as well. When render targets are cached in the registry, an existing target will be reused. But submitting the previous frame would have discarded the recorder already. The layer tree paint would then attempt to dererence a null canvas causing a crash at runtime.

Added tests to ensure that this does not happen both with and without a custom compositor specified by the embedder. I am going to rework this code so that the external view embedders thinks of render target access on a per frame basis but that is a larger change. This smaller patchset should unblock broken builds.

Fixes b/144093523

https://skia.googlesource.com/skia.git/+log/345a2735e2c8..76eaab6b8cef

git log 345a2735e2c8..76eaab6b8cef --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 csmartdalton@google.com Implement multisample "disable" in Vulkan
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-07 mtklein@google.com Reland "hook up float comparisons to x86 JIT"
2019-11-07 herb@google.com Remove unused methods from SkStrike
2019-11-07 mtklein@google.com avoid the JIT on MSAN builds
2019-11-07 halcanary@google.com SkPDF/docs: note that Sfntly subsetter is deprecated
2019-11-07 herb@google.com One glyph() to rule them all!!!
2019-11-07 reed@google.com flesh out blendmodes through Screen
2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-07 robertphillips@google.com Use GrProgramInfo's primitiveType field
2019-11-07 mtklein@google.com Revert "hook up float comparisons to x86 JIT"
2019-11-07 egdaniel@google.com Add handling of failed framebuffer creation in vulkan.
2019-11-07 mtklein@google.com hook up float comparisons to x86 JIT
2019-11-07 mtklein@google.com gn format BUILD.gn
2019-11-07 robertphillips@google.com Add GrPrimitiveType to GrProgramInfo
2019-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1d09b983031b..cc0919dcb64b (8 commits)

Created with:
  gclient setdep -r src/third_party/skia@76eaab6b8cef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com

* Only specify --no-link-platform when --aot isn't specified

* [dart_roll] Update to e68ca9b652acdb642668a6acb5f630d5be6c03da

https://skia.googlesource.com/skia.git/+log/f66ec5d69d04..345a2735e2c8

git log f66ec5d69d04..345a2735e2c8 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 215bc7949b35..27a3d31d7a9d (2 commits)

Created with:
  gclient setdep -r src/third_party/skia@345a2735e2c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com

Roll fuchsia/sdk/core/mac-amd64 from r1tS4... to H_5HL...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

This doc update solves our TODO in https://github.com/flutter/flutter/pull/43676/files#diff-6a35a9a692c9af7473ba1a0a74c979c8R223

dart-lang/sdk@4b9638aaa1 [VM/nnbd] Use a single byte in snapshot to write flags and nullability of types.
dart-lang/sdk@f6efefc09c [dartdevc] Move the custom type test logic to patch files
dart-lang/sdk@1994c5c323 Improve error reporting in ID tests
dart-lang/sdk@e93bf30171 fix deprecated messages for implicit getters/setters
dart-lang/sdk@b647e327aa Fix an assertion to support migration of part files
dart-lang/sdk@335b85fea1 [nnbd_migration] for tool/trial_migration, accept interest argument.
dart-lang/sdk@3e3a926690 Fix spread and Set/Map literal disambiguation when NNBD.

https://skia.googlesource.com/skia.git/+log/714f8cc3ff4b..f66ec5d69d04

git log 714f8cc3ff4b..f66ec5d69d04 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 rosasco@google.com No GL support on Fuchsia.
2019-11-06 csmartdalton@google.com Rename stencil face terminology to clockwise/counter-clockwise
2019-11-06 herb@google.com Allow more sub-pixel position bits

Created with:
  gclient setdep -r src/third_party/skia@f66ec5d69d04

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com

Roll fuchsia/sdk/core/mac-amd64 from 6Du8E... to r1tS4...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

dart-lang/sdk@bdd9e74afc Only distribute a single libtensorflowlite_c per distribution
dart-lang/sdk@c6919a6653 Add a test for issue 39254
dart-lang/sdk@89dd099cad Update TypeParameterElement.== as discussed, add tests.

https://skia.googlesource.com/skia.git/+log/6790423f84ef..714f8cc3ff4b

git log 6790423f84ef..714f8cc3ff4b --date=short --no-merges --format='%ad %ae %s'
2019-11-06 mtklein@google.com add vcmpps
2019-11-06 herb@google.com Improve the dynamic range of SkPackedGlyphID ctor
2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-06 mtklein@google.com unnest matrix multiply
2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-06 jvanverth@google.com Fix issue with RenderPipelineDescriptor creation
2019-11-06 mtklein@google.com JIT splat(0) as xor

Created with:
  gclient setdep -r src/third_party/skia@714f8cc3ff4b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com

dart-lang/sdk@c154677699 [vm] Handle trivial initializers for late fields
dart-lang/sdk@46ae3e4e7a [vm] not remove port if socket was listening by other isolates

Add fml_tests target for the fml unit tests on Fuchsia

This reverts commit 1bfb928e.

Ensure that the device pixel ratio is taken into account with window metrics in physical pixels. (#13708)

This was originally patched in https://github.com/flutter/engine/pull/13193 but
the unit-tests were written under the mistaken assumption (that has been
documented already) that the Flutter window metrics used logical pixel
coordinates. That mistake has been corrected and additional tests to verify
rendering intent has been added.

Fixes https://github.com/flutter/flutter/issues/43906
Fixes https://b.corp.google.com/issues/143529469

https://skia.googlesource.com/skia.git/+log/6e54a299cce9..6790423f84ef

git log 6e54a299cce9..6790423f84ef --date=short --no-merges --format='%ad %ae %s'
2019-11-06 bsalomon@google.com fix tolerance in read pixels tests
2019-11-06 robertphillips@google.com Revert "Fully delineate GL usage w/ skia_use_gl"
2019-11-06 mtklein@google.com guard all SkVMBlitter debug features together
2019-11-06 nifong@google.com find min and max, separared by comma. not minmax.
2019-11-06 nigeltao@google.com Inline SkWuffsCodec::readFrames
2019-11-06 rosasco@google.com Fully delineate GL usage w/ skia_use_gl
2019-11-06 borenet@google.com [infra] Remove Calmbench and ParentRevision bots
2019-11-06 nifong@google.com Record min and max frame times from skpbench in perf
2019-11-06 egdaniel@google.com Have vulkan command and descriptor sets handle failed creation.
2019-11-06 bungeman@google.com Reland "Fix empty run handling in trivial shaper iterators"
2019-11-06 michaelludwig@google.com Combine mask and edge distance in TessellationHelper

Created with:
  gclient setdep -r src/third_party/skia@6790423f84ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com

dart-lang/sdk@462a448ac8 [cfe] Integrate definite assignment, nullability and type promotion analysis
dart-lang/sdk@cfe29c45fd [doc/ffi] Update API docs message to be consistent with website

dart-lang/sdk@24f1f313a2 [cfe] Implement the rest of the NNBD-aware subtype relation
dart-lang/sdk@37d14ad2ce [ddk] Don't use Library.isExternal (second try)
dart-lang/sdk@fe3afde2eb [CFE] Parser: Don't report (recovered) operator as endClassConstructor
dart-lang/sdk@e1f19de968 [cfe] Add MemberBuilder.read/write/invokeTarget
dart-lang/sdk@239ff1408d [cfe] Add MemberBuilder.buildMembers

https://skia.googlesource.com/skia.git/+log/f00524707da7..6e54a299cce9

git log f00524707da7..6e54a299cce9 --date=short --no-merges --format='%ad %ae %s'
2019-11-06 robertphillips@google.com Assert we are now in the world of single-primitive-type render passes

Created with:
  gclient setdep -r src/third_party/skia@6e54a299cce9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com