- 20 10月, 2020 14 次提交
-
-
由 Ferhat 提交于
* Workaround for canvas element lacking support for 3d setTransform * update golden test * Add webkit workaround * Implement DOM rendering for perspective * cleanup * update goldens lock * Add check for shader and filtermask for dom use * Fix svg viewBox. Move zIndex check to bitmap canvas * Fix null check warning * Fix scene_builder zIndex=-1 test to force canvas usage * Add blendmode handling for DOM mode * Update maxdiff and golden locks * Remove unused import * Add drawcolor/drawpaint test. Fix bounds for drawColor/drawPaint * update golden locks * adjust drawColor for dpr * Update test to use canvas * Fix toDataUrl NNBD * Update Picture.toImage to use canvas to obstain image data * Remove write:true from golden calls * Add fill-rule for _pathToSvgElement * Update golden locks * Fix sceneBuilder pushClip / add missing clipBehaviour * Fix test now that clipping works correctly * move overflow handling for tests into DOMClip.addOverflow * Add clipRect to test to keep render inside bitmap canvas area * Update compositing test, fix drawColor coordinates * update golden locks * Skip test for matchGolden infra fail * update golden lock * merge * update maxdiff for text over canvas * update golden diff * update paint spread bounds maxdiff * update paint spread maxDiff
-
由 skia-flutter-autoroll 提交于
-
由 skia-flutter-autoroll 提交于
-
由 Jenn Magder 提交于
-
由 Chris Bracken 提交于
When linting flutter/vulkan/vulkan_window.cc, the call to GrDirectContext::MakeVulkan is undefined when SK_VULKAN is not defined, triggering a lint error. Bug: https://github.com/flutter/flutter/issues/68331
-
由 Jason Simmons 提交于
-
由 Chris Bracken 提交于
This implements the Gtk hooks required to support multi-step input methods on Linux. This builds on the support for composing regions (preedit region in Gtk terminology) added to TextInputModel in https://github.com/flutter/engine/pull/21682. Specifically, the following changes are included: 1. Add handler for TextInput.setMarkedTextRegion framework messages: On any change to the EditableText in the framework, this message is sent which provides an updated rect (in the local co-ordinates of the EditableText) for the composing region. If not in composing mode, the cursor rect is sent. 2. Add handler for TextInput.setEditableSizeAndTransform framework messages: On any change to the RenderObject underlying the EditableText, an updated size for the full EditableText widget, as well as an affine transform matrix from local co-ordinates to Flutter root co-ordinates is sent. 3. On either of the above messages, we use the transformed composing rect to compute the cursor position in Gtk window co-ordinates and inform Gtk, so that it can position any system IM composing window correctly for on-the-spot composing, such as is used when inputting Japanese text. 4. Adds handlers for preedit-start, preedit-changed, and preedit-end signals from Gtk. These are passed on to the TextInputModel. 5. Updates the preedit-commit handler to commit the composing region to the text or, if not composing, insert new text at the cursor. 6. Updates the handler for TextInput.setEditingState framework messages to extract the composing range base and extent and pass these on to TextInputModel. 7. Updates update_editing_state function to set composing base and extent on text input state updates sent to the framework.
-
由 J-P Nurmi 提交于
This PR fixes a few small memory leaks in FlTextInputPlugin. All three cases are creating temporary FlValue instances for lookups and comparison without ever releasing them.
-
由 Jonah Williams 提交于
-
-
由 puelo 提交于
-
由 Jason Simmons 提交于
Specify the Noto Naskh Arabic font to get consistent results in tests using Arabic characters (#21974) See https://github.com/flutter/flutter/issues/68493
-
由 gaaclarke 提交于
while we fix them.
-
由 skia-flutter-autoroll 提交于
-
- 18 10月, 2020 5 次提交
-
-
由 skia-flutter-autoroll 提交于
-
-
由 skia-flutter-autoroll 提交于
-
由 Jonah Williams 提交于
Fixes flutter/flutter#68377 Should be a nullable string. Looks like --null-assertions does not cover the native binding code.
-
由 skia-flutter-autoroll 提交于
-
- 17 10月, 2020 21 次提交
-
-
由 skia-flutter-autoroll 提交于
-
由 Ferhat 提交于
-
由 skia-flutter-autoroll 提交于
-
由 godofredoc 提交于
* Collect logs in the background. * Use fuchsia_ctl log_file option. * Delete the correct file. * Remove commented code.
-
由 skia-flutter-autoroll 提交于
-
由 Chinmay Garde 提交于
A version of this macro is present in most code-bases. The use of this macro must satisfy two requirements: 1: If reached, the process must be terminated in all runtime modes and at all optimization levels. 2: If the compiler requires a value to be returned from the function, encountering this macro should not make the compiler insist on a return value (since the process is about to die anyway). We used to have a version of this macro that wasn't widely used and didn't satisfy the two requirements. I have removed the same and another unused macro in fml/logging.h Fixes https://github.com/flutter/flutter/issues/68164.
-
由 skia-flutter-autoroll 提交于
-
由 Jason Simmons 提交于
-
由 skia-flutter-autoroll 提交于
-
由 Chris Bracken 提交于
This adds enforcement to the linter that all FLUTTER_NOLINT comments be of the form: // FLUTTER_NOLINT: https://github.com/flutter/flutter/issue/ID Every linter opt-out should have an associated bug describing what issue it works around so that others can work on eliminating it, or at least understanding the rationale and whether it's still relevant. This also reduces the likelihood of inadvertent copy-pasting into new files either because the author fails to spot it when copying the copyright block from another file, or assumes that it's necessary for some subcomponent of the engine. Bug: https://github.com/flutter/flutter/issues/68273
-
由 Chris Bracken 提交于
Eliminates FLUTTER_NOLINT where they can be landed without triggering lint failures.
-
由 skia-flutter-autoroll 提交于
-
由 Harry Terkelsen 提交于
-
由 Chris Bracken 提交于
In an upcoming patch, we'll enable enforcement that all FLUTTER_NOLINT comments include an issue link. This migrates the remaining uses to that format. Bug: https://github.com/flutter/flutter/issues/68273
-
由 George Wright 提交于
-
-
由 Chinmay Garde 提交于
Snapshots compiled with sound null-safety enabled require changes to the way in which isolates are launched. Specifically, the `Dart_IsolateFlags::null_safety` field needs to be known upfront. The value of this field can only be determined once the kernel snapshot is available. This poses a problem in the engine because the engine used to launch the isolate at shell initialization and only need the kernel mappings later at isolate launch (when transitioning the root isolate to the `DartIsolate::Phase::Running` phase). This patch delays launch of the isolate on the UI task runner till a kernel mapping is available. The side effects of this delay (callers no longer having access to the non-running isolate handle) have been addressed in this patch. The DartIsolate API has also been amended to hide the method that could return a non-running isolate to the caller. Instead, it has been replaced with a method that requires a valid isolate configuration that returns a running root isolate. The isolate will be launched by asking the isolate configuration for its null-safety characteristics. A side effect of enabling null-safety is that Dart APIs that work with legacy types will now terminate the process if used with an isolate that has sound null-safety enabled. These APIs may no longer be used in the engine. This primarily affects the Dart Convertors in Tonic that convert certain C++ objects into the Dart counterparts. All known Dart Converters have been updated to convert C++ objects to non-nullable Dart types inferred using type traits of the corresponding C++ object. The few spots in the engine that used the old Dart APIs directly have been manually updated. To ensure that no usage of the legacy APIs remain in the engine (as these would cause runtime process terminations), the legacy APIs were prefixed with the `DART_LEGACY_API` macro and the macro defined to `[[deprecated]]` in all engine translation units. While the engine now primarily works with non-nullable Dart types, callers can still use `Dart_TypeToNonNullableType` to acquire nullable types for use directly or with Tonic. One use case that is not addressed with the Tonic Dart Convertors is the creation of non-nullable lists of nullable types. This hasn’t come up so far in the engine. A minor related change is reworking tonic to define a single library target. This allows the various tonic subsystems to depend on one another. Primarily, this is used to make the Dart convertors use the logging utilities. This now allows errors to be more descriptive as the presence of error handles is caught (and logged) earlier. Fixes https://github.com/flutter/flutter/issues/59879
-
由 skia-flutter-autoroll 提交于
-
由 skia-flutter-autoroll 提交于
-
由 skia-flutter-autoroll 提交于
https://dart.googlesource.com/sdk.git/+log/e655b9a3839e..b58cfe5ab24e 2020-10-16 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.11.0-230.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,asiva@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
-