- 27 6月, 2015 8 次提交
-
-
由 Adam Barth 提交于
We're trying to follow the pattern described in https://www.dartlang.org/tools/pub/package-layout.html TBR=iansf@google.com Review URL: https://codereview.chromium.org/1210173004.
-
由 Hans Muller 提交于
When both icons and text are specified, the icon goes on top, 10 pixels of margin goes in between, and the TabBar's height grows to 72. R=ianh@google.com Review URL: https://codereview.chromium.org/1213043002.
-
由 Hixie 提交于
Added a OffsetBase class that Size now inherits from, and added a new Offset class that also inherits from OffsetBase. Offset has: - dx and dy members - zero and infinite static constants - a method that returns a new Offset that's the existing one scaled by a scalar - a unary minus operator - operators overloads such that subtracting or adding two Offsets gives another Offset - a toPoint() method Added Offset and Size to the dart bindings, so they can be used from C++. Changed the Canvas API to use Point, Size, and Offset where appropriate: - drawLine uses Points now - drawCircle uses a Point now - drawImage uses a Paint now - the constructor uses a Size Changed Point as follows: - added a unary minus - Point difference now gives an Offset rather than a Size - You can add an Offset to a Point to get a new Point - toSize() has been replaced by toOffset() Changed Rect as follows: - renamed upperLeft and lowerRight to topLeft and bottomRight for consistency with our other APIs - added bottomLeft and topRight for completeness Changed Size as follows: - now inherits from OffsetBase - added *, /, ~/, and % operators for scaling sizes - subtracting a Size from a Size gives an Offset - subtracting an Offset from a Size gives a Size - changed the + operator to take an Offset instead of a Size - added topLeft, bottomLeft, topRight, bottomRight to match Rect - added center for the same reason - added shortestSide getter since that was a common pattern - removed toPoint() Changed DrawLooperLayerInfo as follows: - setOffset member takes an Offset instead of a Point Changed BoxConstraints as follows: - added biggest getter since it was a common pattern - added smallest getter for symmetry Changed BoxShadow as follows: - offset member is an Offset rather than a Size Changed ViewConstraints as follows: - replaced height and width members by a single size member I did some minor code cleanup in nearby files while I was there, including sorting sky/engine/core/core.gni alphabetically, and fixing some warnings in the examples. BUG= R=abarth@chromium.org, chinmaygarde@google.com Review URL: https://codereview.chromium.org/1214833004.
-
由 Ian Fischer 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1218593002.
-
由 Hans Muller 提交于
It's a typo I introduced in https://codereview.chromium.org/1217533002 TBR=ianh Review URL: https://codereview.chromium.org/1221473002.
-
由 Hans Muller 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1217533002.
-
由 Hans Muller 提交于
Also added a smoke test for examples/widgets/tabs.dart. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1213873002.
-
由 Hixie 提交于
- Rename animate() to watch(). - Fix Toggleable to actually be animated (previously, it was essentially luck that let it be animated -- it was piggy-backing on the splash, I think). R=abarth@chromium.org Review URL: https://codereview.chromium.org/1216533003.
-
- 26 6月, 2015 8 次提交
-
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1208293002.
-
由 Hixie 提交于
Let's hide double.INFINITY a bit more, by providing cleaner APIs for the cases where we're currently trying to use it. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1209233002.
-
由 Hixie 提交于
Add a note about sizedByParent's use. One day we should audit our RenderBoxes and see if any of them can have it set; currently only Scaffold uses it. TBR=abarth Review URL: https://codereview.chromium.org/1216533002.
-
由 Hixie 提交于
New asserts: - verify that after layout, the size fits the constraints - verify that after layout, the size isn't infinite - verify that you don't set the size in performLayout() if you have sizedByParent set - verify that nobody reads your size during layout except you, or your parent if they said parentUsesSize:true Fixes some bugs found by those asserts: - RenderBlock, RenderStack, and RenderScaffold were not always setting parentUsesSize correctly - RenderScaffold was setting its slot entries to null rather than removing them when the slot went away, which led to null derefs in certain circumstances Also, rename a local variable in RenderStack.performLayout() because it was shadowing a variable on the object itself, which was really confusing when I first tried to debug this function... R=abarth@chromium.org Review URL: https://codereview.chromium.org/1213473003.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1204373003.
-
由 Hans Muller 提交于
There's is no support for animating the selected tab indicator, there isn't a TabNavigator container yet, overflow layout (tabs don't fit) isn't supported yet, etc. R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1205953002.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1206373002.
-
由 Hixie 提交于
TBR=collin,hansmuller Review URL: https://codereview.chromium.org/1211573003.
-
- 25 6月, 2015 4 次提交
-
-
由 Hixie 提交于
This also fixes the C++ side to give the right baseline information. Previously it was giving the baseline distance for the font, but not for the actual laid-out text. I considered also providing a "defaultBaseline" accessor that returns the distance for the actual dominant baseline, but it turns out right now we never decide the baseline is ideographic. We always use the alphabetic baseline. We should probably fix that... R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1200233002.
-
由 Hixie 提交于
Also, some minor cleanup in TextStyle to make it more readable. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1203253002.
-
由 Hixie 提交于
R=eseidel@chromium.org, eseidel Review URL: https://codereview.chromium.org/1210653002.
-
由 Ian Fischer 提交于
Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia counterparts. Also changes the framework dart code to use the refactored APIs and fixes the various examples and tests. R=abarth@chromium.org, ianh@chromium.org Review URL: https://codereview.chromium.org/1190123003.
-
- 24 6月, 2015 6 次提交
-
-
由 Collin Jackson 提交于
R=ianh@google.com, abarth, hixie Review URL: https://codereview.chromium.org/1201273002.
-
由 Eric Seidel 提交于
Publishing sky to fix sky_tool. https://github.com/domokit/mojo/issues/262 TBR=johnmaccutchan@google.com Review URL: https://codereview.chromium.org/1205653002.
-
由 Eric Seidel 提交于
We now have to run mojom/lib/generate.dart before we can launch a sky app. :( Fixes https://github.com/domokit/mojo/issues/262 R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/1205623002.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1198293005.
-
由 Collin Jackson 提交于
R=eseidel@chromium.org, eseidel Review URL: https://codereview.chromium.org/1192773004.
-
由 Hixie 提交于
Fix the indenting of the toString() output of the RenderTree, which was broken around RenderParagraph. TBR=eseidel Review URL: https://codereview.chromium.org/1199913009.
-
- 23 6月, 2015 7 次提交
-
-
由 Adam Barth 提交于
This file doesn't belong in the SDK because it is an implementation detail of the Sky engine. Instead, this CL moves the code for dart:sky.internals into the snapshot. This CL is a step towards merging dart:sky.internals with dart:sky, which also resides in the snapshot. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1200953007.
-
由 Adam Barth 提交于
The plan is to use this service for game assets and offline assets. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1193763004.
-
由 Collin Jackson 提交于
R=ianh@google.com, hixie Review URL: https://codereview.chromium.org/1204523002.
-
由 Hixie 提交于
Short-circuit the relayoutSubtreeRoot when the child couldn't change dimensions anyway because the parent constrained it. The relayout subtree root concept is intended to handle the case where a node, when it lays itself out for a second time, changes its opinion about what dimensions it should be. In such a situation, the parent, if it based its own opinion about what size _it_ should be on the child's dimensions, would also need to lay itself out again. Thus, when this scenario is possible, the child remembers the parent, and when it would be told to relayout, we actually start the layout with the parent. In practice, this chains, and we end up with nodes that point to ancestors ten or more steps up the tree such that when the inner most child re-lays-out, the whole app ends up relaying out. This patch tries to short-circuit this for the case where the constraints being applied to the child are such that actually, the child has no choice about its dimensions. In that case, the parent can't change dimensions when the child re-lays-out. This makes a huge difference on the stocks demo app. Without this, on the third rendered frame, there are 72 relayoutSubtreeRoot links, the deepest chain is 8 deep, and 9 of the chains are only 1 level deep. With it, there are 63 relayoutSubtreeRoot links, the deepest chain is only 4 deep, and 38 of the chains are only 1 level deep. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1196553004.
-
由 Hixie 提交于
Update sky_server: - update its help string to admit that it wants the package path as well. - be quiet by default, since it makes the build chatty. - have a -v for verbose mode, for people who like it chatty. - have a default port of 8000, since that's what everyone used. - have a -p option to set the port, for people who don't use the default. - remove its mapping for gen/, since a TODO told me to. - remove the dependency on the build configuration, since it's no longer used. - teach it about .dart files. - rename sky_server/README to README.md, for consistency with other READMEs. Update shelldb to speak the new sky_server protocol. Update tests/services/iframe-embed-vmc.sky since the sky_server change broke the hack it was using. Update skyserver.py to speak the new sky_server protocol. Make webkitpy use SkyServer instead of spawning sky_server itself, since a TODO told me to. Teach webkitpy about dart files. Teach test_perf about dart files. (untested) Teach sky_tool about main.dart, main.sky is deprecated. (untested) R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1200993002.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth, hixie Review URL: https://codereview.chromium.org/1194743003.
-
由 Eric Seidel 提交于
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/1197113003.
-
- 22 6月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Previously this README discussed fn.dart. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1199753002.
-
- 20 6月, 2015 6 次提交
-
-
由 Adam Barth 提交于
They're in the Material design color palette. This also adds a file-level dart doc comment. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1190413003.
-
由 Hans Muller 提交于
Also restored the blue line that appears below focused Input text. R=ianh@google.com Review URL: https://codereview.chromium.org/1194113002.
-
由 Hixie 提交于
Turn on wavy underlines. The waves aren't very pretty yet (they are too short somehow), I'll fix that in a subsequent CL. I abstracted out the wavy underline code so that it doesn't duplicate the code for horizontal and vertical lines. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1201503003.
-
由 Adam Barth 提交于
We're now 25% faster as scrolling the infinite list than stocks1. This CL makes cleans up some code to avoid calling layout on all the rows in the stocks list. Instead, we only layout a row when it first enters the list. R=ianh@google.com Review URL: https://codereview.chromium.org/1195113002.
-
由 Adam Barth 提交于
This Dart library exposes a more idiomatic interface to the asset_bundle service and provides integration with dart:sky. R=viktorl@google.com Review URL: https://codereview.chromium.org/1200463002.
-
由 Hans Muller 提交于
Currently only the decoration property is actually translated to a CSS style. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174213005.
-