1. 11 7月, 2019 23 次提交
  2. 10 7月, 2019 10 次提交
    • S
      Roll src/third_party/skia a3ffaabcc4f2..96fdfe0fe88e (5 commits) (#9731) · 6cf0d135
      skia-flutter-autoroll 提交于
      
      https://skia.googlesource.com/skia.git
      /%2Blog/a3ffaabcc4f2..96fdfe0fe88e
      
      git log a3ffaabcc4f2f0673ee423f45aa858599ed4fc4f..96fdfe0fe88ea318f0e87ec6a56fb05013849690 --date=short --no-merges --format=%ad %ae %s
      2019-07-09 benjaminwagner@google.com Fix test TextBlob_serialize
      2019-07-09 bungeman@google.com Fix header name in build file.
      2019-06-21 jlavrova@google.com Adding locale
      2019-07-09 bsalomon@google.com Restore GL_UNPACK_ROW_LENGTH to 0 between MIP levles
      2019-07-09 egdaniel@google.com Move last few uses of SkColorType out of GrCaps.
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (fmalita@google.com), and stop
      the roller if necessary.
      6cf0d135
    • S
      Fix Fuchsia build. (#9730) · 49a00aed
      Siva 提交于
      49a00aed
    • S
      Roll src/third_party/dart 06c3d7ad3a...09fc76bc51 (#9728) · b3bb39b0
      Siva 提交于
      * Roll src/third_party/dart 06c3d7ad3a...09fc76bc51
      
      dart-lang/sdk@09fc76bc51 [vm, compiler] Remove dead _classRangeCheckNegative.
      dart-lang/sdk@b472d7a9be Unnecessary null aware spread hint
      dart-lang/sdk@f939ad3964 library scope extensions
      dart-lang/sdk@9503969664 [vm/bytecode] Add DebugCheck bytecode instruction
      dart-lang/sdk@fc542be6b4 Issue 36682. Check that selection offset/length is valid in Extract Method refactoring.
      dart-lang/sdk@803658a6d8 [corelib_2] fix bigint_from_test for web platforms
      dart-lang/sdk@ad6b1ebbd6 Support for 'double' fields in protocol.
      dart-lang/sdk@5479175012 Remove incorrect test.
      dart-lang/sdk@058092b5f6 [vm] Fix simarm_x64 build on mac
      dart-lang/sdk@307ca3f3b6 [vm/bytecode] Improve single stepping and breakpoint setting in bytecode.
      dart-lang/sdk@855830f324 Update LSP spec
      dart-lang/sdk@d992f55094 [dartfix] Bump pedantic dep to v1.8.0 and cleanup lint violations
      dart-lang/sdk@41330f3e34 gitignore .clangd
      dart-lang/sdk@8d07009931 [ VM / Gardening ] Mark disassemble_determinism_test as slow on Windows
      dart-lang/sdk@1b82367ed6 Update CHANGELOG to reflect breaking change #36765
      dart-lang/sdk@a86db84e0a [fasta] Preserve information about const constructors in outline.
      dart-lang/sdk@25319ef7a6 Fix bug in codegen/string_escapes_test.dart.
      dart-lang/sdk@7acecda2cc [vm/ffi] Fix FFI Utf8 example.
      dart-lang/sdk@e3b3c6fa28 [vm] Rename 3head flutter patch after re-land of concurrency change
      dart-lang/sdk@2cb5303782 [infra] Update checked in SDKs to 2.4.0
      dart-lang/sdk@fce43ebc4e [ddk] Pass environmentDefines to CFE through CompilerOptions
      dart-lang/sdk@5450d08ca1 Add support for analyzer static error tests.
      dart-lang/sdk@0425997b31 Second attempt to reland "[vm/concurrency] Introduce concept of Isolate Groups"
      dart-lang/sdk@5470159054 [vm, gc] Produce a proper error message when crashing due to lack of memory at isolate startup.
      dart-lang/sdk@bfc7d21da6 Remove useless dart2js_extra/class_test
      dart-lang/sdk@572619b639 [vm, bytecode] Fix vm/cc/CompileFunctionOnHelperThread.
      dart-lang/sdk@4de495fccc [vm, compiler] Remove dead stub ICCallThroughFunction.
      dart-lang/sdk@8a1dcdae68 Graduate 'flutter' domain from experimental, remove unused methods and fields.
      dart-lang/sdk@a945888627 Discard constructors and fields temporarily to get valid code compiling
      
      * Fix analyzer warning.
      b3bb39b0
    • J
    • C
      Rework image & texture management to use concurrent message queues. (#9486) · ad582b50
      Chinmay Garde 提交于
      This patch reworks image decompression and collection in the following ways
      because of misbehavior in the described edge cases.
      
      The current flow for realizing a texture on the GPU from a blob of compressed
      bytes is to first pass it to the IO thread for image decompression and then
      upload to the GPU. The handle to the texture on the GPU is then passed back to
      the UI thread so that it can be included in subsequent layer trees for
      rendering. The GPU contexts on the Render & IO threads are in the same
      sharegroup so the texture ends up being visible to the Render Thread context
      during rendering. This works fine and does not block the UI thread. All
      references to the image are owned on UI thread by Dart objects. When the final
      reference to the image is dropped, the texture cannot be collected on the UI
      thread (because it has not GPU context). Instead, it must be passed to either
      the GPU or IO threads. The GPU thread is usually in the middle of a frame
      workload so we redirect the same to the IO thread for eventual collection. While
      texture collections are usually (comparatively) fast, texture decompression and
      upload are slow (order of magnitude of frame intervals).
      
      For application that end up creating (by not necessarily using) numerous large
      textures in straight-line execution, it could be the case that texture
      collection tasks are pending on the IO task runner after all the image
      decompressions (and upload) are done. Put simply, the collection of the first
      image could be waiting for the decompression and upload of the last image in the
      queue.
      
      This is exacerbated by two other hacks added to workaround unrelated issues.
      * First, creating a codec with a single image frame immediately kicks of
        decompression and upload of that frame image (even if the frame was never
        request from the codec). This hack was added because we wanted to get rid of
        the compressed image allocation ASAP. The expectation was codecs would only be
        created with the sole purpose of getting the decompressed image bytes.
        However, for applications that only create codecs to get image sizes (but
        never actually decompress the same), we would end up replacing the compressed
        image allocation with a larger allocation (device resident no less) for no
        obvious use. This issue is particularly insidious when you consider that the
        codec is usually asked for the native image size first before the frame is
        requested at a smaller size (usually using a new codec with same data but new
        targetsize). This would cause the creation of a whole extra texture (at 1:1)
        when the caller was trying to “optimize” for memory use by requesting a
        texture of a smaller size.
      * Second, all image collections we delayed in by the unref queue by 250ms
        because of observations that the calling thread (the UI thread) was being
        descheduled unnecessarily when a task with a timeout of zero was posted from
        the same (recall that a task has to be posted to the IO thread for the
        collection of that texture). 250ms is multiple frame intervals worth of
        potentially unnecessary textures.
      
      The net result of these issues is that we may end up creating textures when all
      that the application needs is to ask it’s codec for details about the same (but
      not necessarily access its bytes). Texture collection could also be delayed
      behind other jobs to decompress the textures on the IO thread. Also, all texture
      collections are delayed for an arbitrary amount of time.
      
      These issues cause applications to be susceptible to OOM situations. These
      situations manifest in various ways. Host memory exhaustion causes the usual OOM
      issues. Device memory exhaustion seems to manifest in different ways on iOS and
      Android. On Android, allocation of a new texture seems to be causing an
      assertion (in the driver). On iOS, the call hangs (presumably waiting for
      another thread to release textures which we won’t do because those tasks are
      blocked behind the current task completing).
      
      To address peak memory usage, the following changes have been made:
      * Image decompression and upload/collection no longer happen on the same thread.
        All image decompression will now be handled on a workqueue. The number of
        worker threads in this workqueue is equal to the number of processors on the
        device. These threads have a lower priority that either the UI or Render
        threads. These workers are shared between all Flutter applications in the
        process.
      * Both the images and their codec now report the correct allocation size to Dart
        for GC purposes. The Dart VM uses this to pick objects for collection. Earlier
        the image allocation was assumed to 32bpp with no mipmapping overhead
        reported. Now, the correct image size is reported and the mipmapping overhead
        is accounted for. Image codec sizes were not reported to the VM earlier and
        now are. Expect “External” VM allocations to be higher than previously
        reported and the numbers in Observatory to line up more closely with actual
        memory usage (device and host).
      * Decoding images to a specific size used to decode to 1:1 before performing a
        resize to the correct dimensions before texture upload. This has now been
        reworked so that images are first decompressed to a smaller size supported
        natively by the codec before final resizing to the requested target size. The
        intermediate copy is now smaller and more promptly collected. Resizing also
        happens on the workqueue worker.
      * The drain interval of the unref queue is now sub-frame-interval. I am hesitant
        to remove the delay entirely because I have not been able to instrument the
        performance overhead of the same. That is next on my list. But now, multiple
        frame intervals worth of textures no longer stick around.
      
      The following issues have been addressed:
      * https://github.com/flutter/flutter/issues/34070 Since this was the first usage
        of the concurrent message loops, the number of idle wakes were determined to
        be too high and this component has been rewritten to be simpler and not use
        the existing task runner and MessageLoopImpl interface.
      * Image decoding had no tests. The new `ui_unittests` harness has been added
        that sets up a GPU test harness on the host using SwiftShader. Tests have been
        added for image decompression, upload and resizing.
      * The device memory exhaustion in this benchmark has been addressed. That
        benchmark is still not viable for inclusion in any harness however because it
        creates 9 million codecs in straight-line execution. Because these codecs are
        destroyed in the microtask callbacks, these are referenced till those
        callbacks are executed. So now, instead of device memory exhaustion, this will
        lead to (slower) exhaustion of host memory. This is expected and working as
        intended.
      
      This patch only addresses peak memory use and makes collection of unused images
      and textures more prompt. It does NOT address memory use by images referenced
      strongly by the application or framework.
      ad582b50
    • S
      Roll src/third_party/skia 6b82cf638682..a3ffaabcc4f2 (24 commits) (#9726) · 1dcd5f52
      skia-flutter-autoroll 提交于
      
      https://skia.googlesource.com/skia.git
      /%2Blog/6b82cf638682..a3ffaabcc4f2
      
      git log 6b82cf638682354f07dc8bfa756d5806d49643ca..a3ffaabcc4f2f0673ee423f45aa858599ed4fc4f --date=short --no-merges --format=%ad %ae %s
      2019-07-09 bsalomon@google.com Fix up row bytes for single level texture in GrResourceProvider.
      2019-07-09 brianosman@google.com Only include angle in default configs when it's enabled
      2019-06-27 borenet@google.com [infra] Make infra tests idempotent
      2019-07-09 borenet@google.com Revert "[infra] No task deduplication"
      2019-07-09 fmalita@chromium.org Remove onMakeBurstPipelineContext
      2019-07-09 fmalita@chromium.org Optional local matrix for SkShaders factories
      2019-07-09 robertphillips@google.com Make Mock GrBackendFormat use GrColorType (instead of GrPixelConfig)
      2019-07-09 michaelludwig@google.com Reland "More optimizations for CropToRect, for axis-aligned quads that have not been inverted"
      2019-07-09 borenet@google.com [infra] No task deduplication
      2019-07-09 bsalomon@google.com vk_format_to_pixel_config behind GR_TEST_UTILS
      2019-07-08 halcanary@google.com ModifierKey unifies sk_app::Window::ModifierKey & Sample::Click::ModifierKey
      2019-07-09 brianosman@google.com Reland "Make the SkSL interpreter opt-in"
      2019-07-09 jvanverth@google.com Re-enable Vulkan MSAA support in Viewer
      2019-07-09 bsalomon@google.com Use vkCmdClearColorImage to clear backend textures
      2019-07-09 reed@google.com create outer forloop to support loops=-1
      2019-07-09 fmalita@chromium.org [skottie] Motion blur fast path
      2019-07-08 egdaniel@google.com Move uses of functions taking SkColorType to GrColorType versions in GrCaps.
      2019-07-03 fmalita@chromium.org [skottie] Motion blur support
      2019-07-09 brianosman@google.com Revert "Enable MSAA on Gen8 Intel GPUs"
      2019-07-08 scroggo@google.com Check for uninitialized memory during jpeg encode
      2019-07-09 rmistry@google.com [perf_skottiewasm_lottieweb] Handle case where start TS of frame_id not added yet
      2019-07-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a1b6761e6e3c..5dfad811ce32 (13 commits)
      2019-07-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src ea1730d8b2f9..9a8eb165a861 (363 commits)
      2019-07-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8900e7c54a22..8c4c9e37bf96 (1 commits)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (fmalita@google.com), and stop
      the roller if necessary.
      1dcd5f52
    • B
      Revert "Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)" (#9724) · 129979ca
      Ben Konyi 提交于
      * Revert "Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)"
      
      This reverts commit e24bd784.
      
      * Revert "Reland isolate group changes"
      
      This reverts commit 3d2668c3.
      129979ca
    • S
      Roll src/third_party/skia 56065d9b875f..6b82cf638682 (3 commits) (#9718) · 8020d7e4
      skia-flutter-autoroll 提交于
      
      https://skia.googlesource.com/skia.git
      /%2Blog/56065d9b875f..6b82cf638682
      
      git log 56065d9b875feaf85a4374c69259d37b3e2a817e..6b82cf638682354f07dc8bfa756d5806d49643ca --date=short --no-merges --format=%ad %ae %s
      2019-07-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
      2019-07-08 halcanary@google.com GM: s/handleKey/onChar/
      2019-07-08 rmistry@google.com Parse chrome traces for skottie+wasm and lottie-web for perf
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (fmalita@google.com), and stop
      the roller if necessary.
      8020d7e4
    • B
      Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits) · e24bd784
      Ben Konyi 提交于
      dart-lang/sdk@7acecda2cc [vm/ffi] Fix FFI Utf8 example.
      dart-lang/sdk@e3b3c6fa28 [vm] Rename 3head flutter patch after re-land of concurrency change
      dart-lang/sdk@2cb5303782 [infra] Update checked in SDKs to 2.4.0
      dart-lang/sdk@fce43ebc4e [ddk] Pass environmentDefines to CFE through CompilerOptions
      dart-lang/sdk@5450d08ca1 Add support for analyzer static error tests.
      dart-lang/sdk@0425997b31 Second attempt to reland "[vm/concurrency] Introduce concept of Isolate Groups"
      dart-lang/sdk@5470159054 [vm, gc] Produce a proper error message when crashing due to lack of memory at isolate startup.
      dart-lang/sdk@bfc7d21da6 Remove useless dart2js_extra/class_test
      dart-lang/sdk@572619b639 [vm, bytecode] Fix vm/cc/CompileFunctionOnHelperThread.
      dart-lang/sdk@4de495fccc [vm, compiler] Remove dead stub ICCallThroughFunction.
      dart-lang/sdk@8a1dcdae68 Graduate 'flutter' domain from experimental, remove unused methods and fields.
      dart-lang/sdk@a945888627 Discard constructors and fields temporarily to get valid code compiling
      e24bd784
    • B
      Reland isolate group changes · 3d2668c3
      Ben Konyi 提交于
      This reverts commit 64b9eef5.
      3d2668c3
  3. 09 7月, 2019 7 次提交
    • C
      iOS platform view opacity (#9667) · 802bd151
      Chris Yang 提交于
      802bd151
    • B
      Roll src/third_party/dart b5aeaa6796..06c3d7ad3a (44 commits) · 3b6265b7
      Ben Konyi 提交于
      dart-lang/sdk@06c3d7ad3a Revert "Rereland "[vm/ffi] SimDBC on Arm64 Android""
      dart-lang/sdk@16f5e6fb05 [analyzer] prep package:analyzer_plugin for publishing
      dart-lang/sdk@5be07ff646 Support for experimental object fields in analysis server protocol spec.
      dart-lang/sdk@ac93a3c368 [dartdevc] Fixing windows-related source map pathing issues
      dart-lang/sdk@7929e1c714 [vm/ffi] Remove LocalVariable references from Allocate/CloneContext instructions
      dart-lang/sdk@359c36a406 Improve some correction messages; use double quote more consistently
      dart-lang/sdk@c1d3bf8506 Issue 36890. Ignore the name that contains the caret during completion.
      dart-lang/sdk@a6afc5a9b0 Disable tests under windows to fix the bot
      dart-lang/sdk@966038ef58 [analyzer] update package:analyzer_plugin wrt some lints
      dart-lang/sdk@cab2ca275d Update Socket to be a Stream<Uint8List>
      dart-lang/sdk@a85f6ff348 [vm/compiler] Do not create intersection types in type propagation.
      dart-lang/sdk@48e9366923 fix a typo in the vm service spec
      dart-lang/sdk@aee65636ba Add constructors to `Stream` which creates single data or error event streams.
      dart-lang/sdk@d914839ce6 Add tests for diagnostic docs
      dart-lang/sdk@33a5745c49 [vm/ffi] Add missing free() to structs_test.dart
      dart-lang/sdk@1c9408f2ba Update doc link to point at ECMAScript 2018.
      dart-lang/sdk@79a5257155 Revert "Increase analyzer cache size to 512MB."
      dart-lang/sdk@774a392aa3 Add '--benchmarking-x' flag
      dart-lang/sdk@db1abd0674 Initial and partial summary support for extensions
      dart-lang/sdk@588ab11ecc Unify two error codes that are essentially identical
      dart-lang/sdk@fcc72ad83f [vm/ffi] Support FFI in AOT (excluding callbacks).
      dart-lang/sdk@f0d6f119de Make nested_generic_closure_test work for dart2js
      dart-lang/sdk@0a538a4e62 Avoid truncating shift in lib_2/math/low_test
      dart-lang/sdk@8673b5e491 Avoid non-web-integer literals in corelib_2/num_sign_test
      dart-lang/sdk@f0da490328 Avoid non-web integer literal in corelib_2/growable_list_test
      dart-lang/sdk@7b13c45bcc Fix negation precedence and non-web-integers in corelib_2/int_xxx_tests
      dart-lang/sdk@b14f3accbb [fasta] Thread nullability through the subtyping methods in fasta
      dart-lang/sdk@c0932a8af6 Move annotated_code_helper.dart into front_end.
      dart-lang/sdk@cea3d85ade Rename statment -> stmt in testing annotations.
      dart-lang/sdk@ee696f2c35 In flow analysis tests, annotate `doesNotComplete` on functions rather than bodies.
      dart-lang/sdk@c1ca599353 Adapt flow and promotion tests to make use of CFE testing framework.
      dart-lang/sdk@13251657c6 Fix compile errors in flow analysis and type promotion test cases.
      dart-lang/sdk@14ccc77a40 Use decoder.bind(stream) instead of stream.transform(decoder)
      dart-lang/sdk@f41d6de111 [corelib_2] Split date_time_test to increase coverage
      dart-lang/sdk@9bccb7ba4a Rereland "[vm/ffi] SimDBC on Arm64 Android"
      dart-lang/sdk@0b1ec2d937 List.removeLast() docs error occurs if empty
      dart-lang/sdk@4ceefdbe4c Rename ElementId to MemberId and use member: prefix instead of element:
      dart-lang/sdk@aeee6139f5 [cfe] Extract Id, DataRegistry and DataExtractor from dart2js
      dart-lang/sdk@708e919733 Consistently format breaking changes
      dart-lang/sdk@a4f34f4a51 expired experimental flag command line message
      dart-lang/sdk@b8a8cfdcda [cfe] Use InvalidExpression for await on non-async context.
      dart-lang/sdk@0272c1d863 Split language_2/truncdiv_test
      dart-lang/sdk@4babccd988 Fix non-web integer literals in corelib_2/bigint_test
      dart-lang/sdk@738d9f9666 Avoid non-web integer literal in language2/list_test
      3b6265b7
    • D
      Refactor ColorFilter to have a native wrapper (#9668) · 887e0523
      Dan Field 提交于
      887e0523
    • G
      TextStyle.height property as a multiple of font size instead of multiple of... · 75387dbc
      Gary Qian 提交于
      TextStyle.height property as a multiple of font size instead of multiple of ascent+descent+leading. (#9041)
      
      75387dbc
    • L
      Explain why OpacityLayer has an offset field (#9713) · eb89d9d4
      liyuqian 提交于
      According to the request by Amir and Chris.
      eb89d9d4
    • S
      Roll src/third_party/skia aee26ea14efc..56065d9b875f (16 commits) (#9714) · f37b78a3
      skia-flutter-autoroll 提交于
      
      https://skia.googlesource.com/skia.git
      /%2Blog/aee26ea14efc..56065d9b875f
      
      git log aee26ea14efc9bcbfa99fd2e3947dd59ca72bdea..56065d9b875feaf85a4374c69259d37b3e2a817e --date=short --no-merges --format=%ad %ae %s
      2019-07-08 rmistry@google.com [skottie-wasm-perf] Turn on chrome tracing
      2019-07-08 rmistry@google.com [lottie-web-perf] Use SVG renderer and turn on chrome tracing
      2019-07-08 brianosman@google.com Revert &#34;Make the SkSL interpreter opt-in&#34;
      2019-07-08 brianosman@google.com Enable MSAA on Gen8 Intel GPUs
      2019-07-08 robertphillips@google.com Remove some uses of isTestingOnlyBackendTexture
      2019-07-03 cstout@google.com [fuchsia] Use //src/graphics/lib/vulkan for in-tree build
      2019-07-08 egdaniel@google.com Make isFormatTexturable take a GrColorType.
      2019-07-08 michaelludwig@google.com Revert &#34;More optimizations for CropToRect, for axis-aligned quads that have not been inverted&#34;
      2019-07-08 brianosman@google.com Make the SkSL interpreter opt-in
      2019-07-05 halcanary@google.com Sample/Shaders: use resources; cleanup code
      2019-07-08 halcanary@google.com Sample/Lines remove boring sample
      2019-07-03 halcanary@google.com Samples: simplify Sample::Event
      2019-07-08 robertphillips@google.com Make BGRA_8888 renderable &amp; textureable by default in the mock context
      2019-07-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
      2019-07-08 michaelludwig@google.com More optimizations for CropToRect, for axis-aligned quads that have not been inverted
      2019-07-03 halcanary@google.com Sample/Patch: use resources; cleanup code
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (fmalita@google.com), and stop
      the roller if necessary.
      f37b78a3
    • L
      Improve window documentation (#9669) · 92c4469a
      liyuqian 提交于
      To reflect Matt Carroll's recent (02/06/2019) email about promoting
      `WidgetsBinding.instance.window` and demoting `ui.window`.
      
      I have to manually search for Matt's email several times when I need
      to access the Window object. Having it in the documentation would
      help me do that much faster.
      92c4469a