Merge pull request #2567 from chinmaygarde/master

Update Dart revision to pull in changes related to tracing and add more trace types to TracingController

DEPS

@@ -25,7 +25,7 @@ vars = {
 
   # Note: When updating the Dart revision, ensure that all entries that are
   # dependencies of dart are also updated
-  'dart_revision': '4f3a7cb86e04bb1d4d06902924d9c7275a3b6527',
+  'dart_revision': 'd8df41c4835705834badf06ddeef1eee644b6312',
   'dart_observatory_packages_revision': 'cf90eb9077177d3d6b3fd5e8289477c2385c026a',
   'dart_root_certificates_revision': 'c3a41df63afacec62fcb8135196177e35fe72f71',
 

sky/shell/tracing_controller.cc

@@ -72,11 +72,24 @@ static void BaseTraceEventCallback(base::TraceTicks timestamp,
     case TRACE_EVENT_PHASE_INSTANT:
       type = Dart_Timeline_Event_Instant;
       break;
+    case TRACE_EVENT_PHASE_ASYNC_BEGIN:
+      type = Dart_Timeline_Event_Async_Begin;
+      break;
+    case TRACE_EVENT_PHASE_ASYNC_END:
+      type = Dart_Timeline_Event_Async_End;
+      break;
+    case TRACE_EVENT_PHASE_COUNTER:
+      type = Dart_Timeline_Event_Counter;
+      break;
+    case TRACE_EVENT_PHASE_METADATA:
+      type = Dart_Timeline_Event_Metadata;
+      break;
     default:
       // For TRACE_EVENT_PHASE_COMPLETE events, this callback still receives
       // discrete begin-end pairs. This greatly simplifies things. We dont have
       // to track the second timestamp to pass to the Dart timeline event
       // because we never see a Dart_Timeline_Event_Duration event.
+      DCHECK(false) << "Unknown trace event phase";
       return;
   }