Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
sxychenjing
engine
提交
d132ac57
E
engine
项目概览
sxychenjing
/
engine
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
E
engine
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
d132ac57
编写于
4月 24, 2020
作者:
M
Mouad Debbar
提交者:
GitHub
4月 24, 2020
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[web] Fix exception when getting boxes for rich text range (#17933)
上级
cade0e90
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
31 addition
and
2 deletion
+31
-2
lib/web_ui/lib/src/engine/text/paragraph.dart
lib/web_ui/lib/src/engine/text/paragraph.dart
+12
-2
lib/web_ui/test/paragraph_test.dart
lib/web_ui/test/paragraph_test.dart
+19
-0
未找到文件。
lib/web_ui/lib/src/engine/text/paragraph.dart
浏览文件 @
d132ac57
...
...
@@ -359,13 +359,23 @@ class EngineParagraph implements ui.Paragraph {
})
{
assert
(
boxHeightStyle
!=
null
);
assert
(
boxWidthStyle
!=
null
);
if
(
_plainText
==
null
||
start
==
end
)
{
// Zero-length ranges and invalid ranges return an empty list.
if
(
start
==
end
||
start
<
0
||
end
<
0
)
{
return
<
ui
.
TextBox
>[];
}
// For rich text, we can't measure the boxes. So for now, we'll just return
// a placeholder box to stop exceptions from being thrown in the framework.
// https://github.com/flutter/flutter/issues/55587
if
(
_plainText
==
null
)
{
return
<
ui
.
TextBox
>[
ui
.
TextBox
.
fromLTRBD
(
0
,
0
,
0
,
_lineHeight
,
_textDirection
)
];
}
final
int
length
=
_plainText
.
length
;
// Ranges that are out of bounds should return an empty list.
if
(
start
<
0
||
end
<
0
||
start
>
length
||
end
>
length
)
{
if
(
start
>
length
||
end
>
length
)
{
return
<
ui
.
TextBox
>[];
}
...
...
lib/web_ui/test/paragraph_test.dart
浏览文件 @
d132ac57
...
...
@@ -415,6 +415,25 @@ void main() async {
);
});
testEachMeasurement
(
'getBoxesForRange returns a box for rich text'
,
()
{
final
ParagraphBuilder
builder
=
ParagraphBuilder
(
ParagraphStyle
(
fontFamily:
'Ahem'
,
fontStyle:
FontStyle
.
normal
,
fontWeight:
FontWeight
.
normal
,
fontSize:
10
,
textDirection:
TextDirection
.
ltr
,
));
builder
.
addText
(
'abcd'
);
builder
.
pushStyle
(
TextStyle
(
fontWeight:
FontWeight
.
bold
));
builder
.
addText
(
'xyz'
);
final
Paragraph
paragraph
=
builder
.
build
();
paragraph
.
layout
(
const
ParagraphConstraints
(
width:
1000
));
expect
(
paragraph
.
getBoxesForRange
(
1
,
2
).
single
,
const
TextBox
.
fromLTRBD
(
0
,
0
,
0
,
10
,
TextDirection
.
ltr
),
);
});
testEachMeasurement
(
'getBoxesForRange return empty list for zero-length range'
,
()
{
final
ParagraphBuilder
builder
=
ParagraphBuilder
(
ParagraphStyle
(
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录