Rename "BorderSide.None" to "BorderSide.none", since it's a constant, and...

Rename "BorderSide.None" to "BorderSide.none", since it's a constant, and change the sky.Size.infinite() constructor to a constant.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1158263005

engine/core/painting/Size.dart

@@ -12,11 +12,11 @@ class Size {
 
   const Size(this.width, this.height);
 
-  const Size.infinite() : width = double.INFINITY, height = double.INFINITY;
-
   const Size.fromWidth(this.width) : height = double.INFINITY;
   const Size.fromHeight(this.height) : width = double.INFINITY;
 
+  static const Size infinite = const Size(double.INFINITY, double.INFINITY);
+
   bool operator ==(other) => other is Size && width == other.width && height == other.height;
 
   // does the equivalent of "return new Point(0,0) + this"

examples/game/lib/sprite_box.dart

@@ -38,7 +38,7 @@ class SpriteBox extends RenderBox {
   double get systemHeight => _systemHeight;
 
   void performLayout() {
-    size = constraints.constrain(new Size.infinite());
+    size = constraints.constrain(Size.infinite);
   }
 
   void handleEvent(Event event) {
@@ -136,4 +136,4 @@ class SpriteBox extends RenderBox {
     _rootNode.update(delta);
     _scheduleTick();
   }
-}
\ No newline at end of file
+}

examples/raw/ink_well.dart

@@ -52,7 +52,7 @@ class InkWell extends RenderBox {
   }
 
   void performLayout() {
-    size = constraints.constrain(new sky.Size.infinite());
+    size = constraints.constrain(sky.Size.infinite);
   }
 
   void paint(RenderObjectDisplayList canvas) {

examples/raw/touch_demo.dart

@@ -62,7 +62,7 @@ class RenderTouchDemo extends RenderBox {
   }
 
   void performLayout() {
-    size = constraints.constrain(new Size.infinite());
+    size = constraints.constrain(Size.infinite);
   }
 
   void paint(RenderObjectDisplayList canvas) {

sdk/lib/framework/components2/drawer.dart

@@ -115,7 +115,7 @@ class Drawer extends AnimatedComponent {
 
     var mask = new EventListenerNode(
       new Container(
-        desiredSize: new sky.Size.infinite(),
+        desiredSize: sky.Size.infinite,
         decoration: new BoxDecoration(backgroundColor: maskColor)
       ),
       onGestureTap: controller.handleMaskTap,

sdk/lib/framework/components2/scaffold.dart

@@ -75,7 +75,7 @@ class RenderScaffold extends RenderBox {
 
   bool get sizedByParent => true;
   void performResize() {
-    size = constraints.constrain(new sky.Size.infinite());
+    size = constraints.constrain(sky.Size.infinite);
     assert(size.width < double.INFINITY);
     assert(size.height < double.INFINITY);
   }

sdk/lib/framework/rendering/box.dart

@@ -191,7 +191,7 @@ class RenderSizedBox extends RenderProxyBox {
 
   RenderSizedBox({
     RenderBox child,
-    sky.Size desiredSize: const sky.Size.infinite()
+    sky.Size desiredSize: sky.Size.infinite
   }) : super(child) {
     assert(desiredSize != null);
     this.desiredSize = desiredSize;
@@ -377,7 +377,7 @@ class BorderSide {
   final sky.Color color;
   final double width;
 
-  static const None = const BorderSide(width: 0.0);
+  static const none = const BorderSide(width: 0.0);
 
   int get hashCode {
     int value = 373;
@@ -390,10 +390,10 @@ class BorderSide {
 
 class Border {
   const Border({
-    this.top: BorderSide.None,
-    this.right: BorderSide.None,
-    this.bottom: BorderSide.None,
-    this.left: BorderSide.None
+    this.top: BorderSide.none,
+    this.right: BorderSide.none,
+    this.bottom: BorderSide.none,
+    this.left: BorderSide.none
   });
   const Border.all(BorderSide side) :
     top = side,

sdk/lib/framework/rendering/stack.dart

@@ -23,11 +23,11 @@ class RenderStack extends RenderBox with ContainerRenderObjectMixin<RenderBox, S
   }
 
   sky.Size getIntrinsicDimensions(BoxConstraints constraints) {
-    return constraints.constrain(new sky.Size.infinite());
+    return constraints.constrain(sky.Size.infinite);
   }
 
   void performLayout() {
-    size = constraints.constrain(new sky.Size.infinite());
+    size = constraints.constrain(sky.Size.infinite);
     assert(size.width < double.INFINITY);
     assert(size.height < double.INFINITY);
     BoxConstraints innerConstraints = new BoxConstraints.loose(size);

tests/raw/render_flex.dart

@@ -15,7 +15,7 @@ class RenderSolidColor extends RenderDecoratedBox {
   final sky.Size desiredSize;
   final sky.Color backgroundColor;
 
-  RenderSolidColor(sky.Color backgroundColor, { this.desiredSize: const sky.Size.infinite() })
+  RenderSolidColor(sky.Color backgroundColor, { this.desiredSize: sky.Size.infinite })
       : backgroundColor = backgroundColor,
         super(decoration: new BoxDecoration(backgroundColor: backgroundColor)) {
   }