- 31 12月, 2020 1 次提交
-
-
由 Alex Thibodeau 提交于
Expose mono_class_is_open_constructed_type to Unity to allow us to check to see if the class is not yet fully instantiated prior to asttempting to call mono_object_new on it. * Also cleaning up a minor leak of a MonoError in mono_unity_class_inflate_generic_class
-
- 10 12月, 2020 1 次提交
-
-
由 Johan Lorensson 提交于
We hit the following assert when doing full AOT of some assemblies: wrong maximal instruction length of instruction localloc (expected 96, got 99) Assertion: should not be reached at mono\mono\mini\mini-amd64.c:6801 Turns out that that size could be hit when a couple of things happens as part of lowering OP_LOCALLOC and OP_LOCALLOC_IMM: sreg1 is not RAX, RCX or RDI dreg is not RAX, RCX or RDI cfg->param_area is bigger than 127 Fix is to increase max size of the instruction, from 96 -> 120 (same as x86).
-
- 05 11月, 2020 3 次提交
-
-
由 Harald Nielsen 提交于
Reintroduce https://github.com/Unity-Technologies/mono/commit/6c41f64f25da4c12b237b6bb51765722e0dd5281#diff-0ff844e784e15d2542b71c85d2c0133e This is so we will not get errors when resolving strong named assemblies for a version not loaded. This option will ignore the version
-
由 rbalaji 提交于
Revert "Reintroduce https://github.com/Unity-Technologies/mono/commit/6c41f64f25da4c12b237b6bb51765722e0dd5281#diff-0ff844e784e15d2542b71c85d2c0133e" This reverts commit 9d9a0eda.
-
由 Harald Nielsen 提交于
Reintroduce https://github.com/Unity-Technologies/mono/commit/6c41f64f25da4c12b237b6bb51765722e0dd5281#diff-0ff844e784e15d2542b71c85d2c0133e This is so we will not get errors when resolving strong named assemblies for a version not loaded. This option will ignore the version
-
- 27 10月, 2020 1 次提交
-
-
由 Jonathan Chambers 提交于
Without proper alignment, this may lead to reference types being stored at non-pointer aligned offsets. Among other issues this may lead to the GC not scanning those pointers properly.
-
- 22 9月, 2020 1 次提交
-
-
由 Mathieu Bourgeois 提交于
* Generalize commit 0c6932a9 to support LDARG{0|1|2|3}, LDLOC{0|1|2|3}, LDARGS, LDLOCS, LDARG and LDLOC instead of LDLOC and LDLOCS. Improves generated code similar to issue #60945
-
- 14 9月, 2020 1 次提交
-
-
由 Thays Grazia 提交于
* Validate the address that came from IDE using PointerValue. The IDE can send an invalid address and it was crashing mono. Fixes #18191 Fixes #15612 Co-authored-by: NAleksey Kliger (λgeek) <akliger@gmail.com> Wrap create_file_to_check_memory_address in #ifndef _MSC_VER check as it's only used in that scope.
-
- 11 8月, 2020 1 次提交
-
-
由 UnityAlex 提交于
* mono_custom_attrs_construct_by_type allows unity to have a chance at handling the error if one arises instead of fatally asserting * mono_unity_error_convert_to_exception allows unity to take the provided MonoError and fetch the MonoException object within to log into the editor as the exception that was thrown. This change has associated unity changes in order to fix (case 1255935)
-
- 06 8月, 2020 1 次提交
-
-
由 Alex Thibodeau 提交于
Fixing hang that would occur when a Debugger.Break would be triggered while we are already processing a breakpoint. (case 1254123) Adding test for debugger hang fix to case 1254123 Added a new property to Tests class which breaks this test.
-
- 13 7月, 2020 1 次提交
-
-
由 Jonathan Chambers 提交于
Emitting error 100 times is plenty.
-
- 09 7月, 2020 1 次提交
-
-
由 Josh Peterson 提交于
This change applies a similar fix for exFAT partitions as was applied for FAT32 partitions earlier. For exFAT partitions, the invalid inode value seems to be 1 though.
-
- 22 6月, 2020 4 次提交
-
-
由 Rodrigo Kumpera 提交于
Add System.Collections.Generic include to objects.cs
-
由 UnityAlex 提交于
-
由 Thays Grazia 提交于
* Removing some asserts and returning err_invalid_argument with an error message when it's possible. * if we don't find method get_ObjectIdForDebugger we try to find the property Task to continue async debug. Cherry-picked by Alex Thibodeau with some moderate changes
-
由 Thays Grazia 提交于
* When we try to call a method to get the async_id to do an async debug and we are trying to do this in a generic method like this: async Task<T> ExecuteAsync_Broken<T>() { await Task.Delay(2); return default; } We need to inflate the generic type before call the method or we will get the error: Could not execute the method because the containing type 'System.Runtime.CompilerServices.AsyncTaskMethodBuilder1[T_REF]’, is not fully instantiated. Fixes #17549 Fixes #17569 Cherry-picked by Alex Thibodeau -- some light massaging required
-
- 17 6月, 2020 1 次提交
-
-
由 Thays Grazia 提交于
* [debugger] Fixing two crashes while debugging an Android app. -> Doing stepping into in VSM in some situation the frame saved in TLS is not synchronised with what is really been executed in the main thread. This makes the debugger-agent crashes because it tries to get variable info in some memory that is not available anymore. -> To fix it I forced the update of stack when CMD_THREAD_GET_FRAME_INFO is called. -> Doing step over in Visual Studio for Windows, if you have the threads debugger window enabled, VSW calls frame_commands for each thread that is showed, and if the thread is not really_suspended it tries to get variable info from a memory that is not available anymore because the thread is not suspended yet. -> To fix it I don't send variable info of a frame if the thread is not really_suspended and doesn't have an async_state valid. Cherry-picked with some light massaging by Alex Thibodeau (case 1249172)
-
- 07 6月, 2020 1 次提交
-
-
由 Dale Kim 提交于
-
- 03 6月, 2020 2 次提交
-
-
由 Joe Valenzuela 提交于
Same method that ldloc.s uses, which incorporates the byref test.
-
由 Joe Valenzuela 提交于
When we have the following sequence: ldloc n ldfld valuetype [Unity.Mathematics]Unity.Mathematics.int2 Foo::bar and local n is a reference to value, when walking the instructions in mono_method_to_ir, we generally try to avoid loading a whole value type just to load one of the fields. I believe this is an optimization. The test here is not quite complete, though, as we have ref valuetypes where the object stored at the location is actually an address, in which case we still need to treat it as we would a normal reference. This optimization isn't present in the ldloc.n coded forms and is written in a slightly more robust way in ldloc.s, so no changes are necessary there. As an alternative to this commit, we might adopt the ldloc.s test for ldloc as well, or merge in https://github.com/mono/mono/commit/29428d951637ff85b593ea5c9cc5d5236579906d/mono/mini/method-to-ir.c from master which encapsulates much the same intent.
-
- 14 5月, 2020 1 次提交
-
-
由 Ryan Lucia 提交于
This brings us in line with GetDiskFreeSpaceExW on Windows as well as .NET Core.
-
- 06 5月, 2020 4 次提交
-
-
由 UnityAlex 提交于
Attempting to guard against MONO_HANDLE_IS_NULL performing a null deref while checking for null. Sourced from: https://github.com/mono/mono/pull/9188 blindfix for case 1232819
-
由 UnityAlex 提交于
sets. Making associated change to type_in_image to also check the constrained type for a match. Re-adding asserts now they they no longer trigger. updating to K&R coding convention
-
由 Zoltan Varga 提交于
-
由 Zoltan Varga 提交于
Fixes https://github.com/mono/mono/issues/18127.
-
- 13 4月, 2020 2 次提交
-
-
由 Thays Grazia 提交于
- Changed the behavior on debugger-agent, if we can't parse the new behavior is to return invalid_argument and not assert and stop debugging - Changed the mono_domain_set_fast before return from assembly_commands. - Add error message when return INVALID_ARGUMENT Fixes #19146
-
由 Marek Safar 提交于
Fixes #8915
-
- 26 3月, 2020 2 次提交
-
-
由 Jonathan Chambers 提交于
There was a race where a domain was being unloaded while debugger would access it. A domain was only removed from the 'appdomains_list' as a very last step. The domain was already invalid to access at this point (locks freed for example). Worse, images would be unloaded if only referenced by that domain. All places the debugger iterates domains hold the loader lock. The loader lock is acquired by the domain unloading process, so as long as a domain is not unloading when we access it inside of the loader lock we are safe.
-
由 Jonathan Chambers 提交于
Manually applied cherry-pick of https://github.com/mono/mono/pull/8428 Unity: Avoid allocation in Enum.HasFlags (case 1211643) * [jit] Decompose some CEE_BOX opcodes later to allow more optimizations. Optimize a code sequence emitted for Enum.HasFlag () by newer csc versions. Also mark the temporary bblocks used by decompose_vtypes () as out-of-line if the bblock under processing is out-of-line. Mark the domainvar as volatile to avoid optimizing it away since references to it can now be generated later from the decomposition of OP_BOX. * [jit] Check that the enum types are the same. * [jit] Fix support for generic enums. * [jit] Disable the optimization with 64 bit enums on 32 bit platforms.
-
- 05 3月, 2020 2 次提交
-
-
由 Zoltan Varga 提交于
Fixes https://github.com/mono/mono/issues/17737.
-
由 Alexander Kyte 提交于
* [debugger] Add locking around tls->frames usage/freeing * [debugger] more locking and avoid race around mono_threads_join_lock & loader lock
-
- 04 2月, 2020 1 次提交
-
-
由 Thays Grazia 提交于
* [Debugger] Debugger crashes when inside a class, there is an internal struct, with a field that is an enumerator. files.myBucket.GetEnumerator().get_Current().Key Fixes #10735 * [Debugger] Debugger crashes when there is a generic struct with a field that is an enumerator. Example: files.get_Current().Key A unit test that reproduces this crash was added too. Fixes #10735 * Removing the extra space. * UnityAlex cherry-pick modification: Removed tests
-
- 01 2月, 2020 1 次提交
-
-
由 UnityAlex 提交于
Fixes issue in mono_class_init where we would return immediately instead of jumping to the cleanup routine. This would leave init_list in a dirty state for subsequent calls leading to recursive type definitions being thrown incorrectly. (case 1191002)
-
- 16 12月, 2019 1 次提交
-
-
由 Zoltan Varga 提交于
Fix a regression introduced by e05343dd: Disable the ldobj+stobj optimization for reference types. Fixes https://github.com/mono/mono/issues/6777.
-
- 04 12月, 2019 1 次提交
- 05 11月, 2019 1 次提交
-
-
由 Ignas Ziberkas 提交于
-
- 04 11月, 2019 1 次提交
-
-
由 Jonathan Chambers 提交于
Revert "Fix case 1044454: Stopwatch does not track time when an app is in the background or the device is asleep." This reverts commit 442e9223.
-
- 01 11月, 2019 1 次提交
-
-
由 Jonathan Chambers 提交于
-
- 28 10月, 2019 1 次提交
-
-
由 David Rogers 提交于
Fix case 1044454: Stopwatch does not track time when an app is in the background or the device is asleep.
-
- 16 10月, 2019 1 次提交
-
-
由 Jonathan Chambers 提交于
There is logic to ensure debugger thread is shutting down before we continue, but thread has not actually exited. This leaves us open to race conditions in profiler events and thread info machinery that are cleaned up by runtime shutdown.
-