提交 fa501bf7 编写于 作者: A Ankit Jain

[xbuild] Log TaskFinished even when task fails to initialize.

上级 14902f25
...@@ -84,36 +84,38 @@ namespace Microsoft.Build.BuildEngine { ...@@ -84,36 +84,38 @@ namespace Microsoft.Build.BuildEngine {
[MonoTODO] [MonoTODO]
public bool Execute () public bool Execute ()
{ {
bool result; bool result = false;
TaskEngine taskEngine; TaskEngine taskEngine;
LogTaskStarted (); LogTaskStarted ();
ITask task = null; ITask task = null;
try { try {
task = InitializeTask (); try {
} catch (Exception e) { task = InitializeTask ();
LogError ("Error initializing task {0}: {1}", taskElement.LocalName, e.Message); } catch (Exception e) {
LogMessage (MessageImportance.Low, "Error initializing task {0}: {1}", LogError ("Error initializing task {0}: {1}", taskElement.LocalName, e.Message);
taskElement.LocalName, e.ToString ()); LogMessage (MessageImportance.Low, "Error initializing task {0}: {1}",
return false; taskElement.LocalName, e.ToString ());
} return false;
}
try { try {
taskEngine = new TaskEngine (parentTarget.Project); taskEngine = new TaskEngine (parentTarget.Project);
taskEngine.Prepare (task, this.taskElement, GetParameters (), this.Type); taskEngine.Prepare (task, this.taskElement, GetParameters (), this.Type);
result = taskEngine.Execute (); result = taskEngine.Execute ();
if (result) if (result)
taskEngine.PublishOutput (); taskEngine.PublishOutput ();
} catch (Exception e) { } catch (Exception e) {
task_logger.LogError ("Error executing task {0}: {1}", taskElement.LocalName, e.Message); task_logger.LogError ("Error executing task {0}: {1}", taskElement.LocalName, e.Message);
task_logger.LogMessage (MessageImportance.Low, task_logger.LogMessage (MessageImportance.Low,
"Error executing task {0}: {1}", taskElement.LocalName, e.ToString ()); "Error executing task {0}: {1}", taskElement.LocalName, e.ToString ());
result = false; result = false;
}
} finally {
LogTaskFinished (result);
} }
LogTaskFinished (result);
return result; return result;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册