#3154 SQL completion processor fix (NPEs)

plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/editors/sql/syntax/SQLCompletionAnalyzer.java

@@ -669,8 +669,9 @@ class SQLCompletionAnalyzer
         boolean isObject,
         @Nullable DBPNamedObject object)
     {
-        DBPPreferenceStore store = request.editor.getActivePreferenceStore();
-        DBPDataSource dataSource = request.editor.getDataSource();
+        SQLEditorBase editor = request.editor;
+        DBPPreferenceStore store = editor.getActivePreferenceStore();
+        DBPDataSource dataSource = editor.getDataSource();
         if (dataSource != null) {
             if (isObject) {
                 // Escape replace string if required
@@ -693,13 +694,12 @@ class SQLCompletionAnalyzer
                 default:
                     // Do not convert case if we got it directly from object
                     if (!isObject) {
-                        DBPKeywordType keywordType = request.editor.getSyntaxManager().getDialect().getKeywordType(replaceString);
+                        SQLDialect dialect = editor.getSyntaxManager().getDialect();
+                        DBPKeywordType keywordType = dialect.getKeywordType(replaceString);
                         if (keywordType == DBPKeywordType.KEYWORD) {
-                            replaceString = request.editor.getSyntaxManager().getKeywordCase().transform(replaceString);
+                            replaceString = editor.getSyntaxManager().getKeywordCase().transform(replaceString);
                         } else {
-                            DBPIdentifierCase convertCase = dataSource instanceof SQLDataSource ?
-                                ((SQLDataSource) dataSource).getSQLDialect().storesUnquotedCase() : DBPIdentifierCase.MIXED;
-                            replaceString = convertCase.transform(replaceString);
+                            replaceString = dialect.storesUnquotedCase().transform(replaceString);
                         }
                     }
                     break;

plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/impl/jdbc/JDBCSQLDialect.java

@@ -53,9 +53,9 @@ public class JDBCSQLDialect extends BasicSQLDialect {
     private boolean supportsUnquotedMixedCase;
     private boolean supportsQuotedMixedCase;
     @NotNull
-    private DBPIdentifierCase unquotedIdentCase;
+    private DBPIdentifierCase unquotedIdentCase = DBPIdentifierCase.MIXED;
     @NotNull
-    private DBPIdentifierCase quotedIdentCase;
+    private DBPIdentifierCase quotedIdentCase = DBPIdentifierCase.MIXED;
     private boolean supportsSubqueries = false;
 
     private transient boolean typesLoaded = false;

plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/sql/SQLSyntaxManager.java

@@ -175,6 +175,7 @@ public class SQLSyntaxManager {
         }
     }
 
+    @NotNull
     public DBPIdentifierCase getKeywordCase() {
         final String caseName = preferenceStore.getString(ModelPreferences.SQL_FORMAT_KEYWORD_CASE);
         if (CommonUtils.isEmpty(caseName)) {