提交 e73b7650 编写于 作者: N Nikita Akilov

#10841 add comments about bug with border color of notification popups on dart theme


Former-commit-id: 2cbb33c7
上级 f87f2766
......@@ -124,7 +124,8 @@ public abstract class AbstractNotificationPopup extends Window {
resources = new LocalResourceManager(JFaceResources.getResources());
titleForegroundColor = getColor(resources, display.getSystemColor(SWT.COLOR_WIDGET_DARK_SHADOW).getRGB());
borderColor = display.getSystemColor(SWT.COLOR_DARK_GRAY);
//FIXME: on dark theme, the borders aren't distinguishable from the background for whatever reason
borderColor = UIStyles.isDarkTheme() ? display.getSystemColor(SWT.COLOR_GRAY) : display.getSystemColor(SWT.COLOR_DARK_GRAY);
backgroundColor = UIStyles.getDefaultWidgetBackground();
closeJob.setSystem(true);
......@@ -355,9 +356,14 @@ public abstract class AbstractNotificationPopup extends Window {
}
private void fixRegion(GC gc, Rectangle clArea) {
if (!UIStyles.isDarkTheme()) {
// FIXME:
// Notification borders are currently black on dark theme (which is a bug).
// If we proceed to fix the region, popup's corners are colored with border color
// (and the rest of the border is not). This needs to be deleted when the borders are fixed.
if (UIStyles.isDarkTheme()) {
return;
}
gc.setForeground(borderColor);
/* Fill Top Left */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册