#5319 SQL Server: DDL generation fix (defaults + domain names modifiers)

plugins/org.jkiss.dbeaver.ext.mssql.ui/src/org/jkiss/dbeaver/ext/mssql/edit/SQLServerTableColumnManager.java

@@ -66,7 +66,7 @@ public class SQLServerTableColumnManager extends SQLTableColumnManager<SQLServer
         } else {
             // Modify existing column
             // TODO: implement default constraint create/drop
-            //String defaultValue = CommonUtils.toString(column.getDefaultValue());
+            DefaultModifier.appendModifier(monitor, column, sql, command);
         }
     };
 

plugins/org.jkiss.dbeaver.ext.mssql/src/org/jkiss/dbeaver/ext/mssql/model/SQLServerDialect.java

@@ -110,16 +110,24 @@ public class SQLServerDialect extends JDBCSQLDialect {
                 }
             }
         } else if (dataKind == DBPDataKind.STRING) {
-            if (SQLServerConstants.TYPE_UNIQUEIDENTIFIER.equalsIgnoreCase(typeName)) {
-                return null;
-            }
-            long maxLength = column.getMaxLength();
-            if (maxLength == 0) {
-                return null;
-            } else if (maxLength == -1) {
-                return "(MAX)";
-            } else {
-                return "(" + maxLength + ")";
+            switch (typeName) {
+                case "char":
+                case "nchar":
+                case "varchar":
+                case "nvarchar":
+                case "text":
+                case "ntext": {
+                    long maxLength = column.getMaxLength();
+                    if (maxLength == 0) {
+                        return null;
+                    } else if (maxLength == -1) {
+                        return "(MAX)";
+                    } else {
+                        return "(" + maxLength + ")";
+                    }
+                }
+                default:
+                    return null;
             }
         }
         return super.getColumnTypeModifiers(dataSource, column, typeName, dataKind);