Compile warnings fixes

Former-commit-id: daa700b5

plugins/org.jkiss.dbeaver.data.transfer/src/org/jkiss/dbeaver/tools/transfer/registry/DataTransferNodeDescriptor.java

@@ -115,7 +115,7 @@ public class DataTransferNodeDescriptor extends AbstractDescriptor
     {
         implType.checkObjectClass(IDataTransferNode.class);
         try {
-            return implType.getObjectClass(IDataTransferNode.class).newInstance();
+            return implType.getObjectClass(IDataTransferNode.class).getDeclaredConstructor().newInstance();
         } catch (Throwable e) {
             throw new DBException("Can't create data transformer node", e);
         }
@@ -125,7 +125,7 @@ public class DataTransferNodeDescriptor extends AbstractDescriptor
     {
         settingsType.checkObjectClass(IDataTransferSettings.class);
         try {
-            return settingsType.getObjectClass(IDataTransferSettings.class).newInstance();
+            return settingsType.getObjectClass(IDataTransferSettings.class).getDeclaredConstructor().newInstance();
         } catch (Throwable e) {
             throw new DBException("Can't create node settings", e);
         }

plugins/org.jkiss.dbeaver.ext.generic/src/org/jkiss/dbeaver/ext/generic/model/meta/GenericMetaModelDescriptor.java

@@ -89,7 +89,7 @@ public class GenericMetaModelDescriptor extends AbstractDescriptor {
             throw new DBException("Can't create generic meta model instance '" + implType.getImplName() + "'");
         }
         try {
-            instance = implClass.newInstance();
+            instance = implClass.getDeclaredConstructor().newInstance();
         } catch (Throwable e) {
             throw new DBException("Can't instantiate meta model", e);
         }

plugins/org.jkiss.dbeaver.ext.mysql.ui/src/org/jkiss/dbeaver/ext/mysql/tools/MySQLScriptExecuteWizard.java

@@ -18,6 +18,7 @@
 
 package org.jkiss.dbeaver.ext.mysql.tools;
 
+import org.eclipse.jface.wizard.IWizardPage;
 import org.jkiss.dbeaver.ext.mysql.model.MySQLCatalog;
 import org.jkiss.dbeaver.ext.mysql.tasks.MySQLScriptExecuteSettings;
 import org.jkiss.dbeaver.ext.mysql.tasks.MySQLTasks;
@@ -32,7 +33,7 @@ import java.util.Map;
 
 class MySQLScriptExecuteWizard extends AbstractScriptExecuteWizard<MySQLScriptExecuteSettings, MySQLCatalog, MySQLCatalog> {
 
-    private MySQLScriptExecuteWizardPageSettings mainPage = new MySQLScriptExecuteWizardPageSettings(this);
+    private MySQLScriptExecuteWizardPageSettings settingsPage = new MySQLScriptExecuteWizardPageSettings(this);
 
     MySQLScriptExecuteWizard(MySQLCatalog catalog, boolean isImport) {
         super(Collections.singleton(catalog), isImport ? MySQLUIMessages.tools_script_execute_wizard_db_import : MySQLUIMessages.tools_script_execute_wizard_execute_script);
@@ -51,7 +52,7 @@ class MySQLScriptExecuteWizard extends AbstractScriptExecuteWizard<MySQLScriptEx
 
     @Override
     public void saveTaskState(DBRRunnableContext runnableContext, Map<String, Object> state) {
-        mainPage.saveState();
+        settingsPage.saveState();
         getSettings().saveSettings(runnableContext, new TaskPreferenceStore(state));
     }
 
@@ -76,8 +77,16 @@ class MySQLScriptExecuteWizard extends AbstractScriptExecuteWizard<MySQLScriptEx
     @Override
     public void addPages() {
         addTaskConfigPages();
-        addPage(mainPage);
+        addPage(settingsPage);
         super.addPages();
     }
 
+    @Override
+    public IWizardPage getNextPage(IWizardPage page) {
+        if (page == settingsPage) {
+            return null;
+        }
+        return super.getNextPage(page);
+    }
+
 }

plugins/org.jkiss.dbeaver.lang/src/org/jkiss/dbeaver/lang/base/SCMENumber.java

@@ -34,7 +34,7 @@ public class SCMENumber extends SCMLeafNode {
     }
 
     public Number getNumberValue() {
-        return new Double(getPlainValue());
+        return Double.parseDouble(getPlainValue());
     }
 
 }

plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/impl/AbstractDescriptor.java

@@ -28,6 +28,7 @@ import org.jkiss.dbeaver.model.DBPImage;
 import org.jkiss.utils.CommonUtils;
 import org.osgi.framework.Bundle;
 
+import java.lang.reflect.InvocationTargetException;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -191,8 +192,8 @@ public abstract class AbstractDescriptor {
                 throw new DBException("Can't load class '" + getImplName() + "'");
             }
             try {
-                return objectClass.newInstance();
-            } catch (InstantiationException | IllegalAccessException e) {
+                return objectClass.getDeclaredConstructor().newInstance();
+            } catch (InstantiationException | IllegalAccessException | NoSuchMethodException | InvocationTargetException e) {
                 throw new DBException("Can't instantiate class '" + getImplName() + "'", e);
             }
         }

plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/impl/preferences/BundlePreferenceStore.java

@@ -172,7 +172,7 @@ public class BundlePreferenceStore extends AbstractPreferenceStore {
             props.putDouble(name, value);
         }
         dirty = true;
-        firePropertyChangeEvent(name, new Double(oldValue), new Double(value));
+        firePropertyChangeEvent(name, oldValue, value);
     }
 
     @Override
@@ -187,7 +187,7 @@ public class BundlePreferenceStore extends AbstractPreferenceStore {
             props.putFloat(name, value);
         }
         dirty = true;
-        firePropertyChangeEvent(name, new Float(oldValue), new Float(value));
+        firePropertyChangeEvent(name, oldValue, value);
     }
 
     @Override
@@ -202,7 +202,7 @@ public class BundlePreferenceStore extends AbstractPreferenceStore {
             props.putInt(name, value);
         }
         dirty = true;
-        firePropertyChangeEvent(name, new Integer(oldValue), new Integer(value));
+        firePropertyChangeEvent(name, oldValue, value);
     }
 
     @Override
@@ -217,7 +217,7 @@ public class BundlePreferenceStore extends AbstractPreferenceStore {
             props.putLong(name, value);
         }
         dirty = true;
-        firePropertyChangeEvent(name, new Long(oldValue), new Long(value));
+        firePropertyChangeEvent(name, oldValue, value);
     }
 
     @Override

plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/registry/formatter/DataFormatterDescriptor.java

@@ -59,7 +59,7 @@ public class DataFormatterDescriptor extends AbstractDescriptor
         }
         Class<?> objectClass = getObjectClass(config.getAttribute("sampleClass"));
         try {
-            sample = (DBDDataFormatterSample)objectClass.newInstance();
+            sample = (DBDDataFormatterSample)objectClass.getDeclaredConstructor().newInstance();
         } catch (Exception e) {
             log.error("Can't instantiate data formatter '" + getId() + "' sample");
         }

plugins/org.jkiss.dbeaver.net.ssh.jsch/src/org/jkiss/dbeaver/model/net/ssh/DBeaverIdentityRepository.java

 package org.jkiss.dbeaver.model.net.ssh;
 
-import java.util.List;
-import java.util.Vector;
-
 import com.jcraft.jsch.Buffer;
 import com.jcraft.jsch.IdentityRepository;
 import com.jcraft.jsch.JSchException;
 
+import java.util.List;
+import java.util.Vector;
+
 public class DBeaverIdentityRepository implements IdentityRepository {
     
     private SSHImplementationAbstract impl;
@@ -18,7 +18,7 @@ public class DBeaverIdentityRepository implements IdentityRepository {
     }
 
     @Override
-    public Vector getIdentities() {
+    public Vector<?> getIdentities() {
         Vector<com.jcraft.jsch.Identity> result = new Vector<com.jcraft.jsch.Identity>(); 
 
         for (SSHAgentIdentity identity : identities) {

plugins/org.jkiss.dbeaver.team.git.ui/src/org/jkiss/dbeaver/team/git/ui/Activator.java

@@ -18,26 +18,14 @@
 
 package org.jkiss.dbeaver.team.git.ui;
 
-import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.Plugin;
-import org.jkiss.dbeaver.Log;
 import org.osgi.framework.BundleContext;
 
 public class Activator extends Plugin {
     
-    //private static final Log log = Log.getLog(Activator.class);
-
-
-    @Override
-    public void startup() throws CoreException {
-        //super.startup();
-        //log.info("Activator git startup");
-    }
-
     @Override
     public void start(BundleContext context) throws Exception {
-        //super.start(context);
-        //log.info("Activator git start");
+        super.start(context);
     }
 
 }