CB-430 Auth model refactoring

plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/DBPDataSourceConfigurationStorage.java

@@ -33,9 +33,6 @@ public interface DBPDataSourceConfigurationStorage {
 
     boolean isDefault();
 
-    // Datasources provided by some dynamic service (e.gl. cloud)
-    boolean isDynamic();
-
     String getStatus();
 
     List<? extends DBPDataSourceContainer> loadDataSources(DBPDataSourceRegistry registry, Map<String, Object> options)

plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/auth/DBAAuthCredentialsProvider.java

@@ -17,14 +17,20 @@
 
 package org.jkiss.dbeaver.model.auth;
 
+import org.jkiss.dbeaver.DBException;
 import org.jkiss.dbeaver.model.DBPDataSourceContainer;
 import org.jkiss.dbeaver.model.connection.DBPConnectionConfiguration;
 
 /**
- * Auth credentials.
+ * Auth credentials provider.
  */
 public interface DBAAuthCredentialsProvider {
 
-    boolean provideAuthParameters(DBPDataSourceContainer dataSourceContainer, DBPConnectionConfiguration configuration);
+    /**
+     * Fill credential parameters in the specified container and configuration.
+     * Returns false on auth cancel. True otherwise.
+     */
+    boolean provideAuthParameters(DBPDataSourceContainer dataSourceContainer, DBPConnectionConfiguration configuration)
+        throws DBException;
 
 }

plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceDescriptor.java

@@ -618,7 +618,7 @@ public class DataSourceDescriptor
 
     @Override
     public boolean isExternallyProvided() {
-        return storage.isDynamic();
+        return origin.isDynamic();
     }
 
     @Override

plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceRegistry.java

@@ -680,7 +680,7 @@ public class DataSourceRegistry implements DBPDataSourceRegistry {
             List<DataSourceDescriptor> removedDataSource = new ArrayList<>();
             for (DataSourceDescriptor ds : dataSources.values()) {
                 if (!parseResults.addedDataSources.contains(ds) && !parseResults.updatedDataSources.contains(ds) &&
-                    !ds.isProvided() && !ds.getStorage().isDynamic() && !ds.isDetached())
+                    !ds.isProvided() && !ds.isExternallyProvided() && !ds.isDetached())
                 {
                     removedDataSource.add(ds);
                 }

plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceStorage.java

@@ -78,11 +78,6 @@ class DataSourceStorage implements DBPDataSourceConfigurationStorage
         return isDefault;
     }
 
-    @Override
-    public boolean isDynamic() {
-        return false;
-    }
-
     public File getSourceFile() {
         return sourceFile;
     }