提交 22b4970d 编写于 作者: J jurgen

Properties model refactoring

Former-commit-id: 757faef3
上级 0a6a9131
...@@ -18,8 +18,8 @@ ...@@ -18,8 +18,8 @@
package org.jkiss.dbeaver.model.edit; package org.jkiss.dbeaver.model.edit;
import org.eclipse.ui.views.properties.IPropertyDescriptor;
import org.jkiss.dbeaver.model.DBPObject; import org.jkiss.dbeaver.model.DBPObject;
import org.jkiss.dbeaver.model.DBPPropertyDescriptor;
import org.jkiss.dbeaver.model.edit.prop.DBEPropertyHandler; import org.jkiss.dbeaver.model.edit.prop.DBEPropertyHandler;
/** /**
...@@ -29,6 +29,6 @@ public interface DBEObjectEditor <OBJECT_TYPE extends DBPObject> extends DBEObje ...@@ -29,6 +29,6 @@ public interface DBEObjectEditor <OBJECT_TYPE extends DBPObject> extends DBEObje
boolean canEditObject(OBJECT_TYPE object); boolean canEditObject(OBJECT_TYPE object);
DBEPropertyHandler<OBJECT_TYPE> makePropertyHandler(OBJECT_TYPE object, IPropertyDescriptor property); DBEPropertyHandler<OBJECT_TYPE> makePropertyHandler(OBJECT_TYPE object, DBPPropertyDescriptor property);
} }
...@@ -18,10 +18,10 @@ ...@@ -18,10 +18,10 @@
package org.jkiss.dbeaver.model.impl.sql.edit; package org.jkiss.dbeaver.model.impl.sql.edit;
import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.IWorkbenchWindow;
import org.eclipse.ui.views.properties.IPropertyDescriptor;
import org.jkiss.dbeaver.DBException; import org.jkiss.dbeaver.DBException;
import org.jkiss.dbeaver.core.CoreMessages; import org.jkiss.dbeaver.core.CoreMessages;
import org.jkiss.dbeaver.model.DBPNamedObject2; import org.jkiss.dbeaver.model.DBPNamedObject2;
import org.jkiss.dbeaver.model.DBPPropertyDescriptor;
import org.jkiss.dbeaver.model.DBPSaveableObject; import org.jkiss.dbeaver.model.DBPSaveableObject;
import org.jkiss.dbeaver.model.DBUtils; import org.jkiss.dbeaver.model.DBUtils;
import org.jkiss.dbeaver.model.edit.*; import org.jkiss.dbeaver.model.edit.*;
...@@ -56,7 +56,7 @@ public abstract class SQLObjectEditor<OBJECT_TYPE extends DBSObject & DBPSaveabl ...@@ -56,7 +56,7 @@ public abstract class SQLObjectEditor<OBJECT_TYPE extends DBSObject & DBPSaveabl
} }
@Override @Override
public final DBEPropertyHandler<OBJECT_TYPE> makePropertyHandler(OBJECT_TYPE object, IPropertyDescriptor property) public final DBEPropertyHandler<OBJECT_TYPE> makePropertyHandler(OBJECT_TYPE object, DBPPropertyDescriptor property)
{ {
return new PropertyHandler(property); return new PropertyHandler(property);
} }
...@@ -129,7 +129,7 @@ public abstract class SQLObjectEditor<OBJECT_TYPE extends DBSObject & DBPSaveabl ...@@ -129,7 +129,7 @@ public abstract class SQLObjectEditor<OBJECT_TYPE extends DBSObject & DBPSaveabl
return null; return null;
} }
protected void validateObjectProperty(OBJECT_TYPE object, IPropertyDescriptor property, Object value) throws DBException protected void validateObjectProperty(OBJECT_TYPE object, DBPPropertyDescriptor property, Object value) throws DBException
{ {
} }
...@@ -150,7 +150,7 @@ public abstract class SQLObjectEditor<OBJECT_TYPE extends DBSObject & DBPSaveabl ...@@ -150,7 +150,7 @@ public abstract class SQLObjectEditor<OBJECT_TYPE extends DBSObject & DBPSaveabl
extends ProxyPropertyDescriptor extends ProxyPropertyDescriptor
implements DBEPropertyHandler<OBJECT_TYPE>, DBEPropertyReflector<OBJECT_TYPE>, DBEPropertyValidator<OBJECT_TYPE> implements DBEPropertyHandler<OBJECT_TYPE>, DBEPropertyReflector<OBJECT_TYPE>, DBEPropertyValidator<OBJECT_TYPE>
{ {
private PropertyHandler(IPropertyDescriptor property) private PropertyHandler(DBPPropertyDescriptor property)
{ {
super(property); super(property);
} }
......
...@@ -30,6 +30,7 @@ import org.eclipse.ui.views.properties.IPropertyDescriptor; ...@@ -30,6 +30,7 @@ import org.eclipse.ui.views.properties.IPropertyDescriptor;
import org.eclipse.ui.views.properties.IPropertySource; import org.eclipse.ui.views.properties.IPropertySource;
import org.jkiss.dbeaver.model.DBPNamedObject; import org.jkiss.dbeaver.model.DBPNamedObject;
import org.jkiss.dbeaver.model.DBPPersistedObject; import org.jkiss.dbeaver.model.DBPPersistedObject;
import org.jkiss.dbeaver.model.DBPPropertyDescriptor;
import org.jkiss.dbeaver.model.meta.IPropertyValueEditorProvider; import org.jkiss.dbeaver.model.meta.IPropertyValueEditorProvider;
import org.jkiss.dbeaver.model.meta.IPropertyValueTransformer; import org.jkiss.dbeaver.model.meta.IPropertyValueTransformer;
import org.jkiss.dbeaver.model.meta.Property; import org.jkiss.dbeaver.model.meta.Property;
...@@ -53,7 +54,7 @@ import java.util.ResourceBundle; ...@@ -53,7 +54,7 @@ import java.util.ResourceBundle;
/** /**
* ObjectPropertyDescriptor * ObjectPropertyDescriptor
*/ */
public class ObjectPropertyDescriptor extends ObjectAttributeDescriptor implements IPropertyDescriptorEx, IPropertyValueListProvider<Object> public class ObjectPropertyDescriptor extends ObjectAttributeDescriptor implements DBPPropertyDescriptor, IPropertyDescriptorEx, IPropertyValueListProvider<Object>
{ {
private final Property propInfo; private final Property propInfo;
private final String propName; private final String propName;
......
...@@ -21,16 +21,17 @@ import org.eclipse.jface.viewers.CellEditor; ...@@ -21,16 +21,17 @@ import org.eclipse.jface.viewers.CellEditor;
import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ILabelProvider;
import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Composite;
import org.eclipse.ui.views.properties.IPropertyDescriptor; import org.eclipse.ui.views.properties.IPropertyDescriptor;
import org.jkiss.dbeaver.model.DBPPropertyDescriptor;
/** /**
* ProxyPropertyDescriptor * ProxyPropertyDescriptor
*/ */
public class ProxyPropertyDescriptor implements IPropertyDescriptor public class ProxyPropertyDescriptor implements DBPPropertyDescriptor
{ {
protected final IPropertyDescriptor original; protected final DBPPropertyDescriptor original;
public ProxyPropertyDescriptor(IPropertyDescriptor original) public ProxyPropertyDescriptor(DBPPropertyDescriptor original)
{ {
this.original = original; this.original = original;
} }
...@@ -41,12 +42,6 @@ public class ProxyPropertyDescriptor implements IPropertyDescriptor ...@@ -41,12 +42,6 @@ public class ProxyPropertyDescriptor implements IPropertyDescriptor
return this.original.getId(); return this.original.getId();
} }
@Override
public CellEditor createPropertyEditor(Composite parent)
{
return this.original.createPropertyEditor(parent);
}
@Override @Override
public String getCategory() public String getCategory()
{ {
...@@ -60,33 +55,30 @@ public class ProxyPropertyDescriptor implements IPropertyDescriptor ...@@ -60,33 +55,30 @@ public class ProxyPropertyDescriptor implements IPropertyDescriptor
} }
@Override @Override
public String getDisplayName() public Class<?> getDataType() {
{ return original.getDataType();
return this.original.getDisplayName();
} }
@Override @Override
public String[] getFilterFlags() public boolean isRequired() {
{ return original.isRequired();
return this.original.getFilterFlags();
} }
@Override @Override
public Object getHelpContextIds() public Object getDefaultValue() {
{ return original.getDefaultValue();
return this.original.getHelpContextIds();
} }
@Override @Override
public ILabelProvider getLabelProvider() public boolean isEditable(Object object) {
{ return original.isEditable(object);
return this.original.getLabelProvider();
} }
@Override @Override
public boolean isCompatibleWith(IPropertyDescriptor anotherProperty) public String getDisplayName()
{ {
return this.original.isCompatibleWith(anotherProperty); return this.original.getDisplayName();
} }
} }
...@@ -17,8 +17,8 @@ ...@@ -17,8 +17,8 @@
*/ */
package org.jkiss.dbeaver.ext.wmi.edit; package org.jkiss.dbeaver.ext.wmi.edit;
import org.eclipse.ui.views.properties.IPropertyDescriptor;
import org.jkiss.dbeaver.DBException; import org.jkiss.dbeaver.DBException;
import org.jkiss.dbeaver.model.DBPPropertyDescriptor;
import org.jkiss.dbeaver.model.edit.DBEPersistAction; import org.jkiss.dbeaver.model.edit.DBEPersistAction;
import org.jkiss.dbeaver.ext.wmi.model.WMINamespace; import org.jkiss.dbeaver.ext.wmi.model.WMINamespace;
import org.jkiss.dbeaver.model.edit.DBECommand; import org.jkiss.dbeaver.model.edit.DBECommand;
...@@ -39,7 +39,7 @@ public class WMINamespaceManager extends AbstractObjectManager<WMINamespace> imp ...@@ -39,7 +39,7 @@ public class WMINamespaceManager extends AbstractObjectManager<WMINamespace> imp
} }
@Override @Override
public DBEPropertyHandler<WMINamespace> makePropertyHandler(WMINamespace object, IPropertyDescriptor property) public DBEPropertyHandler<WMINamespace> makePropertyHandler(WMINamespace object, DBPPropertyDescriptor property)
{ {
return null; return null;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册