Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
全部都想学怎么办
CppCoreGuidelines
提交
1ca5545c
C
CppCoreGuidelines
项目概览
全部都想学怎么办
/
CppCoreGuidelines
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
C
CppCoreGuidelines
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
1ca5545c
编写于
3月 26, 2020
作者:
H
hsutter
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Followup to close #1586
上级
6f01c706
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
13 addition
and
7 deletion
+13
-7
CppCoreGuidelines.md
CppCoreGuidelines.md
+13
-7
未找到文件。
CppCoreGuidelines.md
浏览文件 @
1ca5545c
...
...
@@ -20271,17 +20271,20 @@ and errors (when we didn't deal correctly with semi-constructed objects consiste
##### Example, bad
// Old conventional style: many problems
class Picture
{
int mx;
int my;
char * data;
public:
// main problem: constructor does not fully construct
Picture(int x, int y)
{
mx = x
,
mx = x
; // also bad: assignment in constructor body rather than in member initializer
my = y;
data = nullptr;
data = nullptr;
// also bad: constant initialization in constructor rather than in member initializer
}
~Picture()
...
...
@@ -20289,6 +20292,7 @@ and errors (when we didn't deal correctly with semi-constructed objects consiste
Cleanup();
}
// bad: two-phase initialization
bool Init()
{
// invariant checks
...
...
@@ -20298,10 +20302,11 @@ and errors (when we didn't deal correctly with semi-constructed objects consiste
if (data) {
return false;
}
data = (char*) malloc(mx*my*sizeof(int));
data = (char*) malloc(mx*my*sizeof(int));
// also bad: owning raw * and malloc
return data != nullptr;
}
// also bad: no reason to make cleanup a separate function
void Cleanup()
{
if (data) free(data);
...
...
@@ -20320,11 +20325,11 @@ and errors (when we didn't deal correctly with semi-constructed objects consiste
class Picture
{
ptrdiff_
t mx;
ptrdiff_
t my;
in
t mx;
in
t my;
vector<char> data;
static
ptrdiff_t check_size(ptrdiff_
t size)
static
int check_size(in
t size)
{
// invariant check
Expects(size > 0);
...
...
@@ -20333,7 +20338,7 @@ and errors (when we didn't deal correctly with semi-constructed objects consiste
public:
// even better would be a class for a 2D Size as one single parameter
Picture(
ptrdiff_t x, ptrdiff_
t y)
Picture(
int x, in
t y)
: mx(check_size(x))
, my(check_size(y))
// now we know x and y have a valid size
...
...
@@ -20341,6 +20346,7 @@ and errors (when we didn't deal correctly with semi-constructed objects consiste
{
// picture is ready-to-use
}
// compiler generated dtor does the job. (also see C.21)
};
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录