提交 ff6d6042 编写于 作者: M Matt Bierner

Fix or supress more implict index access errors

For #76442
上级 ca7605f3
...@@ -212,12 +212,12 @@ export class SimpleWorkerClient<W extends object, H extends object> extends Disp ...@@ -212,12 +212,12 @@ export class SimpleWorkerClient<W extends object, H extends object> extends Disp
this._worker.postMessage(msg); this._worker.postMessage(msg);
}, },
handleMessage: (method: string, args: any[]): Promise<any> => { handleMessage: (method: string, args: any[]): Promise<any> => {
if (typeof host[method] !== 'function') { if (typeof (host as any)[method] !== 'function') {
return Promise.reject(new Error('Missing method ' + method + ' on main thread host.')); return Promise.reject(new Error('Missing method ' + method + ' on main thread host.'));
} }
try { try {
return Promise.resolve(host[method].apply(host, args)); return Promise.resolve((host as any)[method].apply(host, args));
} catch (e) { } catch (e) {
return Promise.reject(e); return Promise.reject(e);
} }
......
...@@ -336,7 +336,7 @@ export class IssueReporter extends Disposable { ...@@ -336,7 +336,7 @@ export class IssueReporter extends Disposable {
this.render(); this.render();
}); });
['includeSystemInfo', 'includeProcessInfo', 'includeWorkspaceInfo', 'includeExtensions', 'includeSearchedExtensions', 'includeSettingsSearchDetails'].forEach(elementId => { (['includeSystemInfo', 'includeProcessInfo', 'includeWorkspaceInfo', 'includeExtensions', 'includeSearchedExtensions', 'includeSettingsSearchDetails'] as const).forEach(elementId => {
this.addEventListener(elementId, 'click', (event: Event) => { this.addEventListener(elementId, 'click', (event: Event) => {
event.stopPropagation(); event.stopPropagation();
this.issueReporterModel.update({ [elementId]: !this.issueReporterModel.getData()[elementId] }); this.issueReporterModel.update({ [elementId]: !this.issueReporterModel.getData()[elementId] });
......
...@@ -52,13 +52,13 @@ export interface IWebWorkerOptions { ...@@ -52,13 +52,13 @@ export interface IWebWorkerOptions {
/** /**
* An object that can be used by the web worker to make calls back to the main thread. * An object that can be used by the web worker to make calls back to the main thread.
*/ */
host?: object; host?: any;
} }
class MonacoWebWorkerImpl<T> extends EditorWorkerClient implements MonacoWebWorker<T> { class MonacoWebWorkerImpl<T> extends EditorWorkerClient implements MonacoWebWorker<T> {
private readonly _foreignModuleId: string; private readonly _foreignModuleId: string;
private readonly _foreignModuleHost: object | null; private readonly _foreignModuleHost: { [method: string]: Function } | null;
private _foreignModuleCreateData: any | null; private _foreignModuleCreateData: any | null;
private _foreignProxy: Promise<T> | null; private _foreignProxy: Promise<T> | null;
......
...@@ -989,7 +989,7 @@ declare namespace monaco.editor { ...@@ -989,7 +989,7 @@ declare namespace monaco.editor {
/** /**
* An object that can be used by the web worker to make calls back to the main thread. * An object that can be used by the web worker to make calls back to the main thread.
*/ */
host?: object; host?: any;
} }
/** /**
......
...@@ -222,10 +222,10 @@ export class InstantiationService implements IInstantiationService { ...@@ -222,10 +222,10 @@ export class InstantiationService implements IInstantiationService {
const idle = new IdleValue(() => this._createInstance<T>(ctor, args, _trace)); const idle = new IdleValue(() => this._createInstance<T>(ctor, args, _trace));
return <T>new Proxy(Object.create(null), { return <T>new Proxy(Object.create(null), {
get(_target: T, prop: PropertyKey): any { get(_target: T, prop: PropertyKey): any {
return idle.getValue()[prop]; return (idle.getValue() as any)[prop];
}, },
set(_target: T, p: PropertyKey, value: any): boolean { set(_target: T, p: PropertyKey, value: any): boolean {
idle.getValue()[p] = value; (idle.getValue() as any)[p] = value;
return true; return true;
} }
}); });
......
...@@ -163,7 +163,7 @@ export class ReviewController implements IEditorContribution { ...@@ -163,7 +163,7 @@ export class ReviewController implements IEditorContribution {
private _emptyThreadsToAddQueue: [number, IEditorMouseEvent | undefined][] = []; private _emptyThreadsToAddQueue: [number, IEditorMouseEvent | undefined][] = [];
private _computeCommentingRangePromise: CancelablePromise<ICommentInfo[]> | null; private _computeCommentingRangePromise: CancelablePromise<ICommentInfo[]> | null;
private _computeCommentingRangeScheduler: Delayer<Array<ICommentInfo | null>> | null; private _computeCommentingRangeScheduler: Delayer<Array<ICommentInfo | null>> | null;
private _pendingCommentCache: { [key: number]: { [key: string]: string } }; private _pendingCommentCache: { [key: string]: { [key: string]: string } };
constructor( constructor(
editor: ICodeEditor, editor: ICodeEditor,
...@@ -396,7 +396,7 @@ export class ReviewController implements IEditorContribution { ...@@ -396,7 +396,7 @@ export class ReviewController implements IEditorContribution {
return; return;
} }
const pendingCommentText = this._pendingCommentCache[e.owner] && this._pendingCommentCache[e.owner][thread.threadId]; const pendingCommentText = this._pendingCommentCache[e.owner] && this._pendingCommentCache[e.owner][thread.threadId!];
this.displayCommentThread(e.owner, thread, pendingCommentText); this.displayCommentThread(e.owner, thread, pendingCommentText);
this._commentInfos.filter(info => info.owner === e.owner)[0].threads.push(thread); this._commentInfos.filter(info => info.owner === e.owner)[0].threads.push(thread);
}); });
...@@ -624,7 +624,7 @@ export class ReviewController implements IEditorContribution { ...@@ -624,7 +624,7 @@ export class ReviewController implements IEditorContribution {
info.threads.forEach(thread => { info.threads.forEach(thread => {
let pendingComment: string | null = null; let pendingComment: string | null = null;
if (providerCacheStore) { if (providerCacheStore) {
pendingComment = providerCacheStore[thread.threadId]; pendingComment = providerCacheStore[thread.threadId!];
} }
if (pendingComment) { if (pendingComment) {
...@@ -658,10 +658,10 @@ export class ReviewController implements IEditorContribution { ...@@ -658,10 +658,10 @@ export class ReviewController implements IEditorContribution {
this._pendingCommentCache[zone.owner] = {}; this._pendingCommentCache[zone.owner] = {};
} }
this._pendingCommentCache[zone.owner][zone.commentThread.threadId] = pendingComment; this._pendingCommentCache[zone.owner][zone.commentThread.threadId!] = pendingComment;
} else { } else {
if (providerCacheStore) { if (providerCacheStore) {
delete providerCacheStore[zone.commentThread.threadId]; delete providerCacheStore[zone.commentThread.threadId!];
} }
} }
......
...@@ -179,7 +179,7 @@ export class ExperimentService extends Disposable implements IExperimentService ...@@ -179,7 +179,7 @@ export class ExperimentService extends Disposable implements IExperimentService
if (context.res.statusCode !== 200) { if (context.res.statusCode !== 200) {
return Promise.resolve(null); return Promise.resolve(null);
} }
return asJson(context).then(result => { return asJson(context).then((result: any) => {
return result && Array.isArray(result['experiments']) ? result['experiments'] : []; return result && Array.isArray(result['experiments']) ? result['experiments'] : [];
}); });
}, () => Promise.resolve(null)); }, () => Promise.resolve(null));
......
...@@ -206,7 +206,7 @@ export const schema = { ...@@ -206,7 +206,7 @@ export const schema = {
type: 'object', type: 'object',
properties: { properties: {
// extensions will fill in // extensions will fill in
}, } as { [key: string]: any },
default: {} default: {}
}, },
preview: { preview: {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册