Fixes #6380: Markdown does not disable autotrigger suggest

src/vs/editor/common/modes.ts

@@ -339,8 +339,6 @@ export interface ISuggestSupport {
 
 	triggerCharacters: string[];
 
-	shouldAutotriggerSuggest: boolean;
-
 	filter?: IFilter;
 
 	provideCompletionItems(model:editorCommon.IReadOnlyModel, position:Position, token:CancellationToken): ISuggestResult[] | Thenable<ISuggestResult[]>;

src/vs/editor/common/modes/supports/suggestSupport.ts

@@ -35,10 +35,6 @@ export class TextualSuggestSupport implements ISuggestSupport {
 		return [];
 	}
 
-	public get shouldAutotriggerSuggest(): boolean {
-		return true;
-	}
-
 	public get filter(): IFilter {
 		return matchesStrictPrefix;
 	}

src/vs/editor/contrib/suggest/browser/suggest.ts

@@ -129,10 +129,6 @@ export class SuggestController implements IEditorContribution {
 	}
 
 	private triggerCharacterHandler(character: string, groups: ISuggestSupport[][]): void {
-		groups = groups.map(supports => {
-			return supports.filter(support => support.shouldAutotriggerSuggest);
-		});
-
 		if (groups.length > 0) {
 			this.triggerSuggest(character, groups).done(null, onUnexpectedError);
 		}

src/vs/editor/contrib/suggest/browser/suggestModel.ts

@@ -82,7 +82,7 @@ class Context {
 		}
 
 		const supports = SuggestRegistry.all(model);
-		this.isAutoTriggerEnabled = supports.some(s => s.shouldAutotriggerSuggest);
+		this.isAutoTriggerEnabled = (supports.length > 0);
 	}
 
 	public shouldAutoTrigger(): boolean {

src/vs/languages/css/common/css.ts

@@ -359,7 +359,6 @@ export class CSSMode extends AbstractMode {
 
 		modes.SuggestRegistry.register(this.getId(), {
 			triggerCharacters: [' ', ':'],
-			shouldAutotriggerSuggest: true,
 			provideCompletionItems: (model, position, token): Thenable<modes.ISuggestResult[]> => {
 				return wireCancellationToken(token, this._provideCompletionItems(model.uri, position));
 			}

src/vs/languages/handlebars/common/handlebars.ts

@@ -131,7 +131,6 @@ export class HandlebarsMode extends htmlMode.HTMLMode<htmlWorker.HTMLWorker> {
 
 		modes.SuggestRegistry.register(this.getId(), {
 			triggerCharacters: ['.', ':', '<', '"', '=', '/'],
-			shouldAutotriggerSuggest: true,
 			provideCompletionItems: (model, position, token): Thenable<modes.ISuggestResult[]> => {
 				return wireCancellationToken(token, this._provideCompletionItems(model.uri, position));
 			}

src/vs/languages/html/common/html.ts

@@ -339,7 +339,6 @@ export class HTMLMode<W extends htmlWorker.HTMLWorker> extends AbstractMode impl
 
 		modes.SuggestRegistry.register(this.getId(), {
 			triggerCharacters: ['.', ':', '<', '"', '=', '/'],
-			shouldAutotriggerSuggest: true,
 			provideCompletionItems: (model, position, token): Thenable<modes.ISuggestResult[]> => {
 				return wireCancellationToken(token, this._provideCompletionItems(model.uri, position));
 			}

src/vs/languages/json/common/json.ts

@@ -94,7 +94,6 @@ export class JSONMode extends AbstractMode {
 
 		modes.SuggestRegistry.register(this.getId(), {
 			triggerCharacters: [],
-			shouldAutotriggerSuggest: true,
 			provideCompletionItems: (model, position, token): Thenable<modes.ISuggestResult[]> => {
 				return wireCancellationToken(token, this._provideCompletionItems(model.uri, position));
 			}

src/vs/languages/less/common/less.ts

@@ -233,7 +233,6 @@ export class LESSMode extends AbstractMode {
 
 		modes.SuggestRegistry.register(this.getId(), {
 			triggerCharacters: [],
-			shouldAutotriggerSuggest: true,
 			provideCompletionItems: (model, position, token): Thenable<modes.ISuggestResult[]> => {
 				return wireCancellationToken(token, this._provideCompletionItems(model.uri, position));
 			}

src/vs/languages/markdown/common/markdown.ts

@@ -239,7 +239,6 @@ export class MarkdownMode extends AbstractMode implements Modes.IEmitOutputSuppo
 
 		Modes.SuggestRegistry.register(this.getId(), {
 			triggerCharacters: [],
-			shouldAutotriggerSuggest: false,
 			provideCompletionItems: (model, position, token) => {
 				return wireCancellationToken(token, editorWorkerService.textualSuggest(model.uri, position));
 			}

src/vs/languages/razor/common/razor.ts

@@ -80,7 +80,6 @@ export class RAZORMode extends htmlMode.HTMLMode<RAZORWorker> {
 
 		modes.SuggestRegistry.register(this.getId(), {
 			triggerCharacters: ['.', ':', '<', '"', '=', '/'],
-			shouldAutotriggerSuggest: true,
 			provideCompletionItems: (model, position, token): Thenable<modes.ISuggestResult[]> => {
 				return wireCancellationToken(token, this._provideCompletionItems(model.uri, position));
 			}

src/vs/languages/sass/common/sass.ts

@@ -334,7 +334,6 @@ export class SASSMode extends AbstractMode {
 
 		modes.SuggestRegistry.register(this.getId(), {
 			triggerCharacters: [],
-			shouldAutotriggerSuggest: true,
 			provideCompletionItems: (model, position, token): Thenable<modes.ISuggestResult[]> => {
 				return wireCancellationToken(token, this._provideCompletionItems(model.uri, position));
 			}

src/vs/languages/typescript/common/languageFeatures.ts

@@ -172,10 +172,6 @@ class SuggestAdapter extends Adapter implements modes.ISuggestSupport {
 		return ['.'];
 	}
 
-	public get shouldAutotriggerSuggest(): boolean {
-		return true;
-	}
-
 	provideCompletionItems(model:editorCommon.IReadOnlyModel, position:Position, token:CancellationToken): Thenable<modes.ISuggestResult[]> {
 		const wordInfo = model.getWordUntilPosition(position);
 		const resource = model.uri;

src/vs/workbench/api/node/extHostLanguageFeatures.ts

@@ -976,7 +976,6 @@ export class MainThreadLanguageFeatures {
 	$registerSuggestSupport(handle: number, selector: vscode.DocumentSelector, triggerCharacters: string[]): TPromise<any> {
 		this._registrations[handle] = modes.SuggestRegistry.register(selector, <modes.ISuggestSupport>{
 			triggerCharacters: triggerCharacters,
-			shouldAutotriggerSuggest: true,
 			provideCompletionItems: (model:IReadOnlyModel, position:EditorPosition, token:CancellationToken): Thenable<modes.ISuggestResult[]> => {
 				return wireCancellationToken(token, this._proxy.$provideCompletionItems(handle, model.uri, position));
 			},