提交 47e54aef 编写于 作者: M Matt Bierner

Return undefined instead of null

上级 4eb2bf39
...@@ -34,14 +34,14 @@ export interface IEditorRegistry { ...@@ -34,14 +34,14 @@ export interface IEditorRegistry {
registerEditor(descriptor: IEditorDescriptor, editorInputDescriptor: SyncDescriptor<EditorInput>[]): void; registerEditor(descriptor: IEditorDescriptor, editorInputDescriptor: SyncDescriptor<EditorInput>[]): void;
/** /**
* Returns the editor descriptor for the given input or null if none. * Returns the editor descriptor for the given input or `undefined` if none.
*/ */
getEditor(input: EditorInput): IEditorDescriptor | null; getEditor(input: EditorInput): IEditorDescriptor | undefined;
/** /**
* Returns the editor descriptor for the given identifier or null if none. * Returns the editor descriptor for the given identifier or null if none.
*/ */
getEditorById(editorId: string): IEditorDescriptor | null; getEditorById(editorId: string): IEditorDescriptor | undefined;
/** /**
* Returns an array of registered editors known to the platform. * Returns an array of registered editors known to the platform.
...@@ -104,12 +104,12 @@ class EditorRegistry implements IEditorRegistry { ...@@ -104,12 +104,12 @@ class EditorRegistry implements IEditorRegistry {
this.editors.push(descriptor); this.editors.push(descriptor);
} }
getEditor(input: EditorInput): EditorDescriptor | null { getEditor(input: EditorInput): EditorDescriptor | undefined {
const findEditorDescriptors = (input: EditorInput, byInstanceOf?: boolean): EditorDescriptor[] => { const findEditorDescriptors = (input: EditorInput, byInstanceOf?: boolean): EditorDescriptor[] => {
const matchingDescriptors: EditorDescriptor[] = []; const matchingDescriptors: EditorDescriptor[] = [];
for (const editor of this.editors) { for (const editor of this.editors) {
const inputDescriptors: SyncDescriptor<EditorInput>[] | undefined = this.mapEditorToInputs.get(editor); const inputDescriptors = this.mapEditorToInputs.get(editor);
if (inputDescriptors) { if (inputDescriptors) {
for (const inputDescriptor of inputDescriptors) { for (const inputDescriptor of inputDescriptors) {
const inputClass = inputDescriptor.ctor; const inputClass = inputDescriptor.ctor;
...@@ -154,17 +154,17 @@ class EditorRegistry implements IEditorRegistry { ...@@ -154,17 +154,17 @@ class EditorRegistry implements IEditorRegistry {
return descriptors[0]; return descriptors[0];
} }
return null; return undefined;
} }
getEditorById(editorId: string): EditorDescriptor | null { getEditorById(editorId: string): EditorDescriptor | undefined {
for (const editor of this.editors) { for (const editor of this.editors) {
if (editor.getId() === editorId) { if (editor.getId() === editorId) {
return editor; return editor;
} }
} }
return null; return undefined;
} }
getEditors(): EditorDescriptor[] { getEditors(): EditorDescriptor[] {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册