未验证 提交 202d5711 编写于 作者: J Jared Tan 提交者: GitHub

fix NPE when fetch empty readHeatMap metrics. (#4891)

上级 d982576a
...@@ -34,7 +34,7 @@ import org.apache.skywalking.oap.server.core.analysis.metrics.DataTable; ...@@ -34,7 +34,7 @@ import org.apache.skywalking.oap.server.core.analysis.metrics.DataTable;
@Getter @Getter
public class HeatMap { public class HeatMap {
private List<HeatMapColumn> values = new ArrayList<>(10); private List<HeatMapColumn> values = new ArrayList<>(10);
private List<Bucket> buckets = null; private List<Bucket> buckets = new ArrayList<>();
public void addBucket(Bucket bucket) { public void addBucket(Bucket bucket) {
this.buckets.add(bucket); this.buckets.add(bucket);
...@@ -50,8 +50,7 @@ public class HeatMap { ...@@ -50,8 +50,7 @@ public class HeatMap {
DataTable dataset = new DataTable(rawdata); DataTable dataset = new DataTable(rawdata);
final List<String> sortedKeys = dataset.sortedKeys(new KeyComparator(true)); final List<String> sortedKeys = dataset.sortedKeys(new KeyComparator(true));
if (buckets == null) { if (buckets.isEmpty()) {
buckets = new ArrayList<>(dataset.size());
for (int i = 0; i < sortedKeys.size(); i++) { for (int i = 0; i < sortedKeys.size(); i++) {
final Bucket bucket = new Bucket(); final Bucket bucket = new Bucket();
final String minValue = sortedKeys.get(i); final String minValue = sortedKeys.get(i);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册