ROCKETMQ-18 Remove bad practices in client.

client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPullConsumer.java

@@ -335,6 +335,7 @@ public class DefaultMQPullConsumer extends ClientConfig implements MQPullConsume
             MessageDecoder.decodeMessageId(uniqKey);
             return this.viewMessage(uniqKey);
         } catch (Exception e) {
+            // Ignore
         }
         return this.defaultMQPullConsumerImpl.queryMessageByUniqKey(topic, uniqKey);
     }

client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java

@@ -210,6 +210,7 @@ public class DefaultMQPushConsumer extends ClientConfig implements MQPushConsume
             MessageDecoder.decodeMessageId(msgId);
             return this.viewMessage(msgId);
         } catch (Exception e) {
+            // Ignore
         }
         return this.defaultMQPushConsumerImpl.queryMessageByUniqKey(topic, msgId);
     }

client/src/main/java/org/apache/rocketmq/client/consumer/PullCallback.java

@@ -22,7 +22,7 @@ package org.apache.rocketmq.client.consumer;
  * @author vintagewang@apache.org
  */
 public interface PullCallback {
-    public void onSuccess(final PullResult pullResult);
+    void onSuccess(final PullResult pullResult);
 
-    public void onException(final Throwable e);
+    void onException(final Throwable e);
 }

client/src/main/java/org/apache/rocketmq/client/consumer/PullTaskCallback.java

@@ -20,5 +20,5 @@ import org.apache.rocketmq.common.message.MessageQueue;
 
 
 public interface PullTaskCallback {
-    public void doPullTask(final MessageQueue mq, final PullTaskContext context);
+    void doPullTask(final MessageQueue mq, final PullTaskContext context);
 }

client/src/main/java/org/apache/rocketmq/client/consumer/listener/ConsumeReturnType.java

@@ -17,9 +17,6 @@
 
 package org.apache.rocketmq.client.consumer.listener;
 
-/**
- * Created by alvin on 16-11-30.
- */
 public enum ConsumeReturnType {
     /**
      * consume return success

client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByMachineRoom.java

@@ -45,12 +45,12 @@ public class AllocateMessageQueueByMachineRoom implements AllocateMessageQueueSt
                 premqAll.add(mq);
             }
         }
-        // Todo cid
+
         int mod = premqAll.size() / cidAll.size();
         int rem = premqAll.size() % cidAll.size();
-        int startindex = mod * currentIndex;
-        int endindex = startindex + mod;
-        for (int i = startindex; i < endindex; i++) {
+        int startIndex = mod * currentIndex;
+        int endIndex = startIndex + mod;
+        for (int i = startIndex; i < endIndex; i++) {
             result.add(mqAll.get(i));
         }
         if (rem > currentIndex) {

client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java

@@ -125,7 +125,7 @@ public class RemoteBrokerOffsetStore implements OffsetStore {
             return;
 
         final HashSet<MessageQueue> unusedMQ = new HashSet<MessageQueue>();
-        if (mqs != null && !mqs.isEmpty()) {
+        if (!mqs.isEmpty()) {
             for (Map.Entry<MessageQueue, AtomicLong> entry : this.offsetTable.entrySet()) {
                 MessageQueue mq = entry.getKey();
                 AtomicLong offset = entry.getValue();

client/src/main/java/org/apache/rocketmq/client/hook/CheckForbiddenHook.java

@@ -24,8 +24,8 @@ import org.apache.rocketmq.client.exception.MQClientException;
  * @author manhong.yqd
  */
 public interface CheckForbiddenHook {
-    public String hookName();
+    String hookName();
 
 
-    public void checkForbidden(final CheckForbiddenContext context) throws MQClientException;
+    void checkForbidden(final CheckForbiddenContext context) throws MQClientException;
 }

client/src/main/java/org/apache/rocketmq/client/hook/FilterMessageHook.java

@@ -20,8 +20,8 @@ package org.apache.rocketmq.client.hook;
  * @author manhong.yqd
  */
 public interface FilterMessageHook {
-    public String hookName();
+    String hookName();
 
 
-    public void filterMessage(final FilterMessageContext context);
+    void filterMessage(final FilterMessageContext context);
 }