- 03 6月, 2021 2 次提交
- 02 6月, 2021 10 次提交
-
-
由 Tomas Vik 提交于
chore: fix eslint errors that got to master from outdated MR See merge request gitlab-org/gitlab-vscode-extension!269
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
fix: remove the broken code related to creating user snippets See merge request gitlab-org/gitlab-vscode-extension!265
-
由 Tomas Vik 提交于
By stipping away all but unchanged lines we allowed edge cases when a file started or ended with changes. In this scenario we wrongly addded unchanged lines to the beginning or the end of the file.
-
由 Tomas Vik 提交于
feat: create new MR diff comments See merge request gitlab-org/gitlab-vscode-extension!266
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
-
- 01 6月, 2021 2 次提交
- 31 5月, 2021 1 次提交
-
-
由 Tomas Vik 提交于
When we dispose commentController, all its therads will get disposed automatically. We don't ever need to call dispose outside of the GitLabCommentThread.
-
- 27 5月, 2021 8 次提交
-
-
由 Tomas Vik 提交于
docs: make README more user oriented See merge request gitlab-org/gitlab-vscode-extension!262
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
chore: enable no-floating-promises eslint rule See merge request gitlab-org/gitlab-vscode-extension!264
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
We can use the standard `getActiveRepositoryOrSelectOne()` and delete the custom project picker. Also, we can remove the duplicated block for getting project to put the snippet in. Lastly, this commit converts several nested if statement into early return statements.
-
由 Tomas Vik 提交于
Creating snippets in user space hasn't worked in a long time. And for the last year, when the extension supports multiple GitLab instances, we wouldn't know which instance to use for adding the user snippet. This commit removes the broken logic and focuses on creating project snippets.
-
由 Tomas Vik 提交于
-
- 26 5月, 2021 1 次提交
-
-
由 Tomas Vik 提交于
create_snippet was the only client using the function
-
- 25 5月, 2021 5 次提交
-
-
由 Tomas Vik 提交于
Most of the client code was making its own `assert()`, because it couldn't continue without having an existing repository. By moving the assert into the `getRepository()` method, we simplify the client code.
-
由 Tomas Vik 提交于
Multiple paces will need to search through all the MR changes and find the correct diff. This commit extracts a method to do that.
-
由 Tomas Vik 提交于
When we create new diff threads, the API requires us to submit all three values (start/base/head SHA) so even though we don't need startSha internally, we have to parse it from the response.
-
由 Tomas Vik 提交于
refactor: track unchanged lines between new and old version of the diff See merge request gitlab-org/gitlab-vscode-extension!261
-
由 Tomas Vik 提交于
-
- 21 5月, 2021 4 次提交
- 20 5月, 2021 4 次提交
-
-
由 Tomas Vik 提交于
Added two new methods to the WrappedRepository: `reloadMr()` and `getMr()`. - `reloadMr()` will fetch additional information for the MR (for now it's the diff). It will also store this fetched information into a cache. - `getMr()` expects that `reloadMr()` has been called in the past. It retrieves the MR information without making api calls.
-
由 Tomas Vik 提交于
This commit changes the way WrappedRepository exposes the GitLabNewService. We used getter which was very hard to mock in tests. Instead, we now use regular function (getGitLabService()) which is easily replaced in tests. Additionally, this commit creates a helper function for creating WrappedRepository, because it is going to be used in many tests in the future.
-
由 Tomas Vik 提交于
This commit replaces the GitLabRepository(GitLabWorkspace) interface with the Wrapped repository. The original objects `{ label, uri, error}` were constructed by the issuable.ts. We now use the WrappedRepository and the error state is signaled by a new `containsGitLabProject` boolean flag. I.e. if the wrapped repository doesn't contain GitLab project, there has been error during fetching it. Also having access to the wrapped repository from within mr_item_model is going to be important in the next commit because it allows us to interact with the MR cache.
-
由 Tomas Vik 提交于
This method isn't used outside of the wrapped_repository module.
-
- 19 5月, 2021 3 次提交