- 02 3月, 2021 5 次提交
-
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
All logic related to creating vscode.CommentThread and setting the correct properties has been extracted to one class. This class will be responsible for resolving threads in the future.
-
由 Tomas Vik 提交于
The GitLabComment is going to be responsible for all comment-related functionality like editing, deleting and reacting.
-
由 Tomas Vik 提交于
The testing responsibility is now strictly divided. The tree_view test is responsible for validating querying lists of issues/MRs and showing these lists as items in the tree_view. The new mr_review test is responsible for all interactions with the MR item, including showing changed files when clicked, fetching discussions and any future review functionality. This commit splits the "shows project merge requests assigned to me with changed files" test in two and all other tests just moved around unchanged.
-
由 Tomas Vik 提交于
chore(ci variables): update the ci_variables.json See merge request gitlab-org/gitlab-vscode-extension!191
-
- 01 3月, 2021 1 次提交
-
-
由 Tomas Vik 提交于
-
- 25 2月, 2021 3 次提交
- 24 2月, 2021 3 次提交
- 23 2月, 2021 7 次提交
-
-
由 Tomas Vik 提交于
We migrated to TS and introduced new concepts since the last update.
-
由 Tomas Vik 提交于
This is a snippet from a book Effective TypeScript: WARNING The examples in this item prefix type names with I or T solely to indicate how they were defined. You should not do this in your code! Prefixing interface types with I is common in C#, and this convention made some inroads in the early days of TypeScript. But it is considered bad style today because it’s unnecessary, adds little value, and is not consistently followed in the standard libraries.
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
Implement git clone command See merge request gitlab-org/gitlab-vscode-extension!172
-
由 Felix Haase 提交于
A simple implementation of the git.clone command for the configured instances. It also includes a credential provider that can clone the repository without user input using the access token See merge request gitlab-org/gitlab-vscode-extension!172 Relates to #222
-
由 Tomas Vik 提交于
docs: add architecture.md See merge request gitlab-org/gitlab-vscode-extension!187
-
由 Tomas Vik 提交于
This document explains how the current code is structured and it also hints at what changes are we planning to do to the extension structure in the near future.
-
- 19 2月, 2021 2 次提交
- 18 2月, 2021 11 次提交
-
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
After implementing detached pipelines, this method is only used within the gitlab_service module.
-
由 Tomas Vik 提交于
We had to change the command for openning pipeline in the browser to support detached pipelines.
-
由 Tomas Vik 提交于
All the data we need are in the API response that lists pipelines.
-
由 Tomas Vik 提交于
Prefer detached pipelines and only report normal branch pipeline when there isn't any detached pipeline (MR pipeline). We also change the logic to fetch MR and pipeline at the same time because we need to know MR anyway to be able to get detached pipeline. Refactoring status_bar to use both pipeline and MR from the response is too difficult to squeeze in this change. We'll have to do it later.
-
由 Tomas Vik 提交于
This reduces the need for readers to keep a variable in their head to read 50 LOC.
-
由 Tomas Vik 提交于
By relying on an exception, we are able to remove several checks for failed project fetching. This also saves one extra call to the /project endpoint. Additionally, this commit replaces a long if statement with an early return.
-
由 Tomas Vik 提交于
The `pipelineGitRemoteName` setting is used to say: "Use this remote for getting pipelines" This purpose of this configuration is to mark a fork. Then you can read issues and MRs from the main project and pipelines from your fork.
-
由 Tomas Vik 提交于
The service can be made simpler by moving the pipeline specific remote out of the service and exposing a more general method.
-
由 Tomas Vik 提交于
Extracting configuration related logic came up in reviews multiple times. Also, the VS Code logic returns missing properties as null. This behaviour is not ideal because null function arguments overrdie the default function arguments. Related discussions: - https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/merge_requests/115#note_432956679
-
由 Tomas Vik 提交于
This fixes a minor bug where if user hasn't configured their instaenceUrl (presumably they use the default gitlab.com), the webview is going to put `null` in the links. This fix makes sure we use the same logic as the rest of the app.
-
- 15 2月, 2021 7 次提交
-
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
test: increase integration test timeout See merge request gitlab-org/gitlab-vscode-extension!184
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
refactor(status bar): extract status_bar module into a class See merge request gitlab-org/gitlab-vscode-extension!181
-
由 Tomas Vik 提交于
-
由 Tomas Vik 提交于
test(integration): reduce test flakiness by replacing globalState See merge request gitlab-org/gitlab-vscode-extension!180
-
由 Tomas Vik 提交于
-
- 12 2月, 2021 1 次提交
-
-
由 Tomas Vik 提交于
test(for_current_branch): fix hardcoded date breaking tests See merge request gitlab-org/gitlab-vscode-extension!179
-