提交 1aaaaa04 编写于 作者: R raphael22 提交者: Kamran Ahmed

Fix - Positioning the popover on scrollable elements

* (feat) - add getter for steps property

* (feat) - add setter for steps property / remove duplicate typing

* (fix) - remove duplicated 'currentModePrevented' type

* (fix) - merge

* merge fix

* (fix) - move all methods after scroll detection - success !

* Refactor highlighting active element
上级 57a6dc52
此差异已折叠。
......@@ -190,15 +190,17 @@ export default class Element {
* @public
*/
onHighlighted() {
this.showPopover();
this.showStage();
this.addHighlightClasses();
const highlightedElement = this;
if (!highlightedElement.isInView()) {
highlightedElement.bringInView();
}
// Show the popover and stage once the item has been
// brought in the view, this would allow us to handle
// the cases where the container has scroll overflow
this.showPopover();
this.showStage();
this.addHighlightClasses();
if (this.options.onHighlighted) {
this.options.onHighlighted(this);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册