提交 ebecdcc1 编写于 作者: L Larry Finger 提交者: John W. Linville

rtlwifi: rtl8192c: Prevent sleeping from invalid context in rtl8192cu

When driver rtl8192cu is used with the debug level set to 3 or greater,
the result is "sleeping function called from invalid context" due to
an rcu_read_lock() call in the DM refresh routine in driver rtl8192c.
This lock is not necessary as the USB driver does not use the struct
being protected, thus the lock is set only when a PCI interface is
active.

This bug is reported in https://bugzilla.kernel.org/show_bug.cgi?id=42775.
Reported-by: NRonald Wahl <ronald.wahl@raritan.com>
Tested-by: NRonald Wahl <ronald.wahl@raritan.com>
Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org>
Cc: Ronald Wahl <ronald.wahl@raritan.com>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
上级 8f526ab4
...@@ -1201,13 +1201,18 @@ static void rtl92c_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw) ...@@ -1201,13 +1201,18 @@ static void rtl92c_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
"PreState = %d, CurState = %d\n", "PreState = %d, CurState = %d\n",
p_ra->pre_ratr_state, p_ra->ratr_state); p_ra->pre_ratr_state, p_ra->ratr_state);
rcu_read_lock(); /* Only the PCI card uses sta in the update rate table
sta = ieee80211_find_sta(mac->vif, mac->bssid); * callback routine */
if (rtlhal->interface == INTF_PCI) {
rcu_read_lock();
sta = ieee80211_find_sta(mac->vif, mac->bssid);
}
rtlpriv->cfg->ops->update_rate_tbl(hw, sta, rtlpriv->cfg->ops->update_rate_tbl(hw, sta,
p_ra->ratr_state); p_ra->ratr_state);
p_ra->pre_ratr_state = p_ra->ratr_state; p_ra->pre_ratr_state = p_ra->ratr_state;
rcu_read_unlock(); if (rtlhal->interface == INTF_PCI)
rcu_read_unlock();
} }
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册