提交 9246585a 编写于 作者: A Al Viro 提交者: Linus Torvalds

[PATCH] nfsd4_truncate() bogus return value

-EINVAL (in host order, no less) is not a good thing to return to client.

nfsd4_truncate() returns it in one case and its callers expect nfs_....  from
it.  AFAICS, it should be nfserr_inval
Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: NNeil Brown <neilb@suse.de>
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
上级 d75f2b9f
...@@ -1600,7 +1600,7 @@ nfsd4_truncate(struct svc_rqst *rqstp, struct svc_fh *fh, ...@@ -1600,7 +1600,7 @@ nfsd4_truncate(struct svc_rqst *rqstp, struct svc_fh *fh,
if (!open->op_truncate) if (!open->op_truncate)
return 0; return 0;
if (!(open->op_share_access & NFS4_SHARE_ACCESS_WRITE)) if (!(open->op_share_access & NFS4_SHARE_ACCESS_WRITE))
return -EINVAL; return nfserr_inval;
return nfsd_setattr(rqstp, fh, &iattr, 0, (time_t)0); return nfsd_setattr(rqstp, fh, &iattr, 0, (time_t)0);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册