提交 89a86402 编写于 作者: D David Howells 提交者: Linus Torvalds

NOMMU: Don't pass NULL pointers to fput() in do_mmap_pgoff()

Don't pass NULL pointers to fput() in the error handling paths of the NOMMU
do_mmap_pgoff() as it can't handle it.

The following can be used as a test program:

	int main() { static long long a[1024 * 1024 * 20] = { 0 }; return a;}

Without the patch, the code oopses in atomic_long_dec_and_test() as called by
fput() after the kernel complains that it can't allocate that big a chunk of
memory.  With the patch, the kernel just complains about the allocation size
and then the program segfaults during execve() as execve() can't complete the
allocation of all the new ELF program segments.
Reported-by: NRobin Getz <rgetz@blackfin.uclinux.org>
Signed-off-by: NDavid Howells <dhowells@redhat.com>
Acked-by: NRobin Getz <rgetz@blackfin.uclinux.org>
Cc: stable@kernel.org
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
上级 2e2ec952
......@@ -1362,9 +1362,11 @@ unsigned long do_mmap_pgoff(struct file *file,
error_just_free:
up_write(&nommu_region_sem);
error:
fput(region->vm_file);
if (region->vm_file)
fput(region->vm_file);
kmem_cache_free(vm_region_jar, region);
fput(vma->vm_file);
if (vma->vm_file)
fput(vma->vm_file);
if (vma->vm_flags & VM_EXECUTABLE)
removed_exe_file_vma(vma->vm_mm);
kmem_cache_free(vm_area_cachep, vma);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册