提交 0ce8c010 编写于 作者: A Al Viro

ext[34]: avoid i_nlink warnings triggered by drop_nlink/inc_nlink kludge in symlink()

Both ext3 and ext4 put the half-created symlink inode into the orphan list
for a while (see the comment in ext[34]_symlink() for gory details).  Then,
if everything went fine, they pull it out of the orphan list and bump the
link count back to 1.  The thing is, inc_nlink() is going to complain about
seeing somebody changing i_nlink from 0 to 1.  With a good reason, since
normally something like that is a bug.  Explicit set_nlink(inode, 1) does
the same thing as inc_nlink() here, but it does *not* complain - exactly
because it should be usable in strange situations like this one.
Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
上级 da01636a
......@@ -2272,7 +2272,7 @@ static int ext3_symlink (struct inode * dir,
err = PTR_ERR(handle);
goto err_drop_inode;
}
inc_nlink(inode);
set_nlink(inode, 1);
err = ext3_orphan_del(handle, inode);
if (err) {
ext3_journal_stop(handle);
......
......@@ -2315,7 +2315,7 @@ static int ext4_symlink(struct inode *dir,
err = PTR_ERR(handle);
goto err_drop_inode;
}
inc_nlink(inode);
set_nlink(inode, 1);
err = ext4_orphan_del(handle, inode);
if (err) {
ext4_journal_stop(handle);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册