• M
    fix uevent action-string regression · a9edadbf
    Mark Lord 提交于
    Mark Lord wrote:
    >
    > On boot, syslog is flooded with "uevent: unsupported action-string;" messages.
    ..
    > Mar 28 14:43:29 shrimp kernel: tty ptyqd: uevent: unsupported
    > action-string; this will be ignored in a future kernel version
    > Mar 28 14:43:29 shrimp kernel: tty ptyqe: uevent: unsupported
    > action-string; this will be ignored in a future kernel version
    > Mar 28 14:43:29 shrimp kernel: tty ptyqf: uevent: unsupported
    > action-string; this will be ignored in a future kernel version
    > Mar 28 14:43:29 shrimp kernel: tty ptyr0: uevent: unsupported
    > action-string; this will be ignored in a future kernel version
    ..
    
    These messages are a regression compared with 2.6.24, which did not
    flood the syslog with them.
    
    The actual underlying problem was introduced in 2.6.23, when somebody
    made the string parsing no longer accept nul-terminated strings as a
    valid input to store_uevent().
    
    Eg.  "add\0" was valid prior to 2.6.23, where the code regressed to
    require "add" without the '\0'.
    
    This patch fixes the 2.6.23 / 2.6.24 regressions, by having the code
    once again tolerate the trailing '\0', if present.
    
    According to GregKH, this mainly affects older Ubuntu systems, such as
    the one I have here that requires this fix.
    Signed-off-by: NMark Lord <mlord@pobox.com>
    Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
    a9edadbf
kobject_uevent.c 8.0 KB