interface.c 15.1 KB
Newer Older
I
Ian Campbell 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32
/*
 * Network-device interface management.
 *
 * Copyright (c) 2004-2005, Keir Fraser
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License version 2
 * as published by the Free Software Foundation; or, when distributed
 * separately from the Linux kernel or incorporated into other
 * software packages, subject to the following license:
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this source file (the "Software"), to deal in the Software without
 * restriction, including without limitation the rights to use, copy, modify,
 * merge, publish, distribute, sublicense, and/or sell copies of the Software,
 * and to permit persons to whom the Software is furnished to do so, subject to
 * the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 */

#include "common.h"

33
#include <linux/kthread.h>
I
Ian Campbell 已提交
34 35 36
#include <linux/ethtool.h>
#include <linux/rtnetlink.h>
#include <linux/if_vlan.h>
37
#include <linux/vmalloc.h>
I
Ian Campbell 已提交
38 39 40

#include <xen/events.h>
#include <asm/xen/hypercall.h>
41
#include <xen/balloon.h>
I
Ian Campbell 已提交
42 43

#define XENVIF_QUEUE_LENGTH 32
44
#define XENVIF_NAPI_WEIGHT  64
I
Ian Campbell 已提交
45 46 47 48 49 50

int xenvif_schedulable(struct xenvif *vif)
{
	return netif_running(vif->dev) && netif_carrier_ok(vif->dev);
}

51
static irqreturn_t xenvif_tx_interrupt(int irq, void *dev_id)
I
Ian Campbell 已提交
52 53 54
{
	struct xenvif *vif = dev_id;

55 56
	if (RING_HAS_UNCONSUMED_REQUESTS(&vif->tx))
		napi_schedule(&vif->napi);
I
Ian Campbell 已提交
57

58 59 60
	return IRQ_HANDLED;
}

61 62 63 64 65
static int xenvif_poll(struct napi_struct *napi, int budget)
{
	struct xenvif *vif = container_of(napi, struct xenvif, napi);
	int work_done;

66 67 68 69 70 71 72 73 74
	/* This vif is rogue, we pretend we've there is nothing to do
	 * for this vif to deschedule it from NAPI. But this interface
	 * will be turned off in thread context later.
	 */
	if (unlikely(vif->disabled)) {
		napi_complete(napi);
		return 0;
	}

W
Wei Liu 已提交
75
	work_done = xenvif_tx_action(vif, budget);
76 77

	if (work_done < budget) {
78 79
		napi_complete(napi);
		xenvif_napi_schedule_or_enable_events(vif);
80 81 82 83 84
	}

	return work_done;
}

85 86 87 88
static irqreturn_t xenvif_rx_interrupt(int irq, void *dev_id)
{
	struct xenvif *vif = dev_id;

89
	xenvif_kick_thread(vif);
I
Ian Campbell 已提交
90 91 92 93

	return IRQ_HANDLED;
}

94 95 96 97 98 99 100 101
static irqreturn_t xenvif_interrupt(int irq, void *dev_id)
{
	xenvif_tx_interrupt(irq, dev_id);
	xenvif_rx_interrupt(irq, dev_id);

	return IRQ_HANDLED;
}

102 103 104 105 106 107 108 109 110 111 112 113
static void xenvif_wake_queue(unsigned long data)
{
	struct xenvif *vif = (struct xenvif *)data;

	if (netif_queue_stopped(vif->dev)) {
		netdev_err(vif->dev, "draining TX queue\n");
		vif->rx_queue_purge = true;
		xenvif_kick_thread(vif);
		netif_wake_queue(vif->dev);
	}
}

I
Ian Campbell 已提交
114 115 116
static int xenvif_start_xmit(struct sk_buff *skb, struct net_device *dev)
{
	struct xenvif *vif = netdev_priv(dev);
117
	int min_slots_needed;
I
Ian Campbell 已提交
118 119 120

	BUG_ON(skb->dev != dev);

121
	/* Drop the packet if vif is not ready */
122 123 124
	if (vif->task == NULL ||
	    vif->dealloc_task == NULL ||
	    !xenvif_schedulable(vif))
I
Ian Campbell 已提交
125 126
		goto drop;

127 128 129 130
	/* At best we'll need one slot for the header and one for each
	 * frag.
	 */
	min_slots_needed = 1 + skb_shinfo(skb)->nr_frags;
I
Ian Campbell 已提交
131

132 133 134
	/* If the skb is GSO then we'll also need an extra slot for the
	 * metadata.
	 */
135
	if (skb_is_gso(skb))
136
		min_slots_needed++;
I
Ian Campbell 已提交
137

138 139 140 141
	/* If the skb can't possibly fit in the remaining slots
	 * then turn off the queue to give the ring a chance to
	 * drain.
	 */
142 143 144
	if (!xenvif_rx_ring_slots_available(vif, min_slots_needed)) {
		vif->wake_queue.function = xenvif_wake_queue;
		vif->wake_queue.data = (unsigned long)vif;
145
		xenvif_stop_queue(vif);
146 147 148
		mod_timer(&vif->wake_queue,
			jiffies + rx_drain_timeout_jiffies);
	}
I
Ian Campbell 已提交
149

150 151
	skb_queue_tail(&vif->rx_queue, skb);
	xenvif_kick_thread(vif);
I
Ian Campbell 已提交
152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168

	return NETDEV_TX_OK;

 drop:
	vif->dev->stats.tx_dropped++;
	dev_kfree_skb(skb);
	return NETDEV_TX_OK;
}

static struct net_device_stats *xenvif_get_stats(struct net_device *dev)
{
	struct xenvif *vif = netdev_priv(dev);
	return &vif->dev->stats;
}

static void xenvif_up(struct xenvif *vif)
{
169
	napi_enable(&vif->napi);
170 171 172
	enable_irq(vif->tx_irq);
	if (vif->tx_irq != vif->rx_irq)
		enable_irq(vif->rx_irq);
173
	xenvif_napi_schedule_or_enable_events(vif);
I
Ian Campbell 已提交
174 175 176 177
}

static void xenvif_down(struct xenvif *vif)
{
178
	napi_disable(&vif->napi);
179 180 181
	disable_irq(vif->tx_irq);
	if (vif->tx_irq != vif->rx_irq)
		disable_irq(vif->rx_irq);
182
	del_timer_sync(&vif->credit_timeout);
I
Ian Campbell 已提交
183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213
}

static int xenvif_open(struct net_device *dev)
{
	struct xenvif *vif = netdev_priv(dev);
	if (netif_carrier_ok(dev))
		xenvif_up(vif);
	netif_start_queue(dev);
	return 0;
}

static int xenvif_close(struct net_device *dev)
{
	struct xenvif *vif = netdev_priv(dev);
	if (netif_carrier_ok(dev))
		xenvif_down(vif);
	netif_stop_queue(dev);
	return 0;
}

static int xenvif_change_mtu(struct net_device *dev, int mtu)
{
	struct xenvif *vif = netdev_priv(dev);
	int max = vif->can_sg ? 65535 - VLAN_ETH_HLEN : ETH_DATA_LEN;

	if (mtu > max)
		return -EINVAL;
	dev->mtu = mtu;
	return 0;
}

214 215
static netdev_features_t xenvif_fix_features(struct net_device *dev,
	netdev_features_t features)
I
Ian Campbell 已提交
216 217 218
{
	struct xenvif *vif = netdev_priv(dev);

219 220
	if (!vif->can_sg)
		features &= ~NETIF_F_SG;
221
	if (~(vif->gso_mask | vif->gso_prefix_mask) & GSO_BIT(TCPV4))
222
		features &= ~NETIF_F_TSO;
223 224
	if (~(vif->gso_mask | vif->gso_prefix_mask) & GSO_BIT(TCPV6))
		features &= ~NETIF_F_TSO6;
225
	if (!vif->ip_csum)
226
		features &= ~NETIF_F_IP_CSUM;
227 228
	if (!vif->ipv6_csum)
		features &= ~NETIF_F_IPV6_CSUM;
I
Ian Campbell 已提交
229

230
	return features;
I
Ian Campbell 已提交
231 232 233 234 235 236 237 238 239 240
}

static const struct xenvif_stat {
	char name[ETH_GSTRING_LEN];
	u16 offset;
} xenvif_stats[] = {
	{
		"rx_gso_checksum_fixup",
		offsetof(struct xenvif, rx_gso_checksum_fixup)
	},
241 242 243 244 245 246 247 248 249 250 251 252 253 254 255
	/* If (sent != success + fail), there are probably packets never
	 * freed up properly!
	 */
	{
		"tx_zerocopy_sent",
		offsetof(struct xenvif, tx_zerocopy_sent),
	},
	{
		"tx_zerocopy_success",
		offsetof(struct xenvif, tx_zerocopy_success),
	},
	{
		"tx_zerocopy_fail",
		offsetof(struct xenvif, tx_zerocopy_fail)
	},
256 257 258 259 260 261 262
	/* Number of packets exceeding MAX_SKB_FRAG slots. You should use
	 * a guest with the same MAX_SKB_FRAG
	 */
	{
		"tx_frag_overflow",
		offsetof(struct xenvif, tx_frag_overflow)
	},
I
Ian Campbell 已提交
263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297
};

static int xenvif_get_sset_count(struct net_device *dev, int string_set)
{
	switch (string_set) {
	case ETH_SS_STATS:
		return ARRAY_SIZE(xenvif_stats);
	default:
		return -EINVAL;
	}
}

static void xenvif_get_ethtool_stats(struct net_device *dev,
				     struct ethtool_stats *stats, u64 * data)
{
	void *vif = netdev_priv(dev);
	int i;

	for (i = 0; i < ARRAY_SIZE(xenvif_stats); i++)
		data[i] = *(unsigned long *)(vif + xenvif_stats[i].offset);
}

static void xenvif_get_strings(struct net_device *dev, u32 stringset, u8 * data)
{
	int i;

	switch (stringset) {
	case ETH_SS_STATS:
		for (i = 0; i < ARRAY_SIZE(xenvif_stats); i++)
			memcpy(data + i * ETH_GSTRING_LEN,
			       xenvif_stats[i].name, ETH_GSTRING_LEN);
		break;
	}
}

298
static const struct ethtool_ops xenvif_ethtool_ops = {
I
Ian Campbell 已提交
299 300 301 302 303 304 305
	.get_link	= ethtool_op_get_link,

	.get_sset_count = xenvif_get_sset_count,
	.get_ethtool_stats = xenvif_get_ethtool_stats,
	.get_strings = xenvif_get_strings,
};

306
static const struct net_device_ops xenvif_netdev_ops = {
I
Ian Campbell 已提交
307 308 309 310 311
	.ndo_start_xmit	= xenvif_start_xmit,
	.ndo_get_stats	= xenvif_get_stats,
	.ndo_open	= xenvif_open,
	.ndo_stop	= xenvif_close,
	.ndo_change_mtu	= xenvif_change_mtu,
312
	.ndo_fix_features = xenvif_fix_features,
313 314
	.ndo_set_mac_address = eth_mac_addr,
	.ndo_validate_addr   = eth_validate_addr,
I
Ian Campbell 已提交
315 316 317 318 319 320 321 322 323
};

struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
			    unsigned int handle)
{
	int err;
	struct net_device *dev;
	struct xenvif *vif;
	char name[IFNAMSIZ] = {};
324
	int i;
I
Ian Campbell 已提交
325 326 327 328

	snprintf(name, IFNAMSIZ - 1, "vif%u.%u", domid, handle);
	dev = alloc_netdev(sizeof(struct xenvif), name, ether_setup);
	if (dev == NULL) {
329
		pr_warn("Could not allocate netdev for %s\n", name);
I
Ian Campbell 已提交
330 331 332 333 334 335
		return ERR_PTR(-ENOMEM);
	}

	SET_NETDEV_DEV(dev, parent);

	vif = netdev_priv(dev);
336

I
Ian Campbell 已提交
337 338 339
	vif->domid  = domid;
	vif->handle = handle;
	vif->can_sg = 1;
340
	vif->ip_csum = 1;
I
Ian Campbell 已提交
341 342
	vif->dev = dev;

343 344
	vif->disabled = false;

I
Ian Campbell 已提交
345 346 347
	vif->credit_bytes = vif->remaining_credit = ~0UL;
	vif->credit_usec  = 0UL;
	init_timer(&vif->credit_timeout);
348
	vif->credit_window_start = get_jiffies_64();
I
Ian Campbell 已提交
349

350 351
	init_timer(&vif->wake_queue);

I
Ian Campbell 已提交
352
	dev->netdev_ops	= &xenvif_netdev_ops;
353 354
	dev->hw_features = NETIF_F_SG |
		NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
355
		NETIF_F_TSO | NETIF_F_TSO6;
356
	dev->features = dev->hw_features | NETIF_F_RXCSUM;
357
	dev->ethtool_ops = &xenvif_ethtool_ops;
I
Ian Campbell 已提交
358 359 360

	dev->tx_queue_len = XENVIF_QUEUE_LENGTH;

361 362 363 364 365 366 367
	skb_queue_head_init(&vif->rx_queue);
	skb_queue_head_init(&vif->tx_queue);

	vif->pending_cons = 0;
	vif->pending_prod = MAX_PENDING_REQS;
	for (i = 0; i < MAX_PENDING_REQS; i++)
		vif->pending_ring[i] = i;
368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387
	spin_lock_init(&vif->callback_lock);
	spin_lock_init(&vif->response_lock);
	/* If ballooning is disabled, this will consume real memory, so you
	 * better enable it. The long term solution would be to use just a
	 * bunch of valid page descriptors, without dependency on ballooning
	 */
	err = alloc_xenballooned_pages(MAX_PENDING_REQS,
				       vif->mmap_pages,
				       false);
	if (err) {
		netdev_err(dev, "Could not reserve mmap_pages\n");
		return ERR_PTR(-ENOMEM);
	}
	for (i = 0; i < MAX_PENDING_REQS; i++) {
		vif->pending_tx_info[i].callback_struct = (struct ubuf_info)
			{ .callback = xenvif_zerocopy_callback,
			  .ctx = NULL,
			  .desc = i };
		vif->grant_tx_handle[i] = NETBACK_INVALID_HANDLE;
	}
388

I
Ian Campbell 已提交
389 390 391 392 393 394 395 396 397
	/*
	 * Initialise a dummy MAC address. We choose the numerically
	 * largest non-broadcast address to prevent the address getting
	 * stolen by an Ethernet bridge for STP purposes.
	 * (FE:FF:FF:FF:FF:FF)
	 */
	memset(dev->dev_addr, 0xFF, ETH_ALEN);
	dev->dev_addr[0] &= ~0x01;

398 399
	netif_napi_add(dev, &vif->napi, xenvif_poll, XENVIF_NAPI_WEIGHT);

I
Ian Campbell 已提交
400 401 402 403 404 405 406 407 408 409
	netif_carrier_off(dev);

	err = register_netdev(dev);
	if (err) {
		netdev_warn(dev, "Could not register device: err=%d\n", err);
		free_netdev(dev);
		return ERR_PTR(err);
	}

	netdev_dbg(dev, "Successfully created xenvif\n");
410 411 412

	__module_get(THIS_MODULE);

I
Ian Campbell 已提交
413 414 415 416
	return vif;
}

int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
417 418
		   unsigned long rx_ring_ref, unsigned int tx_evtchn,
		   unsigned int rx_evtchn)
I
Ian Campbell 已提交
419
{
420
	struct task_struct *task;
I
Ian Campbell 已提交
421 422
	int err = -ENOMEM;

423 424
	BUG_ON(vif->tx_irq);
	BUG_ON(vif->task);
425
	BUG_ON(vif->dealloc_task);
I
Ian Campbell 已提交
426

W
Wei Liu 已提交
427
	err = xenvif_map_frontend_rings(vif, tx_ring_ref, rx_ring_ref);
I
Ian Campbell 已提交
428 429 430
	if (err < 0)
		goto err;

431
	init_waitqueue_head(&vif->wq);
432
	init_waitqueue_head(&vif->dealloc_wq);
433

434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464
	if (tx_evtchn == rx_evtchn) {
		/* feature-split-event-channels == 0 */
		err = bind_interdomain_evtchn_to_irqhandler(
			vif->domid, tx_evtchn, xenvif_interrupt, 0,
			vif->dev->name, vif);
		if (err < 0)
			goto err_unmap;
		vif->tx_irq = vif->rx_irq = err;
		disable_irq(vif->tx_irq);
	} else {
		/* feature-split-event-channels == 1 */
		snprintf(vif->tx_irq_name, sizeof(vif->tx_irq_name),
			 "%s-tx", vif->dev->name);
		err = bind_interdomain_evtchn_to_irqhandler(
			vif->domid, tx_evtchn, xenvif_tx_interrupt, 0,
			vif->tx_irq_name, vif);
		if (err < 0)
			goto err_unmap;
		vif->tx_irq = err;
		disable_irq(vif->tx_irq);

		snprintf(vif->rx_irq_name, sizeof(vif->rx_irq_name),
			 "%s-rx", vif->dev->name);
		err = bind_interdomain_evtchn_to_irqhandler(
			vif->domid, rx_evtchn, xenvif_rx_interrupt, 0,
			vif->rx_irq_name, vif);
		if (err < 0)
			goto err_tx_unbind;
		vif->rx_irq = err;
		disable_irq(vif->rx_irq);
	}
I
Ian Campbell 已提交
465

466 467
	task = kthread_create(xenvif_kthread_guest_rx,
			      (void *)vif, "%s-guest-rx", vif->dev->name);
468
	if (IS_ERR(task)) {
469
		pr_warn("Could not allocate kthread for %s\n", vif->dev->name);
470
		err = PTR_ERR(task);
471 472
		goto err_rx_unbind;
	}
I
Ian Campbell 已提交
473

474 475
	vif->task = task;

476 477 478 479 480 481 482 483 484 485
	task = kthread_create(xenvif_dealloc_kthread,
			      (void *)vif, "%s-dealloc", vif->dev->name);
	if (IS_ERR(task)) {
		pr_warn("Could not allocate kthread for %s\n", vif->dev->name);
		err = PTR_ERR(task);
		goto err_rx_unbind;
	}

	vif->dealloc_task = task;

I
Ian Campbell 已提交
486
	rtnl_lock();
487 488 489 490
	if (!vif->can_sg && vif->dev->mtu > ETH_DATA_LEN)
		dev_set_mtu(vif->dev, ETH_DATA_LEN);
	netdev_update_features(vif->dev);
	netif_carrier_on(vif->dev);
491 492
	if (netif_running(vif->dev))
		xenvif_up(vif);
I
Ian Campbell 已提交
493 494
	rtnl_unlock();

495
	wake_up_process(vif->task);
496
	wake_up_process(vif->dealloc_task);
497

I
Ian Campbell 已提交
498
	return 0;
499 500 501 502

err_rx_unbind:
	unbind_from_irqhandler(vif->rx_irq, vif);
	vif->rx_irq = 0;
503 504 505
err_tx_unbind:
	unbind_from_irqhandler(vif->tx_irq, vif);
	vif->tx_irq = 0;
I
Ian Campbell 已提交
506
err_unmap:
W
Wei Liu 已提交
507
	xenvif_unmap_frontend_rings(vif);
I
Ian Campbell 已提交
508
err:
509
	module_put(THIS_MODULE);
I
Ian Campbell 已提交
510 511 512
	return err;
}

513
void xenvif_carrier_off(struct xenvif *vif)
I
Ian Campbell 已提交
514 515
{
	struct net_device *dev = vif->dev;
516 517 518 519 520 521 522 523 524 525 526 527

	rtnl_lock();
	netif_carrier_off(dev); /* discard queued packets */
	if (netif_running(dev))
		xenvif_down(vif);
	rtnl_unlock();
}

void xenvif_disconnect(struct xenvif *vif)
{
	if (netif_carrier_ok(vif->dev))
		xenvif_carrier_off(vif);
I
Ian Campbell 已提交
528

529
	if (vif->task) {
530
		del_timer_sync(&vif->wake_queue);
531
		kthread_stop(vif->task);
532 533
		vif->task = NULL;
	}
534

535 536 537 538 539
	if (vif->dealloc_task) {
		kthread_stop(vif->dealloc_task);
		vif->dealloc_task = NULL;
	}

540 541 542 543 544 545 546
	if (vif->tx_irq) {
		if (vif->tx_irq == vif->rx_irq)
			unbind_from_irqhandler(vif->tx_irq, vif);
		else {
			unbind_from_irqhandler(vif->tx_irq, vif);
			unbind_from_irqhandler(vif->rx_irq, vif);
		}
547
		vif->tx_irq = 0;
548
	}
I
Ian Campbell 已提交
549

550 551 552 553 554
	xenvif_unmap_frontend_rings(vif);
}

void xenvif_free(struct xenvif *vif)
{
555
	int i, unmap_timeout = 0;
556 557
	/* Here we want to avoid timeout messages if an skb can be legitimately
	 * stuck somewhere else. Realistically this could be an another vif's
558 559 560 561 562 563
	 * internal or QDisc queue. That another vif also has this
	 * rx_drain_timeout_msecs timeout, but the timer only ditches the
	 * internal queue. After that, the QDisc queue can put in worst case
	 * XEN_NETIF_RX_RING_SIZE / MAX_SKB_FRAGS skbs into that another vif's
	 * internal queue, so we need several rounds of such timeouts until we
	 * can be sure that no another vif should have skb's from us. We are
564
	 * not sending more skb's, so newly stuck packets are not interesting
565 566 567 568
	 * for us here.
	 */
	unsigned int worst_case_skb_lifetime = (rx_drain_timeout_msecs/1000) *
		DIV_ROUND_UP(XENVIF_QUEUE_LENGTH, (XEN_NETIF_RX_RING_SIZE / MAX_SKB_FRAGS));
569 570 571 572 573

	for (i = 0; i < MAX_PENDING_REQS; ++i) {
		if (vif->grant_tx_handle[i] != NETBACK_INVALID_HANDLE) {
			unmap_timeout++;
			schedule_timeout(msecs_to_jiffies(1000));
574
			if (unmap_timeout > worst_case_skb_lifetime &&
575 576 577 578
			    net_ratelimit())
				netdev_err(vif->dev,
					   "Page still granted! Index: %x\n",
					   i);
579 580 581 582 583 584 585
			/* If there are still unmapped pages, reset the loop to
			 * start checking again. We shouldn't exit here until
			 * dealloc thread and NAPI instance release all the
			 * pages. If a kernel bug causes the skbs to stall
			 * somewhere, the interface cannot be brought down
			 * properly.
			 */
586 587 588 589 590 591
			i = -1;
		}
	}

	free_xenballooned_pages(MAX_PENDING_REQS, vif->mmap_pages);

592 593
	netif_napi_del(&vif->napi);

I
Ian Campbell 已提交
594 595 596
	unregister_netdev(vif->dev);

	free_netdev(vif->dev);
597

598
	module_put(THIS_MODULE);
I
Ian Campbell 已提交
599
}