Fixed warnings of PMD.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@34579 71c3de6d-444a-0410-be80-ed276b4c234a

core/src/main/java/hudson/model/ComputerSet.java

@@ -301,7 +301,7 @@ public final class ComputerSet extends AbstractModelObject {
     /**
      * Accepts submission from the configuration page.
      */
-    public final synchronized void doConfigSubmit( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException, FormException {
+    public synchronized void doConfigSubmit( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException, FormException {
         BulkChange bc = new BulkChange(MONITORS_OWNER);
         try {
             Hudson.getInstance().checkPermission(Hudson.ADMINISTER);

core/src/main/java/hudson/model/DirectoryBrowserSupport.java

@@ -129,7 +129,7 @@ public final class DirectoryBrowserSupport implements HttpResponse {
      *      Instead of calling this method explicitly, just return the {@link DirectoryBrowserSupport} object
      *      from the {@code doXYZ} method and let Stapler generate a response for you.
      */
-    public final void serveFile(StaplerRequest req, StaplerResponse rsp, FilePath root, String icon, boolean serveDirIndex) throws IOException, ServletException, InterruptedException {
+    public void serveFile(StaplerRequest req, StaplerResponse rsp, FilePath root, String icon, boolean serveDirIndex) throws IOException, ServletException, InterruptedException {
         // handle form submission
         String pattern = req.getParameter("pattern");
         if(pattern==null)

core/src/main/java/hudson/model/Hudson.java

@@ -802,7 +802,7 @@ public final class Hudson extends Node implements ItemGroup<TopLevelItem>, Stapl
     /**
      * Does this {@link View} has any associated user information recorded?
      */
-    public final boolean hasPeople() {
+    public boolean hasPeople() {
         return View.People.isApplicable(items.values());
     }
 

core/src/main/java/hudson/model/RunParameterValue.java

@@ -24,7 +24,6 @@
 package hudson.model;
 
 import java.util.Locale;
-import java.util.Map;
 
 import hudson.EnvVars;
 import org.kohsuke.stapler.DataBoundConstructor;

core/src/main/java/hudson/model/UpdateSite.java

@@ -35,7 +35,6 @@ import hudson.util.VersionNumber;
 import static hudson.util.TimeUnit2.DAYS;
 import net.sf.json.JSONObject;
 import org.kohsuke.stapler.DataBoundConstructor;
-import org.kohsuke.stapler.QueryParameter;
 import org.kohsuke.stapler.StaplerRequest;
 import org.kohsuke.stapler.StaplerResponse;
 import org.jvnet.hudson.crypto.CertificateUtil;
@@ -68,7 +67,6 @@ import java.security.cert.TrustAnchor;
 import com.trilead.ssh2.crypto.Base64;
 
 import javax.servlet.ServletContext;
-import javax.servlet.ServletException;
 
 
 /**

core/src/main/java/hudson/tasks/Ant.java

@@ -115,7 +115,7 @@ public class Ant extends Builder {
      */
     public AntInstallation getAnt() {
         for( AntInstallation i : getDescriptor().getInstallations() ) {
-            if(antName!=null && i.getName().equals(antName))
+            if(antName!=null && antName.equals(i.getName()))
                 return i;
         }
         return null;

core/src/main/java/hudson/tasks/Maven.java

@@ -151,7 +151,7 @@ public class Maven extends Builder {
      */
     public MavenInstallation getMaven() {
         for( MavenInstallation i : getDescriptor().getInstallations() ) {
-            if(mavenName !=null && i.getName().equals(mavenName))
+            if(mavenName !=null && mavenName.equals(i.getName()))
                 return i;
         }
         return null;

core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java

@@ -23,12 +23,19 @@
  */
 package hudson.tasks.test;
 
+import hudson.model.AbstractBuild;
+import hudson.model.AbstractProject;
 import hudson.Extension;
 import hudson.Launcher;
 import hudson.Util;
 import static hudson.Util.fixNull;
-import hudson.model.*;
+import hudson.model.BuildListener;
 import hudson.model.Fingerprint.RangeSet;
+import hudson.model.Hudson;
+import hudson.model.Item;
+import hudson.model.Result;
+import hudson.model.Run;
+import hudson.model.TaskListener;
 import hudson.model.listeners.RunListener;
 import hudson.tasks.BuildStepDescriptor;
 import hudson.tasks.BuildStepMonitor;
@@ -161,7 +168,7 @@ public class AggregatedTestResultPublisher extends Recorder {
          *      so that IDE warns you if you accidentally try to call it.
          */
         @Override
-        protected final String getDescription(TestObject object) {
+        protected String getDescription(TestObject object) {
             throw new AssertionError();
         }
 
@@ -172,7 +179,7 @@ public class AggregatedTestResultPublisher extends Recorder {
          *      so that IDE warns you if you accidentally try to call it.
          */
         @Override
-        protected final void setDescription(TestObject object, String description) {
+        protected void setDescription(TestObject object, String description) {
             throw new AssertionError();
         }
 

maven-interceptor/src/main/java/hudson/maven/agent/PluginManagerListener.java

@@ -31,10 +31,8 @@ import org.apache.maven.project.MavenProject;
 import org.apache.maven.reporting.MavenReport;
 import org.codehaus.plexus.configuration.PlexusConfiguration;
 import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
-import org.codehaus.doxia.sink.Sink;
 
 import java.io.IOException;
-import java.util.Locale;
 
 /**
  * Receives notification from {@link PluginManagerInterceptor},

maven-plugin/src/main/java/hudson/maven/MavenModule.java

@@ -171,7 +171,7 @@ public final class MavenModule extends AbstractMavenProject<MavenModule,MavenBui
      * This method is invoked on {@link MavenModule} that has the matching
      * {@link ModuleName}.
      */
-    /*package*/ final void reconfigure(PomInfo pom) {
+    /*package*/ void reconfigure(PomInfo pom) {
         this.displayName = pom.displayName;
         this.version = pom.version;
         this.relativePath = pom.relativePath;
@@ -458,7 +458,7 @@ public final class MavenModule extends AbstractMavenProject<MavenModule,MavenBui
     /**
      * Creates a list of {@link MavenReporter}s to be used for a build of this project.
      */
-    protected final List<MavenReporter> createReporters() {
+    protected List<MavenReporter> createReporters() {
         List<MavenReporter> reporterList = new ArrayList<MavenReporter>();
 
         getReporters().addAllTo(reporterList);